- 03 Mar, 2020 40 commits
-
-
Josh Simmons authored
Bug: 1040661 Change-Id: Ib9406209e2a8c5c3b753e4cd29b3faf20573f870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082320Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#746574}
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor* to Trace(Visitor*" Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: I60c4e11fb0d50be25c5dcc8a0d5ab854c0ff34c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084723 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746573}
-
Nina Satragno authored
This is a reland of 60d219b6 Temporarily bring back `adjusted_timeout` to make compiling internal android source happy. This will be followed up by a patch updating internal code and later the final removal of `adjusted_timeout`. Original change's description: > [webauthn] Don't adjust timeout when testing > > Move the timeout adjustment from blink to the browser and avoid > adjusting it if we detect a discovery factory override is in place. > > This change makes authenticator browser tests and WPTs 3X faster. > > Fixed: 976428 > Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#746432} Change-Id: If79cd8e5e7add21bd20bc375628cee5f4c3b6e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084725Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#746572}
-
Markus Handell authored
https://chromium-review.googlesource.com/c/chromium/src/+/2033253 unfortunately did away with pause time compensation. This CL adds it back. Bug: 1057810 Change-Id: Iee553ca2e671739fa4ba794878ed09e5bf6954fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085251Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#746571}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b9b24d1b0b80..83af90cf49de git log b9b24d1b0b80..83af90cf49de --date=short --first-parent --format='%ad %ae %s' 2020-03-03 primiano@google.com Merge "Add duplicate frames counter metric" Created with: gclient setdep -r src/third_party/perfetto@83af90cf49de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I05fe962a287bef5ae88eba2e22caae8ac780339a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085711Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746570}
-
Jeremie Boulic authored
The main sections on the storage management page have been added. This change adds a "System" row so that the sizes of the storage items of the storage page (My files, browsing data, apps etc...) add up to the amount of "In use" space displayed at the top of the page. This change creates a SystemSizeCalculator class that keeps track of all calculated sizes. The "System" storage size is displayed as - "Calculating..." while the size of any other item is still being calculated. - "Unknown" if the calculation of any other row fails. - The difference between "In use" and the sum of the other storage items otherwise. If the calculation of a row fails, the corresponding size in the calculation of "System" will be 0. In other words, when the calculation of a row fails, its size is reflected in the System section. Test: unit_tests --gtest_filter="*StorageHandlerTest.SystemSize" browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest" Bug: 733192 Change-Id: Id3b82b10a2b94ed32daba085f8dce719d8272fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060445 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#746569}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f8b286781636..90019cea5ec9 git log f8b286781636..90019cea5ec9 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ancheng.qiao@arm.com Vulkan: Add depth to mipmap generation Created with: gclient setdep -r src/third_party/angle@90019cea5ec9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Icccf3465737d081611d5b10353440104d8eb897c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083749Reviewed-by:
-
Jeremie Boulic authored
On the storage management page, to have the numbers match up to the size that was advertised when the user bought the device, we round the total size to the next power of 2. The total size that was displayed on the storage page was the size of the stateful partition, by far the largest of the 12 partitions present on a ChromeOS device. The vast majority of users doesn't want to worry about these details. We want to numbers on the storage page to add up to the disk size advertized by the manufacturer, a rounded power of 2. unit_tests --gtest_filter="*StorageHandlerTest*" Test: Bug: 1056507, 1013452 Change-Id: Ie8185730183572f5f61fd8646bb9a1fe0f318d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074821 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Sam Sebree authored
This change uses the -internal-light-dark-color css property to set correct dark mode styling on the select native control. Bug: 929098 Change-Id: I029859c64119e139ec228e8476a1501ad256b48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084057Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746566}
-
Jae Hoon Kim authored
ARCVM remains in rootfs. BUG=chromium:1058105 TEST=Build chrome Change-Id: I0a4f37c393a1231120f191920135c4c0e84b00e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085704Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#746565}
-
Ovidio Henriquez authored
This change generates the migration guide HTML file using native_client_sdk/src/doc/Makefile. The Sphinx document generator has changed greatly since these documents were last generated, so the latest version of Sphinx does not work because SmartyPantsHTMLTranslator is no longer available. Change-Id: Id98b77972784d161f10f6a3a0231ede740d24ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078802Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#746564}
-
Koji Ishii authored
This reverts commit fbbcb327. Reason for revert: Regressed crbug.com/1057576 Original change's description: > Fix outline when linebox has non-zero inline offset > > When computing outline rects in an inline formatting context, > the coordinate system needs to be relative to the root of the > inline formatting context, because the algorithm needs to > call |LayoutObject| functions, which uses the coordinate > system for inline |LayoutObject|s. > > This patch fixes not to accumulate line box offset. For the > inline direction, this is usually zero and is not visible, > but non-zero `padding-left` can expose this difference. > > Bug: 1048070 > Change-Id: I30dfabcca621136b6d78892a1856c1336c7438eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038296 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Aleks Totic <atotic@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738646} TBR=wangxianzhu@chromium.org,cbiesinger@chromium.org,kojii@chromium.org,atotic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048070, 1057576 Change-Id: I183b2c0e5ba65e8dd97418e222331ec566d2adbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084775Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#746563}
-
Jeffrey Cohen authored
TBR=ellyjones@google.com Bug: 1058157 Change-Id: I66d30be3bbfbfd2cb1b4754812b31e46840bbede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085599 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746562}
-
Anastasia Helfinstein authored
This is a step towards incorporating Rose and Sophie's code for text navigation and selection from last summer into the new navigation paradigm. Bug: 982004 Change-Id: I4fc4b41b6a151992348e8558eb51cde5172667de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076552 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746561}
-
Hazem Ashmawy authored
Check if crash collection is enabled or not in Activity#onResume so if the user enabled crash collection then returns to the activity the error message would resolve. Fixed: 1054142 Test: enabling/disabling usage and diagnostics settings and return back to crash activity Change-Id: I2fce207e4db3912b467492e2f2935c80009b866c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080490 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#746560}
-
Yi Xu authored
In the current implementation, we always retain the content from the previous surface. However, if the full canvas needs to be repainted in this frame, the old content would over written. So there is no need to retain the content from the previous frame. The performance improvement is measure by "Blink.Canvas.IsFullRepaint". Bug: 1054666 Change-Id: Iae766225e741439c729d75f57e30418d05fe8577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063733Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#746559}
-
Jeffrey Cohen authored
TBR=mlamouri@chromium.org Bug: 1058087 Change-Id: Idf5dbbdd63937afbccf76bd626fa27575da724c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084729Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746558}
-
Stephen McGruer authored
Tackling the set of calls that avoided the automated refactor (for various reasons). There are about 50 in total, split up into a few CLs to make reviewing it easier. Bug: 1051932 Change-Id: Ie8cb346bcd4104c11dcb41f001b26cdc260948b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082905 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#746557}
-
Dong Hwi Lee authored
Change-Id: I3e30b0c29dea6dd6db8657c7236505968dd22274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084726 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6f92b9160b19..9b5ecdf536e0 git log 6f92b9160b19..9b5ecdf536e0 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 bryan.bernhart@intel.com D3D12: Remove extra pre-pass used for RTV/DSV allocation. Created with: gclient setdep -r src/third_party/dawn@9b5ecdf536e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic763a871dab9e56ae55cad909b9f58f22eef42e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082324 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c3c538efb60..7f746ebe3585 Created with: gclient setdep -r src-internal@7f746ebe3585 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034440,chromium:1057166 Tbr: jbudorick@google.com Change-Id: I08116ea262f9a6846fdf757aca58747823ed7937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746554}
-
Joshua Bell authored
In service of https://github.com/w3c/IndexedDB/issues/253 move some transaction scheduling tests from Blink to WPT. This involved converting them from js-test.js to testharness.js, but the overall logic of each test was retained. This also adds one new test which verifies the change described in https://github.com/w3c/IndexedDB/pull/319 - all browsers implicitly block R-O transactions behind overlapping R/W transactions. Change-Id: I596aaa75b79bf3bf3e17a2553abb4e11329d59ab Bug: 921193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081237Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#746553}
-
Alex Cooper authored
Fixed: 1058134 Change-Id: I64f1f5d46697f550fbafa0a2f263c3dcb92e674c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085835 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#746552}
-
Jeffrey Cohen authored
tbr: jbudorick@chromium Bug: 1058137 Change-Id: I80b8d42d9b001534341214584e2192e43281541c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085733 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
-
Eric Roman authored
Change-Id: I83281dbedf4d24c40f3b72858ea7f7a43b3e09ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085833 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746550}
-
Jon Mann authored
Previously the observers are only notified of configuration removal events. This adds support for a new OnConfigurationModified hook. Bug: 966270 Change-Id: I9a02c345f88dd8bbade62a5314beba043cb2a09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085397Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#746549}
-
Yulun Wu authored
Bug: 1056913 Change-Id: I1f6b719deb6f6c91e8569ae08f240149f5c346c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083868Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746548}
-
Yi Gu authored
Bug: None Change-Id: I88d1a220e20f1de630cd34b2483a6c0fcdb9b71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085713Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746547}
-
Reilly Grant authored
This change adds two new Blink runtime feature flags, ScreenWakeLock and SystemWakeLock. These can be used to control support for the "screen" and "system" WakeLockType enum values. These checks need to be implemented by hand in wake_lock.cc since the bindings generator does not support adding the [RuntimeEnabled] attribute to an enum value. A webexposed test has been added to check that only the desired wake lock types are exposed. Bug: 257511 Change-Id: If9e94eb39bfd98d91c08da89340ff541f471abb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081618 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Sergey Ulanov authored
Now cast_runner receives list of web permissions as part of the app config and passes the list to the corresponding frame. This will be used to enable microphone & camera access for apps that need it. Bug: 922833 Change-Id: Ibae772c483a0389d3dee04722aeeb9e8c1b51015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084728 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#746545}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/683c198380db..e3e152bd3a29 git log 683c198380db..e3e152bd3a29 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 gabriel.luong@gmail.com Migrate Object, Progress, StringOutputStream, TextDictionary, and Throttler tests into Ninja build 2020-03-03 joselea@microsoft.com Typecheck ResourceType.js with Typescript Created with: gclient setdep -r src/third_party/devtools-frontend/src@e3e152bd3a29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I31f6604e177a31f7e8d5f7db326c5123bb05b6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082329Reviewed-by:
-
Jose Lopes authored
This is a repeating callback because it's both executed by the FrameProcessor class: * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=7b80418808ca7fc5cb2440969f72923065456c8e&l=398 * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=7b80418808ca7fc5cb2440969f72923065456c8e&l=464 But a copy of it is also passed to the MseTrackBuffer class, which takes ownership of the copy: * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=7b80418808ca7fc5cb2440969f72923065456c8e&l=496 and called later for every enqueued processed frame: * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=365fdc7e79f2cb2bd09d9be3c9dfc5e4d2ffb866&l=255 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I5f8d1ad96b71601cc7355bf348187d3cf7a816bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080476 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#746543}
-
Mason Freed authored
The [1] CL added support for scrolling="noscroll" and scrolling="off", but it did not add any testing of these two values. These two values are explicitly called out in the spec [2], so this CL adds testing. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2083595 [2] https://html.spec.whatwg.org/multipage/rendering.html#the-page Bug: 1057454 Change-Id: I457e22ecbe28c4b0a50ec70ba62d2c32a6c348ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085396 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#746542}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65b70d61..f796ed84 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idff28b5e288a0a1d8aa57ebb1459007c1ef2aa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746541}
-
Maks Orlovich authored
Needed since it sometimes need to be parsed on browser as well, not just renderer. This also makes it uses structured headers parsing, which is what it is spec'd as. This changes parsing behavior somewhat; for example accepting (and ignoring) parameters. It is also supposed to not accept non-space whitespace (which tests are updated for), but the parser doesn't match the spec yet. Bug: 1050726 Change-Id: Ib3953ba74efd2ae74d9003cb59edcba9bb49010f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079295 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#746540}
-
Clemens Arbesser authored
Without this CL, UI and model can go out-of-sync when tapping the radio button directly (see screenshots in linked bug). This is a hotfix for this issue. A proper fix requires a refactoring of the FormAction to make the selection state part of its model (same as was done for the T&C selection state in the CollectUserDataModel). Bug: b/150201921 Change-Id: Ifa0a2839c532a1862358bc68e6d0537dee93b49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083489 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746539}
-
David Tseng authored
Fixed: 1057983 TBR=anastasi@google.com Change-Id: I50185e3bf875caec41ced281c10ff308eca08824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085151Reviewed-by:
-
Weilun Shi authored
Add a new field called client_uuid to system profile to help simulate field trial randomization on the server side. Bug: 1058124 Change-Id: I098f9fe31f3d88a78d5e7d784c2edc498dc1e0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085631 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#746537}
-
Eugene But authored
These flags are respectively passed from WillCloseWebStateAt and WebStateInsertedAt callbacks. Previously mentioned callbacks used CHANGE_REASON_USER_ACTION flag. Also rename CHANGE_REASON_USER_ACTION to CHANGE_REASON_ACTIVATE to better reflect the meaning of the flag. This change is needed by Breadcrumbs feature which attaches steps to reproduce to crashlogs. This way Breadcrumbs can log WebStateActivatedAt events only for user triggered activations (all other activations are not useful and only create noise in Breadcrumbs logs). This CL does not have any functional changes to other features and all clients of WebStateActivatedAt were updated to use new flags in addition to CHANGE_REASON_USER_ACTION. Bug: 1046231 Change-Id: Idc5685ee052e8f056200ea9e94b397a2909b4afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084152 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#746536}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/964aa91580b6..4036cb1f0b6e git log 964aa91580b6..4036cb1f0b6e --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Re-disable SKPs on iOS and images on GPU in nanobench 2020-03-03 robertphillips@google.com Switch member destructor order in SkDeferredDisplayList 2020-03-03 senorblanco@chromium.org Dawn backend: update to onBindBuffer() changes. 2020-03-03 mtklein@google.com have each program own LLVMContext 2020-03-03 mtklein@google.com Program::LLVMState Created with: gclient setdep -r src/third_party/skia@4036cb1f0b6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I5e1c77b4bb9db09bc9050dee68583dbd7b9d8004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082328Reviewed-by:
-
