- 05 Nov, 2019 40 commits
-
-
Steve Kobes authored
Bug: 984109 Change-Id: I34290d577d9a96218dfbf892f669572a2c1b1395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895389 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712747}
-
Jack Lynch authored
This CL disables a few web tests that will be broken by [1] and reenabled by [2]. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1884528 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1811866 Change-Id: I1c6527959c13ec3951425b5c3fd24876c59bbc34 Bug: 963183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887737Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712746}
-
Joshua Pawlicki authored
TBR=msarda@chromium.org Bug: 1021209 Change-Id: I16d475a6b4aa70b891eccc6ba47fadc171078de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898201Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712745}
-
Eugene But authored
Bug: 1021649 TBR: gambard@google.com Change-Id: I05486e779332ab8b3c79fb5b96cbc3fd5c458e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900289Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712744}
-
Joshua Pawlicki authored
Bug: 1020650 Change-Id: I4baa0a0612afb24689854f7109a65b7772a64b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895165 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712743}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f6a2232b48c2..0e2a4d97fd4c git log f6a2232b48c2..0e2a4d97fd4c --date=short --no-merges --format='%ad %ae %s' 2019-11-05 vadimsh@chromium.org [lucicfg] Update from v1.11.4 to v1.11.5. 2019-11-05 danakj@chromium.org Allow the bot_update api to not fetch tags from the git server. Created with: gclient setdep -r src/third_party/depot_tools@0e2a4d97fd4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1019824 Change-Id: I656cc67bd3bcc899f2e5fd9e5e65f1e47e9c0b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712742}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4abff70f..4306aa57 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I383667e47e4073a93f0a756c71eccee51dc8e3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899791Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712741}
-
Mark Yacoub authored
- The kernel expects a rotation bit set even when a flip is required. Set ROTATE_0 bit as well when flipping horizontally or vertically. - Remove old ROTATE defines and use values from libdrm. BUG=1015433 TEST=Krane gets overlay Change-Id: Ia473bc3dee915c0b0fe5f13d8333738d7a14b7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894156 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#712740}
-
Gordon Guan authored
Collect memory statistics specific to MADV_FREE Discardable Memory which are useful for gauging its performance. Bug: 1014513 Change-Id: I5fed1aec612ddc32ae9d2ba347283a55fc69f8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863753Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Gordon Guan <gordonguan@google.com> Cr-Commit-Position: refs/heads/master@{#712739}
-
Dominik Röttsches authored
After r708747 the additional metrics show that the ratio of empty scanning results is either 100% or 0%, not in between. Recording additional failure reasons is required to dig in on why results come back empty. Add a member to FamilyResults to record the failure reason for why meta data on an IDWriteFont could not be extracted. Then, in the FinalizeFontTable() method, summarize and find the most frequent failure reason on why font names and file paths could not be extracted, and report that to UMA as a sparse enum of Windows HResult values. Bug: 1009402 Change-Id: Id57d97ad2eb270720e659315a5d092115324b1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879899Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#712738}
-
Stephen Chenney authored
Plumb the metrics from LayerTreeHost through to CompositorFrameReporter and friends. Note the metrics are not always available and we use zeros when that happens (e.g. in tests the use SingleThreadProxy). Even if non-null, sub components might be zero times if, for instance, layout is clean but paint is not. Based on work from behdadb@: https://chromium-review.googlesource.com/c/chromium/src/+/1850106 Bug: 989138 Change-Id: I2357664cb22f9c76a1cdd5173bacc518bfc5e83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861021 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#712737}
-
Olivier Li authored
Bug: 910288 Change-Id: I4e5c75dddce89f2413412601e113df0e735df20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894629 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#712736}
-
Scott Violet authored
visibility:collapse is only supported for tables, so all of the visibility checks in this class should be removed. BUG=1015987 TEST=wpt/compat/webkit-box-clamp-visibility-change.html Change-Id: Ib68b03a7942d6cd78b13e3d0bb11ba1a8742cb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898398 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712735}
-
Dale Curtis authored
BUG=919789,1021627 TBR=waffles Change-Id: I890aa4c6573f16ad66a353083bae85449313e3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899320Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712734}
-
Marc Treib authored
It's still useful, see e.g. crbug.com/1021537 Bug: 1021168 Change-Id: I4f870f93c65532277763fb5dab1eb3096f5ea680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899846 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#712733}
-
Takumi Fujimoto authored
This prevents SelectFileDialog::Listener methods implemented by MediaRouterFileDialog from getting called after it is destroyed. Bug: 907273 Change-Id: I5ec03d832f1062ff1c2259f765f397b7af4c90a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898404Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#712732}
-
Joshua Pawlicki authored
Bug: 429358 Change-Id: I8703b47bb3094f7918456685545b786d78f09ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900291 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712731}
-
Sergey Ulanov authored
Previously SysmemBufferWriterQueue wasn't handling properly the case when a packet is destroyed after ResetBuffers(). Updated ResetBuffers() to drop weak pointers, to ensure that ReleaseBuffer() is not called after ResetBuffers(). Bug: 1021646 Change-Id: I75045ce7427eb0c539bd198bb73a5a742531f0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899319 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712730}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b0a1f0a96806..215bc7949b35 git log b0a1f0a96806..215bc7949b35 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 jonahr@google.com Add VK_EXT_metal_surface extension support Created with: gclient setdep -r src/third_party/swiftshader@215bc7949b35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:1015454 Change-Id: I84f888801317b9e8c761f94887ae89b12c9ccbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900111Reviewed-by:
-
Richard Knoll authored
There is an edge case where ARC returns an empty list of handlers for tel links. Usually there is at least the Contacts app installed but in case there was an error we still want to append devices to select from. With this change we always call through ShowExternalProtocolDialogWithoutApps which then calls ShowFallbackExternalProtocolDialog if there are no devices. Test: Added a test case that verifies that for an empty list of apps we correctly show the external protocol dialog with devices. Bug: 1020155 Change-Id: Idb55d8548d8c428c6864a3f6cdf50baa8ffff663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890440Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712728}
-
Dale Curtis authored
BUG=1020806 TBR=khmel Change-Id: Ia6d051c5b4e5408312d8247085821fc27780df92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899318Reviewed-by:
-
Dave Tapuska authored
Content layer doesn't need to know about this message and can be solely defined in blink. Remove LifecycleStateChanged from WebLocalFrameClient interface and move to blink's mojo interface. BUG=1008432 Change-Id: I72b7e7b8c9b43b990de57f72ed3e48d8852570e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896766 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Dan Beam authored
We've previously relied on almost all code in Chromium to start with a license header, and therefore placing <include> behind single-line JS comments, as in: // <include src="blah.js"> Harmlessly expands to: // // Copyright the Chromium Authors But this is not always the case, and is kind of a hack. So instead, detect the case of "// " in front of a <include> and remove it. So that same "// <include" becomes: // Copyright the Chromium Authors or in the case that the file doesn't have a copyright, the first line of source code (like in dom_distiller). Sure, it adds more magic to the system, but it's probably fine. R=dpapad@chromium.org Fixed: 1021374 Change-Id: Ie7dbf9607c0a78caa20d0e60662efc9d81f88f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898870Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#712725}
-
Oleg Davydov authored
Extensions outside Chrome Web Store (self-hosted ones) don't have hashes signed by Chrome Web Store (stored in verified_contents.json file), so historically are not checked. This commit adds support for extensions to be "should check, but shouldn't verify": if such an extension has computed_hashes.json file, we'll use it to check extension's content and report appropriately to delegate. Bug: 958794 Change-Id: Id8bce11fa42e5a8099f65d3013cb25f2271f51c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735454 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#712724}
-
Xiaohan Wang authored
This reverts commit f1326b9e and relands 549944d5 without change. Reason for revert: The flaky test has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1900158 Original change's description: > Revert "media: Move Renderer creation to PipelineImpl" > > This reverts commit 549944d5. > > Reason for revert: Suspected culprit of WebMediaPlayerImplTest.Encrypted test failures > > The failure appears deterministic on windows: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/42005 > > but also will flake often on other platforms: > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySgsSBUZsYWtlIj9jaHJvbWl1bUBtZWRpYV9ibGlua191bml0dGVzdHNAV2ViTWVkaWFQbGF5ZXJJbXBsVGVzdC5FbmNyeXB0ZWQM > > Original change's description: > > media: Move Renderer creation to PipelineImpl > > > > Instead of creating the Renderer in PipelineController before pipeline > > start which includes Demuxer initialization, this CL moves Renderer > > creation to PipelineImpl as a step in PipelineImpl::Start() so that the > > Renderer is only created after the Demuxer has been initialized. This > > makes it possible to have more flexible Renderer creation, e.g. create > > different Renderers based on different stream or CDM. > > > > Bug: 1018372, 827990 > > Test: No functionality change. > > Change-Id: I7398d90915df7905bd627f4e4cf82fae40252ee1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895747 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#712397} > > TBR=dalecurtis@chromium.org,xhwang@chromium.org > > Change-Id: Iac06fd02de8b4e436ecb16638994cd1b9fb1f7e7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1018372, 827990 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899873 > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712594} TBR=dalecurtis@chromium.org,xhwang@chromium.org,andypaicu@chromium.org Change-Id: I64ab3d453034bf0faf7250bcfb3d0015972a9bc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018372, 827990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900287Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712723}
-
Dave Tapuska authored
Content/renderer does not need to know about this message so define it solely on the blink interface. BUG=1008432 Change-Id: I522c1bb8462c75e85b480f7784900da75d72e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895511 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I97baf50eab960fc9cbd6577ad1da4b2bda9632c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900150Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#712721}
-
Matthias Körber authored
Bug: 1021543 Change-Id: I794550c57e46d78bbca1ae9ec857e2a27d338874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899779 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712720}
-
Peter Kvitek authored
The function is anonymous::SelectedLinuxBackendToString() and it is called from KeyStorageLinux::CreateService from under a bunch of #ifdef's Change-Id: Ia087cf602b0fc09c76e2f3c77322a66680ed6d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900114 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#712719}
-
Clark DuVall authored
This adds a bool to BrowserController.executeScript() which allows running the script in the main world instead of an isolate. Change-Id: I0574de6493c99b187963217341c7e003fcfedb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895320Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712718}
-
George Zhang authored
The main purpose of the java heap profiler is to obtain a heap dump in the form of an hprof file and then parse the hprof file. Currently,there exists a way to obtain the heap dump but there is no way to parse the hprof file. This CL includes a barebones parser for these hprof files. Bug: 1012072 Change-Id: I7a5d19ba8a4c0284fcae41d7057ad44a0b0acdab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861103 Commit-Queue: George Zhang <zhanggeorge@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, multiple places in code either used literals for payment method names (such as "basic-card", "https://google.com/pay") or defined constants, which were sometimes redundant across platforms. This slowed down the process of management of these constants, e.g., adding new method names or tracking down all usage of a single method name. This patch adds payment_strings.cc (similar to error_strings.cc) with several constants for payment method names used across iOS, Android, and desktop non-test code. The patch adds PaymentStrings.java generated from payment_strings.cc (similarto ErrorStrings.java). After this patch, iOS, Android, and desktop non-test code re-use the same string constants for payment method identifiers. This makes adding a new method names and tracking down usage of each method name easier. Bug: 1017348 Change-Id: I3a879192a6a383d53089547a567f4127897a7bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876756 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#712716}
-
Antonio Gomes authored
The public API is not needed any more now that the WebRTC/Peerconnection implementation resides solely in Blink. Hence, this CL uses RtcSessionDescriptionRequest directly. Note that the CL temporarily duplicates some template definitions in blink/renderer/modules/peerconnection/rtc_peer_connection_test.cc, but it will be sorted out when RTCVoidRequest replaces the uses of WebRTCVoidRequest. The duplication is removed right way in https://crrev.com/c/1899786 (see relation chain). Similar CLs: https://crrev.com/c/1890794 and https://crrev.com/c/1884931. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic23698aa0fcee899f19ac17c3fe464bf2c11c395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897772 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712715}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6e71a5063590..bce667b745aa git log 6e71a5063590..bce667b745aa --date=short --no-merges --format='%ad %ae %s' 2019-11-05 perezju@chromium.org [Telemetry] Do not percent encode story names Created with: gclient setdep -r src/third_party/catapult@bce667b745aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:981349 Change-Id: I74905d3cb5cee230d5ec2f79f6a7430b9f6efea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900110Reviewed-by:
-
Francois Doray authored
Reland #2 "Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode." This is a reland of 9d6a01ba //base now supports ::GetThreadPriority() returning 3, so this shouldn't cause problems on bots. https://crrev.com/712564 Original change's description: > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode. > > This experiment enables: > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of > background threads. This affects memory and IO priority in addition > to CPU priority. > - Increase thread priority to "normal" in scopes where background > threads load modules. > > The expectation is that this will improve responsiveness of Chrome > (input delay, first contentful paint), without regressing jank. > > We are adding the testing config in preparation for enabling this > via Finch in M79. > > Bug: 973868 > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705960} TBR=rkaplow@chromium.org Bug: 973868 Change-Id: I26127cc8e545a1f187a806ed5247c6b91f2f4db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899790Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#712713}
-
Jun Mukai authored
This property was added for Mus and it's been here, though it is always true now. Let's just remove it. Bug: none Test: build passes Change-Id: I1ddbf44e5563984a4516b5800191c5f3b00a0f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898399 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712712}
-
Josh Nohle authored
This CL prepares the way for the addition of SetFeatureStatus() to the DeviceSync mojo service. See http://crrev/c/1831010. Bug: 951969 Change-Id: I488984c741ed7050bef2a78163ef6e93f7aee2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895887Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#712711}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/69dd6b02511c..14c3436191d3 git log 69dd6b02511c..14c3436191d3 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 tsepez@chromium.org Add some missing ObservedPtr<> comparison operators Created with: gclient setdep -r src/third_party/pdfium@14c3436191d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I0c6d437c58d3cba4f762ac6041b1b61a44658c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900107Reviewed-by:
-
Xiaohan Wang authored
The current test has a race condition that by the time MetaData is reported (right after Demuxer initialization), the Renderer might not have been initialized (which triggers the "waitingforkey" event, that will trigger DidBlockPlaybackWaitingForKey(). This CL fixes the test so that Load() will wait for DidBlockPlaybackWaitingForKey() to avoid this race condition. Bug: 1021574 Test: Fix flaky test. Change-Id: Icd3bdae9ceb2a5bb7791418e729e68e323ff74fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900158Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712709}
-
Christopher Grant authored
When feature libraries for DFMs were introduced, the library name matched the .so name (eg. libvr.so). This made library loading easier. However, it necessitated placing these libraries into a build subdirectory, so that Monochrome's libvr.so wouldn't collide with Chrome's libvr.so (with the same applying to the test dummy module, and any future DFMs). Since then, we've learned that this puts a tax on other parts of the system, such as stack decoding tools, when trying to locate such libraries. Further, the module build framework has been improved to package and load feature libraries automatically, which means the files can have arbitrary names. This lets us move to a system where (using VR as an example), we have libmonochrome.so and libmonochrome_vr.so created in the conventional build output directory. VR, for now, still has a factory that loads its own library. Normally, this wouldn't be an issue, since loading a library twice results in a no-op the second time. However, we've been warned that because the soname ("vr") and the library file name don't match, that there could be issues with Android actually loading the library twice. This shouldn't be a problem for VR, but if it is, we could temporarily blacklist VR from being loaded by the module library, until it's native code is fully in the VR DFM, and it's custom factory disappears. Bug: 1015159 Change-Id: Icd20399756d1c4876df922d9c111cda0e67773d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897910Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#712708}
-
