GitLab

Under Refresh, as tabs are hovered and the animating hover highlight
is active, several highlighted tabs can be visible. This will change
the painting order of those tabs so that the lower corners of the tabs
are painted such that they aren't likely to look like a "speech bubble"
as pbos@ referred to them.

As a consequence, last_hovered_tab_ could be removed since it's not
needed with the new logic.

Bug: None
Change-Id: I52c470d22966241e47b8450161e4ab9f31966e1b
Reviewed-on: https://chromium-review.googlesource.com/1140954
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576334}

This patch removes spaces before <br> because the images do
not match due to crbug.com/40634, which LayoutNG does not
have the problem.

TBR=eae@chromium.org

Bug: 591099
Change-Id: I8f0770f8911ce2d5c6f9e37ff90752011b84cb49
Reviewed-on: https://chromium-review.googlesource.com/1142050Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576333}

- Remove messages that no longer apply now that CTAP2 is implemented on desktop
- Add Android-only error messages. I prepended these with 'ANDROID' for
clarity.

Bug: 678885
Change-Id: I96e5850752829c0b1e454837a9e1d1fdfa3a9630
Reviewed-on: https://chromium-review.googlesource.com/1139578
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576332}

This leads to better memory performance as the last frame will be discarded.

Bug: 829813
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7bc753e7e8d74d80d8c8390bd0f33ed45003ed5a
Reviewed-on: https://chromium-review.googlesource.com/1141291
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576331}

This patch changes some tests to standard mode.

They currently fail in LayoutNG, probably due to quirks mode.
Change them to standard mode to see if they still fail.

TBR=eae@chromium.org

Bug: 591099
Change-Id: Ia41cbc42eb1a114a24c4a13411080ee7fae9cf2e
Reviewed-on: https://chromium-review.googlesource.com/1142048Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576330}

Destructuring assignment is not currently allowed in Chrome WebUI, per
the ES6 styleguide:
https://chromium.googlesource.com/chromium/src/+/master/docs/es6_chromium.md#Destructuring-Assignment

Bug: None
Change-Id: I000da1a21e148fe9e8024202fb0e5a6f1bca3cc8
Reviewed-on: https://chromium-review.googlesource.com/1142566Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576329}

When available, attributions for custom backgrounds should be displayed
on the NTP. Three new preferences are needed to store the attributions.
A new embeddedSearch API, SetCustomBackgroundURLWithAttributions, is
used to set these preferences.

Bug: 850309, 863942
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib6e5f41f5842d80aac41dd5314f0cdd75aa8f784
Reviewed-on: https://chromium-review.googlesource.com/1129385Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576328}

"Dictioary" is not a type in spec, and it is replaceable with "object".


Bug: 816352
Change-Id: I745000e7ce0ef82959870ef40e44f20029acbdd6
Reviewed-on: https://chromium-review.googlesource.com/1141559Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576327}

This Cl fixed bug introduced in
https://chromium-review.googlesource.com/1077099, when OOBE Welcome
stopped receiving updated strings on localizedStrings update.


Bug: 850444
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id8e53ed1a193c6e59df744500470cbeb2ed2d84b
Reviewed-on: https://chromium-review.googlesource.com/1142732Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576326}

This involves several small changes:
- Adjust the layout of IconLabelBubbleView to account for the case
  where we want to show the separator but not the label.
- Move the extra space shown in suggest mode from LocationBarView to
  IconLabelBubbleView so it can use the logic and spacing values there.
- Add LocationIconView::ShouldShowSeparator() to indicate that we want
  to show the separator in the steady-state case.
- Adjust the spacing in the suggestion result view to match the current
  spec.

Also, remove a bit of dead code: GetMaxSizeForLabelWidth() and
GetOuterPadding() in IconLabelBubbleView.

Bug: 853355
Change-Id: I108dbf80de3c060ca56bbe502101dfbb1123ef4e
Reviewed-on: https://chromium-review.googlesource.com/1136493
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576325}

Hooked up the menu items to their respective functionalites.
Implemented functionalities for search and delete.

Bug: 850605
Change-Id: I89186c21481ed834f92ac4b5915a41d3e830b273
Reviewed-on: https://chromium-review.googlesource.com/1141208
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576324}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: If8304fd344786392300cfe1f45e3246fd18fff76
Reviewed-on: https://chromium-review.googlesource.com/1142514
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576323}

https://pdfium.googlesource.com/pdfium.git/+log/f22b4e2f6682..c15c0b3a1e9a


git log f22b4e2f6682..c15c0b3a1e9a --date=short --no-merges --format='%ad %ae %s'
2018-07-18 thestig@chromium.org Roll third_party/skia/ af7700265..588f87967 (1391 commits; 41 trivial rolls)
2018-07-18 thestig@chromium.org Handle wrong tag element count in littlecms.
2018-07-18 tsepez@chromium.org Add pdfium::span::as_bytes() and as_writable_bytes().


Created with:
  gclient setdep -r src/third_party/pdfium@c15c0b3a1e9a

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:864932
TBR=dsinclair@chromium.org

Change-Id: If7555664cbb89a71e68d034eacbb6b6be0e87415
Reviewed-on: https://chromium-review.googlesource.com/1142172Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576322}

With the new algorithm in http://crrev/c/1102157, we won't be able to
select cross editing boundary anymore, so layout test
search-cancel-button-mouseup.html will violate a DCHECK in
|TextControlElement::CacheSelection()|.

In fact, we shouldn't allow selection starts with cancel button at all,
this CL adds |user-select: none;| to |SearchFieldCancelButtonElement|.

Bug: 863651
Change-Id: Id23b50503caaf814b0a8a14ea1b7c243b3c51c68
Reviewed-on: https://chromium-review.googlesource.com/1141350Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576321}

Change-Id: I8504e4d3d2ef29ad5c7ade2d059924e4acbf5546
Reviewed-on: https://chromium-review.googlesource.com/1141086Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576320}

This moves all metrics related functionality into a separate class,
and is a pure refactor.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Idba2a55655c3e67476500618e6c324a10cfa0b37
Reviewed-on: https://chromium-review.googlesource.com/1141115Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576319}

Previously, when a frame with a unique origin, such as from a data
URL, created a blob URL, the blob URL looked like blob:null/guid and
resulted in a site URL of "blob:" when navigated to.  This incorrectly
allowed all such blob URLs to share a process, even if they were
created by different sites.

This CL changes the site URL assigned in such cases to be the full
blob URL, which includes the GUID.  This avoids process sharing for
all blob URLs with unique origins.

This fix is conservative in the sense that it would also isolate
different blob URLs created by the same unique origin from each other.
This case isn't expected to be common, so it's unlikely to affect
process count.  There's ongoing work to maintain a GUID for unique
origins, so longer-term, we could try using that to track down the
creator and potentially use that GUID in the site URL instead of the
blob URL's GUID, to avoid unnecessary process isolation in scenarios
like this.

Note that as part of this, we discovered a bug where data URLs aren't
able to script blob URLs that they create: https://crbug.com/865254.
This scripting bug should be fixed independently of this CL, and as
far as we can tell, this CL doesn't regress scripting cases like this
further.

Bug: 863623
Change-Id: Ib50407adbba3d5ee0cf6d72d3df7f8d8f24684ee
Reviewed-on: https://chromium-review.googlesource.com/1142389
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576318}

This CL changes the pre-snapping policy of <video> so that only the size
of the contents is pre-snapped, while the location will exactly match the
content box's final location.

BUG=730284

Change-Id: Id10bd0fbd8021a11b7db4a2950a908f3d1b50ac0
Reviewed-on: https://chromium-review.googlesource.com/1141328Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576317}

This change updates the WebUSB WebIDL files to match the recently merged
spec pull request #142 by hiding interfaces which aren't useful in
insecure contexts.

Change-Id: I98625b2634e452c775601525300672d9440ddbcc
Reviewed-on: https://chromium-review.googlesource.com/1137435
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576316}

We need to enable CMA on some Android devices, but we should continue
using MojoAudioDecoder and MojoVideoDecoder in the gpu process. This
affects Android-based Cast devices.

BUG=b:111465269
TEST=Build, cast YT

Change-Id: Ic76d695204720b91d99ab53ae3b40513cea962c5
Reviewed-on: https://chromium-review.googlesource.com/1139103
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576315}

When a user's cros-termina component needs upgrading, but the user
is not connected to the internet, a dialog is shown.

Bug: 862199
Change-Id: I76808e24b0ff1a256331576f56418302bb52bca5
Reviewed-on: https://chromium-review.googlesource.com/1142706Reviewed-by: Renée Wright <rjwright@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576314}

Changes made by request of UX team.

Bug: 848955
Change-Id: I4b5486a97cf3482f98a26657ac2644b9bc2c1bd4
Reviewed-on: https://chromium-review.googlesource.com/1142200Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#576313}

Per https://github.com/w3c/network-error-logging/pull/90, a NEL report's
`url` field now contains the (sanitized) URL of the request that the
report describes.  (Before that spec update, it was supposed to contain
the URL of the page that made the request, which isn't relevant for
NEL.)  Now that the report contains the "right" URL, the NEL body's
`uri` field is redundant, and can be removed.

Bug: 748549
Change-Id: Ibd2b0213b829e94329ecc7263baecd549d41e40c
Reviewed-on: https://chromium-review.googlesource.com/1141271Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576312}

This CL changes strings used in sync_and_services_preferences, changing
wording to make the string grammatically correct. It also fixes a typo.

Bug: 864791, 864789
Change-Id: I38ee3efb2894562606f6997113aa2d9a81787ef5
Reviewed-on: https://chromium-review.googlesource.com/1142149Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576311}

Make test_ws implement ServiceFactory and package the ui service.
Bind a ws2::WindowService instance to requests for the ui service.
Bind test WindowTreeHostFactory requests in WindowService's registry.
Have the test suites use test_ws + ui services instead of test_wm.

Add a TestGpuInterfaceInterfaceProvider with stub binding functions.
(that and an EventInjector registration placeholder prevent crashes)

Move shadow elevation property registration to ws2::WindowService.

Disable some broken mus-only tests, early return if IsMus from some others.
Remove the old ws service_unittests (catalog conflict packaging ui service)

Bug: 855609
Test: Automated, no regressions.
Change-Id: I58f65551c9c0e1c734ed4ac752b5219ecbead0db
Reviewed-on: https://chromium-review.googlesource.com/1138749
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576310}

https://skia.googlesource.com/skia.git/+log/dc97fdc23571..8364706c02c6


git log dc97fdc23571..8364706c02c6 --date=short --no-merges --format='%ad %ae %s'
2018-07-18 caryclark@google.com correct bookmaker md files
2018-07-18 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 e2c00841a55f..38971fd13599 (2 commits)
2018-07-18 csmartdalton@google.com Add kAAHairline to GpuPathRenderers
2018-07-18 caryclark@skia.org add more fiddle hash checks
2018-07-18 csmartdalton@google.com ccpr: Remove constant scale when solving the cubic midtangent
2018-07-18 reed@google.com add new patheffects
2018-07-18 bungeman@google.com SkUTF16_CountUnichars to error instead of assert.
2018-07-18 robertphillips@google.com Fix explicit allocation bug
2018-07-18 jvanverth@google.com Reland "Add some optimizations to PolyUtils"
2018-07-18 ruiqimao@google.com added GMs that use the vertex caching pipeline
2018-07-18 robertphillips@google.com Pull non-substantive changes out of "Reduce arbitrary opList splitting when sorting"
2018-07-18 timliang@google.com Reland "implemented metal gpu backend texture upload testing"
2018-07-18 csmartdalton@google.com ccpr: Account for stroke and style in path cache keys
2018-07-18 brianosman@google.com Add color space logic to skdiff
2018-07-18 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
2018-07-18 benjaminwagner@google.com Update Win2016 bots.
2018-07-18 bsalomon@google.com Add valgrind suppression for leak in libGLX_nvidia when caching program binaries
2018-07-18 halcanary@google.com Reland "SkDEBUGF: use __VA_ARGS__"
2018-07-18 ziadb@google.com SkAR-Java: finger painting first implementation


Created with:
  gclient setdep -r src/third_party/skia@8364706c02c6

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: Ic8e39efb74f630cf49710dda61543c722c91cef6
Reviewed-on: https://chromium-review.googlesource.com/1142018Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576309}

No additional work is required; flake no longer reproduces.

Bug: 855368
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If1f701b846d59cd4e0fe6cb4fed846355561ee02
Reviewed-on: https://chromium-review.googlesource.com/1142393Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576308}

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I9e4eb9de5bfd5876711bde8b77367ccd7be67aba
Reviewed-on: https://chromium-review.googlesource.com/1142577Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576307}

This reverts commit 14fd238a.
Removes the chrome.send('showAddUser') in md_login.js to avoid a race
between the powerwash dialog and the Gaia signin screen.

Bug: 837501
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7ab656ebe522cbd164073b73b3dd927cca7b1f13
Reviewed-on: https://chromium-review.googlesource.com/1129384
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576306}

Bug: 826476
Change-Id: I6b30a7b5c4c252896d557db14e14a54ad4d36ee5
Reviewed-on: https://chromium-review.googlesource.com/1130827
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576305}

This adds plumbing so that the enterprise policy setting can actually override
the tab lifecycles feature.

BUG=

Change-Id: If86dd7687e993c7ed66955692be8eae88b505990
Reviewed-on: https://chromium-review.googlesource.com/1142355Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576304}

Clean up transfer.js browser test, and generalize it to transfer between
different sources and destinations, move and copy and allow transfer
failures.

This is pre-work to add tests for all the possible transfer behavior
operations.

Bug: 722324
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib1d43a9fe1b7160fe9c93ec10c8cfb1c460889e0
Reviewed-on: https://chromium-review.googlesource.com/1128660
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576303}

Remove the method from PreloadController and CRWWebController
and replace it with a new WebStateDelegate method ShouldAllowAppLaunching
that is implemented by both PreloadController and BrowserViewController.


Bug: 850760, 674991
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I28cd1b512368f27572a028c43f8caaebfe135a8b
Reviewed-on: https://chromium-review.googlesource.com/1137343Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576302}

Since DeviceMotionData class has all the information from
device::MotionData, and DeviceMotionEventPump is now in blink,
DeviceMotionData is now passed to DeviceMotionDispatcher.
device::MotionData will be removed in a subsequent change.

Bug: 861923
Change-Id: I1165d1dbd128197e2e00d7ad63db17d03e6af810
Reviewed-on: https://chromium-review.googlesource.com/1137171
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576301}

Bug: 803774
Change-Id: I91b9def8e3e4506c4d8913cb351129286f3686d1
Reviewed-on: https://chromium-review.googlesource.com/1141668
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576300}

Port.test_type just tries to guess about test type based on
baselines; it sometimes returns "unknown" for test types that
actually are knowable (e.g. because they're in wpt manifest).

This method isn't used except in the script print_web_test_types.py,
and I believe nobody is using that script.

Bug: 740997
Change-Id: I1e98601504affd2d75ab92409ae20da9d28b92a4
Reviewed-on: https://chromium-review.googlesource.com/1142229
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576299}

Re-introduces dynamic header height on Recent Tabs for iOS11.
Originally this was removed because of an iOS10 bug, but
there's no need to stop supporting dynamic height on iOS11.

Bug: 862744
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I17ec0f4b2257b23c24d8ed3e285efce023e3e141
Reviewed-on: https://chromium-review.googlesource.com/1142697
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576298}

Roll to current release version (1.16)

TBR=bajones@chromium.org

Change-Id: Idcb7094df11ddd773e06b89f75d78835558ac6f0
Reviewed-on: https://chromium-review.googlesource.com/1142785Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576297}

Three more cases are added to the Direct Composition Pixel tests.
Pixel_DirectComposition_Underlay test is created by adding a black block
on top of a video.
Pixel_DirectComposition_Nonroot test is created by adding a white gradient
blending effect on a video.
Pixel_DirectComposition_ComplexOverlays test is created by applying scaleX,
scaleY and rotate.

The H.264 mp4 video clip FourColors.mp4 used in these tests is created by
Maggie Chen. The video frames has 4 color blocks (Yellow, Red, Green, Blue)
and it looks like a still image. With this video, the pixel tests can be
done by solid color block comparisons. No golden images are needed.

Bug:848097

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I95483ba8c96c495b1150c749f1f55243c6a5efa5
Reviewed-on: https://chromium-review.googlesource.com/1136003
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576296}

This CL:

1) Extracts StatementID from sql/connection.{h,cc} into its own files
   sql/statement_id.{h,cc}.
2) Adds tests specifically targeting sql::StatementID.
3) Replaces passing StatementID by const reference with passing by
   value.
4) Removes the StatementID constructor that takes a name, and updates
   the call sites to use the source file+line constructor.

Bug: 863724
Change-Id: I5bc6e160fe294189d3e9a2baa8f6be61b21c38d2
Reviewed-on: https://chromium-review.googlesource.com/1137915
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576295}