GitLab

This is a reland of 5c4908e8

Original change's description:
> macOS V2 Sandbox: Remove the feature flags.
>
> The V2 sandbox is now default for all but the network and GPU processes
> on macOS. This CL deletes the feature flag. A new experiment will be
> introduced for the GPU process. The default case for the sandbox profile
> switch is removed, because previous CHECK() failures were confusing to
> diagnose. All profiles must now be handled explicitly, so Chrome won't
> build if a new profile type isn't handled.
>
> Bug: 749839
> CQ-Depend: 1268671
> Change-Id: I0860d3a5148b0085be6a99dc01c4971602ee5582
> Reviewed-on: https://chromium-review.googlesource.com/c/1269996
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Greg Kerr <kerrnel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598128}

CQ-DEPEND=CL:1268671

Bug: 749839
Change-Id: I91544907b640c572823f3aae3e29c0cfa003da51
Reviewed-on: https://chromium-review.googlesource.com/c/1274888Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598822}

When determining if a particular script is an ad, the execution
context should be considered and any script running in an ad context
should be considered an ad script. This provides enhanced coverage
when an ad script then reaches into another context to run a function.

Bug: 894080
Change-Id: I69de3343b004b6ef7b7edfe24c7cbda67c925101
Reviewed-on: https://chromium-review.googlesource.com/c/1273823Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598821}

I found these additional cases in an audit of the code for bug 889220.

Bug: 889220
Change-Id: I649200d91625c2a47848132b79a846174fa4a3e1
Reviewed-on: https://chromium-review.googlesource.com/c/1276551
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598820}

This view will house the webUI that will display Happiness Tracking Surveys.
and it is currently being triggered from the NTP. There is still work to be
done to ensure the extensibility of the hats service. but that will be tackled
after the first survey is established.

Bug: 807714
Change-Id: If61103b72eb0a8c87d42fee7d2b22f765c28e8ae
Reviewed-on: https://chromium-review.googlesource.com/c/1257553
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598819}

This reverts commit d77817c5.

Reason for revert: Land change after M71 branch point to mitigate risk.

Original change's description:
> Use RasterDecoder for CPU raster
> 
> This CL uses RasterDecoder for CPU rasterization (one-copy and
> zero-copy) on worker background raster threads in two cases:
> 
> (1) in renderers whenever GPU raster is blacklisted or cannot create
>     GrContext (similar to
>     LayerTreeHostImpl::GetGpuRasterizationCapabilities)
> 
> (2) in browser whenever GPU raster is not requested
> 
> This CL copies some of the logic in LTHI::GetGpuRasterizationCapabilities
> to RenderThreadImpl::SharedCompositorWorkerContextProvider.
> I copied it so that if we fail GPU rasterization using GLES2Decoder, we
> can fallback to CPU raster using a RasterDecoder.
> 
> This change should be safe because we have been fuzzing all
> RasterDecoder entry points for about 1 quarter.
> 
> When testing this CL, I noticed that chrome://gpu was reporting
> rasterization status incorrectly with --force-gpu-rasterization flag,
> so I fixed that too.
> 
> Bug: 880911
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I8d93b9d0bfe30e9ee0d5e522be0d9f8155a28726
> Reviewed-on: https://chromium-review.googlesource.com/c/1258206
> Commit-Queue: Jonathan Backer <backer@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598801}

TBR=backer@chromium.org,piman@chromium.org

Change-Id: Icd39538a7c98d9d9bb5fff13ddfda12dd46fa05a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880911
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1277267Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598818}

Bug: 801985

TBR=sdefresne@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3818337ec7868677429cc0130e00d061d2cfecbe
Reviewed-on: https://chromium-review.googlesource.com/c/1269873
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598817}

- The added -expected.txt are all about different graphics layer hierarchy.
- Modified -expected.png are about anti-aliased pixels.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib2e471abc8c6d7f97e38dd499c2c59ba58ffaff5
Reviewed-on: https://chromium-review.googlesource.com/c/1274887Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598816}

Pressing the buck button while the ARC IME shows up should hide the
virtual keyboard.
Note that this CL doesn't change the behavior of the back button
in the browser window because it doesn't generate the key
event.

Bug: 845079, 894362
Change-Id: I49de330462339cfc89490827f5e65cc1aef60368
Reviewed-on: https://chromium-review.googlesource.com/c/1276085
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598815}

This CL fixes two crash in video thumbnail flow.

1. VideoFrameExtractor::ReadVideoFrame can return nullptr, and should
report error.

2. Invalid media::VideoDecoderConfig will cause mojo serialization
failure, instead we can use optional to gracefully handle this case.

TBR=dcheng@chromium.org

Bug: 893207
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0dc3115c1a25231535c0743723103d870cbe59fd
Reviewed-on: https://chromium-review.googlesource.com/c/1269724
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598814}

Dice allows enabling multi-account support for extensions.
Since account consistency is now per-profile, this CL refactors the
multi-account support to be per profile as well.

The existing command line switch is removed and replaced by a
base::Feature, which is disabled by default.
Unlike the switch, the feature only enables multi-account for
Dice, and there is no way to enable multi-account when dice is
not enabled.

Bug: 731066
Change-Id: Ice8534f0227bf04bab11aeacb572fb1accde1abd
Reviewed-on: https://chromium-review.googlesource.com/c/928763
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598813}

TBR=kbr@chromium.org

bug: 874939
Change-Id: I1846557bc8534c51f832d3e778c06cf043e81cb0
Reviewed-on: https://chromium-review.googlesource.com/c/1276885Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598812}

This CL adds the OriginTrialsEnabled idl attribute to all
BackgroundFetch idl files, and a LayoutTest to test that when
the origin trial is enabled, the properties in these interfaces
are available.

Change-Id: Ia71e28aaf5cbd03b943a5eff904d21e8f536ea84
Bug: 894448
Reviewed-on: https://chromium-review.googlesource.com/c/1261405Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598811}

Bug: 874553
Change-Id: I9ca8547217eb0b6744bf61f07a91cb818a368534
Reviewed-on: https://chromium-review.googlesource.com/c/1273805
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598810}

This reverts commit 1c320598.

Reason for revert: broke compilation on Win
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932944647631542128/+/steps/compile/0/stdout

../../third_party/blink/renderer/platform/testing/image_decode_bench.cc(43,26):  error: no matching conversion for functional-style cast from 'const char *' to 'base::FilePath'
    const auto file_path = base::FilePath(name);

Original change's description:
> blink image_decode_bench: use more Chromium stuff
> 
> This CL refactors image_decode_bench:
> - Rewrites function ReadFile() to use base::FilePath etc.
> - Configures the Logging and changes fprintf/stderr to LOG()
>  statements, and exit()s into LOG_ASSERT().
> - Names the constant kDefaultDecodeTimes.
> - s/DecodeError/PrintErrorAndExit/ to clarify what it does.
> - Changes uses of CurrentTimeTicks() with base::ElapsedTimer,
>  and uses TimeDelta ISO double to count the elapsed time.
> - Uses perf_test::PrintResult to add info about the image
>  (size and #pixels), when a new parameter (-v / -verbose)
>  is specified after the current two parameters, file and
>  #iterations; output is e.g.:
> *RESULT decode_time /usr/local/google/home/mcasas/Pictures/4.webp: 100 times 790528 pixels (1024x772)= 66.27827 ms/sample
> 
> Bug: 889898
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Ic0a66d2aa3d2f08b13c8af99aed31e61d7246dec
> Reviewed-on: https://chromium-review.googlesource.com/c/1225653
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Leon Scroggins <scroggo@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598803}

TBR=scroggo@chromium.org,noel@chromium.org,mcasas@chromium.org

Change-Id: I7f18f8a464536eb5b6cee86f25930a94f357a0f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 889898
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1277245Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598809}

In this case, arch="iPhone10,3" was not matched by \w+.

Also, fixed escaping . in several places inside regexes.


Bug: 881076
Change-Id: I2814eedce66b1b3c0a8fa8fff0eb6490dc4906cb
Reviewed-on: https://chromium-review.googlesource.com/c/1276889Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598808}

This is the unit test for https://crrev.com/595477, which fixes a crash
when ChromeDriver receives a large number of message packs from Chrome
(issue #877105). The test forces a large number of message packs by
using a very small buffer size.

Bug: 877105
Change-Id: I20895447ef33d75acd07135d8234e899ab1ed91d
Reviewed-on: https://chromium-review.googlesource.com/c/1272068
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598807}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/54ca2cd59219..6272edcb53d3

$ git log 54ca2cd59..6272edcb5 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 junyer Dial down the fanout limits slightly.

Created with:
  roll-dep src/third_party/re2/src

R=mmoroz@chromium.org

Bug: 894073
Change-Id: I4ec6ee50d405fb3b6d72fc27a328cb8b3e16bad2
Reviewed-on: https://chromium-review.googlesource.com/c/1276826Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598806}

When the user is picking a preferred ContentSize from the
"accessibility" bucket, the layout of the article should be different.

Bug: 893525
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8686c33ef80775d799e6fbb8752ee4c011798154
Reviewed-on: https://chromium-review.googlesource.com/c/1273147Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598805}

This reverts commit 7f08809a.

Reason for revert: broke compilation
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932945363042209344/+/steps/compile/0/stdout

../../gin/v8_foreground_task_runner.h:27:60: error: only virtual member functions can be marked 'override'
    void PostNonNestableTask(std::unique_ptr<v8::Task> task) override;
                                                             ^~~~~~~~
  ../../gin/v8_foreground_task_runner.h:34:40: error: only virtual member functions can be marked 'override'
    bool NonNestableTasksEnabled() const override;

Original change's description:
> [gin] Allow posting non-nestable tasks through V8
> 
> Will be used to allow V8 posting top-level tasks.
> 
> Bug: chromium:843903
> Change-Id: I97caa705b561fa8832ef8a11abfc3eefe47ec3f8
> Reviewed-on: https://chromium-review.googlesource.com/c/1273140
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598802}

TBR=mlippautz@chromium.org,jochen@chromium.org

Change-Id: I5d427abfe85e3b69a3d649ee190406a5d9583d9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:843903
Reviewed-on: https://chromium-review.googlesource.com/c/1277086Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598804}

This CL refactors image_decode_bench:
- Rewrites function ReadFile() to use base::FilePath etc.
- Configures the Logging and changes fprintf/stderr to LOG()
 statements, and exit()s into LOG_ASSERT().
- Names the constant kDefaultDecodeTimes.
- s/DecodeError/PrintErrorAndExit/ to clarify what it does.
- Changes uses of CurrentTimeTicks() with base::ElapsedTimer,
 and uses TimeDelta ISO double to count the elapsed time.
- Uses perf_test::PrintResult to add info about the image
 (size and #pixels), when a new parameter (-v / -verbose)
 is specified after the current two parameters, file and
 #iterations; output is e.g.:
*RESULT decode_time /usr/local/google/home/mcasas/Pictures/4.webp: 100 times 790528 pixels (1024x772)= 66.27827 ms/sample

Bug: 889898
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic0a66d2aa3d2f08b13c8af99aed31e61d7246dec
Reviewed-on: https://chromium-review.googlesource.com/c/1225653
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598803}

Will be used to allow V8 posting top-level tasks.

Bug: chromium:843903
Change-Id: I97caa705b561fa8832ef8a11abfc3eefe47ec3f8
Reviewed-on: https://chromium-review.googlesource.com/c/1273140Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598802}

This CL uses RasterDecoder for CPU rasterization (one-copy and
zero-copy) on worker background raster threads in two cases:

(1) in renderers whenever GPU raster is blacklisted or cannot create
    GrContext (similar to
    LayerTreeHostImpl::GetGpuRasterizationCapabilities)

(2) in browser whenever GPU raster is not requested

This CL copies some of the logic in LTHI::GetGpuRasterizationCapabilities
to RenderThreadImpl::SharedCompositorWorkerContextProvider.
I copied it so that if we fail GPU rasterization using GLES2Decoder, we
can fallback to CPU raster using a RasterDecoder.

This change should be safe because we have been fuzzing all
RasterDecoder entry points for about 1 quarter.

When testing this CL, I noticed that chrome://gpu was reporting
rasterization status incorrectly with --force-gpu-rasterization flag,
so I fixed that too.

Bug: 880911
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8d93b9d0bfe30e9ee0d5e522be0d9f8155a28726
Reviewed-on: https://chromium-review.googlesource.com/c/1258206
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598801}

Modernize the interface for JavaRef and its subclasses - make better use
of C++11 features, and mark existing confusing/easily misused APIs as
deprecated. Also. fully reformat the file while it's being changed this
much.

Notable changes:
 - JavaRef can now be converted to bool in bool contexts, so "if (obj)"
   works and "!obj.is_null()" is no longer necessary.
 - ScopedJavaLocalRef<T>::Adopt() now exists to make it more explicit
   that the caller is adopting an existing reference, not creating a new
   one. This should only be used when dealing with return values from
   JNIEnv methods.
 - Conversion constructors/assignments now exist, allowing for example
   JavaRef<jstring> to be assigned to ScopedJavaLocalRef<jobject>.
 - Local references can be constructed or assigned from global
   references and vice versa without needing to use Reset().
 - Confusing forms of Reset() that take different parameters, or behave
   differently from, construction/assignment have been deprecated.

The new API is intended to be somewhat similar to scoped_refptr, which
is the closest native equivalent.

Bug: 519562
Test: base_unittests
Change-Id: I8a989dd04b357e83bc2a28a6ec9b7e14495ccbd2
Reviewed-on: https://chromium-review.googlesource.com/c/1262115
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598800}

Bug: 888176
Change-Id: Ib823bc98d8aaadbd5deacf2ff7288e3661a73db2
Reviewed-on: https://chromium-review.googlesource.com/c/1274841Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598799}

Define a new helper class to register and unregister the test
factory to use in GCMProfileServiceFactory. It uses RAII to
ensure the factory is properly unregistered during the test
cleanup.

Bug: 809610
Change-Id: Iec5457b6372ea23d33f3a07de894c33100f7d9e0
Reviewed-on: https://chromium-review.googlesource.com/c/1261123
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598798}

We need to update the bottom margin on browser controls constraint
changes for VR.

Bug: 884803
Change-Id: I684eac23d8aefcaa8ad8c4cddcf12ebc4a6352cc
Reviewed-on: https://chromium-review.googlesource.com/c/1275145Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598797}

In Python tests in case Chrome fails to start with timeout,
it will be restarted, but no more than 3 times per suite.

Change-Id: Idafa7702d0fe63d4f430ba7a7311b4e62cbafbc7
Reviewed-on: https://chromium-review.googlesource.com/c/1272578Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598796}

WrapUnique(new ...) should be std::make_unique.

Bug: none
Change-Id: Ic2687b75ab5ef5884d2857d05defb37908a9e1ee
Reviewed-on: https://chromium-review.googlesource.com/c/1234961
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598795}

Fix launchApp command flakiness that has been observed in testing.

Bug: chromedriver:2607
Change-Id: I0db77d353079534238e857ffa090de0a37b52568
Reviewed-on: https://chromium-review.googlesource.com/c/1274589
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598794}

This changes adds an enterprise policy that disables NTLM authentication
protocol for enterprise-managed users and allows them to manually turn
it on.
For non-enterprise users, it will be enabled by default.

Bug: chromium:888096
Change-Id: If42e57b9242600ab9b51d61874bf810e2d32a804
Reviewed-on: https://chromium-review.googlesource.com/c/1256002Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598793}

The multiple meanings with the bottom controls are a root for multiple
issues:
 * the CCT bottom bar being overlaid (and leaving a white patch)
 * the PWA bar resizing the viewport deferred
 * the flakiness of fullscreen applications

This CL introduces a solution that provides the bottom bars and the
compositor view holder with the "keyboard extension" as new bottom
element that is independent from others.

Currently, this extension is set on the instance. Long-term, the
delegate would only provide a getter that its children inherit.

Bug: 885113, 704070, 875077, 891657, 881536
Change-Id: I59639204823296b7c4ac701d0243aaa751f8b57d
Reviewed-on: https://chromium-review.googlesource.com/c/1233716
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598792}

Until now CSSFlexibleBox use counter was counting
not only "display: flex|inline-flex" elements,
but also buttons or any other classes that inherit
from LayoutFlexbibleBox:
That's an implementation detail and we shouldn't be interested
in counting those cases as flexbox usage.

The patch moves the counter to LayoutObject::CreateObject()
so we actually check the display value.
The patch also moves the grid layout counter,
despite nobody is inheriting from LayoutGrid now,
a similar issue could happen in the future if someone does it.

New unit tests are added to verify that things are working
as expected now.

Change-Id: I716870a666a4167d19153667bc80f68a3ba0d7e3
Reviewed-on: https://chromium-review.googlesource.com/c/1273107
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598791}

A particular RenderProcessHost may be re-used for multiple renderer
processes. The bug is that GinJavaBridgeMessageFilter is not removed
when this happens, so it is not re-added as a filter to the new renderer
process in this case.

Fix by removing the filter when renderer process dies, so a new filter is
created and added when the new renderer process is created.

Bug: 892452
Change-Id: I0762019282f89d21c53136db58a99d8bbce3af1c
Reviewed-on: https://chromium-review.googlesource.com/c/1274590Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598790}

Previously, the DeviceSync service would retain references to its
dependencies until it was deleted when the browser process was killed.

When attempting to enable the MultiDevice flags by default, this
causes crashes in some tests due to the service not removing itself as
an observer. This CL adds an explicit shutdown step which removes these
references and causes the observer to be removed.

Sample failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933085811650027344/+/steps/sync_integration_tests__with_patch_/0/logs/USS__x2f_SingleClientWalletSyncTest.DownloadProfileStorage__x2f_0/0

Bug: 884066
Change-Id: I87bcc9ab27f0a1032bc6990a71f863786ddf97fc
Reviewed-on: https://chromium-review.googlesource.com/c/1274886
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598789}

- When using chromad kerberos, don't resolve the hostname into an ip
address since kerberos service tickets are keyed on the hostname
- Previously, we resolved any hostname we could (meaning the share was
found during discovery) into an ip address, which could prevent chromad
kerberos from working correctly.

Bug: chromium:853806
Change-Id: I48feec54defdb2821dee526f9f25cff0260363b6
Reviewed-on: https://chromium-review.googlesource.com/c/1274048
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598788}

Change the watchlist to cover ui code like:
chrome/browser/resources/settings/clear_browsing_data_dialog
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingData*

Change-Id: Ibe872c09e8ba9737faf474c1126524ca8c148531
Reviewed-on: https://chromium-review.googlesource.com/c/1276765Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598787}

Not sure yet why this isn't breaking M71, but it's breaking M70.

Bug: 894429
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7eadef0d8a6e990e37300ec0b391f05c1220ec0d
Reviewed-on: https://chromium-review.googlesource.com/c/1276566
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598786}

This is a prerequisite to:
https://chromium-review.googlesource.com/c/chromium/src/+/1122629

When a file chooser dialog is opened for an active iframe, but is closed
when the iframe is in pending deletion, it should not continue.

Bug: 609963
Change-Id: I897258f642e812de4b3abf117a2a83815568aba8
Reviewed-on: https://chromium-review.googlesource.com/c/1253783
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598785}

Currently to fix a layout issue in the save card infobar in iPhone X,
|-setFrame:| is overridden to call |-layoutIfNeeded| in order to update the
layout of subviews immediately. |-setFrame:| won't be required to be
overridden if the logic to adjust the layout constraints is moved from
|-sizeThatFits:| to |-layoutSubviews|. The existing logic is likely to be
wrong as the layout should not get updated in calls to |-sizeThatFits|.

This is likely the root cause for the crash in crbug.com/892144

Bug: 862688,892144
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iee81a30afa14581f304813512b84b86fc5c6feb5
Reviewed-on: https://chromium-review.googlesource.com/c/1262087
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598784}

Current resources that are cached are being reported as 0 byte
resources in Ads.ResourceUsage.Size.* histograms. This is skewing
the histograms low making it hard to see the real distribution of
resource sizes. Record cached resources in a separate histogram.

Change-Id: I379029ff70ad9f655a8e8887ff7cb5a5a3a08f5e
Bug: 859080, 892153
Reviewed-on: https://chromium-review.googlesource.com/c/1258284Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598783}