GitLab

This CL corrects some typoes added in in crrev.com/c/1468144:

1. The ServiceWorkerCache.Cache.*.Match histogram contains its
   own values in addition to have child suffixes.  It should not be
   marked as a pure base.
2. The ServiceWorkerCache.CacheStorage operation suffixes were applied
   to the ServiceWorkerCache.Cache.* histograms incorrectly.

Bug: 927537
Change-Id: I3d46f1aca0b6d7f90ee14a8b18694cfeb5b0f51a
Reviewed-on: https://chromium-review.googlesource.com/c/1481470Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634742}

This CL is adding the missing constuctors receiving the Location
information to ScopedBlockingCall. The location information is added
to the trace event with the same format than the top-level run tasks
events.

The ScopedBlockingCall constructors will be moved to the new
constructor with the Location in the following CLs.

R=gab@chromium.org

Bug: 934302
Change-Id: I6247a1ae099c45ebe9454cd74e9953a2add6e70f
Reviewed-on: https://chromium-review.googlesource.com/c/1479846Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634741}

https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/swarming/doc/Bot.md#graceful-termination_aka-the-sigterm-and-sigkill-dance

test_env.py already has support for this, but it looks like a lot
of the scripts aren't using it. One reason for that could be that
there wasn't a run_command function there yet. I added a simple
run_command function, and made a bunch of scripts use it.

This should fix up all the test suites that use common.py's
functions to run subprocesses including:
 - run_telemetry_as_googletest.py
 - run_chromedriver_test.py
 - telemetry_gpu_unittests.py
 - telemetry_perf_unittests.py
 - telemetry_unittests.py
And many more!

Also delete common's run_integration_test function since no
one is using it.

Bug: 921662, 910584
Change-Id: If670e1b5725e3a7dcfda471b7141d47c73c5ef82
Reviewed-on: https://chromium-review.googlesource.com/c/1461512Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634740}

Add an observer to the tab life cycle unit that will receive the discard
reason every time a tab is being discarded or reloaded, and log the event
type and reason of this state change to the browser-level TabStatsTracker,
which will report the statistics to User Metrics Analysis at regular time
interval as histograms.

Follow-up to CL/1455472.

Change-Id: I7f39dc7693e81cd2a06250dccc685525c11ff590
Reviewed-on: https://chromium-review.googlesource.com/c/1460071Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Yue Ru Sun <yrsun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634739}

Refactoring BrowserThemePack for Chrome Colors. This CL also introduces
skeleton function for Chrome Color generation and a temporary entry point.

Bug: 930206
Change-Id: I1080c4b0bd292c19f024febc36a08a9e0f48ba6a
Reviewed-on: https://chromium-review.googlesource.com/c/1469069
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634738}

In SingleProcessMash there are two aura::Envs. See design doc for details.
This code was calling aura::Env::GetInstance() and expecting to get Ash's
Env. In SingleProcessMash aura::Env::GetInstance() returns Chrome's aura::Env.
The fix is to get the env from the window.

I'm also renaming 'desktop_window_' to display_root_window_ to make it clearer
that the window corresponds only to a display root.

BUG=b:124258894
TEST=none

Change-Id: I3b85610d72ada8adb674441e6e47d5ddd9d1b37f
Reviewed-on: https://chromium-review.googlesource.com/c/1483351Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634737}

This can happen for reinstall candidates, but not for typical play
store candidates. UX from Shibasheikh@ .

Screenshots of before/after:

https://photos.app.goo.gl/sgnKe5pSYTX9AT5P9

Bug: 911427
Change-Id: Ia32be4956f734410b20e8102e755293f4d1b023e
Reviewed-on: https://chromium-review.googlesource.com/c/1469801Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634736}

Bug: 926235
Change-Id: I20c96005e0a87f7487811a282247b7193b4fdbdf
Reviewed-on: https://chromium-review.googlesource.com/c/1483253
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634735}

This CL fixes an UI issue where Skip Ad button right border is displayed
in ChromeOS while it shouldn't.

Bug: 933749
Change-Id: Ibdb8f477d411b733a1b88d1e912714de4c888060
Reviewed-on: https://chromium-review.googlesource.com/c/1482450
Auto-Submit: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634734}

This patch adds Android's implementation of
ContentCaptureReceiverManager which forwards the received message
to its Java peer.

Defines ContentCaptureConsumer interface which should be implemented
to consume captured content.

Bug: 924681
Change-Id: Ia71b74fd04eb63ff24f0b9683cebc3d089e8ec15
Reviewed-on: https://chromium-review.googlesource.com/c/1476515Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634733}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/202f8887f83f..429a6ce38996


git log 202f8887f83f..429a6ce38996 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 mikenichols@chromium.org simple_builders.py:  Remove VMTests from parallel execution


Created with:
  gclient setdep -r src/third_party/chromite@429a6ce38996

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibed136c986a9e4d0aa177e2b9e55dd0c25edf649
Reviewed-on: https://chromium-review.googlesource.com/c/1483156Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634732}

These are not working in 73 but do in 72. Added a new decorator for a
range.
The blackhole test needs to be restricted to <=71

Bug: 933979
Change-Id: I37c67a299e825cde288712b3edb33a7cfe504512
Reviewed-on: https://chromium-review.googlesource.com/c/1479638Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634731}

Some tests are consistently failing

TBR=jbudorick@chromium.org

Bug: 934582, 928459
Change-Id: I405cc5093bb0e28694e332b4a546133507ae94c7
Reviewed-on: https://chromium-review.googlesource.com/c/1482116Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634730}

This CL also updates the string fot the "Manage passwords" button
according to the new spec.

Bug: 835234
Change-Id: I8d003069fed7734c42ef50c5997f43b319cc45e6
Reviewed-on: https://chromium-review.googlesource.com/c/1482977Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634729}

https://chromium.googlesource.com/angle/angle.git/+log/b9039bf76bf3..cf9b2853a7e7


git log b9039bf76bf3..cf9b2853a7e7 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 jmadill@chromium.org Roll Google Test.


Created with:
  gclient setdep -r src/third_party/angle@cf9b2853a7e7

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I62f283c8870ca3c7c81821b657b0689718f31047
Reviewed-on: https://chromium-review.googlesource.com/c/1483157Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634728}

The main motivation is to make the fuzzers pick up the
BORINGSSL_ALLOW_CXX_RUNTIME define, which (in addition to fixing
-Wextra-semi warnigns) makes the fuzzers use the same setting
we use for regular boringssl.

Making most of the other defines consistent is good too.

One undesired side effect is that the fuzzers now also pick up
BORINGSSL_IMPLEMENTATION but that's incorrecto for boringssl's tests already
and improvements for that are tracked in boringssl:258

Bug: 926235
Change-Id: I21a111f308bccb81e23bbdd96b6ba4e218ffd2d5
Reviewed-on: https://chromium-review.googlesource.com/c/1482566
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634727}

The 'Earth' background is the most popular background, based on requests
from the New Tab Page

Bug: 924176
Change-Id: Icf0b4192a19c289788199ee9b616bf8afb2a31b7
Reviewed-on: https://chromium-review.googlesource.com/c/1481991
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634726}

Bug: None
Change-Id: Ie047d98ae56bc5a4a85483f4e2711fda03d7e0f1
Reviewed-on: https://chromium-review.googlesource.com/c/1482563
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634725}

https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/a9bac57ce6c9..f7ce90e84f5a

$ git log a9bac57ce..f7ce90e84 --date=short --no-merges --format='%ad %ae %s'
2019-02-19 krb [spellcheck] Rename cy-GB bdic correctly
2019-02-14 krb [hunspell] Add cy_GB(Welsh) dictionary files
2017-10-16 hichris123 Delete old English dictionaries

Created with:
  roll-dep src/third_party/hunspell_dictionaries

Bug: 692242
Change-Id: I6ba5262dd68f7b60e12d57754e5bf956244fe7ee
Reviewed-on: https://chromium-review.googlesource.com/c/1481056Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634724}

Note that the main logic to handle focus transitions from status area
--> shelf was added in CL 1475149. This makes some small tweaks and
mainly adds the logic for transitions in the other direction.

This is a little more involved because we need to handle situations
where the overflow bubble is showing.

This also adds some extensive tests covering focus-cycling between all
these elements.

You can see a screencast of what this looks like in
    https://bugs.chromium.org/p/chromium/issues/detail?id=753409#c34

Bug: 753409
Change-Id: Ia903c27f54226b4d67cf796d2d076f9da72225a9
Reviewed-on: https://chromium-review.googlesource.com/c/1477464
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634723}

Bug: 934865
Change-Id: I92ebfc18b621b66aff1ab1d32ccb2bb7f44212c5
Reviewed-on: https://chromium-review.googlesource.com/c/1482945
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634722}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9eb6c534..045e7629

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1de6ee96db0e08664e427896658ab8e7b936fca7
Reviewed-on: https://chromium-review.googlesource.com/c/1482942Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634721}

The methods declared & defined in network_instrumentation.[h|cc] are used
only in a few places in ResourceFetcher and ResourceLoader and there is
little benefit on tracing events through them. Instead, this patch drops
those files and inlines their usage in those few places using them.

Additionally, this CL also moves UrlForTraceEvent() in resource_fetcher.cc
to an anonymous namespace along with the other methods returning unique_ptr
pointers to TracedValue, instead of leaving it as a static function.

Bug: 922151
Change-Id: Ia024909609f1c8b79b8cdc0c673f44ec0499944b
Reviewed-on: https://chromium-review.googlesource.com/c/1477686Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#634720}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b607bc8800c1..7aafb27453d3


git log b607bc8800c1..7aafb27453d3 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 headlessclayton@gmail.com Add CMake flag to treat warnings as errors


Created with:
  gclient setdep -r src/third_party/swiftshader@7aafb27453d3

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/123933266
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: I04b1004089626489fb4e47405695a3611a716a3f
Reviewed-on: https://chromium-review.googlesource.com/c/1483159Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634719}

There is no need for clients to call OnChildResizing() as it does nothing in
mus.

BUG=none
TEST=none

Change-Id: Ia38b2032068ac011325fdf0717e8db07a9943626
Reviewed-on: https://chromium-review.googlesource.com/c/1479290
Auto-Submit: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634718}

It controls kerberos credentials delegation behaviour.

BUG=chromium:930019
TEST=not yet

Change-Id: I363f87177757f422959f9b1c55266de49f0ca1a8
Reviewed-on: https://chromium-review.googlesource.com/c/1479962
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634717}

Bug: 931866
Change-Id: Iad447daafcae5486529784fd40686f517fab1ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1482955
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634716}

Test renders 4 colors in 4 quadrants and use glReadPixels to read the
center pixel of each quadrant and and check if the rendering result
matches expectation.

Change-Id: If7b89506c1b84448e98f18b58c85aecff99f04bc
Reviewed-on: https://chromium-review.googlesource.com/c/1476120
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634715}

https://skia.googlesource.com/skia.git/+log/c6461681d608..18e5841c0dae


git log c6461681d608..18e5841c0dae --date=short --no-merges --format='%ad %ae %s'
2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-02-22 thomasanderson@chromium.org Make SkFontConfigInterface_direct and sysroot-aware


Created with:
  gclient setdep -r src/third_party/skia@18e5841c0dae

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:822737,chromium:908463
TBR=jvanverth@chromium.org

Change-Id: I9bd3e3b98970fd6363c4f4868c53abc303361fab
Reviewed-on: https://chromium-review.googlesource.com/c/1483154Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634714}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a33c0190f771..67e798b11f20


Created with:
  gclient setdep -r src-internal@67e798b11f20

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0e857226297c5f614936a0192f1b066da65cd13c
Reviewed-on: https://chromium-review.googlesource.com/c/1483290Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634713}

This CL adds two chrome://flags flags for crrev.com/c/1475065.

Bug: 931836
Change-Id: I513f988e36c853383c41f48b1ed0841a5ca10b60
Reviewed-on: https://chromium-review.googlesource.com/c/1481904Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634712}

This adds a test for the case where the start and end circles of a
radial gradient fully overlap (while having non-zero radii).

Bug: 933413
Change-Id: Id059cb607f6fc137111d2306dd9c9eef1f55b6bc
Reviewed-on: https://chromium-review.googlesource.com/c/1483023
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634711}

This patch refactors the relationship between PaymentRequestDialogView
and PaymentRequestState to be more generic. Instead of waiting for the
state event of fetching all payment instruments (specific), the view now
waits for an initialization task (abstraction) to finish initialization
(generic). This will help to add more initialization tasks in follow up
patches. For example, PaymentRequestSpec will become an initialization
task as well, so the view can wait for the spec to completely
initialized, in case if PaymentRequest.show() was called with a promise.

Bug: 817073
Change-Id: I19c133ab3084a7a26628380135c21abeeb1c7436
Reviewed-on: https://chromium-review.googlesource.com/c/1478090
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634710}

R=haraken@chromium.org
CC=blink-reviews-onion-soup@chromium.org

BUG=891908

Change-Id: I2783d2caf8b915a06bb5277d35ca650f079a58c7
Reviewed-on: https://chromium-review.googlesource.com/c/1483173
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634709}

This CL adds a null check to prevent a crash occurring in
MediaSessionImplParamBrowserTest.

Bug: 933742
Change-Id: Ia2d6eaf9a8a8c7ce1e165ad56d09ec3d6830730c
Reviewed-on: https://chromium-review.googlesource.com/c/1481081Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634708}

Change-Id: I21690fe27cb4ea7e256943fe6ffc6ed7e8bb99c1
Reviewed-on: https://chromium-review.googlesource.com/c/1481964
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634707}

This reverts commit f54db458.

Reason for revert: Miscommunication with server team requirements. Need to change some logic

Original change's description:
> HTTPS Previews: Use the DRP experiment instead of a Finch-provided one
> 
> This experiment doesn't actually seem very useful in Finch. It's better
> to reuse the DRP experiment which is accessible in chrome://flags.
> 
> Bug: 934376
> Change-Id: I27a5bdfa4f57fa761eaae62106113e7fc5529ba1
> Reviewed-on: https://chromium-review.googlesource.com/c/1481995
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Commit-Queue: Robert Ogden <robertogden@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634682}

TBR=robertogden@chromium.org,ryansturm@chromium.org

Change-Id: I354e3ca9ccd61617b47031ba0880890084210a9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 934376
Reviewed-on: https://chromium-review.googlesource.com/c/1482947Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634706}

It's hit when creating a new window in fullscreen. The linked bug
mentions leaving it in place as a reminder to add a test, but I keep
getting bit. The bug should sufficiently document the need for a test.

Bug: 844482
Change-Id: Ibbd1cf24864c8122e82ba189072dcc2711afc326
Reviewed-on: https://chromium-review.googlesource.com/c/1482558
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634705}

- This change prevents more than one instance of a UpdateCredential
  dialog for a single mount.
- Each mount, when prompted, will have their own dialog to update
  credentials.
- Previously, it was possible to have multiple dialogs and would crash
  the File App. The cause of the crash is after successfully updating
  the credentials of the share via the first dialog, the second dialog
  is no longer in a stable state and holds stale callbacks.

Bug: 931846
Test: end to end manual test
Change-Id: I09f85c084028943bceed3831e81cefce503f2bb7
Reviewed-on: https://chromium-review.googlesource.com/c/1470726
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634704}

[Sheriff] Expectations for virtual/outofblink-cors-ns/http/tests/security/cross-origin-worker-indexeddb-allowed.html

The test is flaky (crashing) on Mac

Bug: 934866
No-try: True
No-presubmit: True
Change-Id: I8ab29cf258e6b7c80e0c4589c54f6fedab6641db
Reviewed-on: https://chromium-review.googlesource.com/c/1482833Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634703}