- 06 Aug, 2019 30 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7c8928d0a054..bf176a0d6db9 git log 7c8928d0a054..bf176a0d6db9 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 timvp@google.com Vulkan: Suppress KHR-GLES2 ASTC 3D Texture Tests Created with: gclient setdep -r src/third_party/angle@bf176a0d6db9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: None Change-Id: I7742af3a90c08fd3f08ae515fa07b5cfce74b8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684212}
-
Chih-Yu Huang authored
We plan to enable new VideoDecoder implementation per board, instead of enable all boards at the same time. We won't enable boards that are not supported yet. This CL remove the fallback video decoder. Then we could catch any initialize or runtime failure of new VideoDecoder implementation. BUG=chromium:984482 TEST=open crosvideo.appspot.com on Kevin and Eve Change-Id: I03026057b317ffde5436d8eb53c579ed18210bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734833Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#684211}
-
Sorin Jianu authored
The required updater files are archived as an uncompressed LZMA archive (similar to a tar file), which then is compressed using LZMA, and the result of the compression is inserted as a binary resource into the updater installer file. updater.7z -> updater.packed.7z -> UpdaterSetup.exe At the moment, the updater files are: updater.exe and uninstall.cmd. However, in the debug component build, some other run time dependencies are needed. The dependencies are collected at build time and archived with the updater files. The vast majority of this code has been lifted from //chrome/installer/mini_installer. It is possible to further make the code a shared library between the installer and updater projects. This would be work for the future. Bug: 989772 Change-Id: I9b84e8d1f4475b9977d5b7fd78f37272dd7c6212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730309 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#684210}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/921f6a175146..36756e459041 git log 921f6a175146..36756e459041 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-05 vapier@chromium.org repo: pull in v1.13.4 changes Created with: gclient setdep -r src/third_party/depot_tools@36756e459041 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I5889ff83f4ecb023cb8c8bf0ee7c5f52a527496b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737740Reviewed-by:
-
Ken Rockot authored
This is a reland of a42acfa3 PS1 is the original CL, PS3 is the trivial fix of deleting a stale #include. Original change's description: > Move file_util service off Service Manager > > Eliminates all Service Manager dependencies from > //chrome/services/file_util/. > > Adds a LaunchFileUtilService() call to //chrome/browser/, which launches > a dedicated service process for file utilities that can be controlled by > the returned Mojo remote. > > Adapts client library call sites to use LaunchFileUtilService instead of > a Connector. > > Bug: 977637 > Change-Id: Ie3e3a583fd00a6d9f77137d0febbccf6a086ff0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732679 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#684140} NOPRESUBMIT=true Bug: 977637 Change-Id: If90c7cbbef6c144843a7964e5db5c5f8357f26bd Tbr: sky@chromium.org Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736115 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#684208}
-
Andrey Kosyakov authored
This reverts commit d8c863a6. Reason for revert: broke build, example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8905916412276160432/+/steps/compile__with_patch_/0/stdout Original change's description: > BundledExchangesParser: Update the bundle format [1/2] > > This updates BundledExchangesParser to parse the new bundle format [1]. > > Changes: > - Updated the magic header bytes [2] > - Version field is added (we use implementation-specific version string > "b1\0\0", which matches gen-bundle's output [3]) > - Fallback URL (== Primary URL) field is added > - ParseMetadata() returns error type ("format error" or "version error") > and fallback URL if available > - Updated spec ref comments > > The structure change of the index section is not reflected yet. It will > be updated in the next CL. > > The test bundle file (hello.wbn) is generated with gen-bundle of > github.com/WICG/webpackage revision a3cef2c, which supports the new > bundle format except for the new index section structure. > > [1] https://github.com/WICG/webpackage/pull/450 > [2] https://github.com/WICG/webpackage/pull/454 > [3] https://github.com/WICG/webpackage/pull/458 > > Bug: 969596 > Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684200} TBR=horo@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,ksakamoto@chromium.org,rsesek@chromium.org Change-Id: Ifce2b07c15a57a2030887cbfaad5853cbc5af992 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 969596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737883Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#684207}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8be476e7a4e0..92d36fb5ab54 git log 8be476e7a4e0..92d36fb5ab54 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 eashanbhatt@google.com device_unittest: Add device_unittest executable 2019-08-05 bhthompson@google.com Disable unittests on branch pre flight builders Created with: gclient setdep -r src/third_party/chromite@92d36fb5ab54 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I900561a42dfe72c3011b76f87305875e7727290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737734Reviewed-by:
-
Donn Denman authored
Updates the 1) Removes the Up/Down arrow and the divider line (issue 961458) for the new layout. 2) Increases the space between the Close and Open-in-tab icons (Issue 961469) 3) Adds a new class OverlayPanelRepaddingTextView for a text view that has adjustable padding at the end of the text to allow the text width to shrink to accommodate the multiple icons when the Bar is expanded. 4) Does some sytle/dimen cleanup to make Overlay Panel and PT separate from Contextual Search and fix a text spacing problem with long titles in PT. NOTE that the new layout still needs changes: it has a grab bar that intrudes into the text area. We have a separate bug to move the grab bar up and increase the overall bar height and round the corners (issue 961454). BUG=961458, 961469 Change-Id: I832f71e3526fe05759f8512842cb9b4e64becdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606598 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#684205}
-
Varun Khaneja authored
DomIsAmbiguous: This metric is false only at most 0.476% over the last 1 year. MaxNodesExceededInFrame: This metric is true only at most %0.342 over the last 1 year. R=lpz Bug: 975258 Change-Id: Ic804a93f8323dda441ad1c3ffcde5c499b19fbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721557 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#684204}
-
Fabrice de Gans-Riberi authored
Bug: 989693 Change-Id: I374adfcba8920f50700da58027fe6c4a98ec19b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737869Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684203}
-
Adam Langley authored
As discussed in the accessibility section of crbug.com/973982, the PIN dialog needs to announce errors to screen readers. This change uses an IronA11yAnnouncer to speak the errors in the PIN dialog when they occur. BUG=990992 Change-Id: I9e11f994ea90d280c16cc931ef533dbe014b90e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735517Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#684202}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f399ecdef769..27f295ee6c4f Created with: gclient setdep -r src-internal@27f295ee6c4f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:988587,chromium:None,chromium:None,chromium:None Change-Id: I240bf5f6f0c0987ee050b95c905d3c47ad32b1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737729Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684201}
-
Kunihiko Sakamoto authored
This updates BundledExchangesParser to parse the new bundle format [1]. Changes: - Updated the magic header bytes [2] - Version field is added (we use implementation-specific version string "b1\0\0", which matches gen-bundle's output [3]) - Fallback URL (== Primary URL) field is added - ParseMetadata() returns error type ("format error" or "version error") and fallback URL if available - Updated spec ref comments The structure change of the index section is not reflected yet. It will be updated in the next CL. The test bundle file (hello.wbn) is generated with gen-bundle of github.com/WICG/webpackage revision a3cef2c, which supports the new bundle format except for the new index section structure. [1] https://github.com/WICG/webpackage/pull/450 [2] https://github.com/WICG/webpackage/pull/454 [3] https://github.com/WICG/webpackage/pull/458 Bug: 969596 Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#684200}
-
siyua authored
Server side gcl http://google3/googledata/googleclient/chrome/finch/gcl_studies/AutofillSaveCardBubbleStringExperiment.gcl Bug: 961082 Change-Id: Ibc0e489839643a19d0b77345f539dc2289871a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728041Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#684199}
-
Jenny Wong authored
Bug: internal 135280530 Change-Id: I611e61735b4537e5db330cb6c78fe05fcb193170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706786 Commit-Queue: Jenny Wong <jyw@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#684198}
-
Jeremy Chinsen authored
Currently PDFiumEngine can only generate a single-view layout for documents. This CL adds DocumentLayout::GetTwoUpViewLayout() which takes a vector of pages and returns the pages formatted for two-up view, as well as updates the size of the layout. This helper function makes the two-up view layout testable. This CL also adds PDFiumEngine::LoadPagesInTwoUpView() which calls DocumentLayout::GetTwoUpViewLayout() to format pages in two-up view and appends them to |pages_|. This allows PDFiumEngine to render documents in two-up view. Bug: 51472 Change-Id: I6b65210f32efc205376d53abaeaa0c6eab84ac2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733737 Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684197}
-
James Cook authored
We're still assessing the impact of the Chrome OS settings split, which changes page zoom and display zoom behavior on some system UI surfaces. Bug: 988754, 988803 Change-Id: I240f1a91d8dcb9175289d93016acec3ac67dfd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731779 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL moves static input from FindNotificationsToShow to the constructor. This can help to improve testing and make it easier to add more features in the future. Bug: 963304 Change-Id: I0931c72cbcb59bed1506a48c41974eee7435ab77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732478 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#684195}
-
Miyoung Shin authored
The */interfaces and */mojo directories paths were changed to */mojom recently. This CL updates mojo paths in accordance with that changes and fixes the wrong path of wallpaper.mojom. Bug: 990423 Change-Id: I8f9415f161b2fb82765ce7f9294d39bf55b1774c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734174Reviewed-by:
-
Lei Zhang authored
Now that DocumentLayout exists, move the constants used for document layout over. Reduce the number of constants to remove redundancies and update users of the constants to compensate. After this, it may make sense to move some users of those constants from PDFiumEngine to DocumentLayout as well. Change-Id: I8b5e5f0a83b5c0b1448f5f14f86a4df100e73f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733850Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684193}
-
Joonghun Park authored
This behavior follows the spec, https://drafts.csswg.org/css-contain/#containment-size, as the statement below. 'Replaced elements must be treated as having an intrinsic width and height of 0.' For this behavior, when 'contain: size' is specified, LayoutReplaced::IntrinsicSize returns zero size instead of the intrinsic size it actually has. Before this CL, |LayoutReplaced::ComputeIntrinsicSizingInfoForReplacedContent| did early return with "FloatSize()", but |LayoutReplaced::ComputeReplacedLogicalWidth| has *if statement* for specified and intrinsic css size, so *that* early return couldn't be reached. Addition to it, ComputeIntrinsicSizeFoo uses |LayoutReplaced::IntrinsicSize| essentially, and it returned non-zero size and that value was used before this CL. Bug: 955163 Change-Id: If0309ae5f1adb2e3026ff92bfde2ffb07ba73582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703540Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Joonghun Park <pjh0718@gmail.com> Cr-Commit-Position: refs/heads/master@{#684192}
-
Hwanseung Lee authored
Use enum class instead of enum for MaximumFlexSizeRule enum class is more type safety. Bug: 940736 Change-Id: I661e67465a1f38e78b336f93df97cb09f1d36f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735447Reviewed-by:
-
Rakib Hasan authored
This reverts commit 8e5eba11. Reason for revert: This CL is causing the linux-perf-builder to consistently fail. Here is the link to the first failure https://ci.chromium.org/p/chrome/builders/ci/linux-builder-perf/98727. This CL is in the blame list. Original change's description: > Navi: Remove usage of 'Onboarding' most places in welcome code. > > Bug: 986979 > Change-Id: I19a775d8d10be2792bed68f67d29219ee0ca85d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728060 > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684175} TBR=sky@chromium.org,hcarmona@chromium.org Change-Id: I696cbb2c2d1013006a55e73c263abc5a72b183ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986979 Bug: chromium:991026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737812Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#684190}
-
Brendan Hansknecht authored
Added AutotestPrivateGetShelfItemsFunction to the autotestPrivate api. Made required changes to autotest_private.idl to support ShelfItems as a return type to JavaScript. Added a test case to AutotestPrivate to confirm the shelf item is returned properly. Updated HistogramValue enum for extensions functions with new item. Test: locally on eve and browser_tests --gtest_filter="AutotestPrivateApiTest.AutotestPrivate" Bug: 989231 Change-Id: Ic3dead8c31585fcd6cf6a799d1306fabb11f1552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733866 Commit-Queue: Brendan Hansknecht <bhansknecht@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#684189}
-
Anurag Agrawal authored
Bug: http://b/111500583 [Audio] Use NON_BLOCKING mode in CMA backend audio code. Ref: b/110722296 Change-Id: I04879e148e832c795fe2066143d8ef4e29ec5315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715474Reviewed-by:
-
Min Qin authored
This reverts commit 59639625. Reason for revert: Fixing test for Chrome OS and cast TBR=xingliu@chromium.org Change-Id: I0a2c7aa5949e5a55ec8346fa8c673c9fb6dd7964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736987Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684187}
-
Alex Moshchuk authored
Bug: 905513 Change-Id: Ide18c23965aa99634fc22cdea1a319c4df01f29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733647Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Yun Liu authored
Compile release build will fail with Java coverage on. Bug: 988116 Change-Id: I37770bdb07c4915b3071db7e7096b4271c859760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721952Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#684185}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=johnchen@chromium.org Change-Id: I1c13ba6ccc98a17abe21e88822fcd786173e7022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733594 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#684184}
-
David Benjamin authored
Anything request-specific is going to interact badly with pooling. Fortunately, no such request-specific options exist. Bug: 951205 Change-Id: I6a75332784d9bcd5b63bb73b96a305c159df65a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737373 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#684183}
-
- 05 Aug, 2019 10 commits
-
-
Kevin Babbitt authored
AXRange::GetScreenRects was written to handle cases where there are multiple lines per text anchor, but in practice this never happens, because each line of text gets its own InlineTextBox and thus its own anchor. Removing the inner loop drastically reduces the runtime cost, especially in cases where there are multiple nodes per line, since CreateNextLineStart/EndPosition can become linear in the number of nodes. On http://en.wikipedia.org I saw a 73% reduction in runtime for this method with the inner loop removed. Bug: 928948 Change-Id: I327d6369abaf0e697f8b9cf2156b9af2bcfce449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733794Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#684182}
-
Yuke Liao authored
Change-Id: I4c1ba8139847fd6a72f0d9ba6e0e1f8d62d927b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736893Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#684181}
-
Mia Bergeron authored
LockScreenMediaControlsView currently handles the scenario where there is a single media session and it briefly flashes to null between tracks. However, if there are multiple media sessions, the UI will briefly flash to the "secondary" session. This CL handles both scenarios by waiting for the first media session ID to resume. Bug: 982022 Change-Id: Icaf13d4d0bed37b474adc746a3c13e0d5d9b98ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732878Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#684180}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e03cdf09226..eb0770211a6c git log 0e03cdf09226..eb0770211a6c --date=short --no-merges --format='%ad %ae %s' 2019-08-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-05 halcanary@google.com experimental/editor: margins now handled by application layer 2019-08-05 reed@google.com specialize drawAtlas for raster backend 2019-08-05 egdaniel@google.com Add supported GrColorTypes to Mtl FormatTable. Created with: gclient setdep -r src/third_party/skia@eb0770211a6c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: If7129e9a8c0ac2acd5c4f65cfc6bdaa79460c98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737589Reviewed-by:
-
Ben Pastene authored
This reverts commit 182cbf00. Reason for revert: test still failing on betty bot https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-google-rel/11472 Original change's description: > chromeos/BUILD.gn: remove security.SELinuxARC from failed list > > Removed because this tast test is no longer failing. > > BUG=chromium:968155 > TEST=Manual. > > Change-Id: Iaba0c34b16e2fb970af4295f919bf9e878e2f18d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732149 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Miah Sanchez <miahsanchez@google.com> > Cr-Commit-Position: refs/heads/master@{#683654} TBR=achuith@chromium.org,bpastene@chromium.org,miahsanchez@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:968155 Change-Id: I7d5b878a6c6325e6df377a4a7fa3e5c2e4840e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737728Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#684178}
-
Gang Wu authored
Bug:991008 TBR=jzw@chromium.org Change-Id: I38399f22277d0b776304448ce4210d0900dc552d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736711Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#684177}
-
Nate Fischer authored
No change to logic, only moves a file. The aw/browser/net/ folder is going away, aw/browser/network_service/ will be the long-term home for network-related code. This cleans up a couple leftover includes from when we had to check the NetworkService feature. Bug: 989842 Test: None - just verify it compiles Change-Id: Idb7e6e7c56048fbf93a2924db7f5907a0919e5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733791Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684176}
-
Hector Carmona authored
Bug: 986979 Change-Id: I19a775d8d10be2792bed68f67d29219ee0ca85d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728060 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
minch authored
Bug: 977430 Change-Id: I62fbc664bbaf2489152b5817fa7162845c815e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737160Reviewed-by:
-
Chris Palmer authored
An old form of a double-free check was present in comments. The new form is in live code. Also remove a TODO we likely won't be able to do. Bug: None Change-Id: Ibbd18b6c98ae7729f46cf8f314e34b0634458d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733803Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#684173}
-
