- 14 Nov, 2018 40 commits
-
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: LayoutTests/h* - LayoutTests/o* Most of this patch is mechanical rebaseline, except that: - Some LayoutNG-specific baselines become redundant and are removed. - Two LayoutNG-specific baselines are added due to different treatments of formatting characters in legacy and NG innerText implementations. Bug: 887148 Change-Id: I433fc4cf279a95e71a5b21fd84780fa6825dd8dd Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1331747Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608045}
-
Becky Zhou authored
Bug: 905248 Change-Id: Iab5d219feccbb265c72a83770d3a48bc368e2d10 Reviewed-on: https://chromium-review.googlesource.com/c/1336032Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608044}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7f2b6fa66575..d7157b2ccf53 git log 7f2b6fa66575..d7157b2ccf53 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 egdaniel@google.com Revert "Reland "Have a GrBackendFormat be stored on gpu proxies."" 2018-11-14 mtklein@google.com skip alpha scale if 256 2018-11-14 egdaniel@google.com Reland "Have a GrBackendFormat be stored on gpu proxies." Created with: gclient setdep -r src/third_party/skia@d7157b2ccf53 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:903701 chromium:903756,chromium:903701 chromium:903756 TBR=rmistry@chromium.org Change-Id: Ib7f4f617164efa46fdc0435416971fbb06f2a197 Reviewed-on: https://chromium-review.googlesource.com/c/1335776Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608043}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d7aa8b741012..74096ec8f277 git log d7aa8b741012..74096ec8f277 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 hjd@google.com Merge "Fix tools/gen_binary_descriptors" 2018-11-14 eseckler@google.com Merge "perfetto: replace remaining gtest_prod.h header usages" 2018-11-14 skyostil@google.com Merge "Implement trace sqlite exporting" 2018-11-14 lalitm@google.com Merge "trace_processor: fix multiple bugs with filtering and casting" 2018-11-14 fmayer@google.com Merge "profiling: Update README." Created with: gclient setdep -r src/third_party/perfetto@74096ec8f277 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4afcedd02fff000630e9df6541b94dd76a8a74cd Reviewed-on: https://chromium-review.googlesource.com/c/1335833Reviewed-by:
-
Saman Sami authored
There is an existing bug in Chrome OS where the screensaver is told to hide even though it's still visible. Before crrev.com/c/1277826 this used to only cause a freeze, but since then the screensaver disappears altogether. The reason is that during the first 10-20 seconds after logging into Chrome OS, there are 30+ renderers spawned in the background that don't actually draw anything. These renderers overwhelm FrameEvictionManager such that any renderer that goes hidden (e.g. the screensaver) will have its surface immediately evicted. This used to work fine before because notifying FrameEvictionManager used to happen in OnFirstSurfaceActivation as opposed to EmbedSurface, and therefore these useless renderers would not interfere with frame eviction. The Chrome OS team is worried they won't have a proper fix in time, so for the time being implement a behaviour similar to what we had before: only report DelegatedFrameHosts to FrameEvictionManager that have seen their first surface activation. Bug: 900373 Change-Id: Ic98929f8e1c834de2af22aa299805395be6a9072 Reviewed-on: https://chromium-review.googlesource.com/c/1334590 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#608041}
-
Min Qin authored
If we have multiple file picker dialogs, we queue the callbacks in a deque so that they will be handled sequentially. However, if one of the download is removed while enqueued, OnConfirmationCallbackComplete() call to ShowFilePicker() will cause an reentrance into OnConfirmationCallbackComplete(). This CL fixes the issue by posing a task to call ShowFilePicker(). Unit test is also added. BUG=904319 Change-Id: I00d324a06977a173671a3405594371ccbdc4a5fc Reviewed-on: https://chromium-review.googlesource.com/c/1332776Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608040}
-
Dave Tapuska authored
Read the attribute based on the origin trial being enabled otherwise even if it wasn't the attribute would get set on the navigation param. In the same branch count the usage as this will be useful for the origin trial. BUG=872777 Change-Id: I1cc4eeba4051cf45c65e54f7dad02ec1114ecb1a Reviewed-on: https://chromium-review.googlesource.com/c/1334198 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608039}
-
Eric Stevenson authored
Reland of dc8f3c0a. chrome_public_test_apk is now merged with chrome_public_apk_for_test which should fix the proguard issue. TBR: agrieve@chromium.org Bug: 688465 Change-Id: Ie43eae7f945e5ae444f1cb0adc0703b334402f3c Reviewed-on: https://chromium-review.googlesource.com/c/1333988Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608038}
-
Tommy C. Li authored
Removes the page info popup triggering unelision on Desktop. Users found it more surprising than useful. We are adding other, more explicit methods of unelision. This CL is a simple revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1265497 Bug: 874592, 894862 Change-Id: Ia1ebc7de91bb69f0aac9df22235b4ea24e7c0e93 Reviewed-on: https://chromium-review.googlesource.com/c/1332266Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#608037}
-
Mitsuru Oshima authored
Bug: None Test: Print window tree and the browser's window shows its name "BrowserFrameAsh" Change-Id: I3520f7a735441c9c8d6b2cf56ae91d03eafa5db4 Reviewed-on: https://chromium-review.googlesource.com/c/1334588Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608036}
-
Shawn Gallea authored
Include wayland_input_delegate.h in server.cc until a later CL, this is needed for classes in server.cc that inherit from it. Bug: 896710 Test: Build ChromeOS Change-Id: I668280ccceab8a9e75874247919d0d0b3fea1cb1 Reviewed-on: https://chromium-review.googlesource.com/c/1316100 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608035}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c59d48ec1594..d5fa47311da1 git log c59d48ec1594..d5fa47311da1 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 dgarrett@google.com image_lib_unittest: Fix test if default board set. 2018-11-14 dgarrett@google.com repo_sync_manifest: Rework repo_sync_manifest. Created with: gclient setdep -r src/third_party/chromite@d5fa47311da1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id31c4aa62ff8c7326c060eb8221c49cb046dd4f2 Reviewed-on: https://chromium-review.googlesource.com/c/1335830Reviewed-by:
-
Rayan Kanso authored
Inform upstream systems when a fetch is completely finished (event dispatch is complete) to know that it's safe to remove in-memory fetch data. Bug: 904818 Change-Id: Ieef3ff87ce66e97f177ef8422994adb22568e155 Reviewed-on: https://chromium-review.googlesource.com/c/1333815Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#608033}
-
Dave Tapuska authored
Use appropriate types in loader code. BUG=879657 Change-Id: I3d94d7a6d6b3dce98792f4bf055a871f49d5a2da Reviewed-on: https://chromium-review.googlesource.com/c/1332507Reviewed-by:
-
Wei Li authored
This test was disabled before. Now we should be able to re-enable it since we can reliably test fullscreen states. In this CL, we also removed an obsolete TODO since we no longer support MacOS 10.9. BUG=845389 Change-Id: I2226bb408bf966b9eeca185fade145c0206ea0bd Reviewed-on: https://chromium-review.googlesource.com/c/1334200Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#608031}
-
bsheedy authored
Short circuits RenderTestRule's Bitmap comparison if Bitmap.sameAs returns true. This comparison is signiciantly faster than the fallback pixel-by-pixel comparison, particularly when comparing large images like those produced by VR. Bug: 904012 Change-Id: Ia9cdd91c91f94079d853ec28fd49fee3c3dd0905 Reviewed-on: https://chromium-review.googlesource.com/c/1334945Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608030}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1680e702bb3f..8eae8558004a Created with: gclient setdep -r src-internal@8eae8558004a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I20b667a7bf308633ccf17bfd7191db8673aca8b6 Reviewed-on: https://chromium-review.googlesource.com/c/1335774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608029}
-
Tony de Luna authored
Make NetworkTrayView own its network state observer. We want to have multiple instances of NetworkTrayView in the future, one for each network icon type. Now each instance is responsible of subscribing to network state updates. BUG=902409 Change-Id: I5dabfbff662dea6c975a4d64e63691194c7e5476 Reviewed-on: https://chromium-review.googlesource.com/c/1332210Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#608028}
-
Alex Newcomer authored
For the new launcher design: - Make grid title padding 0. - Allow max space for the title. This brings the app pods up to spec. Bug: 885338 Change-Id: I41ceb36558c8955079f476bdd8511ccc77e4fb40 Reviewed-on: https://chromium-review.googlesource.com/c/1332415Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608027}
-
Xiaocheng Hu authored
This patch hoists the creation of VisiblePosition from EndOfWord to its caller ComputeEndRespectingGranularityAlgorithm() to reduce the usage VisiblePosition. Bug: 657237 Change-Id: I29cc408d35ecc30db4aa635f5ad4bed88c0032c5 Reviewed-on: https://chromium-review.googlesource.com/c/1330789Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608026}
-
Sergey Ulanov authored
Add explicit dependency on fuchsia-sdk:zx in googletest. This should unblock chromium roll to V8, which was broken after crrev.com/607798 TBR=dpranke@chromium.org Bug: 893369 Change-Id: I58895fce6d2ed40008cac724735403be8b70226d Reviewed-on: https://chromium-review.googlesource.com/c/1336070Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608025}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b0c06d4b490c..6b8b30c8a1b1 git log b0c06d4b490c..6b8b30c8a1b1 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 cbruni@chromium.org [telemetry] Preserve stacktrace on rethrow in InspectorBackendList Created with: gclient setdep -r src/third_party/catapult@6b8b30c8a1b1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia3e03613712f46d5d75e7913faea2d43c6208e97 Reviewed-on: https://chromium-review.googlesource.com/c/1335775Reviewed-by:
-
Abhishek Arya authored
R=mmoroz@chromium.org Change-Id: I2f2b99dbdfd97247b52d5bb86d53908237c3ff94 Reviewed-on: https://chromium-review.googlesource.com/c/1336074Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608023}
-
Scott Violet authored
One lives in ash, the other in the browser. The one in ash is responsible for the actual window management and animations, the one in the browser for forwarding to the one in ash and caching state. I'm happy to rename these classes in the future. BUG=756085,875111 TEST=covered by test Change-Id: I2367534e0566742f3897c69fb8ece7dfff1b1aff Reviewed-on: https://chromium-review.googlesource.com/c/1328567Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608022}
-
Fernando Serboncini authored
This reverts commit fd1a4804. Reason for revert: Broke build. Original change's description: > viz: Include presentation-feedback with begin-frame. > > Instead of sending the presentation-feedback over a separate IPC, > include it with the begin-frame messages. The presentation feedback > can be requested for each frame. So this can reduce an extra IPC > per frame for each client. > > BUG=883592 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iab52a29f406078eab79948a942124c8e13cb4332 > Reviewed-on: https://chromium-review.googlesource.com/c/1175492 > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608002} TBR=sadrul@chromium.org,flackr@chromium.org,boliu@chromium.org,tsepez@chromium.org,piman@chromium.org Change-Id: Id6732cb3052d7cd2d7c4c8cf9256eb8856ab23d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883592 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1336080Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608021}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d4f327ba. With Chromium commits locally applied on WPT: 39c398ad "Worklet: Modernize service worker interception tests for worklets using async/await" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I7a3d9eac1d26f1dc7a0bebbd9a746a5e01affc00 Reviewed-on: https://chromium-review.googlesource.com/c/1335729 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608020}
-
Rouslan Solomakhin authored
Before this patch, some errors for payment handlers were printed to stderr, which is not convenient for web developers. This patch re-routes payment handler related error and warning messages into the web developer console. In case of errors in the payment handler page that close the payment handler window, the error messages are printed into the developer console for the page that invoked PaymentRequest instead, so that the messages don't disappear immediately after being printed. The error messages in the payment handler info fetcher have been expanded to notify the web developer about more corner cases that would make the payment handler not work properly, such as cross-site iframes when installing a payment handler. In addition, this patch adds unit tests for JIT payment handler install. After this patch, more errors for payment handlers are printed in the web developer console, which is more convenient for web developers. Change-Id: If14b7a947eb2a4915dfe66f5ac2d3cccfc4b6e07 Bug: 867747 Reviewed-on: https://chromium-review.googlesource.com/c/1321093Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608019}
-
Antonio Gomes authored
This CL migrates AccountReconcilor and AccountReconcilorDelegate production code away from SigninManager, leaves migration away from ProfileOAuth2TokenService and unittests for a follow up step. Unit tests were minimally adapted to keep passing. TBR=mkwst@chromium.org (chrome/browser/extensions/api/browsing_data/) BUG=903907 Change-Id: I9093fb989351b9a924a02a07821a637c59038ba2 Reviewed-on: https://chromium-review.googlesource.com/c/1330223 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#608018}
-
Carlos IL authored
Bug: 752372 Change-Id: I11f97243aa8aecd1ae00d55317e31d94d8e0d612 Reviewed-on: https://chromium-review.googlesource.com/c/1334649Reviewed-by:
-
yiyix authored
Bug: 894149 TBR=sadrul@chromium.org Change-Id: Ibeece84bc1490050a9c61c8deb976c370506e45e Reviewed-on: https://chromium-review.googlesource.com/c/1335279Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#608016}
-
John Budorick authored
Tbr: crouleau@chromium.org,nednguyen@google.com,perezju@chromium.org Bug: 903849 Change-Id: Ib0857c3bbd630ea7e47928dcd43b9f9fcc12597e Reviewed-on: https://chromium-review.googlesource.com/c/1335935Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608015}
-
Anders Hartvoll Ruud authored
According to css-variables-1, any custom property that participates in a cycle is invalid. This also applies to registered custom properties. In the current implementation, however, registered custom properties with an initial value can not become invalid; they compute to their initial value instead, as provided by registerProperty. A consequence of this, is that fallbacks (specified by var()-references) are never triggered if the referenced property is a registered property with an initial value defined. The value for any unregistered custom property, if no other value is specified, is the invalid initial value described by css-variables-1. This means we can just avoid storing the variable on ComputedStyle, to signify the invalid initial value. However, the value for any registered custom property, if no other value is specified, can be the initial value specified by registerProperty. When there is no value explicitly stored on ComputedStyle, we check StyleInitialData and fetch the initial value from there. Hence, we can not use the absence of a value to signify an invalid registered variable, as we already use this state to mean "initial value from registerProperty". This means that we must explicitly store a value for registered properties that participate in a cycle. This CL adds CSSInvalidVariableValue to do this. * When resolving a registered custom property, if a cycle is detected, set the registered value to CSSInvalidVariableValue. * When looking up a registered custom property, if we already have the value CSSInvalidVariableValue, return nullptr instead of initial data. This triggers fallbacks. * The code that set the cycle_detected flag was weird; a cycle could be marked as detected, even though ResolveTokenRange succeeded. This meant that any custom property which referenced a property in a cycle would also be treated as part of the cycle, which is wrong. Fixed by only setting the cycle_detected flag when we have cycle start points. * CSSInterpolationType did not initialize its cycle_detected variable, which led to undefined behavior. R=futhark@chromium.org Bug: 641877 Change-Id: I2c518b176de26f7b2f05b36b568041a228fcb0ea Reviewed-on: https://chromium-review.googlesource.com/c/1333758 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608014}
-
Hugo Holgersson authored
Intent to Ship (approved November 6): https://groups.google.com/a/chromium.org/d/msg/blink-dev/Fku6784p0wI/3MyOMTk7BwAJ This CL mimics Firefox's behavior; all content in scroll containers are now keyboard-accessible, see the test reach-and-scroll-overflow-div-without-mouse.html. Without this fix, some scrollers' web content is not accessible at all without a mouse pointer. To be able to write compact and hopefully soon WPT-compatible tests, this CL generalizes spatial navigation's JS helpers so they also cover sequential navigation. If you suspect this change caused a regression, try disabling it: --disable-blink-features=KeyboardFocusableScrollers Follow-up: - This change is needed by spatial navigation (Issue 801162). Bug: 585413 Change-Id: I200cdfd1afd02b354ef23bafd119abe558491dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1258331 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608013}
-
Camillo Bruni authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I40efb621c05c77f0d032f8392991cb3b827cab1d Reviewed-on: https://chromium-review.googlesource.com/c/1329666 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#608012}
-
Adithya Srinivasan authored
MakeIsolatedRequest was renamed in https://crrev.com/c/753624. Change-Id: I1225ce04242adb398693ac0ff4612c9f672754df Reviewed-on: https://chromium-review.googlesource.com/c/1334663Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#608011}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/388a62c2..ebedb7eb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iadba57fbe09f1fe7ee15ff1a84b2c4141712783a Reviewed-on: https://chromium-review.googlesource.com/c/1335732Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608010}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: Ic8f20ba353bf9805d79916f440fe10137a97aff7 Reviewed-on: https://chromium-review.googlesource.com/c/1325981 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608009}
-
Alex Clarke authored
We are no longer considering having anything other than a FIFO scheduler on the IO thread (which is why it was added in the first place). Split off from https://crrev.com/c/1320329. TBR=gab@chromium.org Bug: 863341, 891670 Change-Id: I6e7c4fdd2772ec85dfffcf4bad051b0785b0a050 Reviewed-on: https://chromium-review.googlesource.com/c/1335930 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#608008}
-
Stephane Zermatten authored
This patch take out initialization and delayed shutdown from AutofillAssistantUiController: * initialization goes into a new class AutofillAssistantFacade, called from CustomTabActivity. * UiDelegateHolder becomes a toplevel class, responsible for delayed shutdown and UI pausing The following responsibilities remain in AutofillAssistantUiController: * bridging Java -> C++ and C++ -> Java * account management and authentication This patch also unifies the way the "give up" message is displayed in Java, removes the unnecessary C++ OnGiveUp method and always hides the overlay and the event filter when switching to graceful shutdown mode. Bug: 806868 Change-Id: Idef806520f5e6e8a6dda4fc843d61bf77c1eafb4 Reviewed-on: https://chromium-review.googlesource.com/c/1333652 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608007}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2b1f6b373ca9..5beeee15c175 git log 2b1f6b373ca9..5beeee15c175 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 zoddicus@users.noreply.github.com Add fuzzer for spvBinaryParser (#2045) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@5beeee15c175 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If335b01039a4bc91001837fa5de5c3cad8b519cd Reviewed-on: https://chromium-review.googlesource.com/c/1335831Reviewed-by:
-
