GitLab

The various programs stored in GLRenderer are 5-dimensional arrays,
and adding color conversion to them would require adding a 6th
dimension.

Create a ProgramKey structure that uniquely identifies a program, and
create a single unordered_map to cache programs.

Gut all off the GLRenderer::Get*Program* functions, to just call a
common GLRenderer::GetProgram function, which takes this key.

Adding color conversion will now just consist of adding a new field to
the ProgramKey structure. Before we do that, we'll remove all of the
(now-stub) GLRenderer::Get*Program* functions, and have the callers
all call GLRenderer::GetProgram.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2613903002
Cr-Commit-Position: refs/heads/master@{#443362}

Make sure the active URL is correctly set for crash reports.

BUG=643746, 630895

Review-Url: https://codereview.chromium.org/2622073005
Cr-Commit-Position: refs/heads/master@{#443361}

This will make it easier to land an upcoming ResourceHandler refactor,
and also gives us some more ASSERTs shared with other tests. Also add
checking of the error code the request is canceled with.

Also prevent next ResourceHandler in the chain from being called
re-entrantly

BUG=659317

Review-Url: https://codereview.chromium.org/2626663002
Cr-Commit-Position: refs/heads/master@{#443360}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2629003002
Cr-Commit-Position: refs/heads/master@{#443359}

CastContentWindowImpl is the implementation of CastContentWindow
now. Add a CastContentWindowAndroid specific for Android platform.

BUG=NONE
TEST=cast_shell_apk

Change-Id: I6092f733b54638256bd3028ac3d889f6b52a02fe
Review-Url: https://codereview.chromium.org/2570623003
Cr-Commit-Position: refs/heads/master@{#443358}

BUG=679905

Review-Url: https://codereview.chromium.org/2627093006
Cr-Commit-Position: refs/heads/master@{#443357}

And use it for SessionController interface.

BUG=648964

Review-Url: https://codereview.chromium.org/2617763003
Cr-Commit-Position: refs/heads/master@{#443356}

SkPaint now has refFoo() helpers which return sk_sp<> values.  We can
simplify some call sites.

BUG=skia:5077
R=reed@google.com
TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2625403002
Cr-Commit-Position: refs/heads/master@{#443355}

BUG=none

Review-Url: https://codereview.chromium.org/2616403005
Cr-Commit-Position: refs/heads/master@{#443354}

base::Time::FromString() and base::Time::FromUTCString() might fail
at runtime on bad input. This adds a WARN_UNUSED_RESULT to their
declarations to ensure that all callers properly handle the result.

Apart from unit-tests, this changes two things:

- DataUseTracker::RemoveExpiredEntriesForPref() will also
  remove any entries with an invalid date string.

  This doesn't change the runtime behaviour though, because
  a failure in base::Time::FromUTCString() would keep the
  local |key_date| variable to 0, which would have been
  considered too old anyway.

- VariationsSeedStore::ImportFirstRunJavaSeed() has
  a new failure mode triggered by an invalid response
  date |FIRST_RUN_SEED_IMPORT_FAIL_INVALID_RESPONSE_DATE|

  It looks like the FirstRunResult enum values are only
  used on Android to report UMA metrics, so ensure that
  the new constant is added at the end of the list to
  avoid generating confusing histograms.

- PexeDownloader::didReceiveResponse() still ignores
  invalid HTTP response 'last-modified' header dates.
  As with RemoveExpiredEntriesForPref() this doesn't
  change the runtime behaviour, but it is hard to see
  whether this is desirable or dangerous.

- ConvertRequestValueToFileInfo() still ignores
  invalid date strings, as mentioned by the comment
  above the base::Time::FromString() line.

BUG=669625

Review-Url: https://codereview.chromium.org/2605293002
Cr-Commit-Position: refs/heads/master@{#443353}

For clients in a Precache trial group who've started a precache in the last 15
days, registers them in a matching group in the PrecacheSynthetic15D trial. For
those who've started a precache in the last 1 day, registers in them in the
PrecacheSynthetic1D trial also.

BUG=663987

Review-Url: https://codereview.chromium.org/2596093002
Cr-Commit-Position: refs/heads/master@{#443352}

https://chromium.googlesource.com/angle/angle.git/+log/008450b..417df92

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2625083005
Cr-Commit-Position: refs/heads/master@{#443351}

We can only generate 6 points for even non-convex quads.
It falls from the w component crossing 0 implies we have to remove
at least one corner for each 2 we add. We can only do that twice.
4 -> 3+2 -> 2+4 -> 1+2.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2627213002
Cr-Commit-Position: refs/heads/master@{#443350}

Currently, |updateAccounts()| is sometimes called multiple times in
AccountSigninView which results in multiple "update GMS" dialogs being
generated, and the user must click back three times for the dialogs to
disappear.

This CL changes signin to re-use existing dialogs where possible and
always remove old dialogs before creating a new one.

BUG=679851

Review-Url: https://codereview.chromium.org/2626083004
Cr-Commit-Position: refs/heads/master@{#443349}

Essentially a scroll node specific version of
http://crrev.com/2612093002 which was only omitted there
in the interest of incrementality.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2623313003
Cr-Commit-Position: refs/heads/master@{#443348}

This cleans up the async read pixel code a bit by using weak ptrs
instead of cancelable callbacks.

BUG=678234
TEST=cc_unittests
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2628883004
Cr-Commit-Position: refs/heads/master@{#443347}

BUG=634434

Review-Url: https://codereview.chromium.org/2622383002
Cr-Commit-Position: refs/heads/master@{#443346}

This was reverted due to crbug.com/679174 which is fixed by using the
browser action container view's |animationEndFrame| instead of its
frame when calculating the size of the location bar.

Browser actions will be reordered in a future change.

BUG=648558, 648563, 673362

Review-Url: https://codereview.chromium.org/2607533004
Cr-Commit-Position: refs/heads/master@{#441925}
Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf

patch from issue 2607533004 at patchset 80001 (http://crrev.com/2607533004#ps80001)

Review-Url: https://codereview.chromium.org/2631463004
Cr-Commit-Position: refs/heads/master@{#443345}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ed0540fbc6ef..290f611623b2

$ git log ed0540fbc..290f61162 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd [dashboard] Add addEventListener shim

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2631513005
Cr-Commit-Position: refs/heads/master@{#443344}

Use was removed in https://codereview.chromium.org/2462753002/

BUG=557406
TEST=Compiles
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2622423002
Cr-Commit-Position: refs/heads/master@{#443343}

Replaces a tdefault textured layer used for a shield with a solid color
layer.

BUG=537050
TEST=NONE - no visible change

Review-Url: https://codereview.chromium.org/2627153006
Cr-Commit-Position: refs/heads/master@{#443342}

This patch adds an ability to request an image decode from
the compositor. The caller should specify which image
(SkImage) to decode and a callback. In return, it gets an
id. When the image is decoded, the callback is issued with
this id. The decode is then kept alive for 2 compositor
frames.

Right now, only unittests are using this functionality.

R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2537683002
Cr-Original-Commit-Position: refs/heads/master@{#443085}
Committed: https://chromium.googlesource.com/chromium/src/+/bb991d41668aa0f37aa6d6712e3bf9b52a5480ae
Review-Url: https://codereview.chromium.org/2537683002
Cr-Commit-Position: refs/heads/master@{#443341}

BUG=553459

Review-Url: https://codereview.chromium.org/2628893005
Cr-Commit-Position: refs/heads/master@{#443340}

This CL adds an ios_clean_chrome_unittests target and tests for the
public and internal APIs of BrowserCoordinator.

BUG=

Review-Url: https://codereview.chromium.org/2626033002
Cr-Commit-Position: refs/heads/master@{#443339}

BUG=677716
TEST=See bug for repro steps.

Review-Url: https://codereview.chromium.org/2624373002
Cr-Commit-Position: refs/heads/master@{#443338}

The config class encapsulates the configuration data for the settings
reset prompt experiment.

BUG=

Review-Url: https://codereview.chromium.org/2614773008
Cr-Commit-Position: refs/heads/master@{#443337}

Previously we were only looking for <link>s with icons within <head>,
and since SVG document don't have those, no icons would be found.
Instead, for SVG documents (with a root/document element of <svg>), just
collect all <link> (HTMLLinkElement) elements, regardless of position in
the document, using a pre-order traversal. This appears to match the
behavior of Gecko.

BUG=385466

Review-Url: https://codereview.chromium.org/2628873003
Cr-Commit-Position: refs/heads/master@{#443336}

https://skia.googlesource.com/skia.git/+log/693fdbd6b81a..90ee03b0d177

$ git log 693fdbd6b..90ee03b0d --date=short --no-merges --format='%ad %ae %s'
2017-01-12 liyuqian Revert "Implement Analytic AA for General Paths (with Guard against Chrome)"
2017-01-12 fmalita Fix SkImageFilterCache race
2017-01-11 liyuqian Implement Analytic AA for General Paths (with Guard against Chrome)
2017-01-12 reed fix clipping in rasterhandleallocator

BUG=668937

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2629163003
Cr-Commit-Position: refs/heads/master@{#443335}

This adds a test for the Flash information displayed on the
chrome://version page. The test cannot check the actual version or
location as it varies per build, or is disabled in Chromium builds.

BUG=680273

Review-Url: https://codereview.chromium.org/2629033002
Cr-Commit-Position: refs/heads/master@{#443334}

Revert of Android: Delete rezip in favor of zipalign -p (patchset #2 id:210001 of https://codereview.chromium.org/2612773005/ )

Reason for revert:
Broke system webview merging of debug builds.

Original issue's description:
> Reland of Android: Delete rezip in favor of zipalign -p
>
> There's no need for a custom alignment tool now that zipalign supports
> page-aligning libraries.
>
> Previously reverted in:
> https://codereview.chromium.org/2595233003/
>
> Reason for reland:
> Contains fix for monochrome (tested merging locally).
>
> BUG=676029,676589
>
> Review-Url: https://codereview.chromium.org/2612773005
> Cr-Commit-Position: refs/heads/master@{#442906}
> Committed: https://chromium.googlesource.com/chromium/src/+/c3fd406f53369c1714d3587087146ff6ead4adab

TBR=michaelbai@chromium.org,jbudorick@chromium.org
NOTRY=true
BUG=676029,676589

Review-Url: https://codereview.chromium.org/2621353004
Cr-Commit-Position: refs/heads/master@{#443333}

To enable latching, MouseWheelEventQueue(MWEQ) uses a timer to send GSE
events. When a fling arrives if the timer is running, MWEQ will stop it
and won't send the pending GSE.

In input_handler_proxy, ScrollBegin is called only once in
HandleGestureFlingStart. This ScrollBegin won't do a new hittesting
because CurrentlyScrollingLayer already exists (No GSE is sent before
fling to clear the CurrentlyScrollingLayer when it's being handled).

ScrollEnd won't get called in FlingScrollByMouseWheel for every wheel tick.
Instead, it will be called only once in CancelCurrentFlingWithoutNotifyingClient,
when the fling is over (last ScrollBy didn't scroll or fling time is terminated).

To test locally use the --enable-features=TouchpadAndWheelScrollLatching
runtime flag.

BUG=526463
TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled

Review-Url: https://codereview.chromium.org/2625453002
Cr-Commit-Position: refs/heads/master@{#443332}

BUG=none

Review-Url: https://codereview.chromium.org/2622613003
Cr-Commit-Position: refs/heads/master@{#443331}

Revert of [wasm][asm.js] Turn on asm.js -> WebAssembly by default. (patchset #2 id:20001 of https://codereview.chromium.org/2625823006/ )

Reason for revert:
Suspecting this CL is causing these tests to fail:
fast/workers/worker-shared-asm-buffer.html
virtual/sharedarraybuffer/fast/workers/worker-shared-asm-buffer.html

From the layout test results, it seems that turning on asm.js will append some console results to the test outcome.
Example build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/22022

Original issue's description:
> [wasm][asm.js] Turn on asm.js -> WebAssembly by default.
>
> BUG=v8:4203
> R=danno@chromium.org,titzer@chromium.org,jochen@chromium.org
>
> Review-Url: https://codereview.chromium.org/2625823006
> Cr-Commit-Position: refs/heads/master@{#443289}
> Committed: https://chromium.googlesource.com/chromium/src/+/7417bea53a78a97ae815479e5d73cf0840d90c88

TBR=jochen@chromium.org,bradnelson@google.com,danno@chromium.org,titzer@chromium.org,bradnelson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4203

Review-Url: https://codereview.chromium.org/2631543002
Cr-Commit-Position: refs/heads/master@{#443330}

https://pdfium.googlesource.com/pdfium.git/+log/e7fb8eb3e9f2..db7647083d0a

$ git log e7fb8eb3e..db7647083 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 rbpotter Add postscript path

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2626213003
Cr-Commit-Position: refs/heads/master@{#443329}

Revert of Re-enable fetching component policies for login screen apps (patchset #3 id:40001 of https://codereview.chromium.org/2603463003/ )

Reason for revert:
I'm very sorry I have to revert this since it's breaking device policy updates.

https://bugs.chromium.org/p/chromium/issues/detail?id=679956#c7

Original issue's description:
> Re-enable fetching component policies for login screen apps
>
> This CL relands enabling fetching of policies for Chrome OS login screen
> apps.
>
> The originally landed code was temporarily disabled due to DMServer
> responding with errors when an unknown policy type was requested. Now
> this can be enabled back, after the DMServer got fixed to at least
> ignore the new policy type (until it starts to actually provide policies
> with this type).
>
> BUG=644304,666720
> TEST=re-enabled browser tests;
>      manual test: sign into an enrolled device, go to chrome://policy
>      and check that the device policies were fetched successfully
>
> Committed: https://crrev.com/5eb4901df37717dd05fd071a807a0ebaf563f0f3
> Cr-Commit-Position: refs/heads/master@{#441015}

TBR=emaxx@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=644304,666720

Review-Url: https://codereview.chromium.org/2621413007
Cr-Commit-Position: refs/heads/master@{#443328}

This is a semi-mechanical change to convert i18n-content to $i18n{}. The
Non-mechancal changes are some formatting adjustments.

BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626123002
Cr-Commit-Position: refs/heads/master@{#443327}

ImageTexture binding is supported for only immutable texture [1]
[1] https://www.khronos.org/opengles/sdk/docs/man31/html/glBindImageTexture.xhtml

CMAA needs to use ImageTexture binding, so it checkes internal format is RGBA8.
However, in GLES2 context, immutable texture can have RGBA internal format, because of
https://codereview.chromium.org/2458103002/
This CL makes it check immutable texture directly.

BUG=535198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2543123003
Cr-Commit-Position: refs/heads/master@{#443326}

SyncedProperty is used as a synchronization primitive to track state on
the impl thread, necessary to resolve conflicts for concurrent main-impl
mutations. As such it should only exist on the impl thread.

Currently, the ScrollTree creates these on the main thread while they
only store the current main thread value. This is unnecessary complexity
that can be avoided. This change makes ScrollTree store just the offset
on the main thread, and a SyncedProperty for the offset on the impl thread.

BUG=662619
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2621403003
Cr-Commit-Position: refs/heads/master@{#443325}

It is unused in Chrome and its tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2630483002
Cr-Commit-Position: refs/heads/master@{#443324}

Revert of Stop bad results on first memory benchmark run (patchset #8 id:140001 of https://codereview.chromium.org/2589173004/ )

Reason for revert:
Suspecting that this CL is causing many failures on benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.

Example builds:

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323

Original issue's description:
> Stop bad results on first memory benchmark run
>
> The first memory system-health story ran in a set has been reporting
> memory use differently all subsequent runs. This is due to how we
> flush the system caches.
>
> Just before we measure memory we flush the system caches unfortunately
> this doesn't immediately take effect, instead the next story run is
> effected. Due to this the first story run has anomalous results.
> This option causes us to flush caches each time before Chrome starts
> so we effect even the first story - avoiding the bug.
>
> *************** Note to Perf Sheriff ****************
>
> Regressions across several memory metrics are
> expected for system_health.memory_mobile,
> system_health.memory_desktop and memory.top10_mobile
> as we stop under counting memory use.
>
> *****************************************************
>
> BUG=chromium:671156
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
>
> Review-Url: https://codereview.chromium.org/2589173004
> Cr-Commit-Position: refs/heads/master@{#443273}
> Committed: https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68593f75a051ed

TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:671156

Review-Url: https://codereview.chromium.org/2627323002
Cr-Commit-Position: refs/heads/master@{#443323}