- 05 Sep, 2019 40 commits
-
-
Matt Menke authored
The URLRequestContext is only being used by one internal legacy consumer, which doesn't need either file or data URL support. We'll want to remove the URLRequestContext when we can, but for now, removing these two factories will let us remove the code in net/ to handle those two types of URLs, as they're not handled by the network service. Bug: 934009 Change-Id: I753f03bcc6e9f915cb64490d9bee9a8664a90695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787401Reviewed-by:
Junbo Ke <juke@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693847}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/invalidation. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=pavely@chromium.org Bug: 891670 Change-Id: I7bd7daa3a93a1ff5166ee56bdff138cd098ab4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787098 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#693846}
-
Miyoung Shin authored
This CL converts WakeLockPtr and WakeLockRequest in chrome, chromeos, components, content, extensions, services and blink to the new Mojo types, and uses pending_receiver<WakeLock> in wake_lock.mojom, wake_lock_context.mojom, wake_lock_provider.mojom in services and wake_lock.mojom in blink. Bug: 955171, 978694 Change-Id: Ia79726cbdbc97ffd5714e976f65c4339d9356ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771371 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#693845}
-
inglorion authored
We were seeing out of memory errors on Windows ThinLTO bots. After measuring memory consumption of linking chrome.dll and chrome_child.dll, it became clear that the estimated memory usage of a thin link was too low. Adjusting to a more realistic value. R=dpranke,gbiv,thakis BUG=967074 Change-Id: I7d43d38e28e351a2dc16d79abbf332972cf66e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785680Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Auto-Submit: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#693844}
-
Jeremy Roman authored
Use [RaisesException] for immediate promise rejections in /third_party/blink/renderer/modules/picture_in_picture. The bindings layer implicitly converts thrown exceptions in promise-returning functions to promise rejections, and using ExceptionState makes this more similar to ordinarily throwing exceptions, notably by including the auto- generated exception context that makes it easier to see what IDL operation caused an exception to be thrown. This CL was uploaded by git cl split. R=beaufort.francois@gmail.com Bug: 1001114 Change-Id: I0d6265ccaccab772bac9e7d2ff111ff111432000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786670 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#693843}
-
Xing Liu authored
This reverts commit e5bdbac6. Reason for revert: Wrong revert, test added here is not failing. The other CL introduced a flaky, which is reverted in: https://chromium-review.googlesource.com/c/chromium/src/+/1787277 Original change's description: > Revert "Notification scheduler: Add icon database metrics." > > This reverts commit 63c7234e. > > Reason for revert: Unit test failure (crbug.com/1001018) > > Original change's description: > > Notification scheduler: Add icon database metrics. > > > > This CL adds icon database metrics, also fixes a typo in > > stats::LogImpressionEvent. > > > > Bug: 963298 > > Change-Id: I2fcd44d773166345760ee647c26e464c9ca0f89e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785161 > > Commit-Queue: Xing Liu <xingliu@chromium.org> > > Reviewed-by: Hesen Zhang <hesen@chromium.org> > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693510} > > TBR=isherman@chromium.org,dtrainor@chromium.org,xingliu@chromium.org,hesen@chromium.org > > Change-Id: I94b298d9754e4651f757de2ba82a369be6523801 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 963298 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786372 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693607} TBR=peria@chromium.org,isherman@chromium.org,dtrainor@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: I7db11edabd91c9a8265b7f8961054def38f804ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786644Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#693842}
-
Yasmin authored
This CL also utilizes the defined metrics and also adds Shared Clipboard error dialog on desktop to Android flow. Bug: 995256 Change-Id: I2fbfb969870d462f199ff44c268a1d10376f345d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782806Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#693841}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/screenlock_monitor. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=braveyao@chromium.org Bug: 891670 Change-Id: I6bcf570a1b0a1edaa4f35c20250692026ff66de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787067 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#693840}
-
Emily Stark authored
This CL expands existing Page Info histograms to record Safety Tip status. Bug: 987754 Change-Id: I3ed817597965e3b1072bc44b601a2502e25b7789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783713 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#693839}
-
Gyuyoung Kim authored
This CL converts mojo::Binding to mojo::Receiver in TestRendererServiceImpl. And also, this CL applies mojo::Receiver to mojom::TestServiceRequest. Bug: 955171 Change-Id: I74c3b39f48060544adc7496657c0485eb504800c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786364Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#693838}
-
Gabriel Charette authored
Backport some tests in /components/web_resource/resource_request_allowed_notifier_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/web_resource/resource_request_allowed_notifier_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=asvitkine@chromium.org Bug: 891670 Change-Id: I13509fa01b3fadb6cffa203cba15975ac553e8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786777 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#693837}
-
Doug Arnett authored
Currently there is no visibility in interventions-internals if a coin flip is preventing you from seeing a preview. This posts a new event to that page when a coin flip happens. Bug: 1000436 Change-Id: I5e1367891acb3e5f57e045a6e55335b081a25357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785821 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693836}
-
Ian Kilpatrick authored
This unions different types of rare-data which are mutually exclusive. They fall into (3) categories at the moment: - block-data (inflow block which which doesn't establish a new formatting context). - table-cell-data (display: table-cell). - custom-data (display: layout(foo)). This keeps the actual structs within the union private such that nobody messes around with uninitialized "things". This saves ~28bytes of RareData size. (+/- 4 bytes for bad math). Change-Id: I1af5445222d82d8a0ac5dac5573602b807751857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758654 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#693835}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 6964027315f70c6817217d8dba0368fd3a274ba3`. Also add a temporary workaround for a pre-existing-but-now-triggered msan false positive. TBR=thestig Bug: 998158,998966 Change-Id: I638cc88d9d7b161c42cf849acbf6a3e0fd95d9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773745 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#693834}
-
Rayan Kanso authored
The `updateUI`'s options parameter should be optional. No behavioral changes are required. Bug: 1000785 Change-Id: I0d84ce1e985911e8e0db16311678aa93d8db886e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787281 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693833}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/offline_pages. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=chili@chromium.org Bug: 891670 Change-Id: Ie41dd4e6a7e49c643df9a45421b6f7fef1b57c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786822 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#693832}
-
Tanisha Mandre authored
- Add a flag for the 'Use Camera' button in the 'Add Credit Card' view. - The button directs the user to a credit card scanner that uses the camera to scan a credit card number. Bug:989432 Change-Id: I431e8c915cdf3a745f470a2ab1ecc4552e761311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787550Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Cr-Commit-Position: refs/heads/master@{#693831}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/base/x. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=thomasanderson@chromium.org Bug: 891670 Change-Id: I5f3900a36d951e5c999e5a27f02d4a076dc1578b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787178 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#693830}
-
Gabriel Charette authored
This reverts commit 85d4a0fa. Reason for revert: most likely wrong culprit? Original change's description: > Revert "Backport some tests in /remoting to SingleThreadTaskEnvironment" > > This reverts commit afa2cbc7. > > Reason for revert: non_viz_browser_tests failed because of: > OAuth2Test.SetInvalidTokenStatus > > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6325 > > Original change's description: > > Backport some tests in /remoting to SingleThreadTaskEnvironment > > > > These tests were previously migrated from single-threaded MessageLoop to > > a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as > > part of crbug.com/891670. > > > > //base OWNERS decided in retrospect that it was better to keep a > > single-threaded option for TaskEnvironment and introduced > > SingleThreadTaskEnvironment. This CL retrofits that decision for > > /remoting. > > > > This CL is a no-op if it passes CQ. > > > > This CL was uploaded by git cl split. > > > > R=jamiewalch@chromium.org > > > > Bug: 891670 > > Change-Id: Id50cc3412d6fbec3e5c71672bf74f6abf0f7332d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786679 > > Auto-Submit: Gabriel Charette <gab@chromium.org> > > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > > Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693548} > > TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,gab@chromium.org > > Change-Id: Ibe96ffa6ddf39371dc64c6ad7236ec366f9331c4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 891670 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787279 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693613} TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,gab@chromium.org,olka@chromium.org Change-Id: Idb489a187fcfb8343079c83f66088c6b6c8b5091 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787184Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#693829}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ash. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jamescook@chromium.org Bug: 891670 Change-Id: Ia6c9e5450e044adca6f225e44796d5f58923e893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787101 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#693828}
-
Dan Harrington authored
Previously, it was possible that the RenderFrameHost was destroyed before attempted access by OfflinePageAutoFetcher::Create(). The fix is to avoid passing a task runner, which would PostTask(). Bug: 1000002 Change-Id: Ibb3859e9a859442cd80ef04d483c5c4ea37d01f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782695Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#693827}
-
Dana Fried authored
This CL provides expand and contract animations for views that are being shown or hidden. It should cover the needs of the identity chip and butter. Still to do: - Move animating_layout_manager to ui/views/layout - Rename flex_layout_types_internal to something more appropriate - Implement slide and fade animations - Handle multiple views being added/removed at once more cleanly - Allow per-child-view transition rules instead of a per-layout default Bug: 1000131 Change-Id: Ia73475e9eda7e72c118a02160b3fc7234474ee83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782040Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#693826}
-
Marc-André (MAD) Decoste authored
Change-Id: Ia7ae936644266d98abe9be88341e81fb3fc2eb96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786138Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#693825}
-
Chris Blume authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/d460d6b1cb96..baa5dc24258b $ git log d460d6b1c..baa5dc242 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 jonathan.wright Add Arm NEON implementation of h2v2_merged_upsample 2018-07-19 jonathan.wright Add Arm NEON implementation of h2v1_merged_upsample Created with: roll-dep src/third_party/libjpeg_turbo Change-Id: I869c7d101395df111340cf70fe0d18793a9a5311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785622Reviewed-by:
Jonathan Wright <jonathan.wright@arm.com> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#693824}
-
Jan Scheffler authored
Fixed regression introduced in #1693175 (https://chromium-review.googlesource.com/c/chromium/src/+/1693175/4/third_party/blink/renderer/devtools/front_end/ui/Toolbar.js) which kept toolbar buttons from showing their keyboard shortcuts in the tooltip. Bug: chromium:999195 Change-Id: I0d0259f19a4abc45d3fe57df419319866e311688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782172 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#693823}
-
Maksim Moskvitin authored
BackendMigrator logic requires resetting sync metadata for specific datatype. For regular datatypes, corresponding logic lives inside ModelAssociationManager and DataTypeManager, which don't have access to Nigori's ModelTypeController. For Directory implementation of Nigori this logic implemented through Directory::PurgeEntiesWithTypeIn(). We can detect required migration, because call of Directory::PurgeEntiesWithTypeIn() plumbed through SyncEngineBackend. We just restart ModelTypeController for Nigori and this triggers call of NigoriSyncBridge::ApplyDisableSyncChanges(). We keep in-memory state of explicit passphrase key loaded from the prefs, because we need it for future support of BackendMigrator for USS Nigori. It's safe, because if we stop due to disabling sync, we will also clear corresponding pref and we should not worry about in-memory state of the bridge, since we won't continue use the same instance. This is not perfect solution, and we need to try a better one. But for now all alternatives too intrusive (getting rid of ModelTypeController for Nigori or moving it into the UI thread). This CL allows passing Migration*ClientTest with enabled USS implementation of Nigori. Bug: 922900 Change-Id: I9f7b218dec46ebfcc21ad8093b73e3c019fd438f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784606 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#693822}
-
Steve Kobes authored
Bug: 1000716 Change-Id: I25013ba77c03a05357f787c4ecec540d0e54ddd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787348Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#693821}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c3c41d20e9c..b6f7d201f629 Created with: gclient setdep -r src-internal@b6f7d201f629 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1f8f1a69a03552d6b82baff70314479e20ab1dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787350Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693820}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/autofill/core/browser/payments. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jsaul@google.com Bug: 891670 Change-Id: I860dba930b082a4d094da8ad0e7bb00d6a6237d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786828 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#693819}
-
Ioana Pandele authored
In certain variants of the dialog, we make a recommendation to change the leaked password. We want this to be emphasized. Bug: 986317 Change-Id: I369a3b9a1e21acb8e51f43f6f4980d2645bf60f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781583 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#693818}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b0e2347fedfc..76500e5d0a62 git log b0e2347fedfc..76500e5d0a62 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 csmartdalton@google.com Clean up GrGLIRect 2019-09-05 bsalomon@google.com Fix profile width check in GrRectBlurEffect. 2019-09-05 jvanverth@google.com Reland "Add launch screen to iOS apps" Created with: gclient setdep -r src/third_party/skia@76500e5d0a62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:995308 Change-Id: I0c05029acb56eb3f10d11d51d6ad4a3f6d0930ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787846Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693817}
-
Arthur Hemery authored
This fixes the tests run by the android bfache fyi bot. It currently tries to run browser_tests when it should instead run android_browsertests, content_shell_test_apk and chrome_public_test_apk. Bug: 976218 Change-Id: If0abf33ec48a14c3cb1d3024e43ad2f9a0b18f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787541Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#693816}
-
chrome://dev-ui-loaderSamuel Huang authored
This CL changes the error message shown to the user if the DevUI DFM fails to install. The text is approved by UX. The formatting matches that of chrome://dino (desktop version, instead of the more fancy Android version). Styles are flattened for simplicity. Bug: 927131 Change-Id: I30cd76f27aaadd821655d6a4716f7be2ea2c664c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785081 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#693815}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/components/tether. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 891670 Change-Id: I6f698c1eda62dffb5167e82b122e1c6b18c57bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787215 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693814}
-
Synthia Islam authored
Currently a save dialog will return in a read-only file handle if the site is configured to not be allowed to prompt for write access. Modify the logic before triggering the file chooser to reject this attempt Bug: 990988 Change-Id: I0a63a64ce4605fed6c83c67df60027b09a9b3329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753986 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693813}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/services/network_config. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 891670 Change-Id: I344d2168d15d303bab24507d348c85bdda2782ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786851 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693812}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2dc5f73698ee..1ed60ee797b6 git log 2dc5f73698ee..1ed60ee797b6 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 treehugger-gerrit@google.com Merge "Never start data-source twice." 2019-09-05 eseckler@google.com Merge "proto: Add Tracks for TrackEvents" 2019-09-05 rsavitski@google.com Merge "protozero packed repeated field encoding/decoding" 2019-09-05 lalitm@google.com Merge "trace_processor: add strongly typed column wrapper classes" 2019-09-05 tneda@google.com Merge "perfetto-ui: Adding triangle pointer to current search result" Created with: gclient setdep -r src/third_party/perfetto@1ed60ee797b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I71525903c9f435789e4e607f6d44eb3d709ca348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693811}
-
Tatiana Buldina authored
Bug: chromedriver:3042 Change-Id: I8ebec3e58904e63926aa276902c7a92559c8ab66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785681Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#693810}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/network. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 891670 Change-Id: I04efc7575adafc026c094f9e8d255708f4ecb804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786897 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693809}
-
Mingjing Zhang authored
This feature allows tracking frame throughput during video playbacks. This frame sequence tracker is a special case in that its tracking process occurs in video_frame_submitter, unlike most other frame sequence trackers that operate mainly in layer_tree_host_impl. Sample tracing report: https: //drive.google.com/file/d/1B9AZCsbLmOyIzIFxFGzDOgINISx7p3lk/view?usp=sharing Bug: chromium:986300 Change-Id: I9a41861e59bbe16d652b49de6b802ccc89833906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755978 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#693808}
-