You need to sign in or sign up before continuing.
- 15 Nov, 2019 40 commits
-
-
Rohit Rao authored
This test fails on smaller form factors because the test is looking for results that are no longer visible on screen after ranking changes bumped them down in the results list. BUG=1025199 Change-Id: I41df71ccaee252f9cc80e3c47b6884adeeb8cb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918266 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715667}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/88de31e0..8415d24c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I02e9f4fb57b9a3b9f18afd41a7fdac7a11cb5dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715666}
-
Oriol Brufau authored
Currently GridTrackSizingAlgorithmStrategy::GetCachedGridTrackSize and GridTrack::CachedTrackSize don't return the GridTrackSize by reference. This means that some code like const GridLength& length = track.CachedTrackSize().MaxTrackBreadth(); DCHECK(length.IsFlex()); has a stack-use-after-scope issue, since GridTrackSize::MaxTrackBreadth returns a GridLength by reference, which will point to the temporary object returned by CachedTrackSize. To avoid this problem, this patch makes GetCachedGridTrackSize and CachedTrackSize return a const reference instead of a temporary copy. Change-Id: I3e43bf88a475b30747a101195705a22d93cc52a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919140Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#715665}
-
Yifan Luo authored
See https://github.com/whatwg/fetch/pull/948 . Bug: 1011724 Change-Id: I546752f3d0120f71cc810bfb17f960789e6c53dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917259Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@google.com> Cr-Commit-Position: refs/heads/master@{#715664}
-
Liviu Rau authored
Land only after a confirmation of successful run of devtools_frontend_linux_blink_light_rel bot. https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1916899 Bug: chromium:1018204 Change-Id: I42bde537652bdf445d74788fb5e6764cabe5d960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916466 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#715663}
-
Rasmus Brandt authored
Bug: 1025166 Change-Id: I482cedef1cb489384e896e5d8ff8b70f0ecd496e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913409Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rasmus Brandt <brandtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715662}
-
Dan Elphick authored
Instead of passing a using base::ThreadTaskRunnerHandle::Get(), which can fail if it's not set up yet, pass nullptr, which causes it to just run on a background thread. This is fine for the shared memory API as it is not tied to any particular Isolate. Additionally this moves registration into the V8SharedMemoryDumpProvider constructor which itself is created as a Singleton after the first V8 Isolate is created. This ensures that the shared memory is actually set up before the first dump is provided. Bug: v8:7464, 1023644 Change-Id: I18fde2c388c3b4c01191b00b4ec441d6964b473b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912205 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#715661}
-
Alex Ilin authored
This is a reland of 131762ce This also contains a fix for the bug causing shared memory creation failures on ARC++N and ARC++P devices. Original change's description: > ARC: upgrade protected buffers to new shared memory api > > This change wraps the FD-based protected buffers in a > base::subtle::PlatformSharedMemoryRegion rather than the legacy > SharedMemoryHandle. Aside from a couple of new validation checks, > functionality is unchanged. > > Bug: 849207 > > Change-Id: I2df619dc58c6313393e41eef7e4807edf340875e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697183 > Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> > Reviewed-by: Matthew Cary (CET) <mattcary@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686169} TBR: rsesek@chromium.org Bug: 849207 Change-Id: Ibd3ccc02edb21b54ec6eb701afaac0ab5783a138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916463 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715660}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36fbe6029343..4207870bcd60 git log 36fbe6029343..4207870bcd60 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 3da910d55f20..c3f22f7cba60 (2 commits) Created with: gclient setdep -r src/third_party/angle@4207870bcd60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: Idbc8ce29a41683f6c339ef96ed10df3b2eb9e87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715659}
-
sandromaggi authored
This tests that adding a profile manually and listening to outside profile change works. Bug: b/143265578 Change-Id: I6e3aeb963eb5038b21db7aac0ff4dca6eff2eaff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917203 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#715658}
-
Chih-Yu Huang authored
Originally DmabufVideoFramePool allocates frames by VideoFrameLayout, which mainly contains VideoPixelFormat and frame size. VideoPixelFormat is a enum that lists well-known pixel formats. However, we might need buffers with proprietary format during hardware-accelerated video decoding. To support that, we should use fourcc, which could also list proprietary formats, to indicate pixel format. This CL changes DmabufVideoFramePool to allocate frames by Fourcc instead of VideoPixelFormat. Bug: 1004727 Test: Run video_decode_accelerator_tests on Kevin and Eve Test: media_unittests --gtest_filter=FourccTest.* Test: media_unittests --gtest_filter=PlatformVideoFramePoolTest.* Change-Id: Ibebea0a93589d26c8c892585789301ca11dfb5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895251 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Alex Ilin authored
This CL removes deprecated RenderThread::HostAllocateSharedMemoryBuffer since it's no longer used. Bug: 795291 Change-Id: Ia0d4e3824d48a83ed2295351e62e4d518eb085af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916873Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715656}
-
Marc Treib authored
Still required, thus extended to M83: enable-sync-device-info-in-transport-mode enable-sync-uss-nigori enable-sync-uss-passwords Flags already removed, thus removing metadata entries: enable-sync-uss-bookmarks sync-support-secondary-account Bug: none Change-Id: I05426ec0909a3b24c856aa4ce79200f42123901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917769 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#715655}
-
Marc Treib authored
The only function of the NetworkResources interface was creating HttpPostProviderFactory instances. That can just as well be achieved by a simple callback. There is some (small) hope that this might resolve a crash that may be related to passing raw (and unretained) NetworkResources pointers around between threads. TBRing simple call site update on ios. TBR=eugenebut Bug: 951350, 1023993 Change-Id: I59e4eb6355ea232b6b7c4c2dceee73eca49436f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916462 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715654}
-
Alex Ilin authored
This CL replaces usage of deprecated base::SharedMemory with base::UnsafeSharedMemoryRegion. Also the CL removes media::GpuVideoAcceleratorFactories::CreateSharedMemory() since it no longer used. Bug: 849207 Change-Id: I6b9f2492e6e6ae5e41eb45c2268aa095cd91f49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916864Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715653}
-
Ioana Pandele authored
Change-Id: I5851f65b70bf3ae575431220554d1d305a1c57d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917767Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#715652}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/02fac7d86e64..74f35e48d500 git log 02fac7d86e64..74f35e48d500 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 sprang@webrtc.org Add support for dynamic processing mode in PacedSender. Created with: gclient setdep -r src/third_party/webrtc@74f35e48d500 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I3264cdf18e9dc5a09f23c7cc614fb2427aacb361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918971Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I969b73f21a40b72fa532521c4c9d62782fa8aacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918969Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b1d68d80..88de31e0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8fb0f7988d2ac2004b8745d378ae21f6dafdc313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917045Reviewed-by:
-
Vadym Doroshenko authored
Change-Id: I565fc449a2ba850c0b5aa1e552e0f01a6731e1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917515 Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Marc Treib authored
Follow-up to crrev.com/c/1910226. This time, the entry point was DeleteJournal::delete_journals_ which was written to, but never used. Pulling on that lets us remove a whole bunch of unused code. Bug: 854684 Change-Id: I2df76885ce23edc280b2f9c2c83cafad2b99e9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911786 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9b67273de9e5..b639e68495ae git log 9b67273de9e5..b639e68495ae --date=short --no-merges --format='%ad %ae %s' 2019-11-15 shaobo.yan@intel.com Add large buffer to handle super large data block commands Created with: gclient setdep -r src/third_party/dawn@b639e68495ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ie26d59724e03d9e37db40b81367e31020539a3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918968Reviewed-by:
-
Chih-Yu Huang authored
This reverts commit 93d15a17. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "media/gpu: Add ImageProcessorWithPool class." > > This reverts commit 66ea7860. > > Reason for revert: Fix the break build. > > Original change's description: > > Revert "media/gpu: Add ImageProcessorWithPool class." > > > > This reverts commit fc923406. > > > > Reason for revert: This CL breaks build https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/2959 > > > > Original change's description: > > > media/gpu: Add ImageProcessorWithPool class. > > > > > > This CL adds ImageProcessorWithPool class, which is a simple client of > > > ImageProcessor. By injecting a DmabufVideoFramePool for allocating > > > output frames and a callback for receiving processed frames, the > > > caller could process input frames by Process() without managing output > > > buffer. > > > > > > BUG=chromium:1004727 > > > TEST=ninja image_processor_test > > > > > > Change-Id: If1ad0d57d36c8f80e509f0cdfd87e3e3b572ac66 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874069 > > > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#715623} > > > > TBR=deanliao@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org > > > > Change-Id: I9717e687fb823af335989b4e5ca86b0b49f5be0c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: chromium:1004727 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917768 > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#715626} > > TBR=deanliao@chromium.org,akahuang@chromium.org,dvadym@chromium.org,hiroh@chromium.org,acourbot@chromium.org > > Change-Id: I59a49457b7a182bf9eb927e793545145b77fd98b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1004727 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918915 > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715644} TBR=deanliao@chromium.org,akahuang@chromium.org,dvadym@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: Idbc1a504314372cdb0496816c29f79fa84ea7770 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1004727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918916Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715645}
-
Chih-Yu Huang authored
This reverts commit 66ea7860. Reason for revert: Fix the break build. Original change's description: > Revert "media/gpu: Add ImageProcessorWithPool class." > > This reverts commit fc923406. > > Reason for revert: This CL breaks build https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-dbg/2959 > > Original change's description: > > media/gpu: Add ImageProcessorWithPool class. > > > > This CL adds ImageProcessorWithPool class, which is a simple client of > > ImageProcessor. By injecting a DmabufVideoFramePool for allocating > > output frames and a callback for receiving processed frames, the > > caller could process input frames by Process() without managing output > > buffer. > > > > BUG=chromium:1004727 > > TEST=ninja image_processor_test > > > > Change-Id: If1ad0d57d36c8f80e509f0cdfd87e3e3b572ac66 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874069 > > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#715623} > > TBR=deanliao@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org > > Change-Id: I9717e687fb823af335989b4e5ca86b0b49f5be0c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1004727 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917768 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715626} TBR=deanliao@chromium.org,akahuang@chromium.org,dvadym@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: I59a49457b7a182bf9eb927e793545145b77fd98b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1004727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918915Reviewed-by:
-
Andy Paicu authored
The original CL caused a crash (crbug.com/1016233). This was addressed in https://chromium-review.googlesource.com/c/chromium/src/+/1871698 but this introduced a new crash. This CL includes an amend on the initial fix, that prevents the crash. The first patchset is the first relanding CL, the first attempted crash fix. > https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > introduced a crash because InfoBarService::RemoveInfoBar DCHECKS that > the infobar is part of the owned list of infobars. When the tab is > closed, the infobar is removed but then the PermissionPromptAndroid > object destructor attempts to remove it again. This CL ensures that > that this situation does not happen by listening for the infobar > remove event and ensuring we don't try to remove the infobar that > was already removed. > > Kill quiet permission requests if a new request is made > > > > Bug: 1014026 > > Change-Id: I5fe93b9bc7b39873900d9e15dcba66dfddd7c4ef > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860015 > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Reviewed-by: Balazs Engedy <engedy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706445} > Bug: 1014026, 1016233 > Change-Id: Iaa857811c6617afd97af9708a51ea49ea98fe385 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871698 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708160} Bug: 1014026, 1016233 Change-Id: Ib54cc4504a24b83b4ef0b97b51d51f0455afdd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890035 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715643}
-
Kamila authored
Updating this flag to M83, as we might still decide to experiment with different UI details, after launching. Bug: 986737 Change-Id: I049d06e4f909f2375c4f12065b61d68f1106b212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917766Reviewed-by:
-
Colin Blundell authored
The RELOAD command is currently not handled in the //weblayer SSL implementation. However, this command can be triggered by the user: e.g., go to badssl.com and click on the "MITM" button; the resulting interstitial will have a Reload button. This CL wires up handling of this command. Bug: 1023856 Change-Id: Ib2b2fae52066bb26fbed8d895ad1b75d7295b7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914384 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#715641}
-
Chris Hall authored
R=amraboelkher,afakhry Change-Id: Iea73004e48664dd0ff1e2c711d0f073ac42a515e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918903 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#715640}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/password_manager This CL was uploaded by git cl split. R=dvadym@chromium.org Bug: 1018667 Change-Id: I977fb12a0fb0fedb897a804d306fc1b755ff6653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917524 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#715639}
-
Gauthier Ambard authored
Fixed: 1021649, 1022152 Change-Id: Ic9e2d7f03b54c12728bead867edfb6e672931714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903352Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715638}
-
Hajime Hoshi authored
TBR=dpranke@chromium.org Bug: 1024767 Change-Id: I8fc0d6e2acbc7fbd723770cf8e5dce5b14feb3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918913Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715637}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3da910d55f20..c3f22f7cba60 git log 3da910d55f20..c3f22f7cba60 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 dneto@google.com Update README (#3047) 2019-11-14 pierremoreau@users.noreply.github.com Update README (#3048) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c3f22f7cba60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I34caf31cc9ef37a73b34fee70e8449855d23c542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918965Reviewed-by:
-
Ioana Pandele authored
This is no longer active. Bug: 903249 Change-Id: Iaf30dfacc0e6216935aee86266e2716da6958a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916819Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#715635}
-
Robbie Gibson authored
The root cause of the crash is that it is now possible for the omnibox to not have a default match. Up until now, we've been using the selected match to get the icon to show in the omnibox, but if there is no default match, then there is no icon. We should have a better solution than showing the icon for the first match, but this prevents the crash. Bug: 1024885 Change-Id: Idd78aca12de8db026e353895bb7f665d97005101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917502Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#715634}
-
Gauthier Ambard authored
This is mostly to try to reproduce the breakage. Bug: 1013462 Change-Id: I806d8e78475bf343c35b4c1ab5459201ffdfff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876327Reviewed-by:
-
Bret Sepulveda authored
MediaRouterContextualMenuUnitTest was creating a BrowserActionTestUtil, which when the feature is on relies on BrowserView::toolbar, which is not defined in a non-Views test. However, it appears BrowserActionTestUtil is not actually necessary for the tests, so this patch deletes it. Bug: 984654 Change-Id: I5c40a54ea2383dc7a1c47c0f244370f005692e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916464Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715632}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f4db6a76640..36fbe6029343 git log 5f4db6a76640..36fbe6029343 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b2407dd746de..102fd19c65f4 (4 commits) Created with: gclient setdep -r src/third_party/angle@36fbe6029343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: I1a16185166d6c76c787e1bc9dc4d289854fe55c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918964Reviewed-by:
-
Bret Sepulveda authored
Force ExtensionsToolbarMenu off in ToolbarActionsModelUnitTest.ActionsToolbarActionsVisibilityWithSwitch. The test is crashing because of the DCHECK_NE inside ToolbarActionsModel::SetActionVisibility; the actions no longer start visible in the way the test expects. The behavior of the test relevant to the new UI is already covered by the existing test TogglingVisibilityAppendsToPinnedExtensions, so it now forces the feature off. This patch also removes "WithSwitch" from the test name, to avoid confusion. Bug: 984654 Change-Id: Ifeb199156b90b311c4162d24cc5d62cd928fb98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916863Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715630}
-
Guido Urdaneta authored
The audio service is enabled by default on all platforms since M75. There is no need to keep the old codepaths anymore. Several parameterized tests running with and without service/process have been deparameterized so that they run with the default process configuration. Bug: 1019245 Change-Id: Icf02a989f4579a39d15dcd33094a94f422231e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887810Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#715629}
-
chrome://media-appTrent Apted authored
Adds "launch.js" to chrome://media-app Adds "receiver.js" to chrome://media-app-guest A simple protocol transfers a blob from the host to the guest over postMessage and invokes `app.loadFiles` to open the image. Imports media_app.externs.js into the open-source repo for coverage of the closure typechecking targets on a wider range of build configurations. This file exists for a src-internal checkout at media_app_ui/resources/app/app/media_app.externs.js . Currently it's copied and given a copyright header. b/144380429 tracks automation/checking for this. The actual fileHandler integration is deferred to https://crrev.com/c/1913282 due to a regression (https://crbug.com/1022677). This CL comes with a test that invokes `loadBlob` which will eventually be triggered by the fileHandler logic. Bug: 996088 Change-Id: I88a08de670690416f16874d0fbff3bf01f84e095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903109 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#715628}
-
