- 02 Aug, 2019 29 commits
-
-
Tim Song authored
This fixes the problem of the launcher closing after clicking on the\ app info drop down menu item on ChromeOS. Note this CL partially reverts the mash changes made in https://chromium-review.googlesource.com/c/chromium/src/+/897470 TEST=unit test + manually verified BUG=987304 Change-Id: If92559f5d205d41db94c63aaf01090011552ff2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726756 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#683426}
-
Robert Sesek authored
This has been present for two milestones, which should be sufficient to clean up a harmless file. Bug: 973882 Change-Id: I9506284bc480ea3d38fa5e2dd21491355857e9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731017Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683425}
-
Sky Malice authored
virtual/blink-cors/http/tests/fetch/serviceworker-proxied/thorough/cookie-base-https-other-https.html virtual/streaming-preload/http/tests/fetch/serviceworker-proxied/thorough/cookie-base-https-other-https.html virtual/blink-cors/http/tests/fetch/serviceworker/thorough/cookie-nocors-base-https-other-https.html TBR: zmin@chromium.org Bug: 990145, 990146 Change-Id: I637b12c4bf06f37eceed41374e4c8f8051eeecf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731105Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683424}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d014b3d5541d..3bd52c2334a0 git log d014b3d5541d..3bd52c2334a0 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 achuith@chromium.org chromite/lib: Add achuith to device.py and device_unittest.py 2019-08-01 dhanyaganesh@chromium.org config: make eve critical again. Created with: gclient setdep -r src/third_party/chromite@3bd52c2334a0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia823152e0bc3c2b64c4057465a7666d31cf2ecb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683423}
-
Xiyuan Xia authored
- Replace tablet mode observing part of TabletModeClient with ash::TabletMode calls; - TabletModeClient -> TabletModePageBehavior to better reflect what the remaining part does; Bug: 974238 Change-Id: I009e970ee2d9bbf8e94a294f84a5beb8aaf76258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717823 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#683422}
-
Kyle Horimoto authored
This dialog failed to load fully when cellular SIM was locked due to a JavaScript error trying to access CrOncStrings. This bug was exposed due to another CL [1] which defaults the Cellular network's name to "Cellular" if there is no SIM card (and, thus, no carrier name to show in its place). In this case, the "Cellular" string is actually a field of the CrOncStrings object, but that object was not defined in the dialog. This CL defines the object and eliminates the error. Note that it may be a good idea to refactor CrOncStrings usage; I've filed [2] to investigate this issue. This CL also adds myself as an OWNER for this directory, since I'm now the networking lead. This directory was accidentally skipped in [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1660263 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=990121 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1532905 Bug: 983484 Change-Id: I748f300616d54ee9e1ff167371396647e58cfc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731952 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#683421}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/593b1a6ca228..369f9e5df60b git log 593b1a6ca228..369f9e5df60b --date=short --no-merges --format='%ad %ae %s' 2019-08-01 geofflang@chromium.org GL: Support Rectangle textures as sources for glCopyTextureCHROMIUM. 2019-08-01 syoussefi@chromium.org Vulkan: Enable passing ES2 multisample tests Created with: gclient setdep -r src/third_party/angle@369f9e5df60b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:982294 Change-Id: I93c11f49d229f69a68ce873e41b01f5c25ac74b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730528Reviewed-by:
-
Jun Mukai authored
It turns out layer_tree_host_ can be nullptr in tests which passes unexpectedly on bots other than UBSan bots. This CL fixes this behavior. Bug: 989936 Test: compositor_unittests on the UBsan gn flags Change-Id: I6e8ff606709b07f19e6309e3b5a96ca240f0de99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731954Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#683419}
-
Xinghui Lu authored
See: https://docs.google.com/document/d/1E1uyto12NGe9kZFpqH8T8pRyhaOdzcKwHW51RETw-0Q/edit Bug: 979119 Change-Id: I21c84f254c90d17884b3038ab3ec23121994d6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730580 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683418}
-
Joel Hockey authored
Added AppBrowserController::HasTabstrip to allow System Web Apps to turn on browser FEATURE_TABSTRIP. The tabstrip is required for CrOS chrome://terminal. Bug: 846546 Change-Id: I3f1a6ebafd7b32be51bde17d7ad31526b8cd1ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714121Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#683417}
-
Daniel Bratell authored
The blink::ParsedContentType::Mode type had an alias blink::Mode which made that type name unavailable or caused shadowing warnings for other code in the blink namespace. It makes sense that code has to write ParsedContentType::Mode instead of Mode since that will be clearer. Change-Id: Ie20089fdde14fe0aea4b2beb6f8ab82aa955fdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732089Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#683416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5833269d4277..cba141f276a8 Created with: gclient setdep -r src-internal@cba141f276a8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ibac8a9edf77be251af8d3ab5aa26dee744324855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731021Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683415}
-
Daniel Rubery authored
I extended the following four metrics because they showed an unexpected jump in M73 that I couldn't immediately explain: SBClientDownload.SignedBinaryDownload SBClientDownload.ExtractSignatureFeaturesTime SBClientDownload.DownloadRequestTimeoutDuration SBClientDownload.DownloadRequestTimeoutStats If the changes in M73 turn out to be expected, I'll remove these metrics as well, since we don't have any immediate plans for them. I removed the following SBClientDownload metrics because we don't have any immediate plans to use them: SBClientDownload.ZipTooBigToUnpack SBClientDownload.DownloadFileWithoutDiskImageExtensionHasKolySignature SBClientDownload.DmgFileHasExecutableByType SBClientDownload.DmgFileHasNoExecutableByType SBClientDownload.DmgFileFailureByType SBClientDownload.DmgFileArchivedBinariesCount SBClientDownload.DmgTooBigToUnpack Bug: 975430, 969936, 984257, 988872 Change-Id: I722cd40948513a42f53c64e4d8e4ba9bf05123de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725321Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
-
Xing Liu authored
On each user action, the client now can receive the custom data map. This CL adds the custom data to impression proto. We will plumb this data to the client and add this data to impression tracker in a following CL. Bug: 977255 Change-Id: I4b9552bf30c620a66d466cf6eeabc0f2549666fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717703 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683413}
-
Eric Karl authored
The following tests are flaky. Disabling them for now. MediaSourceTest.Playback_VideoAudio_WebM WebRtcDataBrowserTest.CallWithSctpDataAndMedia WebRtcDataBrowserTest.CallWithDataAndMedia Bug: 990116 Change-Id: I6164f487483ea1a5cb74490553146ca0c1dfb59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730784 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683412}
-
Charlene Yan authored
Change-Id: I076892df0b6e105c8a0af8fb4ef98a8f2464bd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731955Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#683411}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/077eb792907f..25661d1e1dc6 git log 077eb792907f..25661d1e1dc6 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 thestig@chromium.org Add experimental JavaScript retrieval APIs. 2019-08-01 tsepez@chromium.org Move CPWL_AppStream to CPDFSDK_AppStream. 2019-08-01 tsepez@chromium.org Remove dependence from cjs_field.cpp to fpdfapi/font Created with: gclient setdep -r src/third_party/pdfium@25661d1e1dc6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I910532d42ae3394f7cdac763b1c67a1a1384c8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732061Reviewed-by:
-
Chris Harrelson authored
Previously, it always called it from the LayoutView, regardless of what layout changed. This will be more efficient in typical cases of non-root layouts. It may be more inefficient in the following cases a. Two layout roots are present, of which one is an ancestor of the other (in this case, the new code will update the overlapping layout tree portions twice). b. Cases when LocalFrameview::UpdateLayout recurses, due to NeedsLayout being true after the first one. If we consider these cases sufficiently rare, then this CL is ok as-is. Handling (a) and (b) is possible but is harder to implement. Bug: 462719,970224 Change-Id: Ie65dc73a70bb9362dfa20ff9ad4070e3945d3c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728717Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683409}
-
Julian Watson authored
BUG=985192 Change-Id: I15da8fd02164d3c2089c4dddc24b48171577cde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728171Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#683408}
-
Kenichi Ishibashi authored
crrev.com/c/1717885 was a workaround to fix use-after-free of URLLoaderRequestController. This CL reverts the workaround. This CL makes ServiceWorkerNavigationLoader reset fallback callback when the controller is destructed. This way we won't touch a stale controller. Bug: 989404 Change-Id: Icf24e22b6fe5a3a6f29ccca95b21eb4233dab3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730409 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#683407}
-
Tricia Crichton authored
When running run_py_tests.py, chmod on temp dirs can fail occasionally. Wrapped the command with try/except to suppress the error and allow tests process to complete. Change-Id: I896f10021348f45a065a66787a4bad5dcb01b70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732150 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#683406}
-
Nate Fischer authored
No change to logic, only adds metrics. Following up on an issue where apps failed to specify MIME types, we realized it would've been very helpful to understand how frequently we expect this to happen in the wild. This CL adds metrics to track cases where we expect apps to explicitly tell us with the MIME type for content. Bug: 989346 Test: None Change-Id: Idfb1e7b68cb79622f1e6795b050ed72c090b4163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730729 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#683405}
-
Jenna Himawan authored
Bug: 990051 Change-Id: I3db913053bcd038514cde1cf26f6a72de4102a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730775 Commit-Queue: Jenna Himawan <jhimawan@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683404}
-
Patrick To authored
This change runs most of the existing OpenVR/WMR tests with OpenXR by adding OpenXR to the WEBXR_VR_ALL_RUNTIMES* macros. Remaining tests to add are addressed in: crbug.com/986637 (input) crbug.com/986621 (drawing pixels) Bug: 976434 Change-Id: I6b0a48d37d1380ba50b97b2d97d5b7accb9c495b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714304 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#683403}
-
Sasha McIntosh authored
Prework to removing uyvy output format references in gpu_memory_buffer_video_frame_pool. UYVY is no longer used, in favor of yuv420. Bug: 988538 Change-Id: Ice37e5f2f3975cd9c784d4a5470906e23a13345a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713668Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683402}
-
Daniel Cheng authored
Document the high-level goal of IPC review. Change-Id: Ie367c0026fe9d009196d2c58ec5619db4a4b72bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730498 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683401}
-
Sky Malice authored
TBR=siggi@chromium.org Bug: 990148 Change-Id: Ibeda7b1d6628105d59d66d8788e5fb99d04a9221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731699Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683400}
-
Kyle Milka authored
Show the focus outline on a selected bg tile when navigating with the keyboard. http://go/scrcast/NTA2NTc0NTg1MzU3OTI2NHw1NGE3MmRmYS02Ng Bug: 937570 Change-Id: I96c1449ddff90a5c32a2348607506ab5ae728743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728045Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#683399}
-
Tony Yeoman authored
This has thread safety issues, reverting to reland a fixed version. This reverts commit 0f70801a. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Cros SR] Reflect user history deletion actions in the model. > > We have an on-device model ranking commonly used URLs in the CrOS > launcher, which stores these URLs in the model itself. This CL > observes the history service and deletes URLs from the model that > are removed by the user. > > Bug: 931149 > Change-Id: If9e9654a00ae804807319a3dc5dc91b599698c7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725032 > Commit-Queue: Tony Yeoman <tby@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683049} TBR=jiameng@chromium.org,tby@chromium.org Change-Id: Iadd8433895f16fb3c9e3a4d5f9b2a53869612ab3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731990Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#683398}
-
- 01 Aug, 2019 11 commits
-
-
Jinsuk Kim authored
Gesture navigation on rendered pages opened via 'open in a new tab' was not working due to a bug in the logic determining the activation of its UI. This CL fixes the bug by having it use the same logic used by native pages. Bug: 989729 Change-Id: Ifdf6df5fa4ec5a7ce592167d16c5c63434c27b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728535Reviewed-by:
-
Evan Stade authored
CollectedCookiesViews::CreateAndShowForWebContents may be called while an existing dialog (widget) is in the process of closing. In this case, exit gracefully instead of crashing. The only way I can think of that might be possible to repro this IRL (i.e. aside from clusterfuzz) would be to: a) open page info bubble b) click "cookies" c) open page info bubble again d) click "cookies", then focus cookies dialog, press escape, all in rapid succession e) cookies dialog starts closing f) click on "cookies" is a posted task, and is handled after cookies dialog starts closing, but before finishing closing This is probably exceedingly rare, enough so that it's not worth being concerned with re-opening the cookies dialog. (And arguably, it shouldn't re-open anyway, since the last command the user issued was "escape" (close).) Bug: 989888 Change-Id: Ic4e3274128f5530b621d9dfe4e99dd6d24bddc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731914Reviewed-by:
-
Charlene Yan authored
Bug: 978109 Change-Id: Ie59d4d378da2476d9e78fc20f5a6a8e5929e55f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731763 Commit-Queue: Charlene Yan <cyan@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#683395}
-
Jared Saul authored
Context: These features hard-code in Chrome that Elo and JCB cards are unsupported for upload save to Google Payments. In M75, the AutofillDoNotUploadSaveUnsupportedCards study (Project Passport Control) does the same thing but dynamically via a Payments RPC and for more card types. Thus, these features can finally go away (M69-M74). Note that this CL is essentially a reversal of the original one: https://chromium-review.googlesource.com/c/chromium/src/+/1153301 Bug: 868552, 902366 Change-Id: I820a110afb83002151e726ae539097104e6ae45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717490Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#683394}
-
Hiroshige Hayashizaki authored
`delivery_value` can be None. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: Ia40b1cb4a75d14384092fb1fb84c51df8411ef15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723012 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683393}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/447b45d42307..24146be8336f git log 447b45d42307..24146be8336f --date=short --no-merges --format='%ad %ae %s' 2019-08-01 ehmaldonado@chromium.org depot_tools: Simplify CheckCallAndFilter[AndHeader] Created with: gclient setdep -r src/third_party/depot_tools@24146be8336f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: If6530ac3c6647eb6e452bc719e787eb6bc7cf246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731760Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL moves the inline script CSP check from PendingScript::ExecuteScriptBlock() (#execute-the-script-block) to ScriptLoader::PrepareScript() (#prepare-a-script) as spec'ed. This CL removes Script::InlineSourceTextForCSP() which is no longer used. Behavior changes (the new behavior is spec-conformant and thus this CL adds WPT tests): - Previously <script>'s error events were fired when inline script CSP check fails, while after this CL the events are no longer fired. Test: scripthash-basic-blocked-error-event.html (Moved from layout test with expectation changes) This CL makes Chromium's behavior align with Firefox and Safari. - If the nonce attribute is changed or the CSP list is updated after prepare-a-script before evaluation, previously the new nonce/CSP were used for CSP, while after this CL the old nonce/CSP (at the time of prepare-a-script) is used. Test: scriptnonce-changed-*.html This CL makes Chromium's behavior align with Firefox. (Safari's behavior is different from any other browsers) This CL also adds scripthash-changed-*.html (just for symmetry with scriptnonce-changed.html), which pass only on Chromium. Bug: 964537 Change-Id: I8673956101d9d13708c452db23258f125cb3d256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618262 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#683391}
-
Ken Rockot authored
This removes ChildProcessLauncher's nominal dependency on BrowserThread initialization by capturing the client's current SequencedTaskRunner rather than the current thread's BrowserThread::ID, which may not be initialized yet. Bug: 989769 Change-Id: Ia4b9cb0781540f6737be761c201b6440f7713ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731473Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#683390}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I8d94c4267bb1730765e247d4841cad3ac7622a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728268 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683389}
-
Glenn Hartmann authored
It's WebAPK-specific logic, so it seems like it belongs there. I also made a utility getWebApkInfo() function. IMHO, it makes conceptual sense that WebApkActivity only deals with WebApkInfo (it mostly shouldn't need to know that WebappInfo even exists). Change-Id: Ia2ed8583e4c1810327582481651dd44aa1678bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730092 Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#683388}
-
Jeremy Chinsen authored
In single-view, pages are horizontally centered within the document. This centering is being done in PDFiumEngine, making it difficult to test. This CL moves the centering logic for single-view to draw_utils::CenterRectHorizontally(). This allows us to test the logic. Bug: 51472 Change-Id: Idd67cde3c57d4155c9e02ca82a36ad19a6205f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730524 Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#683387}
-
