- 05 Jun, 2019 40 commits
-
-
Pavel Shmakov authored
TBR=szermatt@chromium.org Bug: 970219 Change-Id: I00ac5f6d684a6be77eb692f901fafd323227aebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645226Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666252}
-
Xida Chen authored
The specific one is virtual/blink-cors/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-preload-allowed.php The original test is already marked flaky. TBR=gayane@chromium.org NOTRY=true Bug: 678499 Change-Id: I7d220e6aa12bd4079d392021e387e7cac1422fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644935Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666251}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/082a93c5faa3..a6e239978796 git log 082a93c5faa3..a6e239978796 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 perezju@chromium.org [Telemetry] Add story_run.AsDict method Created with: gclient setdep -r src/third_party/catapult@a6e239978796 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:966835 TBR=skyostil@google.com Change-Id: I3b917cc089811a3c77ce590a645c14c2129f1fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666250}
-
Xida Chen authored
The specific test is virtual/blink-cors/http/tests/security/offscreencanvas-placeholder-read-blocked-no-crossorigin.html is comes from a virtual test suite. The original version of this is already skipped and has a bug associated with it. TBR=gayane@chromium.org NOTRY=true Bug: 922951 Change-Id: I091ddd40fa96f73ac4d832920cdcf2b002d978bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645374Reviewed-by:
-
Roman Sorokin authored
Both oobe_dialog_host.css and screen_gaia_signin.css had :host rules. Removed one from screen_gaia_signin.css Also removed v2 class - introduced saml-interstitial class. Alternative would be to keep saml-interstitial with the same size and not shirk it Bug: 971172 Change-Id: Ib9e93c4bc347910286812114df29579467c0b2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645360Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666248}
-
Stephen Chenney authored
Drawing a 100px x 100px div with border radius 50px is not the same as with border radius calc(100% - 1px) = 99px. R=foolip@chromium.org BUG=968430 Change-Id: I953c26b72d55d930cdbbcfa969f38b892e3151f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639566 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#666247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80255d87a852..f6dc12884b53 Created with: gclient setdep -r src-internal@f6dc12884b53 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I88f5e59de71b08e8f1394e82eca55a053e42884b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645175Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666246}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/82e7e7a3..13da560b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7cb18c61ebee265facd13e6bd32db77a56e3516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645372Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666245}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 40bc2a0e. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." a5b31124 "DetachLayoutTree clear hover/active state on dom removal." 04c3df15 "Canvas::TestMetrics: Measure the TextMetrics info after loading the font" 2d4812d4 "[css-contain] Fix <select> dimensions with size containment" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ie398bf1d5ba104960265ed368d0bf31dfb9e032d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645492Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666244}
-
Mythri A authored
We would like to run a finch trial on this feature. Bug: v8:8394 Change-Id: Iecac081955574c4add95627e10c3dbd5eda547c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642640Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#666243}
-
Eugene But authored
This target does not include sources yet, because existing tests are not EG2 compatible yet. Bug: 922813 Change-Id: I75aac839686946eb73cc893ae3235ca7fed9ba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642113 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#666242}
-
Carlos Caballero authored
It is no longer used, and you should be posting tasks with BEST_EFFORT priority instead. Bug: 887407 Change-Id: I3792d648a5a9702ccdf08859b7bf65b58c5dbafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645215 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#666241}
-
Eugene But authored
This test will be ported to EG2 and EG2 can not depend on chrome app classes like OmniboxPopupRow. Bug: 922813 Change-Id: I5b1ae3f263b18117f52322d22266c4db6fad4bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642138 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
After some of the CLs from https://crbug.com/952766, SigninManager no longer needs access to some of SigninManagerBase members. These CL makes those member private instead of protected. Bug: 952766 Change-Id: I8b6e190a027234cb931de05d0d2969289bd6f4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643538Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#666239}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac79ca16c651..9893f8e15152 git log ac79ca16c651..9893f8e15152 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2dd40a44d1a6..3c219171135d (5 commits) 2019-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src ce989eac..72cb69b7 (348 commits) 2019-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 79d4ac9ab695..5b424e69101a (2 commits) 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 mtklein@google.com print 1/K floats as fractions 2019-06-04 mtklein@google.com move peepholes where they're relevant 2019-06-04 fmalita@chromium.org [skottie] Initial text range selector support 2019-06-04 mtklein@google.com print SKVM test failures 2019-06-04 mtklein@google.com allow two immediates 2019-06-04 robertphillips@google.com Make color initialization version of createBackendTexture public 2019-06-04 mtklein@google.com add SkVMBuilders.* to DM deps in G3 2019-06-04 michaelludwig@google.com Extract GrQuadList into separate header 2019-06-04 borenet@google.com [infra] Fixes for chrome_release_branch 2019-06-04 mtklein@google.com dump register and instruction count 2019-06-04 mtklein@google.com add extract instruction 2019-06-04 mtklein@google.com add pack instruction 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 mtklein@google.com add mul_unorm8 instruction 2019-06-04 mtklein@google.com centralize test/bench SkVM builders Created with: gclient setdep -r src/third_party/skia@9893f8e15152 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ib407a179e3d2c135e8f676685de2cec37e8044f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645054Reviewed-by:
-
Henrique Ferreiro authored
This CL moves SigninManager’s observing of ProfileOAuth2TokenService::OnRefreshTokensLoaded() to SigninManagerBase, if’def-d out on ChromeOS. This is a step in eliminating the inheritance relationship between SigninManager and SigninManagerBase, as motivated in this design doc: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.8jjdy95t6p7x and described concretely here: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.mbkrv9nkb93w The functionality is ifdef-d out on ChromeOS, as it is currently not used on that platform. Bug: 952766 Change-Id: Icafd01997b140c34c560fca642356c41197eb24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635614 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Mario Sanchez Prada authored
As part of the Onion Soup effort to move the PushMessaging feature into Blink, we need to get rid of this class now that is no longer used, since the implementation of mojom::PushMessaging inside of //content/browser (content::PushMessagingManager) communicates now directly with Blink's blink::PushMessagingClient. Bug: 939943 Change-Id: Ibe2eefce97a0bf52e98f28a7c540b998afc6fd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631402 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666236}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/97b926857759..659eeddb2df5 $ git log 97b926857..659eeddb2 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 bruce.mitchener Use C++11 override keyword. 2019-06-01 corbett.dav [myanmar] Make medial_group match the OT spec 2019-05-29 qxliu [subset] Hmtx/vmtx tables to use subset2 and new iterator frameworks 2019-06-03 ariza added parentheses to FDSelect::sanitize as well 2019-06-03 ariza added test data 2019-06-03 ariza parenthesized cond-exp in CFF2FDSelect::sanitize 2019-06-03 ebrahim Reapply possible bsearch overflow fix 2019-06-03 bruce.mitchener test: Use nullptr in C++ code. (#1744) 2019-06-02 ebrahim [ci] revert to xenial 2019-06-02 ebrahim minor 2019-06-02 ebrahim Use a unified bsearch (#1741) Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 969261 Tbr: bungeman, eae Change-Id: Ib7c0a4cc9fec1d8f390a8d41dc5cb2ff2b0ffdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645212Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#666235}
-
Jan Krcal authored
Bug: 836718 Change-Id: Ie8e1a039d8ef653b5377bb57638cd180dd87e1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642551Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#666234}
-
Darren Shen authored
In a previous patch, we changed the MODECHANGE key behaviour so that pressing it once will only show the current input method. This was to follow the UX specs. However, upon consideration, we're going to change it back to the original behaviour of switching to next input method on first key press. The original code used a event rewriter to convert the MODECHANGE key into Ctrl-Shift-Space (which switches to the next key press). We then changed the code to be in ash accelerators because of the extra logic involved. Now that we don't need this extra logic, we could revert back to event rewriter, but we think it's better to keep it in accelerators because we still have some extra logic around histogram logging. TBR=holte@chromium.org Bug: 953901 Change-Id: I2cf4dc41300b62ee6f57085408e199a2a55062b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642487 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#666233}
-
Sergio Villar Senin authored
They belong to wtf/ and the WTF:: namespace. They're currently placed in the top-level platform/ directory under blink namespace. Bug: 968504 Change-Id: Iea6bb38e5b4406b18c4a264d7ded6d2065a73d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635821 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL collapses all code-paths for accessory sheets into one. All sheets now have common classes for coordinator, mediator and model. For the ViewBinders, this would make no sense (since they are static classes used to implement interfaces anyway) and Views are largely shared anyway. The wiring is only partly hidden in these super classes since it would be too difficult to find the connection between ViewBinder, Model and Coordinator if we would just require interfaces [1]. Minor, intentional clean-ups: - Credit Cards now have a UserInfo type representation. - The address sheet isn't any longer in V2 but instead guarded by the same flag as the credit card sheet. [1] I tried and reverted it. It pretty much takes 300 more lines away but then, the whole component becomes very in-transparent. Details to follow. Bug: 902425 Change-Id: Ia44694f72418b5f27a021569bfb3e70a19f24201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634736 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#666231}
-
Alex Chau authored
- Introduce encryption result enum and callback - Added encryption logic in GcmEncryptionProvider based on EncryptionRoundTrip unit test Bug: 966035 Change-Id: I390651722f89eaf380c8a2e8d43a76ad72d447c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635610Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#666230}
-
Jan Wilken Dörrie authored
This change removes code duplication between base::BindOnce and base::BindRepeating by introducing a generic base::internal::BindImpl. Bug: 554299 Change-Id: Ia06233baf973d62b458ed5cb3fbded0da865f83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617775Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#666229}
-
jdoerrie authored
This change introduces base::Contains(), generalizing the existing base::ContainsKey() and base::ContainsValue(). base::Contains() has multiple templated overloads, depending on what API the queried container provides. If possible, it invokes a contains() member function on the passed in container. If this does not work, it will choose a member find() function. If such a function is not present either, it will use std::find() as a fallback. Bug: 970209 Change-Id: I54fb619b6cf229308a40cc81658bd800c3671d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631406Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d944a1a52fef..082a93c5faa3 git log d944a1a52fef..082a93c5faa3 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 dberris@chromium.org SheriffRedux: Handle empty configs cases Created with: gclient setdep -r src/third_party/catapult@082a93c5faa3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181,chromium:971170 TBR=skyostil@google.com Change-Id: I652bbd5f045fafe120d84f6f4d4a102fbc862d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645121Reviewed-by:
-
Julie Jeongeun Kim authored
This class is not used: (1) app_shell is defunct as a product (2) no tests rely on the class Its presence is a hindrance to an upcoming effort to internalize OAuth2TokenService behind IdentityManager. This change was originally authored by Colin Blundell<blundell@chromium.org> Bug: 967598 Change-Id: I7e353d891518d1626eb2e4d83294c6ca223b0d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635120 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666226}
-
arthursonzogni authored
This is probably caused by a slow renderer process that is removed by the swapout / unload timeout before it has finished running its unload handler. BUG=969727 Change-Id: I83c9af526ce0550435f62758a057741c5155b7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643533 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#666225}
-
Sami Kyostila authored
Add transparent forwarding wrappers in order to remove the "WithTraits" suffix from the various task posting APIs. These wrappers will be removed once all the call sites have been rewritten to also remove the suffix. This patch also renames methods on the TaskExecutor interface to remove the same suffix as well as some internal ThreadPool APIs; the full code base will be adjusted in later patches. TBR=kkhorimoto@chromium.org Bug: 968047 Change-Id: I429da2bdf0ad75240b3f4fc574e3b6932bf1be40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640650Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#666224}
-
Martin Robinson authored
Change to original: Modified implementation to use a WindowObserver in the View accessibility code to reduce the test surface of the original patch. This should eliminate issues with flaky tests. Now instead of firing a "window minimization state changed" event the code fires a "window visibility changed" event. Original change's description: > Add support for setting the AtkObject state and sending the > appropriate AtkWindow events when a toplevel window in Chrome > is minimized and restored. Bug: 866336 Change-Id: I18636759730879762fcbe8e423a4537590241757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619700Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#666223}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbfc92ef1538..80255d87a852 Created with: gclient setdep -r src-internal@80255d87a852 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I9e52c6615df83e744a4eb1321a82437feb6f370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645120Reviewed-by:
-
Richard Knoll authored
This allows us to see how this new feature is used and to spot any issues in the current UX. Bug: 969018 Change-Id: Ib6c2d01b18df6b137c0e5929316eada77f4aba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638517Reviewed-by:
-
Tanmoy Mollik authored
Reland "Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string" This is a reland of 2669b5b5 The previous cl had a merge conflict with another cl that introduced a new file components/signin/core/browser/oauth2_token_service_delegate_android_unittest.cc This cl fixes the error. > Changing OAuth2TokenService::Observer and its subclasses to use CoreAccountId instead of std::string > > This cl is part of the effort to use CoreAccountId instead of std::string > to denote account_id. > > Bug: 959157 > Change-Id: I6b95b6adf7d73228c399162daf2867c532acd7cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626599 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@google.com> > Cr-Commit-Position: refs/heads/master@{#663069} Bug: 959157 Change-Id: I064945cb25872e8c87e3f9012cd4cf44a9c98d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628622Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#666220}
-
Anatoliy Potapchuk authored
Bug: 959967 Change-Id: Ie103f78978f3daaaf31f280c8c51e6c96601242a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641262 Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#666219}
-
Vasilii Sukhanov authored
Currently if the username has a conflict with current credentials, it's cleared before presaving. The CL moves this logic into PasswordGenerationState. Bug: 936011 Change-Id: Ib008187f301a44e2d9cf1ef3f9c5dbaef2255d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643553 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#666218}
-
Siddhartha S authored
This reverts commit bfb7d0c3. Reason for revert: Roll after perfetto fix Roll src/third_party/perfetto/ fc15cad36..f80d2d4f0 (27 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/fc15cad36895..f80d2d4f0a64 $ git log fc15cad36..f80d2d4f0 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 primiano@google.com Disable metatrace_unittest on windows builds 2019-06-05 primiano@google.com Speculative fix of windows build 2019-06-05 eseckler@google.com service: Fix tracing service unittest build for chromium. 2019-06-04 primiano@google.com Fix races in metatrace unittest and gcc build 2019-06-04 fmayer@google.com Make HeapprofdEndToEnd a parametrized test. 2019-06-04 hjd@google.com typo: the the -> the 2019-06-04 hjd@google.com Reland: perfetto_cmd: add ability to compress trace packets 2019-06-04 fmayer@google.com Fix typo. 2019-06-04 hjd@google.com Revert "perfetto_cmd: add ability to compress trace packets" 2019-06-04 eseckler@google.com tools/idle_alloc: Only build in standalone builds. 2019-06-04 hjd@google.com perfetto_cmd: add ability to compress trace packets 2019-06-04 fmayer@google.com Add missing setsid before fork to avoid leaking children. 2019-06-04 hjd@google.com Make tools/tmux work with fish 2019-06-04 primiano@google.com Move README.md from include/perfetto to include/ 2019-06-04 primiano@google.com Improve metatrace, allow to be used in production 2019-06-03 ssid@google.com Fix idle_alloc.cc build 2019-06-03 ssid@google.com Rename the thread names in ChromeThreadType to specify chrome 2019-05-31 kodiobika@google.com Added tests for raw syscall recording 2019-06-03 primiano@google.com Add API usage example for the Android tree 2019-06-03 fmayer@google.com Add docs for idle page tracking. 2019-06-03 eseckler@google.com processor: Parse TrackEvent arguments 2019-06-03 primiano@google.com Add consumer API and --query cmdline to list data sources 2019-06-03 fmayer@google.com Update trace_to_text for heap_profile. 2019-06-03 lalitm@google.com perfetto: add java proto targets and fix compile 2019-06-03 fmayer@google.com Allow to specify data_source_stop_timeout in TraceConfig. 2019-06-03 lalitm@google.com docs: add toc entry and fix some links 2019-05-31 fmayer@google.com Use IDLE bit instead of referenced bit. Original change's description: > Revert "tracing: Add thread names and types to perfetto traces and roll perfetto" > > This reverts commit 906024f5. > > Reason for revert: Perfetto roll seems to break compile: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911612852241220240/+/steps/compile/0/stdout?format=raw > > Original change's description: > > tracing: Add thread names and types to perfetto traces and roll perfetto > > > > Roll src/third_party/perfetto/ fc15cad36..3cd1230c5 (6 commits) > > > > https://android.googlesource.com/platform/external/perfetto.git/+log/fc15cad36895..3cd1230c5eb3 > > > > $ git log fc15cad36..3cd1230c5 --date=short --no-merges --format='%ad %ae %s' > > 2019-06-03 ssid Fix idle_alloc.cc build > > 2019-06-03 ssid Rename the thread names in ChromeThreadType to specify chrome > > 2019-06-03 fmayer Update trace_to_text for heap_profile. > > 2019-06-03 lalitm perfetto: add java proto targets and fix compile > > 2019-06-03 lalitm docs: add toc entry and fix some links > > 2019-05-31 fmayer Use IDLE bit instead of referenced bit. > > > > Created with: > > roll-dep src/third_party/perfetto > > > > Depends on aosp/973864. > > > > Change-Id: Ib57d2b9005fea04673c133e8f5aed19fddcf4a29 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637680 > > Commit-Queue: ssid <ssid@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#665798} > > TBR=ssid@chromium.org,eseckler@chromium.org > > Change-Id: I26be2dd8e6af0038f623d4b306124d2b54f758dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642748 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665805} TBR=ssid@chromium.org,eseckler@chromium.org,shend@chromium.org Change-Id: I93290110464f8a2d9ea3c38eaecb33ae002e3ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643652 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#666217}
-
Rune Lillesveen authored
As discussed in github issue 3949[1], we should not set the canvas color to black if the view is forced transparent, like it wouldn't be white in the default scheme. [1] https://github.com/w3c/csswg-drafts/issues/3949 Change-Id: I33ff79c17c245a9cbae3a5602d2240361fca293d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643575Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#666216}
-
arthursonzogni authored
This checks subframes survives while being in the BackForwardCache. In particular, what happens when loading a new main document in the same process of the cached subframe? Does it survive? Currently: Yes. + Test: BackForwardCacheBrowserTest.SubframeSurviveCache1 + Test: BackForwardCacheBrowserTest.SubframeSurviveCache2 + Test: BackForwardCacheBrowserTest.SubframeSurviveCache3 + Test: BackForwardCacheBrowserTest.SubframeSurviveCache4 Four new test cases: 1) A1(B2) -> C3 -> A1(B2) 2) A1(B2) -> B3 -> A1(B2) 3) A1(B2) -> B3(A4) -> A1(B2) -> B3(A4) 4) A1(B2) -> B3 -> A4 -> B5 -> A1(B2) Bug: 511340 Change-Id: I25414030dc48d5bf7fcbe85b33dc00c9a2cd890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627029 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Alex Clarke authored
A followup to https://crrev.com/c/1637460 Bug: 906125 Change-Id: Ib9bb0ba030e001816c6b75d124060f8a04a8525d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638540 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#666214}
-
Etienne Pierre-doray authored
Add perftests to compute read + write throughput. This CL only implements benchmarks for ThreadLocalStorage. PlatformThreadLocalStorage will be added as a follow-up. Change-Id: I80de0bcb3a31e771646c942413aa156ecf960798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643469 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
