GitLab

String IDS changes only so, TBR'ing owners.
// For chrome/browser/ui/cocoa
TBR=asvitkine
// for
TBR=msw

BUG=660349

Review-Url: https://codereview.chromium.org/2626723002
Cr-Commit-Position: refs/heads/master@{#442735}

BUG=none

Review-Url: https://codereview.chromium.org/2613033003
Cr-Commit-Position: refs/heads/master@{#442734}

To make snackbars and infobars animate, snackbars were moved to be child
of CompositorViewHolder, and TabContentViewParent was introduced to handle the
animation. One side effect of such design is that many Android views in
CompositorViewHolder now rely on a behavior to receive touch event.

This CL removes such behavior, as it is not the standard Android routine and it
makes our view hierarchy no longer extensible. Instead, a parent of
CompositorViewHolder is introduced to harbor all Android views that may display
on top of content.

This CL also moves infobars to be a sibling of snackbar, and their parent will
be a new FrameLayout called bottom_container.

BUG=640710

Review-Url: https://codereview.chromium.org/2623493003
Cr-Commit-Position: refs/heads/master@{#442733}

BUG=675359, 675358

Review-Url: https://codereview.chromium.org/2623713002
Cr-Commit-Position: refs/heads/master@{#442732}

unique, but clients aren't.

Also, dump whether the SB check for the URL returned by the DBManager had timed
out.
Also, make the dump buffer smaller hoping to get more minidumps.

BUG=660293

Review-Url: https://codereview.chromium.org/2616653002
Cr-Commit-Position: refs/heads/master@{#442731}

This caused RunOldLayout to use wrong PercentageResolutionSize

<main style="width:500px;height:150px;position:relative;border: solid black">
  <div style="position:absolute;top:25%;width:50%;background-color:yellow;">hi</div>
</main>

This used to display at 1/2 width in NGLayout.

BUG=635619

[ng_constraint_width]

Review-Url: https://codereview.chromium.org/2616093004
Cr-Commit-Position: refs/heads/master@{#442730}

BUG=679084
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2620103002
Cr-Commit-Position: refs/heads/master@{#442729}

Current items (Copy link address, Copy link text) shown in the context
menu for tel tag link do not make sense.

Update the items shown in the context menu when long pressing a tel
link. The items include:
1. Call: acts the same as clicking on the link
2. Send message: navigates to the default message app to send a text
message for given telephone number.
3. Add ot contacts: navigates to Contacts and add the given phone number
to the contact.
4. Copy: copys the phone number.

BUG=394299

Review-Url: https://codereview.chromium.org/2619493006
Cr-Commit-Position: refs/heads/master@{#442728}

Change Picture subpage can get into an odd state when the user navigates
away and then back again. This CL fixes that regression and adds a test.

BUG=674844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626733002
Cr-Commit-Position: refs/heads/master@{#442727}

This bug caused LayoutTest to fail:
virtual/layout_ng/css2.1/20110323/absolute-replaced-width-055.htm

BUG=635619

[ng_bug_margin_top]

Review-Url: https://codereview.chromium.org/2628583003
Cr-Commit-Position: refs/heads/master@{#442726}

roll-dep src/third_party/chromite chromiumos/chromite.git

https://chromium.googlesource.com/chromiumos/chromite.git/+log/de4d8e3236c7..267bf6a6bbd0

$ git log de4d8e323..267bf6a6b --date=short --no-merges --format='%ad %ae %s'
2016-12-08 laszio Add chell-chrome-pfq to waterfall.
2017-01-07 laszio afdo: fix a python syntax problem
2017-01-06 laszio afdo: initialize gsurls before using it in AFDOUpdateEbuildStage
2016-12-02 vapier patch: handle gerrit results that omit http/https results
2016-09-22 aaboagye Paygen: Split up Paygen into Build + Test stages.
2016-11-23 achuith cros_run_vm_test: --vm-sanity for running vm_sanity.py.
2016-11-01 dgarrett bootstrap: Create script to launch cbuildbot on branch.

BUG=

Review-Url: https://codereview.chromium.org/2626803002
Cr-Commit-Position: refs/heads/master@{#442725}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d49320dbc448..854df3eb017b

$ git log d49320dbc..854df3eb0 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 sullivan Remove former contributors from OWNERS

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2620173002
Cr-Commit-Position: refs/heads/master@{#442724}

Merge internal change 144001562.

BUG=

Review-Url: https://codereview.chromium.org/2619993003
Cr-Commit-Position: refs/heads/master@{#442723}

Generated via src/content/test/gpu/gather_swarming_json_results.py.

BUG=679899
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2627733002 .
Cr-Commit-Position: refs/heads/master@{#442722}

In Widevine CDM component updater, when we copy the adapter, we should
also copy the adapter signature file.

BUG=660287
TEST=Manually tested

Review-Url: https://codereview.chromium.org/2617023004
Cr-Commit-Position: refs/heads/master@{#442721}

https://skia.googlesource.com/skia.git/+log/356f7c2600ef..3444cadedd47

$ git log 356f7c260..3444caded --date=short --no-merges --format='%ad %ae %s'
2017-01-10 mtklein Invalidate icache in copy_to_executable_mem()
2017-01-10 brianosman Add Gray8 pixel config
2017-01-10 mtklein SkSplicer: no need to set_k() manually.
2017-01-10 mtklein disable splicer on MSAN bot
2017-01-10 halcanary Remove last of SK_SUPPORT_LEGACY_IMAGE_ENCODER_CLASS
2017-01-10 mtklein SkSplicer: fix aarch64 jump offset, turn on testing on aarch64 Android bots
2017-01-10 mtklein SkSplicer: test and fix loop logic
2017-01-10 brianosman Revert "Add Gray8 pixel config"
2017-01-10 mtklein Test SkSplicer on x86-64 bots, except Windows.
2017-01-10 brianosman Start including 'winrt' in Windows toolchain
2017-01-10 msarett Respect SkColorSpace in SkPNGImageEncoder
2017-01-10 halcanary Clean up unused SK_SUPPORT_LEGACY_IMAGE_ENCODER_CLASS code

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2620133002
Cr-Commit-Position: refs/heads/master@{#442720}

BUG=

Review-Url: https://codereview.chromium.org/2620163002
Cr-Commit-Position: refs/heads/master@{#442719}

https://chromium.googlesource.com/angle/angle.git/+log/037340d..98e3407

BUG=chromium:678526,chromium:679607,chromium:679725

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623983002
Cr-Commit-Position: refs/heads/master@{#442718}

Assertion.h provides macros active only in Debug builds, but also ones
active in all builds, including ones used to crash out on when security-
sensitive conditions are violated, so it's important to test they work
as intended.

Review-Url: https://codereview.chromium.org/2626813002
Cr-Commit-Position: refs/heads/master@{#442717}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5f24a96d..1f92260e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2623923002
Cr-Commit-Position: refs/heads/master@{#442716}

on the offline interstitial

BUG=674717

Review-Url: https://codereview.chromium.org/2625553002
Cr-Commit-Position: refs/heads/master@{#442715}

Today we DVLOG(2) exclusively in decoder_stream.cc, making it hard to
filter out unimportant messages and only show important ones.

In this CL, different log levels are used for different events, using
the following rule:
- Level 1: Construction, destruction, initialization and error.
- Level 2: Important repeating events like reset, reinitialization and
           config change.
- Level 3: Other more frequent events like read, decode etc.

Review-Url: https://codereview.chromium.org/2627443004
Cr-Commit-Position: refs/heads/master@{#442714}

This API fetches the device description for a DIAL device, given a label for a device already discovered.

The request is configured to not send/receive cookies, ignore proxies, and ignore redirects.

Requests are retried with backoff on 5XX responses.

The response is validated in multiple ways:
- Valid Application-URL: header value
- Response body is a valid UTF-8 string
- Response body is <= 256kb

Additional validations are possible by following the DIAL spec closely at the risk of ignoring some devices.  See comments in device_description_fetcher.cc for details.

Note: The API function implementation is complicated by thread hopping.  See comments in dial_api.h for how this may be improved in the future.

BUG=671932
TESTED=Manually, unit tests, API test

Review-Url: https://codereview.chromium.org/2583853004
Cr-Commit-Position: refs/heads/master@{#442713}

Code changes:
- Disabling onboarding content for ChromeOS. Promotions for CrOS are out-of-scope for this launch.
- Ensuring that preference-specified tabs do not appear in new windows when a tabbed browser already exists for the profile.

Test changes:
- Removed 12 outdated tests
- Fixed or updated 9 tests

Details of affected tests, and rationale, can be found in this doc: https://docs.google.com/a/google.com/document/d/1PjAemEEFrl0gIDVQfnr1oAnHkb6DcV47HlOyyo7ICZI/edit?usp=sharing

BUG=608875,314819,313856

Review-Url: https://codereview.chromium.org/2475913003
Cr-Original-Commit-Position: refs/heads/master@{#442487}
Committed: https://chromium.googlesource.com/chromium/src/+/a52322134679a349366417e04e502bc8ce1f68e4
Review-Url: https://codereview.chromium.org/2475913003
Cr-Commit-Position: refs/heads/master@{#442712}

Update cc PropertyTreeBuilder to build additional maps from element id
(used for animation purposes) to the involved transform and effect
nodes.

This map is currently unused but will be used in subsequent patches so
as to eventually allow us to remove the existing maps from layer id to
these same nodes.

This is also a required step for SPv2 composited animation support
wherein, again in a subsequent patch, we will populate these maps in
PaintArtifactCompositor.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2612093002
Cr-Commit-Position: refs/heads/master@{#442711}

Save package does not decode the url when the web content has no title.

Also add some unit tests for special characters.

BUG=654591

Review-Url: https://codereview.chromium.org/2595753002
Cr-Commit-Position: refs/heads/master@{#442710}

Instead of using the last bucket, use the first bucket when no location is available.

BUG=668923

Review-Url: https://codereview.chromium.org/2620813002
Cr-Commit-Position: refs/heads/master@{#442709}

When switching media element src, MediaSession goes uncontrollable and
then controllable. The current MediaSession routing algorithm resets
metadata and controls when the session goes uncontrollable. However this
resetting is unnecessary but will cause notification flickering as well.
This CL removes the unnecessary reset signal.

BUG=678945

Review-Url: https://codereview.chromium.org/2612293003
Cr-Commit-Position: refs/heads/master@{#442708}

This is a quick fix to stop crashes; I'll do a more robust change in a
followup.

BUG=679657,673883

Review-Url: https://codereview.chromium.org/2621923004
Cr-Commit-Position: refs/heads/master@{#442707}

This needs to land prior to my CL for speeding up closure by
enforcing dependencies by poisoning namespaces:
https://codereview.chromium.org/2588843002

BUG=none

Review-Url: https://codereview.chromium.org/2623743002
Cr-Commit-Position: refs/heads/master@{#442706}

NWA was allowing invisible widgets to be activated, which
doesn't work in mus.

BUG=678070

Review-Url: https://codereview.chromium.org/2615743003
Cr-Commit-Position: refs/heads/master@{#442705}

Fixed the issue where the names of the archives would be random GUIDs
after pulling down from the device. Added a renaming step in the script
which would parse the mhtml source, get the original URL and use that as
filename in order to make archive names easier to understand.

BUG=None

Review-Url: https://codereview.chromium.org/2618863002
Cr-Commit-Position: refs/heads/master@{#442704}

This patch removes the flag for OCR dialog theme, which is no longer
used.

BUG=678642

Review-Url: https://codereview.chromium.org/2620963003
Cr-Commit-Position: refs/heads/master@{#442703}

Previously, separators always used 0xE9E9E9.  This CL allows themes to specify
the color.  This is currently overridden by the Gtk theme which gives a better
appearance on dark themes.  The difference can be seen in:
https://bugs.chromium.org/p/chromium/issues/detail?id=132847#c39

BUG=132847
R=erg@chromium.org,estade@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2623753002
Cr-Commit-Position: refs/heads/master@{#442702}

Old name webStateDidLoadPage:withSuccess: did not follow Coding
Guidelines for Cocoa, where word before argument should describe the
argument.

BUG=None

Review-Url: https://codereview.chromium.org/2622643003
Cr-Commit-Position: refs/heads/master@{#442701}

BUG=678983

Review-Url: https://codereview.chromium.org/2623613007
Cr-Commit-Position: refs/heads/master@{#442700}

Upon end of stream, chunk demuxer should decrease the duration to
match the highest buffered end time. This was not happening for
user-set durations which exceeded the highest buffered end time by
less than a microsecond.

Additionally, some style refactoring. For MSE, we pull duration
directly from the demuxer, which stores the user set value with full
precision. Moving this logic to WMPI from HTMLMediaElement ensures
duration WMPI uses matches that of HTMLMediaElement.

TEST=New layout test and manual testing of bug report steps
BUG=669997

Review-Url: https://codereview.chromium.org/2581533002
Cr-Commit-Position: refs/heads/master@{#442699}

This implements a fallback crash handler launcher. The launcher will be instantiated in the Crashpad handler process, where it pre-computes a command line to be launched on crash. This will be triggered off the UEF, under some form of single-instance locking.

BUG=678959

Review-Url: https://codereview.chromium.org/2596463002
Cr-Original-Commit-Position: refs/heads/master@{#442596}
Committed: https://chromium.googlesource.com/chromium/src/+/d4e43bb5146c7a59123ff5f3b6e853d8e8c29130
Review-Url: https://codereview.chromium.org/2596463002
Cr-Commit-Position: refs/heads/master@{#442698}

Original CL: https://codereview.chromium.org/2608803002/
PS 2 fixes chromeos_unittests.

It is common for a proxy configuration URL to be added as 'foo.com'
instead of 'http://foo.com'. Rather than relying on all UI to
validate the input, we should do so in the ONC conversion.

BUG=677357
TBR=emaxx@chromium.org,pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2619363004
Cr-Commit-Position: refs/heads/master@{#442697}

Revert of [Offline Pages] Remove need for OfflinePolicy when constructing an Offliner. (patchset #1 id:1 of https://codereview.chromium.org/2624523003/ )

Reason for revert:
The policy might be used shortly. This may be too soon

Original issue's description:
> [Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.
>
> BUG=679822
>
> Review-Url: https://codereview.chromium.org/2624523003
> Cr-Commit-Position: refs/heads/master@{#442687}
> Committed: https://chromium.googlesource.com/chromium/src/+/73b5ae5acf62a62a0782eef02086bd7b2b2b3fe4

TBR=dimich@chromium.org,petewil@chromium.org,dougarnett@chromium.org,dewittj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679822

Review-Url: https://codereview.chromium.org/2624833002
Cr-Commit-Position: refs/heads/master@{#442696}