- 05 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ec816af6e720..9c62f66c7235 git log ec816af6e720..9c62f66c7235 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 540662253ea3..b82ed734e767 (1 commits) Created with: gclient setdep -r src/third_party/angle@9c62f66c7235 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iadfab14bc0292d6f75eafe0f38c99c7ad6754562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738549}
-
Mikel Astiz authored
This is a reland of f52179a5 The feature was disabled by default before branching because some implementation parts were missing on Android. Original change's description: > Enable sync trusted vault support by default > > The feature is in a working state can be enabled by default. > > Bug: 1000146 > Change-Id: I66ef6f65d97234f47eaa76d1daafb8d3637692ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000702 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731898} Bug: 1000146 Change-Id: If2c11c87bbc021daaa6656f9e85b592302dd8327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035966Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738548}
-
Anton Bikineev authored
This is needed to prevent races in generational barrier and concurrent sweeper. Bug: 1029379 Change-Id: I80b7ece9a0b5d7c15844f220070833242125147c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005029Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#738547}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I9abd5f1f12d91ec58ae57aacfb0522c47a9d6ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038186Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0f6bcd18b2ef..7c3a1fc08224 git log 0f6bcd18b2ef..7c3a1fc08224 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 eshr@google.com Move initial quality experiment to adaptation module Created with: gclient setdep -r src/third_party/webrtc@7c3a1fc08224 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3891d05882c337bdbf19058102a87a6a6023cb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038750Reviewed-by:
-
Michael Thiessen authored
This change locks the SchemeRegistry on first use, which required refactoring url_util.cc to differentiate between SchemeRegistry use for adding Schemes, and SchemeRegistry use for using Schemes. Tests can now only modify schemes after initialization by calling url::UnlockForTests(), which creates a scoped object that resets the schemes, so tests can't mistakenly leave global scheme state modified. This change required changes to browser startup to decouple scheme registration from ContentMain, found here: https://chromium-review.googlesource.com/c/chromium/src/+/1945926 Doc: https://docs.google.com/document/d/1kDKqBaq-b6EbUm0F4ea7ARoksUcj1KUx3qxFuSXEwM4/edit Bug: 783819 Change-Id: Idcac37ccae297735176eba20b50ced3f9e63f9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901591Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#738544}
-
Julian Pastarmov authored
This reduces the number of individual writes to the file and sets maximum update rate of 6 writes per minute. BUG=1013546 TEST=components_unittests:LoopbackServerTests Change-Id: I40a51051b449dd8f88582420f78079dd2187bd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940687Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738543}
-
Thomas Tellier authored
Bug: 1022758 Change-Id: I1d19aac9d03a75f220329aa27db96d45be347a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035673 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738542}
-
Javier Ernesto Flores Robles authored
This reverts commit 960c8468. Reason for revert: This breaks password breach and crashes due the coordinator never been register with the dispatcher. Bug: 1046346, 1048612 Original change's description: > [iOS][coordinator] Modernize Password Breach Coordinator. > > This CL modernizes the PasswordBreachCoordinator > - to use the superclass -initWithBaseViewController:browser: > initializer, > - to remove the public property for dispatcher, > - to update the naming and usage of ‘dispatcher’ parameters to > match the usage guidelines. > > Bug: 1029346 > Change-Id: I26064ad9d0cf024185a28c33483db5631c4c7cd7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000626 > Commit-Queue: Nazerke Kalidolda <nazerke@google.com> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731997} TBR=marq@chromium.org,stkhapugin@chromium.org,nazerke@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029346 Change-Id: Ic02febc7d647d55ae893fb07117d81a76b1a17d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038770Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#738541}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f045c94a5ad1..d2b2837f5716 git log f045c94a5ad1..d2b2837f5716 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 fmayer@google.com Merge "Make ExperimentalFlamegraphNodesTable::Row init more explicit." Created with: gclient setdep -r src/third_party/perfetto@d2b2837f5716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I31ed0aa8058744553cc71330fae475df2836ffed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038184Reviewed-by:
-
Mikel Astiz authored
This reverts commit b50b951d. Reason for revert: suspect of causing crashes in tests, e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60586 Original change's description: > [Tab Groups] Hide separator for tab next to a named header. > > Bug: 1046554 > Change-Id: I79f37516e26aeb0fea7261b20082c7f882485918 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036483 > Reviewed-by: Connie Wan <connily@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738308} TBR=cyan@chromium.org,connily@chromium.org Change-Id: I586becb5914e17465a8849d6aa93c73b77c2fdd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035896Reviewed-by:
-
Artem Sumaneev authored
BUG=chromium:1039304 TEST=None Change-Id: Ie8d3c5e858671aac80415dcb1cf8f90436513f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036004Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/heads/master@{#738538}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I2f6a77de1c6d32682e5caa81bd673e3250d9b460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038155Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738537}
-
Maria Kazinova authored
Primarily to let it keep track of fields that have user input. Done via sharing FieldDataManager between AutoFillAgent and PasswordAutofillAgent. It was done to fix the problem of some user input not being saved when the page was changed at the moment of submission. The saving criteria was changed and interaction with FieldDataManager was added to always check for user typed input in addition to less trustworthy criteria (i.e. focusability that can be changed at the moment of submission). This is a fix for a previously reverted CL. Previous CL reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1991623 Now the saving criteria is milder. Bug: 957444, 1006745 Change-Id: I902e734600d5818a984ad12e310b6cd821bc51e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035983Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#738536}
-
Wez authored
ScopedRunTimeout is intended to be used to fail tests if a loop is Run() for too long, rather than to Run() the loop for a specific length of time. Clean up some tests which were using ScopedRunTimeout inappropriately. TBR=gab,xiyuan,mmenke Bug: 1021777 Change-Id: I42e72bb4a2a69f4eff3c84dbaf56dfaf975c86d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036009Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#738535}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b350d45696f..b55270f60f58 Created with: gclient setdep -r src-internal@b55270f60f58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045478 Tbr: jbudorick@google.com Change-Id: Id1ae9ce8b9f5889bb4534d8920c16f430062e86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038182Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738534}
-
Hazem Ashmawy authored
Add the button to change WebView provider as a neutral dialog button instead of overriding the existing positive button to open the correct WebView DevUI. This error dialog is shown when the dev ui is launched from a package that is different from the selected as the system's webview provider. Fixed: 1041606 Test: Manually change WebView provider and go back to wrong dev ui, inspect the dialog to see the two buttons Change-Id: I21e8f5f4b2d3b9d9c608df0abbe299442e2e9453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036068Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#738533}
-
Yuzu Saijo authored
This CL changes DCHECKs to CHECKs in ServiceWorkerVersion::Restore ControlleeFromBackForwardCacheMap to figure out the cause of the crashes. Bug: 1021718 Change-Id: Ifdfe7772466b24ce18366d66895152b132b929c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035529 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Auto-Submit: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738532}
-
Vladislav Kuzkokov authored
Bug: 1033439 Change-Id: I120e7c80f9a8a2f927f6aee0a57c8f3aa56614ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036181Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738531}
-
Mikel Astiz authored
Sample build failure where both failed: https://ci.chromium.org/p/chromium/builders/ci/win-asan/10148 TBR=benwells@chromium.org Change-Id: Iecc7d75fd41e2ded960ffdfd9e6f5f7bf3b3c8d0 Bug: 1048980,1049036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036069Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc3307c395e2..c631b7cc5f8c git log bc3307c395e2..c631b7cc5f8c --date=short --first-parent --format='%ad %ae %s' 2020-02-05 ehmaldonado@google.com Fix error on PRESUBMIT PostUploadHook Created with: gclient setdep -r src/third_party/skia@c631b7cc5f8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042324 Tbr: scroggo@google.com Change-Id: I353143759f21a32f771a83135386af05645a0ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038129Reviewed-by:
-
Maggie Chen authored
The Vulkan spec 1.2 and the Vulkan loader 1.2 were released in January 2020. Bug:775983 Change-Id: Ide4c904d210cd2d0e37c84f23b8a59f63c9f08c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037848 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738528}
-
Rushan Suleymanov authored
Propagate specific error codes when commit failed from CommitContributor to ModelTypeSyncBridge. Bug: 1047123 Change-Id: I118ce292bb6c27049099334f12dab0f75da9d059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030903 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738527}
-
David Jean authored
In the case of manual password saving, we need to skip the 'save password' infobar banner and let the user click the key badge to manually save or update the password. We also need to be able to remove the badge if user removes password. I've kept the badge handling as is, tied with the banner and infobar, even though we skip the banner. Works only for info reboot ui. Can be demo tested by patching 2012031 over this. Bug: 1045431 Change-Id: I0b208467910311ab0c86c4b90da593bb1827f93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019267 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bdd9db2010fa..f045c94a5ad1 git log bdd9db2010fa..f045c94a5ad1 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 lalitm@google.com Merge "tp: move span join and window tables to sqlite folder" Created with: gclient setdep -r src/third_party/perfetto@f045c94a5ad1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I29f2d668e70b5c0f49042f82bfc9dfc20b8355d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038180Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a8b54a9. With Chromium commits locally applied on WPT: 2aeae229 "SharedWorker: Add shared-worker-options-credentials.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I95874d12ea66f3cc173d27f67d9eacd6c7eb3641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037735Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738524}
-
Thibaud Michaud authored
The streaming compilation top tier callback is now triggered, even when the module is actually fetched from V8's in-memory module cache. R=ahaas@chromium.org Bug: v8:10165 Change-Id: I6f053c27c7ccf4d7ecae6fba709b48c08caf02fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037994Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#738523}
-
Sigurd Schneider authored
This CL fixes an issue where JavaScript execution would continue after reloading on a breakpoint. See design doc: https://docs.google.com/document/d/1aO9v0YhoKNqKleqfACGUpwrBUayLFGqktz9ltdgKHMk The CL depens on V8 change in crrev.com/c/1924366 and tests should fail until that change is landed+rolled to chromium. Fixed: 1004038 Fixed: 1014415 Change-Id: I182393ebd4c68588163dda7c607be8bb09a3eda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926502Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#738522}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/166b478fa620..9b350d45696f Created with: gclient setdep -r src-internal@9b350d45696f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I87c709b4373311fd7e56e17da2103703bc431e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038126Reviewed-by:
-
Robbie Gibson authored
Omnibox NTP Zero-Prefix Suggestions use the RemoteSuggestionsService to actually get their suggestions. The corresponding factory currently doesn't exist on iOS, so this CL creates it. Bug: 1048193 Change-Id: I7ad14129a954e96225adc9d6b000087165ce5859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035964 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738520}
-
Mihai Sardarescu authored
This reverts commit fcca6197. Reason for revert: Required downstream fix was submitted. Original change's description: > Revert "[iOS] Enable Earl Grey 1 and 2 tests for ClearSyncedData feature." > > This reverts commit 3edb7dbb. > > Reason for revert: consistently fails on downstream bots. > > Original change's description: > > [iOS] Enable Earl Grey 1 and 2 tests for ClearSyncedData feature. > > > > Previously the test case testSignOutAndClearDataFromNonManagedAccountClearsData() was disabled due to a misuse of the ScopedFeatureList flag, which should only be used for unit tests. This meant that the flag was not set correctly in the tests. > > > > The change uses the AppLaunchManager to enable the experimental flag on Earl Grey 2 and the flag within the Earl Grey 1 JSON setup. > > > > Bug: 1045981 > > Change-Id: I3160477a5230d24617168800a5cabacb4b8fd672 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023835 > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#737283} > > TBR=sdefresne@chromium.org,bpastene@chromium.org,fernandex@chromium.org > > Change-Id: I58ffda870f5d63c9b23fb9fb40903d14b2fd9ead > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1045981 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032120 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737316} TBR=sdefresne@chromium.org,bpastene@chromium.org,fernandex@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045981 Change-Id: I861b7342e2407bc972e6d794ec2ad85a4cd73019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037993Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738519}
-
Alex Clarke authored
Unlike WebView it looks like VariationsService is a better fit than a custom java fetcher since we expect to have network permissions. Note without backend changes this patch should be a NOP since no trials currently target WebLayer as a platform. WebLayerFieldTrials is a stub and as such it doesn't currently support WebLayer specific trials. AFAIK this doesn't prevent a trial's config specifying WebLayer only. The variations service itself has plenty of tests but there doesn't seem to be any tests for the equivalent hookup code in Chrome/WebView. Bug: 1025612 Change-Id: Ib7dfe64455a323cfafd160b2612f148872e0fa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028770 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738518}
-
Tanmoy Mollik authored
Crashes in chrome canary might be because SyncErrorInfoBar is passed null WebContent on launch from the active tab. Bug: 1048300 Change-Id: I2042b020e9b82c4fc10b876a3b83aed1de22fb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035986Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#738517}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a9624b4d5d0b..9e52bc0d0c1d git log a9624b4d5d0b..9e52bc0d0c1d --date=short --first-parent --format='%ad %ae %s' 2020-02-04 bclayton@google.com utils/vscode: LSP - Support OpExtInst (#3140) 2020-02-04 kubak@google.com Fix typos in opt's help. Update environment version. (#3170) 2020-02-04 stevenperron@google.com Start SPIRV-Tools v2020.2 2020-02-04 stevenperron@google.com Finalize SPIRV-Tools v2020.1 2020-02-04 stevenperron@google.com Update CHANGES 2020-02-04 afdx@google.com spirv-fuzz: Fuzzer pass to add composite types (#3171) 2020-02-04 afdx@google.com Update script that checks copyright years. (#3173) 2020-02-04 afdx@google.com spirv-fuzz: Disallow copying of null and undefined pointers (#3172) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9e52bc0d0c1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I3431737acb0df5ec530bc78909bfe7016c53b91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038123Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f764fc02e94c..ec816af6e720 git log f764fc02e94c..ec816af6e720 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 807f14657a25..b932cf53f769 (3 commits) 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 41a7302e9c62..8e8e1d0dd729 (4 commits) 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src e85fe4c3cc9f..ab47cacfd3b3 (1 commits) 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 7a2d408dea60..9e52bc0d0c1d (11 commits) Created with: gclient setdep -r src/third_party/angle@ec816af6e720 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I0cffa53427ea5e34685d21ff858636ce71a54b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038178Reviewed-by:
-
Boris Sazonov authored
Replace ChromeSigninController in ChromeBackupAgent with IdentityManager.GetPrimaryAccountInfo(). This is safe to do, because the native side is already loaded - the same method accesses JNI methods above. Bug: 1046412 Change-Id: Icfa1522bf0f8ec552d6211dd4dad4b12e7f74d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025468Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738514}
-
Luciano Pacheco authored
Table header move padding to the label so clicking in the padding area activates the click event in the label to sort the column. Change the cursor to pointer in the column header to indicate that it has an action (sorting the column). Reset the table header font-weight because it's already using Robot Medium which is already the right weight. Fix the border radius for the file row thumbnail so it shows perfectly rounded. Reset the padding top in the file row because in the current spec the text doesn't need the additional padding to align with the icon [1]. [1] - https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/css/common.css?l=343&rcl=80e9555e489ff4a6743f2d8f99dafdbaccc7397f Bug: 992821 Change-Id: I06b1b6e5c842162f6b1a3ea027932869704995a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033059 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738513}
-
Sean Harrison authored
Add: PRIVACY_SITE_SETTINGS_ALL PRIVACY_SITE_SETTINGS_AR PRIVACY_SITE_SETTINGS_VR These were missed in a previous CL and hits a DCHECK Add corresponding test to site_settings_page_test.js Merge all tests into one to remove flakiness, testing each logging call in a separate test was taking too long and causing sporadic timeouts resulting in flakiness. Now all logging checks are done by navigating around a single test instance and resetting proxy state, speed up removes all flakiness and was significant enough to allow the merging of all 4 split test suites without timeout concerns. Bug: 1046488, 1048858 Change-Id: I074e2581d3489e179adfdc187e7165284ccc2685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027447 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738512}
-
Takuto Ikuta authored
This is to take crrev.com/c/2036856 crrev.com/c/2036854 Bug: 984869 Change-Id: Iaa623376bfde92ae0620fd20362dd122764a8746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037189 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#738511}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/540662253ea3..b82ed734e767 git log 540662253ea3..b82ed734e767 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 johnkslang@users.noreply.github.com Merge pull request #2077 from kainino0x/configurable-target-pr Created with: gclient setdep -r src/third_party/glslang/src@b82ed734e767 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I93714bfe94cf2595049bb607463f9aa013b14b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038128Reviewed-by:
-
