GitLab

NOTRY=true
TBR=croleau@chromium.org
CC=mythria@chromium.org,ulan@chromium.org
BUG=953371

Change-Id: Ibcb64d10e27ee87925f71f627abfe960e54464ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574604Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652405}

- UMA shows this interface has no usage.

Change-Id: Ifcb68620aceab0d8a857b4a3a0c768990bf47905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546762
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652404}

Plumb the supported refresh rates from the browser to GPU process and
the preferred refresh rate setting from the GPU to browser process.

R=ericrk@chromium.org

Bug: 938106
Change-Id: I00f2564dfa523bebe0c76fa855ae844b72ba68da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556415
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652403}

See: https://docs.google.com/document/d/1E1uyto12NGe9kZFpqH8T8pRyhaOdzcKwHW51RETw-0Q/edit
CL for Android: https://crrev.com/c/1574892

R=drubery
TBR=rockot

Bug: 953997
Change-Id: Ie2138e3f4c15a82a722351cc47ddbde06016e8ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574938
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652402}

If NewTabPageLocation is set to any URL, then we will skip the
'nux-ntp-background' module.

Bug: 951833
Change-Id: I3ddbc76eb8a42d95b63cbec288df9b212dcff632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568769
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652401}

DXVA VDA outputs corrupted bitstream IDs in some cases. GVD allowed this
(in Release builds) and sets the VideoFrame timestamp to 0. This change
makes VdaVideoDecoder do the same.

Bug: 936747
Change-Id: Ie127bb9c57caa21082bce9f1b631f4ae723b631a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574884Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652400}

There is a gutter rect around the scrollbar during which thumb drags
will behave as though the mouse is on the thumb even if it moves off the
thumb but is still inside the gutter rect.  If the mouse moves outside
of that gutter rect, the thumb snaps back to its original position.
This behavior offers users the ability to quickly toggle between two
positions in a scroller by intentionally moving the thumb in the
non-scrolling direction in and out of the gutter.  However, it also can
frustrate users if they grabbed the scrollbar thumb and dragged in the
scrolling direction but unintentionally move outside of the gutter
causing the thumb to snap back.

This change modifies the behavior so that scrollbars have an infinitely
large interaction gutter rect in the scrolling direction.

Bug: 801188
Change-Id: I838741053305122adf5b81345eb56d87916edd0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566027
Commit-Queue: Sam Fortiner <samfort@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652399}

This CL adds a class to cache API calls before NotificationScheduler
async initialization is done.

Bug: 930968
Change-Id: Ic4bff46205393d684ec7c825e96daad788d0a914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573240Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652398}

If either BookmarkBarEnabled or EditBookmarksEnabled is set and disabled
then the 'nux-google-apps' module will not be shown.

Bug: 951837
Change-Id: I8c696ceec0f408074c67610f2eff4c129d5f21d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568685
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652397}

This reverts commit 1c60a4f0.

Reason for revert: Causing a lot of regressions for developer apps. 

Original change's description:
> Enabling forbid sync XHR in page dismissal by default.
> 
> Bug: 827324
> Change-Id: Id12b26c1303a977081702e792b0bd8e3ecbd8012
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542148
> Commit-Queue: Katie Dillon <kdillon@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#649921}

TBR=haraken@chromium.org,kdillon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 827324
Change-Id: I01c10dc87ba39bb716502a995f076b3c31bb4e91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573878Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652396}

This allows us to be more explicit when content::ResourceType needs to
be smuggled in an untyped int. It has the effect of introducing more
static_cast<int>, but this makes the conversion sites explicit.

This also allows several other incidental fixes:
- the Mojo version of the enum no longer defines a sentinel value (which
  violates best practices in the security guidelines)
- the C++ version of the enum can now define a compiler-enforced
  kMaxValue enumerator.
- Since kMaxValue is no longer a distinct value, dummy handling for this
  value can be removed. This revealed a quirk in
  chrome/browser/predictors/loading_data_collector.cc

Tbr: avi@chromium.org
Tbr: blundell@chromium.org
Tbr: droger@chromium.org
Tbr: rdevlin.cronin@chromium.org
Change-Id: I7203a029b1fcb06426c957d208e9278a25d4a45b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569345
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652395}

Bug: 939867
Change-Id: Ia1a8e99cea9ba5433b60f4213b1a3a1304cd9b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573159Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652394}

This completes the chain of render-side CLs to fetch the smoothness
and power efficiency stats for decodingInfo() with a KeySystemConfig.

Bug: 907909
Change-Id: Ia39df593706a6b2447ea2666cd4005c4fbc8fbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554897
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652393}

This CL marks the following histograms as never expiring:
  -Extensions.WebRequest.TotalBlockingRequestTime
  -Extensions.WebRequest.TotalRequestTime
  -Extensions.WebRequest.TotalExtraHeadersRequestTime

These are useful in monitoring the performance of the web request API and
detecting regressions.

BUG=953036

Change-Id: I296ad0a064261db44ec0004e42a27d3bad95f8c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572865Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652392}

Tab groups are currently identified using TabGroupData pointers. However,
this is fragile because those pointers may not be valid forever and
because memory address may be reused. It makes more sense to use an
opaque int ID for this purpose instead. This also allows the API to
explicitly define when a group may be null or not, by using
base::Optional. Also, in a future patch, tab_strip_layout.h/cc will be
able to operate using that ID and continue to avoid knowledge of any
particular View type.

This patch also includes some miscellaneous refactoring in
tab_strip_model_unittest.cc.

Bug: 905491
Change-Id: I9700a50d5fa9e4050ec2169af8e1362d11d9dade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562764
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652391}

https://chromium.googlesource.com/catapult.git/+log/f88c75708b4d..67f7f92555b7


git log f88c75708b4d..67f7f92555b7 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 benjhayden@chromium.org Fix y-axis unit in spa
2019-04-18 benjhayden@chromium.org Fix report-template css


Created with:
  gclient setdep -r src/third_party/catapult@67f7f92555b7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:952290
TBR=oysteine@chromium.org

Change-Id: I4f65e22452d69ab6b858c9cbb0ba57e26f67cd58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574784Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652390}

Bug: 879208
Change-Id: I60eb7cf15b6817814addb6094ca1ff9c4c252b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1423352
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652389}

Bug: 919685
Change-Id: I8b890cf3601cdb2d2784b23b8f98f3929a7d7d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574878Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652388}

If BrowserSignin is set to Disabled (0):
  - "Already a Chrome user? Sign in" text will be replaced with "Skip"
  - The "signin-view" module will be skipped

Screenshot in bug.

Bug: 904875
Change-Id: I765cdf44513389111325c6aeb9c410707ac1c300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568316
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652387}

Bug: 848942
Change-Id: I55c8c9ba6c61dbdb5de894bbf8aadc1e98239d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571696
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652386}

This logic previously lived inside the NotificationManager making it
harder to test. By moving it to a separate class, the SharedPreference
logic can be tested more easily.

Furthermore, the new class supports versioning so that the information
stored in the SharedPreferences can be modified in the future in a
backwards compatible way.

Bug: 939026
Change-Id: I1953003ed3ef262c4aa7a5a038bc6d76875364bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568486
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652385}

https://chromium.googlesource.com/angle/angle.git/+log/d18c048ab5a6..85a239d09128


git log d18c048ab5a6..85a239d09128 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 jmadill@chromium.org Vulkan: Write docs on format tables.
2019-04-18 jmadill@chromium.org Vulkan: Rename Vulkan "Texture" format to "Image"
2019-04-18 jonahr@google.com Skipped tests not accumulated in dEQP stats output.


Created with:
  gclient setdep -r src/third_party/angle@85a239d09128

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: If1d5325d2e1819b4406aa5c79025adcca78fd02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574485Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652384}

Exposing it in the activate callback ensures that the portalHost is
exposed when the promise callback is executed.

Bug: 948118, 921776
Change-Id: Ie654fdefd3e75187a06e8c06eba3de52f8276ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548316Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652383}

Thanks to Eric Feiveson <ericfe@google.com> for suggesting to rely
on the typedefs in std::map<> which was critical for getting this working.

Bug: 947911
Change-Id: I2a73061698d45ace2eaf859534f696a86542d35b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574820
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652382}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/86dcbc73338c..b76dd93cb5bb


git log 86dcbc73338c..b76dd93cb5bb --date=short --no-merges --format='%ad %ae %s'
2019-04-18 jrosenth@chromium.org chromeos-config: experimental/important changes


Created with:
  gclient setdep -r src/third_party/chromite@b76dd93cb5bb

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib27764b2a88be2ae7fdbef998133eb8c6256e399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574484Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652381}

Bug: 953090
Change-Id: Idd7b74c5e32ddb711910b9c178b1e33037c7ff48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570696Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652380}

Bug: 908139
Change-Id: Ib362d71f610a90fe094f3c4ed892ef578ebf85aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566417Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652379}

Change-Id: I8d9681685e2320626d44528ead716f44d1bc327e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572814
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652378}

BUG=933147
R=nhiroki@chromium.org,kinuko@chromium.org

Change-Id: I892b5dace7d56d55bd7087e75abc135793b7547a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569205
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652377}

DidUpdateState can be null if there is no key associated with a state
update. In these cases, since we only care about extracting the keypress
associated with edits, we can just ignore the DidUpdateState call and
return early.

Change-Id: I5a6ce0a5ef13b8afad89abf6dab3eaf39167e74a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573083
Commit-Queue: Robert Lord <lard@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652376}

A callback is used to populate the DeviceInfo with the latest state
on support for SendTabToSelf feature on the device. The information is used
to determine which set of devices tabs can be shared to.

Change-Id: Ib0f9093ae20ff8fc05494222789107a215057d79
Bug: 937004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570478
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652375}

This will allow us to measure the performance difference and see
the difference in the user engagement metrics and extrapolate to
estimate the usefulness of bfcache.

One-pager: https://docs.google.com/document/d/10Ff_5oq7k-oYuXTTKdN0v_JKG3bU1GPgAWWF7i4nMvs/edit#

R=creis@chromium.org
BUG=954271

Change-Id: I54dfe4634739a6c1eb3d33eee5025ecfe8622945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572343
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652374}

This change ensures that observers are notified that the UsbService is
being destroyed as the very first step of the destructor, which
unfortunately means that an explicit call needs to be added as the first
line of every subclass destructor.

This allows the DeviceManagerImpl instance in the device service to
close all bindings before callbacks owned by the UsbService are
destroyed. Otherwise these trigger a DCHECK.

Bug: 953248
Change-Id: I0a05f29a6e759cb4340301b92f13ea90af76bcd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574142
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652373}

Function declaration (.h) and definition (.cc) orders should match.
Move them around so that they do match. Also, place helper functions
under the main read/write functions.

All changes affect only function declaration/definition order, except
changes marked with comments.

Change-Id: I546f8135e4f7ff9b597f31d316de64abda7deb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572759
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652372}

This change removes the flag and marks the feature for later removal.

Bug: 954178
Change-Id: Ieeb004efb6fed206109ee8e8dad5cb40f4e0fd17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572704
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652371}

This CL registered the database needed by notification scheduler in
leveldb proto.

TBR=peter@chromium.org

Bug: 930968
Change-Id: Ib397a706c0a91ca688f19bb98d022205b1e3ca14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566538Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652370}

Previously zx_handle_duplicate() was called with ZX_RIGHT_DUPLICATE.
This means that the duplicate handle cannot be used for anything other
than to create new handles. Fixed it to use ZX_RIGHT_SAME_RIGHTS.

Bug: 852011
Change-Id: I3e628430676e7da56044502c3142ed1c5600e2c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572371Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652369}

This reverts commit 1e6642b0.

Reason for revert: This change broke a translation extraction tool process outside of Chromium. It can probably be updated to handle the change, and better to not be broken in the meantime.  For details, see https://crbug.com/954348 : Translation extraction failure (components_strings.grd)

Original change's description:
> [omnibox] Add and load Pedal concept data for de, en, fr, ja, zh-CN
> 
> Previously, Pedal concept data was a singular resource in English but
> this CL restructures the resources to load localized data from a
> pak depending on selected language. Data for the first four non-English
> languages localized by the translation team is included.
> 
> Bug: 893183
> Change-Id: I0e88d23de65038720a4f3543613ff8bd83dc5444
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572526
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Orin Jaworski <orinj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652212}

TBR=tommycli@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,orinj@chromium.org

Change-Id: I0e3a37b3828b164f43275fa937e7a2a9d9a746bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574200Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652368}

TBR=zmo@chromium.org,magchen@chromium.org

Bug: 848093, 868561, 890227
Change-Id: Idb5362622787a3b32cfdfe5e585b71c92af4f7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574141
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652367}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b2943927c04..8dfc0bce4ac7


git log 7b2943927c04..8dfc0bce4ac7 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 btolsch@chromium.org Add openscreen gclient config copy-pasta


Created with:
  gclient setdep -r src/third_party/depot_tools@8dfc0bce4ac7

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I524f40b4f2c99256410e2e521d414b736591e095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574778Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652366}