- 31 Jan, 2020 40 commits
-
-
Robin Lewis authored
This would otherwise be created once a user logs in. This reduces friction if the admin wants to set registry entries before anyone has signed in. Bug: 1047460 Change-Id: I035717a3c46513a23540f9b19274841b5eff3667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031872Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#737447}
-
Eric Orth authored
Fix a missing nullptr initialization. Original change: https://chromium-review.googlesource.com/c/chromium/src/+/2003256 Change-Id: I5aa663c8273449c0e77f526c55097eb288edb72d Bug: 1047641, 1022059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032787 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#737446}
-
Alex Ilin authored
This CL adds an implementation of a dummy Reauth dialog to SigninViewController. This dialog is needed only for developer needs and should never be shown in production. The dialog is hidden behind "SigninReauthPrompt" feature flag. This CL also adds minor details to the comment of SigninViewController::ShowReauthPrompt() method. Bug: 1045515 Change-Id: I74b066157ddfa3d697f12e45511c9cbdceaf1c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030766Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737445}
-
Sigurdur Asgeirsson authored
It's been a couple of years since this code was used, and the oncoming refactoring will be easier without this in the way. Bug: 1044707 Change-Id: Ic6e07b8f3ce61312d2c5a89d8af9850ea7510a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032230Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737444}
-
Josh Simmons authored
Bug: 1030813 Change-Id: Ic368d70f3d78a49ea280f70cc795935e11cdc264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031428 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737443}
-
Mugdha Lakhani authored
Create the UrlBarController interface and a simple version of the method createUrlBarView() without UrlOptions. Use it in WebLayerShellActivity to show a URL bar. UrlBarController updates url text whenever the visible URL changes. This means that the embedder doesn't have to listen to onVisibleUriChanged and create a new URL Bar view. Bug: 1025607, 1044571 Change-Id: I83bff6f82354ab970dbd84d3d24e5fac2cf66db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017408 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737442}
-
David Tseng authored
Bug: 1046430 Change-Id: I583b0ac6928a1c209368507f427c0c40dbd22c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026110 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737441}
-
Patrick Monette authored
This will allow the WorkerTaskProvider to do accurate bookkeeping on running shared workers, even though it dynamically subscribe and unsubscribe to the SharedWorkerService while some workers are already running. Bug: 1041093 Change-Id: I4480eff07b9735d7b0b2132caaed75a7e78311d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015565 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#737440}
-
Kevin Schoedel authored
Occasionally a WebContentController is destructed before we have received RenderViewDeleted notifications for all observed RenderWidgetHosts. Therefore, it is not safe to call RemoveInputEventObserver on every RenderWidgetHost that we started observing; we need to remove only from currently live RenderWidgetHosts. Bug: b/148227677 Change-Id: Ic9a7a4f187eb154665fc2ad093dd9464f7520e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020246 Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#737439}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/278efaec3531..4c93e8d76db8 $ git log 278efaec3..4c93e8d76 --date=short --no-merges --format='%ad %ae %s' 2020-01-30 wub gfe-relnote: Enhance the error_details of QUIC_NETWORK_IDLE_TIMEOUT and QUIC_HANDSHAKE_TIMEOUT errors. No behavior change except the error message. 2020-01-30 fayang Instead of checking handshake done frame received, just check both endpoints' handshake state is HANDSHAKE_CONFIRMED. There is a possibility where HANDSHAKE_DONE frame is received before observer gets set. 2020-01-30 bnc Do not send PRIORITY_UPDATE frame if it does not change priority. 2020-01-30 bnc Refactor MaybeSendPriorityUpdateFrame(). 2020-01-30 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_lifo_write_scheduler. 2020-01-30 bnc Do not send PRIORITY_UPDATE from server. 2020-01-30 bnc Add HTTP2_CODE_COUNT_N API and decompress_failure_3 counters to debug source of DECOMPRESS_FAILURE errors. 2020-01-29 renjietang Grease HTTP/3 settings. 2020-01-29 dschinazi Improve QuicFramer testing of retry 2020-01-29 ianswett gfe-relnote: Inline QuicConnection::MaybeSetAckAlarmTo because it's only used in one place. No functional change, not flag protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I77d441e23cc6750a7b872613a046326340f7bb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032011Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#737438}
-
Andrew Xu authored
Due to the side effect from https://crrev.com/c/1988855, auto-hide shelf is hidden after opening the system tray. Update on the shelf's visibility state is triggered by the visibility change of system tray. However, calculation on the auto-hide state depends on the state of tray bubbles which are created/destructed after the visibility change. This CL delays the update on the shelf's state when the visibility of system tray changes. In addition, a test case is added for this scenario. Bug: 1046464 Change-Id: I72d48b5872ca9efc8160c9fd6bba6bd55addfa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028766Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737437}
-
Ken Rockot authored
This is a fairly thorough rewrite of the StorageArea mojom interface and the related StorageAreaObserver interface. A very brief summary of the changes is: - StorageAreaObserver is no longer associated with StorageArea - The Blink DOM Storage implementation no longer relies on StorageArea replies being ordered against StorageAreaObserver events - CachedStorageArea no longer resets its StorageAreaObserver connection once established - All storage mutations (or failed mutations) now result in a StorageAreaObserver event. Follow-up changes should be able to simplify IPC further by removing StorageArea message replies, removing some redundant messages, and possibly reducing the complexity of the different caching modes. Rough preliminary proposal: https://docs.google.com/document/d/1N27aEvjJa-3t_kunyyGATlmTyuTU8HNkv0sLDgZCLGM/edit Bug: 1000959 Change-Id: I810626eda9e5f409b8f08439ab66801dd7376a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025873 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#737436}
-
Vincent Boisselle authored
Change-Id: I87319ac1548bde596dedeb65fa8f02c762590734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032229Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#737435}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/55890e1afe33..41a7302e9c62 git log 55890e1afe33..41a7302e9c62 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 capn@google.com Split JIT creation from LLVMReactor.cpp into LLVMJIT.cpp Created with: gclient setdep -r src/third_party/swiftshader@41a7302e9c62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iaa474736e15f998f73640603ab90c6cf464fce0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737434}
-
sczs authored
The modal will be presented from an Infobar banner (which might change in subsequent CL's). Adds a forward GURL declaration on InfobarSaveCardModalDelegate Bug: 1029067 Change-Id: I6d4f69aa69ced0b93b46b36809b229cdf6b6fd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028743Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#737433}
-
Robert Ogden authored
Adds mainframe to the name to clarify its purpose. No behavioral changes. Bug: 1023483 Change-Id: I88fb202f350d088cc5b0a5b41873bc6e40b457de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032715 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Jeffrey Kardatzke authored
This code appeared wrong because it was locally allocating buffers for the planes and then wrapping them in a VideoFrame which marked them as unowned memory. The memory would be deallocated after the call to Encode completes, and that posts a task so when the memory is actually accessed later it would be invalid. The V4L2 VEA also expects to receive owned memory on input buffers as well. other patches for buffer allocation unrelated to this) Bug: None Test: CacheLineUnalignedInputTest/** passes for I420 on trogdor (w/ Change-Id: I4552d803e5572f3f155dd984a273a1c0ffbc4b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032050Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#737431}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ada8ab49f7b..4d67872733ec git log 4ada8ab49f7b..4d67872733ec --date=short --first-parent --format='%ad %ae %s' 2020-01-31 agable@chromium.org Enable recipe-roller autosubmit Created with: gclient setdep -r src/third_party/depot_tools@4d67872733ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:773529 Tbr: agable@chromium.org Change-Id: I1ca7a01095efc36f6517e6b35221a12d641f5da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033415Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/09b742896513..0b016536ab1f git log 09b742896513..0b016536ab1f --date=short --first-parent --format='%ad %ae %s' 2020-01-31 zhizhouy@google.com trace_data: fix typo in error message Created with: gclient setdep -r src/third_party/catapult@0b016536ab1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039776 Tbr: wenbinzhang@google.com Change-Id: Ie4ae9639c5babcb49a0715dfad5de6162aca5fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033413Reviewed-by:
-
Tommy Li authored
Just a feature flag for investigatory work. No concrete plans yet. Bug: 1046561 Change-Id: I328f4d8e7edd2a4eee012202f7363a3e7374ee35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026123Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#737428}
-
Kevin Marshall authored
Adds a new field "force_content_dimensions" to the Cast ApplicationConfig table. If the field is set, then the value is passed to Frame::ForceContentDimensions() on application startup. Bug: b/144361044,b/144725868 Change-Id: I895071e8236aaf0e55435b0c1ea5e6eef8008e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029259 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#737427}
-
Demetrios Papadopoulos authored
- Adding a new c/b/r/settings/settings.gni file. - Defining |settings_namespace_rewrites| and |settings_auto_imports| holding common Settings-related entries - Also extract a few non-Settings common rewrites to tools/polymer/polymer.gni This is so that they can be reused across multiple BUILD.fn files. Bug: 1026426 Change-Id: I11ee3b4e30d3e4871b9483e2a7a9ff5ec8bae7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032568 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737426}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bfe3ef8feb3b..261f792f836a git log bfe3ef8feb3b..261f792f836a --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sprang@webrtc.org Allow software fallback on lowest simulcast stream for temporal support 2020-01-31 phoglund@webrtc.org Implement histogram perf results writer. Created with: gclient setdep -r src/third_party/webrtc@261f792f836a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9de66edbbb0ccd2bb8dce65d4834e578d00b56dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033412Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f768708f30f0..c2a397db501d git log f768708f30f0..c2a397db501d --date=short --first-parent --format='%ad %ae %s' 2020-01-31 soxia@microsoft.com Accessibility: "Clear site data" button click sets focus Created with: gclient setdep -r src/third_party/devtools-frontend/src@c2a397db501d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042144 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I814e64074be7b9863bc62cab9ab17a1c2eeea86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033419Reviewed-by:
-
Patrick Monette authored
Bug: 993033 Change-Id: Iff54ba97386e5e81438f3442a05c48d9df9ff88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031752 Auto-Submit: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This test flakily fails on Mac, like in this run: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2044 The flakes are caused by the scrollbar sometimes showing or not showing; see the root cause analysis given on the linked bug. Using "overflow: hidden" on the body will prevent the scrollbar from ever showing. Bug: 1005670 Change-Id: Icb7ac47e6c0acd53b7733693282a493e3ab0e09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033366Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737422}
-
Matt Jones authored
This patch ensures the getter for the bottom controls offset is no larger than the bottom controls height. This fixes an issue with the bottom container (infobars, etc.) where the infobar would appear partially or completely offscreen because of controls height being 0 without having updated offsets. We should be getting a signal from the renderer for this, but that can be addressed in a followup. Bug: 103602 Change-Id: Iedecc00364649c5be09c70e0f7db37773db57e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033367Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737421}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f44a809f9a3b..2dd9ed07760d git log f44a809f9a3b..2dd9ed07760d --date=short --first-parent --format='%ad %ae %s' 2020-01-31 natlee@microsoft.com Handle Device Lost for Command Encoder Finish Created with: gclient setdep -r src/third_party/dawn@2dd9ed07760d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I31a4ac6085a197190c2794635f76a3c87539c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033421Reviewed-by:
-
John Chen authored
Rebaseline to fix 6 new web tests failures on MacOS 10.14. These were all pixel comparison failures introduced by recent CLs. These CLs were authored before MacOS 10.14 was added as a default trybot, and thus only rebaselined the tests to 10.13. https://crrev.com/737203 introduced 4 failures: * virtual/controls-refresh-hc/virtual/controls-refresh/color-scheme/month-picker/month-picker-appearance-disabled-values.html * virtual/controls-refresh-hc/virtual/controls-refresh/color-scheme/month-picker/month-picker-appearance.html * virtual/controls-refresh/month-picker/month-picker-appearance-step.html * virtual/controls-refresh/month-picker/month-picker-appearance-value-not-in-interval.html https://crrev.com/737259 introduced 2 failures: * virtual/layout_ng_fragment_traversal/fast/table/027-vertical.html * virtual/layout_ng_fragment_traversal/fast/table/border-collapsing/003-vertical.html Bug: 1028242 Change-Id: I9909f63ccdb264cd982c04523aaa077c83432ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033329 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737419}
-
Clark DuVall authored
Calling ClearBindings() on a factory with no in progress requests could have previously led to a leak. Change-Id: Ia7bba6f5476366d4ffa7912974190c32c0bebd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032717Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737418}
-
Sadrul Habib Chowdhury authored
When a frame ends, inform the trackers of the BeginFrameArgs that caused the most-recent activation from the main-thread. This information will be used in subsequent CLs to validate/assert assumptions, and improve tracking updates from the main-thread. BUG=1021963 TBR=xidachen@ reviewed trivial change in platform/graphics/ change. Change-Id: I3aa314031affd06b244c9ca5e14bc8c72fb915cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028254 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737417}
-
Dale Curtis authored
The high efficiency path for skipping uploads when a VideoFrame is already in a given texture was not working. The last uploaded id was never set on the texture. Bug: 776222 Test: Manual inspection confirms texture uploads only when needed. Change-Id: If8a7c19d45f874e4335418ea5c19f602c2e007c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032340Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737416}
-
Manu Cornet authored
Also remove |TargetBounds| comparison logic in the shelf layout manager that isn't used any more, and access some of the shelf components directly from |Shelf| instead of going through |ShelfWidget|. This is a step in the direction of better compartmentalizing each shelf component and better coordinate animations. Change-Id: If9e4b6dcb17c40988e54db2395271b84922a6167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032073 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Francois Marier authored
Bug: 1042466 Change-Id: I6097ebac532787baf383076fe9eeed9bff54aa4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003916Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Francois Marier <francois@brave.com> Cr-Commit-Position: refs/heads/master@{#737414}
-
Patrick Noland authored
Bug: b/148339489 Change-Id: I1714f3439c6d88d764b8e894add7fd93eeed2baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032422 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737413}
-
ccameron authored
This reverts commit 2a085af2. Reason for revert: 5 GPU FYI bots started failing after this (extremely mysteriously, because this shouldn't affect them this way) https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20Intel/98243 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Release%20%28Intel%29/19387 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20dEQP%20Release%20AMD/96734 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/20055 https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20GPU%20ASAN%20Release/14113 Original change's description: > Remove three flaky suppressions on Mac NVIDIA WebGL > > These tests are no longer flaky > conformance/ogles/GL/exp2/exp2_001_to_008.html (WebGL 1 and 2) > conformance2/textures/canvas/tex-3d-rg16f-rg-float.html > > Bug: 923080 > Change-Id: Ibc0e4b488779a0843a787acacac6c9544e34c50f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029260 > Auto-Submit: Austin Eng <enga@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737052} TBR=kbr@chromium.org,enga@chromium.org Change-Id: I92cc1297bd71bc82b8e22662e58affe53b40ad6c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033626Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#737412}
-
Xida Chen authored
This reverts commit e11c77ab. Reason for revert: Suspect causing layout test failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/7513 Original change's description: > Switch to using an explicit ended signal for HTMLMediaElement. > > We've long used now > dur as an implicit signal, but with poorly muxed > media this can be unreliable. Since EndedPlayback() is used for a few > important signals, we should ensure it's always right. As such, switch > to using the explicit signal known by the WebMediaPlayer. > > This has been the source of a lot of flakiness over the years and we've > been thinking about doing this since 2014. > > The only tricky part is in handling seeks to the end of file correctly; > our pipeline previously required that play be called before we would > trigger a real pipeline ended event. Instead we relied on HTMLME just > declaring the playback ended at now >= dur. Now we will "render" end > of stream even if playback hasn't started if we have nothing to play. > > Bug: 409280, 1035472 > Test: Updated unittests, all existing tests pass. > > Change-Id: I1fbea34e8ac9e772d5b3573cd57df5d8c065e9c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021292 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737397} TBR=dalecurtis@chromium.org,jrummell@chromium.org,mlamouri@chromium.org,rtoy@chromium.org,guidou@chromium.org Change-Id: I99a7000fa2bc33db0b9abc3b257bc56f0778fb2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 409280, 1035472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033541Reviewed-by:
-
Xida Chen authored
This reverts commit 35e625a4. Reason for revert: I think this caused compile failure: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/9728?blamelist=1#blamelist-tab Original change's description: > build cachetool on windows > > The only issue seems to be handling arguments :) > > Change-Id: I1574bf3fdb50b15c9599adb63395c83bc28681a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018125 > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737401} TBR=rsleevi@chromium.org,jeremya@chromium.org Change-Id: I5665cd7302b6f6ade7a48a7c278b15fae5a3aa29 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033341Reviewed-by:
-
Nico Weber authored
This used to not work, but now it does. Follow-up to https://chromium-review.googlesource.com/c/2016844 Bug: 1047347 Change-Id: I6a8290ef69c5f1d5840c289fc73677dbe3d5236d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031679 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#737409}
-
Tibor Goldschwendt authored
Change-Id: I22a400da520922e46308cc5a870876ef9865d5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026893 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#737408}
-
