- 19 Mar, 2020 24 commits
-
-
Joel Hockey authored
Change-Id: I7c64fc381870279c1efb7810a3c5112e973e8e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108261 Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#751553}
-
Simon Que authored
Bug: 1058221 Change-Id: I8161b10880fbf00308782f8736008cb2197f23b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087498 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#751552}
-
Haiyang Pan authored
Bug: 1046059 Change-Id: I5a29498d1d915560fa4d108f8666dd3da8032f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109145Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#751551}
-
John Budorick authored
Bug: 1054829 Change-Id: I67804e5c3a4ed100db2f7649635a4868606c828f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109232 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#751550}
-
Nate Chapin authored
Bug: 1029822 Change-Id: I70227ea4880bda6f8e128a9f8ef79aa47e0ec9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103375Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751549}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: Ifc7a95188282547c49c0a30b2ffacb949f984f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103649 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#751548}
-
shrekshao authored
Bug: 1059491 Change-Id: I6df4870cb8ece3986a2ad0fecd28b50593ae2e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108874Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#751547}
-
Ben Pastene authored
is_linux is (somewhat confusingly) true for cros: https://source.chromium.org/chromium/chromium/src/+/master:build/config/BUILDCONFIG.gn;drc=1f696d603497028148b745f487686e7de50b5bdc;l=291 CrOS device builds prefer use_bundled_fontconfig to be false, so set its default value to account for that. Bug: 937821 Change-Id: I1a93312642767ba4994868b80c7686d04bb6c289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109174Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751546}
-
Xiaocheng Hu authored
ComputedStyle::SetFontDescription() clears the FontFallbackList (and hence, FontSelector) on the Font object when successful. As a result, callers, need to store the FontSelector value before calling, and use Update() to restore it after calling. This patch makes SetFontDescription() preserve the FontSelector value, so that the pattern can be eliminated, and we have fewer call sites of the deprecated function Font::Update(). Bug: 1049295 Change-Id: I6f4c17d3d0cfe79d2f32ca610ad39ecbf75e2d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108867Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751545}
-
Xianzhu Wang authored
Previously RuntimeEnabledFeatures::*Enabled() was incorrect when there were multiple levels of depends_on or implied_by. Now call *Enabled() of the depends_on/implied_by features instead of getting their bool variables (which don't reflect the features' status if there are depends_on/implied_by). Add cycle detection of implied_by because that situation would otherwise cause infinite recursion with this CL. Add detection of non-origin-trial feature implied by origin trial feature because that situation is invalid (see crbug.com/1061959) and would otherwise cause compilation error with this CL. Bug: 1061443, 1061959 Change-Id: I7b6cda1076f0c2a81edb5567a745d237c88259ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104019Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#751544}
-
Xianzhu Wang authored
This fixes the following issues: 1. LayoutBox::PixelSnappedBorderBoxRect(offset) previously added Location() to the offset, causing incorrect offset when |offset| was the correct paint offset. The logic was correct when |offset| was PaintLayer::SubpixelAccumulation() only. 2. PaintLayerScrollableArea used PaintLayer::SubpixelAccumulation() when calculating the pixel-snapped geometry of overflow controls, but the function always returned an empty size in CompositeAfterPaint. For 1, now don't add Location(). Update the caller in composited_layer_mapping.cc to pass PaintLayer::SubpixelAccumulation() + Location(). Changed the version of LayoutBox::PixelSnappedBorderBoxRect() with offset parameter (now expecting paint offset) to PixelSnappedBorderBoxSize(). Still keep the problematic no-parameter LayoutBox::PixelSnappedBorderBoxRect() (which still have a lot of callers) labeled with TODO(crbug.com/962299). For 2, let PaintLayerScrollableArea() use the new LayoutBox::PixelSnappedBorderBoxSize() with the correct paint offset, to avoid using PaintLayer::SubpixelAccumulation(). This doesn't fix the fundamental issue of crbug.com/1020913 which requires using subpixels in overflow control geometries. Bug: 1020913 Change-Id: I8b2d311c76889a4c6583543d12341028a5f49817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106744Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751543}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I1fc0d99c47f1171c131d0c5fbc818f69426c6387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103303Reviewed-by:
-
Ionel Popescu authored
This change adds a new feature flag for the eye-dropper functionality and updates the color-picker UI to have the eye-dropper icon. A new virtual test suite that enables the eye-dropper has been added. This CL is going to be followed by a series of changes that are going to fully implement the eye-dropper: - add an eye-dropper controller that is responsible for the inter-process communication between the popup and the eye-dropper window - platform specific implementations for the customized eye-dropper window Bug: 992297 Change-Id: I685c22f0264e1c01192a46f27f907763dc17c6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108081Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751541}
-
Sandeep Vijayasekar authored
Cast code needs to access media::GpuVideoAcceleratorUtil::ConvertGpuToMediaEncodeProfiles Bug: internal b/147798485 Test: gn check Change-Id: I78e9f0cba452e608db23018cc921b9a842319562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109119Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@google.com> Auto-Submit: Sandeep Vijayasekar <sandv@google.com> Cr-Commit-Position: refs/heads/master@{#751540}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/42d02fb84d56..41a6191ed80e git log 42d02fb84d56..41a6191ed80e --date=short --first-parent --format='%ad %ae %s' 2020-03-18 dberris@google.com Validate inputs for tryjobs Created with: gclient setdep -r src/third_party/catapult@41a6191ed80e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1062615 Tbr: oysteine@google.com Change-Id: I6157ccc62d63d192ff31ea8157ae8d2a0cb54ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751539}
-
Sean Topping authored
This reland fixes the OOBE issues introduced by the original change. The CastWebService API has been simplified so that clients no longer need to provide a SiteInstance when creating CastWebViews. The renderer preloading logic, which was previously disjoint from CastWebView, has now been incorporated. Merge-With: eureka-internal/366173 Bug: internal 77879457 Test: CQ, manually verify on display assistant device. Change-Id: I11a70a9d2898d6efadd3888b3251e797d043ed52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092428Reviewed-by:
Junbo Ke <juke@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#751538}
-
Adam Langley authored
This configuration allows for more data in the QR code, which we'll need in order to put a public key in it. BUG=1002262 Change-Id: If70c8c67a61ce9fdd3ce1ef87851c5e6cfdcc076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107425 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#751537}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I83d37613caac05b54db3e7ca9e31c9bb9036e64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106805Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751536}
-
Tina Wang authored
- Remove feature core code from chrome/browser/profile_card/. - Remove app code from chrome/android/java/..../chrome/browser/profile_card/. - Remove build source and dependency from: chrome/android/BUILD.gn chrome/android/chrome_java_sources.gni chrome/android/java/DEPS Bug: 1062032 Change-Id: Ie35da3b2cae003f62c42224ae66eece7169cd9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105462Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751535}
-
Jeff Yoon authored
Creating src-side changes for running Chromium on ios-sim-cronet. Deleting iOS JSON counterpart as its no longer in use. - xcode_build_version set in ci.star. 11c29 cache set by default. - gn_args migrated to mb_config.pyl - included cronet_ios mixin as cronet was setting args that iOS didn't. - test suites migrated to test_suites.pyl. - ios_cronet_tests with cronet_tests introduced. Bug: 1055164,912681 Change-Id: Id865b2d83db0ff7434347d588664ebb8729fa965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106433 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Nate Chapin authored
Mostly just test updates, but change FetchManager::Loader to use DynamicTo<LocalDOMWindow> instead of Document::DynamicFrom. Bug: 1029822 Change-Id: I05de7e3e95b9c426ee384e2ad064a400bb49ad7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103300 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I418db9e9669a9fbbd178865c6f460c163f0d9441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108897Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b0c540211ca..1574c49c4f09 git log 3b0c540211ca..1574c49c4f09 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 kahinds@microsoft.com High contrast support for Changes Panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@1574c49c4f09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20c6e909118d3f2bcede4e3a2d52ad5434057db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108893Reviewed-by:
-
Ken Rockot authored
Bug: 1059389 Change-Id: I0bb19abd33c9aa9e88220d106c208871b11976fd Tbr: tommi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108533 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
- 18 Mar, 2020 16 commits
-
-
Ahmed authored
BUG=1004806 Change-Id: I7df0490af3bba2a829135afc04eca72a5bc0791d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108792Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751529}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/855b1a3f2a02..9a55c361cbb3 Created with: gclient setdep -r src-internal@9a55c361cbb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I53b013effa0be3dc0da12ed12d2ed0d96962eab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105937Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751528}
-
Ian Wells authored
Bug: 1044139 Change-Id: I2f8b28b646dbae5a8da8a568a294f0635acd1cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103392Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#751527}
-
Scott Violet authored
This reverts commit cc205c1f. Reason for revert: This looks to have broken linux-archive-rel. I'm guessing DEPS are wrong. https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/24465 [48678/80681] CXX obj/chrome/common/importer/interfaces_mojolpm/profile_import.mojom-mojolpm.o FAILED: obj/chrome/common/importer/interfaces_mojolpm/profile_import.mojom-mojolpm.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/importer/interfaces_mojolpm/profile_import.mojom-mojolpm.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"n344329-9284abd0-6\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_ABI_UNSTABLE -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_NODISCARD -DCR_LIBCXX_REVISION=375504 -DCR_SYSROOT_HASH=79a7783607a69b6f439add567eb6fcb48877085c -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_40 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_40 -DENABLE_IPC_FUZZER -DWEBP_EXTERN=extern -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_PNG -DSK_ENCODE_WEBP -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\" -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_HAS_JPEG_LIBRARY -DSK_USE_LIBGIFCODEC -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DVK_NO_PROTOTYPES -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DWEBRTC_USE_BUILTIN_ISAC_FIX=0 -DWEBRTC_USE_BUILTIN_ISAC_FLOAT=1 -DWEBRTC_USE_X11 -DHAVE_SCTP -DNO_MAIN_THREAD_WRAPPING -I../.. -Igen -I../../third_party/libwebp/src -I../../third_party/libyuv/include -I../../third_party/jsoncpp/source/include -I../../third_party/jsoncpp/generated -I../../third_party/protobuf/src -Igen/protoc_out -Igen -Igen/out/Release/gen -I../../third_party/protobuf/src -Igen -Igen/out/Release/gen -Igen -Igen/out/Release/gen -Igen -Igen/out/Release/gen -Igen -Igen/out/Release/gen -Igen -Igen/out/Release/gen -I../../third_party/skia -I../../third_party/libgifcodec -I../../third_party/vulkan/include -I../../third_party/skia/third_party/vulkanmemoryallocator -I../../third_party/vulkan/include -I../../third_party/boringssl/src/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/perfetto/include -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/abseil-cpp -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -fcomplete-member-pointers -m64 -march=x86-64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wextra-semi -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -Wno-implicit-int-float-conversion -Wno-final-dtor-non-final-class -Wno-builtin-assume-aligned-alignment -Wno-deprecated-copy -Wno-non-c-typedef-for-linkage -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -ftrivial-auto-var-init=pattern -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-shorten-64-to-32 -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -Wno-deprecated-declarations -c gen/chrome/common/importer/profile_import.mojom-mojolpm.cc -o obj/chrome/common/importer/interfaces_mojolpm/profile_import.mojom-mojolpm.o In file included from gen/chrome/common/importer/profile_import.mojom-mojolpm.cc:17: In file included from ../../chrome/common/importer/profile_import_process_param_traits.h:8: In file included from ../../chrome/common/importer/profile_import_process_param_traits_macros.h:23: In file included from ../../content/public/common/common_param_traits.h:24: In file included from ../../content/public/common/common_param_traits_macros.h:15: ../../content/public/common/web_preferences.h:18:10: fatal error: 'third_party/blink/public/mojom/v8_cache_options.mojom.h' file not found #include "third_party/blink/public/mojom/v8_cache_options.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Reland "Adding mojolpm fuzzer." > > This is a reland of 96b8d308 > > Original change's description: > > Adding mojolpm fuzzer. > > > > This adds code that generates libprotobuf-mutator based > > structure-aware fuzzers as part of the mojom compilation process. > > (changes in //mojo). > > > > It also adds a fuzzer for CodeCacheHost using this framework to demonstrate > > how it will be used, and documentation explaining that fuzzer and how to use > > this generator to write new fuzzers. (changes in //content/test). > > > > It finally includes a few changes to typemap and traits files that > > were necessary to smooth over some inconsistencies in existing code > > using mojo. > > > > Bug: 941849 > > Change-Id: I660a57bd90c0963bd9a0b8608c746cdb767edc98 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978739 > > Commit-Queue: Mark Brand <markbrand@google.com> > > Auto-Submit: Mark Brand <markbrand@google.com> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > > Reviewed-by: Oliver Chang <ochang@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#746827} > > Bug: 941849 > Change-Id: I01feb96401e1c9cbd3bbb2bf2a22ecc253d36b4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087408 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751464} TBR=pkasting@chromium.org,dcheng@chromium.org,droger@chromium.org,rockot@google.com,ochang@chromium.org,markbrand@google.com,mpdenton@google.com,tmathmeyer@chromium.org,mpdenton@chromium.org Change-Id: If628a61fbfa40c17aa25752317263d7a79a4fb9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109280Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751526}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/83e138ca962c..1f9b5960d8b2 git log 83e138ca962c..1f9b5960d8b2 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 rharrison@chromium.org Use new binding type reflection provided by spvc Created with: gclient setdep -r src/third_party/dawn@1f9b5960d8b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iaf026ef0aeee700b010bd5551c400a6d4c2e9a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108888Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds the skeleton for the credential list. As this is going to be the main view controller it has a Coordinator to control all the presentations as well as the mediator and the associated protocols. In follow ups CLs the view controller will add a table view controller and a search bar. The mediator will fetch the passwords, filter and provide recommendations based on the service identifiers, as well as validate the log in state before providing passwords. Bug: 1045454 Change-Id: I5f539c489629d04ebd11a79f49b8b420a24ef1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094310 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751524}
-
John Lee authored
Example of what it might look like on Linux: https://imgur.com/a/j0VmU6q Change-Id: I044b1fcb8154e15211f89cee7d1b8b8d1725a604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106761 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751523}
-
Yuwei Huang authored
Previously we made FtlMessageReceptionChannel run the stream closed callback with a CANCELLED status when StopReceivingMessages is called, and FtlSignalStrategy would special-case CANCELLED and do nothing in that case. This is potentially related to the zombie host issue, where the FTL server might potentially return a CANCELLED status. Reporting CANCELLED for user triggered cancellation doesn't do much and potentially causes amiguation, so this CL just removes this logic and adds a log to see if the server can indeed respond with a CANCELLED status. Bug: 1062759 Change-Id: I9d3069e9f3dda49052015bb5ab67fa060a4516bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108875 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#751522}
-
Demetrios Papadopoulos authored
Unit tests will be migrated in later CLs, as this element is tested from people_page.html which is not quite ready yet. Bug: 1026426 Change-Id: Iec7765dcdbae46a4e3ce1080d4526e5afbd88a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106954Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751521}
-
Peter Kotwicz authored
This CL moves shouldStayInWebapp() logic from ExternalNavigationDelegateImpl to CustomTabDelegateFactory. This CL does not modify behaviour as WebApkActivity/WebappActivity uses CustomTabDelegateFactory BUG=054718 TEST=CustomTabExternalNavigationTest.testShouldDisableExternalIntentRequestsForUrl Change-Id: I3766f09e1915f065039e4dffd4ee589c2352aecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103129Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751520}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e14702b1..96241ef6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe91aeb9d3c0c573d4914d7633885f6f58ed8bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105798Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751519}
-
Adam Goode authored
In crbug.com/758048, zeroconf-discovered printers were changed to use a more friendly name, but used the make and model instead of the printer's display name. In Privet, the display name of the printer is stored in the "ty" key of the TXT record: https://developers.google.com/cloud-print/docs/privet#2.2.2.-ty But in zeroconf, the display name should be derived from the mDNS name: See https://developer.apple.com/bonjour/printing-specification/bonjourprinting-1.2.1.pdf section 7.1. "ty" describes the make and model of the printer, see section 9.2.6. With this change, zeroconf printers will have the recommended name, like in Privet. Bug: 895502 Change-Id: I6e088927c68c626c52056cdc04540684e95f2878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108827Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Adam Goode <agoode@chromium.org> Cr-Commit-Position: refs/heads/master@{#751518}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc0f1319307e..bc98fbeec99b git log dc0f1319307e..bc98fbeec99b --date=short --first-parent --format='%ad %ae %s' 2020-03-18 amaiorano@google.com Subzero: fix external function calls on x86-32 Created with: gclient setdep -r src/third_party/swiftshader@bc98fbeec99b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I102b03487217d91eddd5940eb743cfd707ece90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108664Reviewed-by:
-
Sunggook Chue authored
The changes are - gIRA register WebContentOberser for render frame host deletion. - In frame host deletion callback, it nullify member variable of frame host pointer. - Render frame host pointer check is made before referencing it. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1062091 Change-Id: I7bc261a292b63c8e60865916315b3dea59130c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107618 Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#751516}
-
Rakina Zata Amni authored
With ProactivelySwapBrowsingInstance, we will swap BrowsingInstances on most cross-site navigations, which means there will be more cross-process navigations on Android. This CL tries to reduce that by trying to reuse the previous page's renderer process for the new page when we do a proactive BrowsingInstance swap, if possible. Note that the CL won't change cases where we are already forcing a BrowsingInstance + process swap. Browser-initiated cross-site navigations will cause BrowsingInstance + process swap no matter what, and they will keep doing so even with this CL. Some renderer-initiated cross-site navigations, however, do not trigger a BrowsingInstance swap without us proactively swapping, so it is OK to reuse the process in their case (because we would've done so anyways if we don't do a proactive BrowsingInstance swap). See https://docs.google.com/document/d/1b-uMmwzTlwGfpn8pjd59iA57RnBHVx4IOarWnxYYxQk/edit?usp=sharing for more context (google-only) Bug: 977562 Change-Id: I57d725aa1435de0ee54788de4bfe627161400725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043521 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751515}
-
Xianzhu Wang authored
It was needed when some style affecting visual effect of the whole DOM subtree changed before we had raster invalidation on paint property changes. The following existing tests ensure correct invalidation on change of the css properties that previously caused subtree paint invalidation: paint/invalidation/mix-blend-mode-separate-stacking-context.html css3/blending/svg-isolation-remove-isolation.html css3/blending/svg-isolation-add-isolation.html Added new tests for -webkit-mask-image and -webkit-mask-box-image. Change-Id: Ib5fab2d553b9b52588d55d14559293df8cab182f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101304 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751514}
-
