- 28 Aug, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1edb54fb7bc59d118f182b9472800a4dee8167ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802579}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598550957-d21440687343c81b6a2048a74a0e183994baca81.profdata to chrome-mac-master-1598594188-9fa81c93dd83e8129d07cc38e4d22506253a8a4e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I37d0ed2acb0301298a9f3abd544f012614be84f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381391Reviewed-by:
-
Arthur Wang authored
This reverts commit 7cba29c9. Reason for revert: Switch to logging.error instead of raise exception Original change's description: > Revert "Reland "Temporary add verify_file_exists to check files downloaded."" > > This reverts commit 44e43142. > > Reason for revert: Lots of builders are failing in gclient runhook. > https://ci.chromium.org/p/chrome/builders/ci/test-wifi-tablet/19099? > > Original change's description: > > Reland "Temporary add verify_file_exists to check files downloaded." > > > > This reverts commit 2b17e053. > > > > Reason for revert: Reland initial cl after fix the typo > > > > Original change's description: > > > Revert "Temporary add verify_file_exists to check files downloaded." > > > > > > This reverts commit e69f63a3. > > > > > > Reason for revert: Causing infra failures on chrome/ci/android-internal-chromium-tot, see crbug.com/1122206. > > > > > > Original change's description: > > > > Temporary add verify_file_exists to check files downloaded. > > > > > > > > R=bsheedy@chromium.org > > > > > > > > Context: to make sure those wprarchive files are downloaded properly. > > > > Bug: 1096656 > > > > Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386 > > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > > > Commit-Queue: Arthur Wang <wuwang@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#801957} > > > > > > TBR=dpranke@google.com,bsheedy@chromium.org,wuwang@chromium.org > > > > > > Change-Id: I4d7f023d4e4d8f441d2cbdc33788e17f859377ab > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1096656 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378541 > > > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Cr-Commit-Position: refs/heads/master@{#801977} > > > > R=bsheedy@chromium.org > > TBR=dpranke@google.com, wuwang@chromium.org, wylieb@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Bug: 1096656 > > Change-Id: If288ccd984009baacb9dda60f14aa548ec94a272 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378892 > > Commit-Queue: Arthur Wang <wuwang@chromium.org> > > Reviewed-by: Arthur Wang <wuwang@chromium.org> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#802390} > > TBR=dpranke@google.com,bsheedy@chromium.org,wylieb@chromium.org,wuwang@chromium.org > > Change-Id: Ia62b89df8121aa6cbf6726a81f8f64a400a49d33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1096656 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380742 > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802407} R=bsheedy@chromium.com, dpranke@google.com TBR=bsheedy@chromium.org, wuwang@chromium.org, wylieb@chromium.org, xingliu@chromium.org Bug: 1096656 Change-Id: I58f357581ac01287e47dcf1473c4a1b83c94c0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380327Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Arthur Wang <wuwang@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802577}
-
Clemens Arbesser authored
Before this change, newly created controllers would always show a default 'Opening <domain>' message. Now, when a newly created controller replaces an existing controller, the last status message of the previous one is preserved (until the new one explicitly sets a new one). Note: this only applies when directly replacing controllers. It does not address a similar issue that happens if the onboarding is shown (see discussion in linked bug). Bug: b/166590955 Change-Id: I02ea033c71c5f925e30276774d649c19b669fdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379850 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802576}
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: Icf414fd6e13c50d708cd93397834c7d06e07972a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379343Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#802575}
-
Meredith Lane authored
Adds an override for margin-inline-start for the <ul> in the settings dialog on desktop to avoid it being scaled incorrectly with font size. Also adds in some miscellaneous CSS fixes to ensure the settings dialog conforms to spec. See go/reader-mode-ux for details. AXRelnotes: N/A Bug: 1120909, 1025300 Change-Id: Ifd53d2ce264874b7debadaa11055c9db0768ee19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368661 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802574}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e133da26969..47ebbfa449fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1122174 Tbr: melzhang@google.com Change-Id: I6655d33d9c7fc3b23d17f2b6849e4a306784adf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381197Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802573}
-
Hirokazu Honda authored
This CL adds a test option to test temporal layer encoding for vp9 and adds a stream validation of produced temporal layer structures. Bug: 1045825 Test: video_encode_accelerator_tests on atlas with --num_temporal_layers=3 Change-Id: I9e574335fe4b161fe3f848505dc82df7faa2fd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374486 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#802572}
-
Wei Lee authored
Since camera intents need different window constraints (e.g. The window should bind with the window of the caller Android app), this CL implements CameraAppDialog to show CCA in it rather than browser window. Bug: 980846 Test: Manually Change-Id: If5f706d8a5a433dce1762ecc8aedef4fc35c5765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245985 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#802571}
-
Rune Lillesveen authored
Make sure we report tracepoints for all cases where we UpdateActiveStyle. Before this change we did not trace the points where we invoked StyleEngine::UpdateActiveStyle directly. Change-Id: Ic5f2e13ca0d0cbb356b99f2643ca888deb5b1afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283205Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#802570}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/983b416231c4..d385091edd58 2020-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e3029d74 to 15c4ec7c (406 revisions) 2020-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 68c8ed7aec14 to d3eba1db0a14 (19 revisions) 2020-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1f48854dae26 to ec3650f56ca2 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1122621 Tbr: mtklein@google.com Test: Test: Test: dEQP-GLES31.functional.uniform_location.nested_array.*sampler2D_* Change-Id: Ie82b61568b4321ead957b1ed575978f936170587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381290Reviewed-by:
-
Toni Barzic authored
Introduces fileManagerPrivate methods for getting holding space state, and adding/removing files from the holding space. getHoldingSpaceState returns the list of files that have been added to the holding space (as list of their file system URL). toggleAddedToHoldingSpace ensures that all of the items passed to it match the intended "added to holding space" state. The CL utilizes newly added methods to add an option to "Pin" or "Unpin" files to shelf. The strings are not yet localized, pending a confirmation from UX on the final wording (the command labels will be updated when the strings are finalized). Note that the command is guarded by the TemporaryHoldingSpace feature. Additionally, the set of volumes that support the action is restricted to volumes available locally that are not expected to suddenly become unavailable (e.g. archives and removable volumes are not supported as they are likely to be unmounted by the user, making pinned files unavailable). Adds API tests for newly added methods. Bug:1113768 Change-Id: I80d85aa0643944a89bfbd293fc305d9c752c0b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376478 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#802568}
-
Rakina Zata Amni authored
On normal navigations, focus and text input state will be cleared on navigation because the previous page's document, etc will be discarded. TextInputManager will reset its |active_view_| and notify observers when RWHV gets destructed due to navigation through TextInputManager::Unregister, causing the virtual keyboard, etc. to be closed after navigations. On bfcached navigations, the document and RWHV stays alive so the relevant focus and text input states never gets cleared. This CL makes us clear the states when a page gets stored into the back-forward cache too. Bug: 1116391 Change-Id: I1d7f090c4c9a63fdd0957c4de0dc3241f3be157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362046 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#802567}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/82b1c03b6876..c6fa19fccc98 2020-08-28 tsepez@chromium.org Remove references to a "FDE" font / font mgr. 2020-08-28 thestig@chromium.org Add CPEs for libpng and freetype. 2020-08-28 thestig@chromium.org Remove third_party/eu-strip. 2020-08-28 thestig@chromium.org Update fx_lpng build for MIPS and ARM. 2020-08-27 thestig@chromium.org Use files_to_check parameter with RunUnitTestsInDirectory(). 2020-08-27 thestig@chromium.org Remove custom gmock-port.h. 2020-08-27 thestig@chromium.org Rewrite some comments in coverage_report.py. 2020-08-27 thestig@chromium.org Upgrade to lcms 2.11. 2020-08-27 thestig@chromium.org Convert |CXFA_Document::m_pPendingPageSet| to cppgc::Member. 2020-08-27 thestig@chromium.org Encapsulate |CXFA_Document::m_pPendingPageSet|. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6f43fe7cf7b31195fdf13891894e911191b46b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381199Reviewed-by:
-
Mike Dougherty authored
Convert many URLS which point to pages hosted from the ios/testing/data/http_server_files directory. These pages are already served by the existing |self.testServer| so it is not necessary to create an web::test::HttpServer is necessary. Bug: 891834 Change-Id: I91a35739eaf2a3ad9091112da2ba4c88b7d6d24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377511 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#802565}
-
Viviane Yang authored
Add integration of PushMessagingRefresher to PushMessagingServiceImpl. When a PushMessagingService::OnInvalidation event arrives, a new subscription is made that will overwrite the old subscription stored in the browser (PushMessagingAppIdentifier stored in preferences and {sender_id, subscription_id} stored in SW database. A `pushsubscriptionchange` event is fired after the new subscription becomes valid. The old subscription is kept in memory so that messages through the old subscription is still accepted. After the browser is closed, the old subscription is gone. Bug: 1116498 Change-Id: I6034abf01d939aa942a2bc05fa3a2c77ecf39996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375328Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#802564}
-
Daniil Lunev authored
Now it has a timeout for service discovery and feature gated. The feature is enabled only if the diagnostic package is present in the system. See https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2371828 Bug: b:151176984 Change-Id: I015fe605be3cf780e4d0b0e9eb76d6062d4b65b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379457 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#802563}
-
Eric Seckler authored
We are already setting this field on the TraceConfig since crrev.com/c/2210427, but failed to marshall it through the mojom layer. This patch adds it to the mojom + traits. Bug: 1120147, 1060400 Change-Id: I104b605db6a2f282199a18d4a2eeceac8faa8d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368875Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#802562}
-
My Nguyen authored
Current view: http://screen/6SBjgfswjnB7ar2 Spec: http://go/cros-lang-settings-ux-slide#slide=15 Refer to https://crbug.com/1113439#c9 for interaction with the language list. When language list is selected twice the focus color remains. This is the first iteration, depending on UX feedback, will explore listening to mouseover to make the interaction more polish. Color added based on http://go/cros-ux-design-system#29440852-b458-4da4-ac16-6cc54c2a6cb3 Bug: 1113439 Change-Id: Ife032868598f1a9cfa1e90a194dc9d66d1d176a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377769 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802561}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6b381c7456a9..89760badbdb0 2020-08-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e887fc7f..186593cd (802375:802477) 2020-08-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55f2a783..e887fc7f (802244:802375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia2467053e8e6d02d6028db00c1db46f2f334fc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381198Reviewed-by:
-
K. Moon authored
Changes chrome_pdf::UrlLoader::GetDownloadProgress() to take mutable reference parameters, rather than pointers to int64_t. Bug: 1099022 Change-Id: Ia6ab2fe8a2bdfa1909b06534647a226982c246ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381251 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802559}
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: I5ac058d46a9772dbe3c311c2e433556a123e49b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375172 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#802558}
-
Noel Gordon authored
Decided to format this code to improve its readability. Question about the .bind can come later. Bug: 1114622 Change-Id: I6dae8c4dd1af622ec20918c5e23a90653dea244a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381232 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802557}
-
Rakib M. Hasan authored
I erroneously re-used CIPD package tags which is causing the skew tests to fail. I created new tags that are only used once and can be used in variants.pyl. Bug: 1041619 Change-Id: I0c27dd24879759b790429a0992466967cfec8941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381055 Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#802556}
-
Glen Robertson authored
gcp_utils.h / win_http_url_fetcher.h (in "common") includes scoped_lsa_policy.h / scoped_handle.h [respectively] (in "gaiacp_lib"). "gaiacp_lib" depends on "common". So, moving scoped_lsa_policy.{cc,h} / scoped_handle.h to "common". This allows us to enable gn check for all of credential_provider. Bug: 898837 Change-Id: I13aaad5f75183bc5149772d0658210fd75e5d50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377527 Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#802555}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bfc5d2e5fc91..7acdddbda544 2020-08-28 szuend@chromium.org [ts] Type-check sdk/TracingManager.js with TypeScript 2020-08-28 szuend@chromium.org [ts] Type-check sdk/ProfileTreeModel.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d136b22dad292e1c97ae9eb5efe46e9446ee2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380615Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1d05e35a865..d3eba1db0a14 2020-08-28 courtneygo@google.com Fix ASAN error with test 2020-08-28 jmadill@chromium.org Fix warnings that show up in Skia with MSVC. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I06154e2db2f8113d9aaf9a2af1977c3e383928a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381193Reviewed-by:
-
K. Moon authored
Adds chrome_pdf::UrlRequest and chrome_pdf::UrlResponse structs to replace pp::URLRequestInfo and pp::URLResponseInfo. The new structs do not depend on Pepper (in particular, they no longer require a pp::InstanceHandle at creation time). The new structs only support the subset of properties used by the PDF viewer. The UrlResponse is also fetched on open, rather than on each call to GetResponseInfo() (now just response()). Bug: 1099022 Change-Id: Id49e8a931973d541f0fba0e5e232041337c7a971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378456Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#802552}
-
Luciano Pacheco authored
Dragger icons can't be operated via keyboard or screen readers, only by mouse. Thus we hide it from screen readers. over the buttons, the dragger icons shouldn't be focused by Chromevox. Test: Manually: Enable Chromevox and navigate with Search+b to iterate Bug: 111515 Change-Id: Ib5c122f9c98d0e7128430f1bdeb4af9e7b131143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379439 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
The column sort icon can be hidden from the screen reader because the whole column header already acts as a button and it has the appropriate ARIA role and label for sorting. over the buttons, the sort icon shouldn't be focused by Chromevox, but user can focus the column headers and sort the column. Test: Manually: Enable Chromevox and navigate with Search+b to iterate Bug: 111515 Change-Id: I342b2e29cdaa25d1dc8ea9385b6b019b4f90d2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381215 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Sophey Dong authored
Bug: 1121997 Change-Id: I21f99c4056960b9093ea92d1b45476fd195fe0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378141Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#802549}
-
Jimmy Gong authored
- There was a typo in the metrics: "Printing.Cups.*" vs. "Printing.CUPS.*" Bug: 1121691 Test: Unittest Change-Id: Ica74af69d7e572dad3f1750561e047ff00d30c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380964Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Austin Tankiang authored
Added the |enroll_called_| field as |callback_| will become null when it gets called. Bug: 1007662 Change-Id: I3c426a32daf6b5b37a5dc9d790e401014533e195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379431 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802547}
-
Victor Vasiliev authored
node_hash_map is used in QUICHE. R=mbonadei@chromium.org Bug: 1046390 Change-Id: I2cbf5fc833453b45e9b72f18d302a292bdb853b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379635Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#802546}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/952f088d41e1..983b416231c4 2020-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 8c012e879646 to 900bd341a3c6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I5d1d98b7df6c9bd1f086560002ac60e15d9c37ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381194Reviewed-by:
-
Richard Chui authored
In overview mode, ChromeVox was only announcing a window closed only if it was the first window in the list. This is because the alert was only triggered by windows that overview_session was observing. This CL moves that accessibility alert to be triggered by each individual overview item when it is destroyed. Test: manual Change-Id: Id502ef1e3f46d56f21029111f78c2d1393f790d4 Fixed: 1111940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380810Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#802544}
-
Cattalyya Nuengsigkapian authored
Announces desk name instead of desk number while switching/removing a desk or moving windows between desks. R=minch@chromium.org, xdai@chromium.org Bug: 1114254 Change-Id: I3354c88c2f0861ad091c76cc234d4ef69d8a7311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379634Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#802543}
-
Eric Willigers authored
runtime_enabled_features.json5 previously only had a comment indicating WebShare is shipped on Android. Change-Id: I9eac95bfb77aef8154cd637a089b528568a7c38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379422 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#802542}
-
Yuki Shiino authored
IDL nullable dictionaries are forbidden as argument type and dictionary member type. Adds a validator of the rule. Bug: 997708 Change-Id: I4b3f922ac77c8c6de949b7098b5096759c83f00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379337Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#802541}
-
Jiewei Qian authored
This CL adds a method to return all registered system web apps that should be installed. Bug: 1095524 Change-Id: Id1c14fc47307dbd4548e3cc55e95ec473835fd00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371842 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
