- 27 Sep, 2018 40 commits
-
-
Anand K. Mistry authored
BUG=None Change-Id: I6e53fd84f1897d2ce5d783b82bd0ce9b88a6bf01 Reviewed-on: https://chromium-review.googlesource.com/1248069Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594588}
-
Nico Weber authored
features::kViewsBrowserWindows was mainly used by ScopedMacViewsBrowserMode to test code in cocoa mode. We've removed all references to that class, and we removed the feature from about:flags, so the only effect of this CL here is that it will disable chrome/mac/cocoa for folks who get the feature through finch. In theory that should be nobody, but we're seeing a handful folks run the cocoa browser still (which by now no longer has a toolbar, tab strip, download shelf, bookmark bar, ...). Bug: 832676, 887392 Change-Id: I0cb7f360616eabb2c96ecfdcb39d665206dcacb2 Reviewed-on: https://chromium-review.googlesource.com/1226299 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#594587}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d50fdd753416..3a6b6bda177a git log d50fdd753416..3a6b6bda177a --date=short --no-merges --format='%ad %ae %s' 2018-09-27 kwiberg@webrtc.org AudioCodingModuleTest.TwoWayCommunication: Remove non-automatic mode Created with: gclient setdep -r src/third_party/webrtc@3a6b6bda177a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If20c2f46d4b3926ebe313b614e4f5f7db51b4f18 Reviewed-on: https://chromium-review.googlesource.com/1247505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594586}
-
Sam McNally authored
When running with DriveFS enabled for the first time, recover any files in the local cache marked as dirty to a folder in Downloads, similar to the existing process for recovering from database errors, and clean up any old Drive client metadata. The existing Drive client code does not expect dirty files to be removed from its cache so clearing its metadata is necessary to limit confusion when switching back from DriveFS. Reset the DriveFS migration pref when running without DriveFS; each first DriveFS after running without DriveFS should migrate pinned files and recover any unsynced files. This should avoid losing data if a user toggles between DriveFS and not multiple times with unsynced files. Move Drive and DriveFS data to separate subdirectories in files app browsertests to avoid interference, in particular in DriveFS migration tests. Bug: 883242 Tbr: slangley@chromium.org Change-Id: I20199ffd04ad7f63cb77ac9a53e49ba1bf830502 Reviewed-on: https://chromium-review.googlesource.com/1242783 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#594585}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a31ac84a0bb..53d082585814 Created with: gclient setdep -r src-internal@53d082585814 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0ec99854a7e331e3e955bb2ac751f7bda6012bec Reviewed-on: https://chromium-review.googlesource.com/1247444Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594584}
-
Keishi Hattori authored
Adds UMA metrics to debug slow IncrementalMarkingFinalize. Theshold for slow IncrementalMarkingFinalize is set to 40ms to be around the 99th percentile. Bug: None Change-Id: Ied90405ef408e2917d33d83eba4701f1076936bc Reviewed-on: https://chromium-review.googlesource.com/1233017Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594583}
-
Kent Tamura authored
custom-elements: Do not distinguish V0 custom elements and V1 custom elements in :unresolved and :defined matching. This CL changed the behavior of :unresolved selector for V1-defined custom elements, and the behavior of :defined selector for V0-defined custom elements. The following table shows the current behavior: :unresolved :not(:defined) :defined Built-in false false true Not-defined true true false V0-defined false true false V1-defined true false true After this CL, the behavior is: :unresolved :not(:defined) :defined Built-in false false true Not-defined true true false V0-defined false false* true* V1-defined false* false true V0 custom elements specification defined ':unresolved' and V1 custom elements specification defines ':defined', but we don't need to distinguish V0-defined elements and V1-defined elements for these selectors. The current behavior makes it difficult to migrate V0 custom elements to V1 custom elements gradually. Bug: 889336 Change-Id: I48ecced042fe78314b42da4ea65baddb720e38fc Reviewed-on: https://chromium-review.googlesource.com/1248061Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#594582}
-
Xiaocheng Hu authored
This patch converts some layout tests to use testharness instead of plain text dump or js-test.js. It is a preparation for crrev.com/c/1243119. The changed tests have non-trivial text failures with that patch (due to flakes or non-trivial dependency on js-test.js), so we convert them in this CL to reduce noise there, and ensure that there are only newline text diffs in the other CL. Bug: 887148 Change-Id: I46d7508ddde62e32ddfa421e9975b39b73cc06df Reviewed-on: https://chromium-review.googlesource.com/1246902 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#594581}
-
Kunihiko Sakamoto authored
"_MAX" suffix typically represents the last value in an enum, whereas "_COUNT" is more commonly used to count the number of entries. This CL should have no behavior changes. Change-Id: I976c67473f9590a815514ac59758d3a7abc0ad8e Reviewed-on: https://chromium-review.googlesource.com/1245022Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594580}
-
Jordy Greenblatt authored
The specs for this case are in Comment 13 in the bug: https://bugs.chromium.org/p/chromium/issues/detail?id=878644#c13 Screenshot of results of CL: http://screen/KJj4Rxeo84H Note that the font size (13px) and line height (16px) are explicitly spelled out here because the default height without that specification was slightly off. Bug: 878644 Change-Id: Ie93a3c173c3b43b7cab23177a02c8eb8f9c70181 Reviewed-on: https://chromium-review.googlesource.com/1247194 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594579}
-
Sam McNally authored
Bug: 883230 Change-Id: Iab1c421c8a4325c628f915d35b280dc3c8be8a69 Reviewed-on: https://chromium-review.googlesource.com/1240054Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/af8b73c9e632..115e8a2625f5 git log af8b73c9e632..115e8a2625f5 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 jmadill@chromium.org Vulkan: Store "is packed" in buffer formats. Created with: gclient setdep -r src/third_party/angle@115e8a2625f5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ie8dd83d73e8f24557f260ce2477a8c71968dac93 Reviewed-on: https://chromium-review.googlesource.com/1247981Reviewed-by:
-
Daniel Erat authored
Update PowerManagerClient to pass serialized protocol buffers to powerd's SetScreenBrightness D-Bus method instead of passing native D-Bus arguments to SetScreenBrightnessPercent. This allows passing the reason for the request. Bug: 881786 Change-Id: I753fb19f45f99acf3142d91ba96cf3650699df33 Reviewed-on: https://chromium-review.googlesource.com/1244551Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#594576}
-
Ted Meyer authored
leaving already-called-callbacks in the input_buffer_queue_ was causing crashes when they were called a second time. Bug: 889375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6623f6736aa0551253a23282562721facf06acf0 Reviewed-on: https://chromium-review.googlesource.com/1247421Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594575}
-
Yuzu Saijo authored
OomIntervention should not be re-triggered on the same page if the user declines the intervention once. This CL fixes the bug. Bug: 889131, 887119 Change-Id: Idb9eebb2bb9f79756b63f0e010fe018ba5c490e8 Reviewed-on: https://chromium-review.googlesource.com/1245019 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
During aggregation, SurfaceAggregator marks all resources used for a draw in the resource provider. This has the side effect of deleting unused resources and their textures, generating sync tokens, and returning the resources to the client. This involves GL work which is issued before drawing commands, and gets prioritized by GPU scheduler because sync token dependencies aren't issued until the draw. This CL extends ScopedBatchReturnResources to include all places where the resource provider deletes resouces including marking used resources, and makes Display hold a ScopedBatchReturnResources for the entire duration of draw including surface aggregation. This defers the GL commands for deleting resources to after the draw, and prevents context switching because the scheduler knows sync token dependencies at that time. This has a big impact on WebGL performance in general, and especially on certain older Adreno 3xx devices. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0e0ba47b54c3bb2c0a7bc344f65f2caba7d8c117 Bug: 835353 Reviewed-on: https://chromium-review.googlesource.com/1200414 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594573}
-
Kouhei Ueno authored
This CL introduces signed_exchange_utils::ShouldAdvertiseAcceptHeader, which can be used to query if a origin should be sent "Accept: application/signed-exchange" header. The origins list is managed by the feature "SignedHTTPExchangeAcceptHeader", and a Finch param attached to it. Note: Use the below args to test this: --enable-features=SignedHTTPExchangeAcceptHeader<AcceptHeaderStudy --force-fieldtrials=AcceptHeaderStudy/Group --force-fieldtrial-params=AcceptHeaderStudy.Group:OriginsList/www%2eexample%2ecom The subsequent CL will actually plumb this to the navigation loaders. Bug: 887201 Change-Id: I06cc991e396b28ab0d02e2bbba3a117fd53d4fe5 Reviewed-on: https://chromium-review.googlesource.com/1235473Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#594572}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c8b28b92f6f3..f221bac5302a git log c8b28b92f6f3..f221bac5302a --date=short --no-merges --format='%ad %ae %s' 2018-09-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f221bac5302a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idc60de3856eb55a852c985caca3e95432742a9b9 Reviewed-on: https://chromium-review.googlesource.com/1247503Reviewed-by:
-
Nick Harper authored
Bug: 863877 Change-Id: I15547be6d4ab6367ca5c84f6b7e0b70f7bb70734 Reviewed-on: https://chromium-review.googlesource.com/1244576Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#594570}
-
Katie D authored
UX approved over email. Bug: 833047 Change-Id: I73c5b12d98fa332aa29089d7af23bb420d659436 Reviewed-on: https://chromium-review.googlesource.com/1241995Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#594569}
-
Yoichi Osato authored
This patch extracts MarkSelected at call sites since the function used to be called not directly because of LayoutTextFragment. This patch also shrinks ComputeNewPaintRange not to bring a hashset. Then the hashset appears only at one function. Bug: 889360 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I44a020ccf9172c6159bec5251a3ab3733b7d4868 Reviewed-on: https://chromium-review.googlesource.com/1244699Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#594568}
-
Abhishek Arya authored
R=mmenke@chromium.org,asanka@chromium.org Bug: 865732 Change-Id: I0744cba403f2809c8b09b0b2f5cf6e618ecb2f76 Reviewed-on: https://chromium-review.googlesource.com/1247187 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#594567}
-
Robert Sesek authored
- BrowserWindowMacTest tested both modes, and now it only tests views. - PermissionBubbleInteractiveUITest forced Cocoa, but all the tests are disabled, so it doesn't matter that it cannot force a mode. - The ScopedMacViewsBrowserMode is removed from CocoaTest. - In its place, CocoaProfileTest now brings up a ViewsDelegate so that it can properly create a views BrowserWindow. CocoaProfileTest should be removed in favor of TestWithBrowserView. Bug: 832676 Change-Id: I4648d893a71794c2f0b3c108b0afb05d45dc84be Reviewed-on: https://chromium-review.googlesource.com/1246731 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594566}
-
Shimi Zhang authored
There were ownership issue of the file descriptor, use ParcelFileDescriptor instead of raw fd to prevent wrong ownership exchange. Current tests should cover this change. Bug: 882608 Change-Id: I974739f4b3d59c9ac3ba21006f686e7a38244806 Reviewed-on: https://chromium-review.googlesource.com/1244803 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#594565}
-
Stuart Langley authored
Calling ReadDirectory() before we have fetched the full corpus will result in multiple calls to the backend to get the data. If this is done repeatedly (which it is) this unnecssarily slows down the initial loading of the app. If we're still loading teh corpus then cache the result of ReadDirectory for 30 seconds before refreshing. Adds test and a better log mesage so we can see what directories are being read. Bug: 783184 Change-Id: I0a1c27dab2244a933f9d43d6ec48ccf0010fc110 Reviewed-on: https://chromium-review.googlesource.com/1237902 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#594564}
-
Xiaohan Wang authored
To remove duplicate code. In another CL, I also need it in ClearKeyCdm. Bug: 169203 Test: No functionality change. Change-Id: I077d0b52780e960f4da6e974405eff6a2dd2fe06 Reviewed-on: https://chromium-review.googlesource.com/1247561Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594563}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6ab99ab..d4c562dc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23247f95b25c2f0461f5df0237d380c9d09bd236 Reviewed-on: https://chromium-review.googlesource.com/1247224Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594562}
-
Zhenyao Mo authored
only send back collected bits rather than full GPUInfo BUG=718215 TEST=bots, manual R=piman@chromium.org,magchen@chromium.org,dcheng@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib7c6107057bd39579d3bad95400599c5a84ce8b0 Reviewed-on: https://chromium-review.googlesource.com/1246689 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#594561}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1c718f91de16..d50fdd753416 git log 1c718f91de16..d50fdd753416 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 buildbot@webrtc.org Roll chromium_revision 71e95f98..1574cf43 (594375:594482) 2018-09-26 buildbot@webrtc.org Roll chromium_revision cc51f289..71e95f98 (594271:594375) 2018-09-26 ssilkin@webrtc.org Mark all low layer frames as references if inter-layer pred is enabled. 2018-09-26 danilchap@webrtc.org Remove redundant member variable in RtpRtcp Created with: gclient setdep -r src/third_party/webrtc@d50fdd753416 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I79771e6515e0ecec71b3c1a72f39f2cacb3c98a4 Reviewed-on: https://chromium-review.googlesource.com/1247085Reviewed-by:
-
Scott Chen authored
In the NUX Onboarding welcome flow, it's necessary to direct the users back to the chrome://welcome page after they finish signing in. Since the page navigates to a remote location when the user is signing in, the specified URL has to be stored in the sign-in helper in the backend. Bug: 874147 Change-Id: I39126f1072d172fcec023de160889ac7f4ecb7b4 Reviewed-on: https://chromium-review.googlesource.com/1239353 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#594559}
-
smut authored
Bug: 723130 Change-Id: I1325f20c64a2f3536f0f5b61346c0fefc2ca5c4c Reviewed-on: https://chromium-review.googlesource.com/1247200 Commit-Queue: smut <smut@google.com> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#594558}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44b480c37a8b..3a31ac84a0bb Created with: gclient setdep -r src-internal@3a31ac84a0bb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I83dbab80c8614717b5a2871aa72939692910ac61 Reviewed-on: https://chromium-review.googlesource.com/1247076Reviewed-by:
-
Dale Curtis authored
Was left off in previous CLs. BUG=879970 TEST=passes cq Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3dd5288bf60381e42a8ab08d054bdf60e4e96f96 Reviewed-on: https://chromium-review.googlesource.com/1244613 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594556}
-
Fady Samuel authored
This reverts commit c68cd4c5. Reason for revert: There are some lingering invariants violations this is hitting. Bug: 884148 Original change's description: > Surface Synchronization: Detect invariants violations in LayerTreeHost > > Currently some invariants violation checks are in LayerTreeHost for mac > but not for other platforms. This CL enables the check on other platforms. > > Bug: 672962 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iade0eee8322f9126a5ee7409b2e79aa00593b2d1 > Reviewed-on: https://chromium-review.googlesource.com/1217598 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590175} TBR=ccameron@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 672962 Change-Id: If795714a072608b9f6c0fe613004c71fa3c9da6f Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1247403Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594555}
-
Jonathan Metzman authored
https://chromium.googlesource.com/external/github.com/google/libprotobuf-mutator.git/+log/3fc43a01d721..c148984c5af6 $ git log 3fc43a01d..c148984c5 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 metzman change int32_t to uint32_t 2018-09-17 metzman remove whitespace change 2018-09-17 metzman [NFC] Change types for in uniform_int_distribution for Windows 2018-08-23 allenwebb Added "make install" and pkg-config file. 2018-09-07 35739080+Allen-Webb Added per field mutator hooks. (#98) 2018-09-04 vitalybuka Update .travis.yml 2018-08-24 vitalybuka Update libxml2.cmake 2018-08-23 vitalybuka Temporarily fix for libxml2 build issue 2018-08-23 vitalybuka Switch to https://gitlab.gnome.org/GNOME/libxml2 2018-06-25 vitalybuka Update README.md 2018-06-25 eneyman Edit links in README to reflect new file names. 2018-05-30 eneyman Add include statement to fix build 2018-03-06 vitalybuka Disable libFuzzer len_control. 2018-01-30 vitalybuka Update .travis.yml 2018-01-23 vitalybuka Update .travis.yml 2018-01-15 vitalybuka Disable gcc debug because gcc crashes there 2018-01-15 vitalybuka gcc 7 2018-01-15 vitalybuka nproc 2018-01-15 vitalybuka Fix -Werror=sign-compare 2018-01-15 vitalybuka Update protobuf Disabled leak sanitizer on travis, looks like travis removed SYS_PTRACE. Created with: roll-dep src/third_party/libprotobuf-mutator/src Bug: 884560 Change-Id: I6861a5010af72bbd0c4305c0c68d7a7626b7bb6d Reviewed-on: https://chromium-review.googlesource.com/1247323Reviewed-by:
Vitaly Buka <vitalybuka@google.com> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594554}
-
Shimi Zhang authored
In PrintingContext, we rely on raw file descriptor to figure out which PrintingContext is responsible for current task. The ultimate goal was to figure out which PrintingController that PrintingContext is talking to. But since PrintingControllerImpl is a singleton, every PrintingContext is associated with the same PrintingController. So there is no need to use the raw file descriptor to distinguish between PrintingControllers. This CL removes the dependency on raw fd, in preparation for fixing double ParcelFileDescriptor closing issue (http://crrev/c/1244803). Bug: 882608 Change-Id: Ic3b7496661c913c028a86c7c2cd5e853a98a83a2 Reviewed-on: https://chromium-review.googlesource.com/1244832 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594553}
-
Yuzu Saijo authored
This CL adds more memory metrics when OomIntervention is enabled. This adds UMA of (1)renderer memory usage reported every second and (2)time after navigation when intervention is triggered. Bug: 888935 Change-Id: Iad60b53b47665db0e8b051df50221b9860dd8680 Reviewed-on: https://chromium-review.googlesource.com/1242732Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
Also tweak CSS to ensure that the contents keep their intended size when the parent is maximized. Bug: 884089 Change-Id: Ie3b5dc63e8531f0d97b3b7a239114ae75cfadcba Reviewed-on: https://chromium-review.googlesource.com/1246787 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit dee92446. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 594509 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZGVlOTI0NDZmNzhhYzcwMzYxZGU1OWFlMjI0OTM5YmU4ZjgyMzk4Zgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/43524 Sample Failed Step: network_service_browser_tests Sample Flaky Test: WebRequestUnresponsiveListenerTest.WebRequestListenerNeverResponds/0 Original change's description: > [Extensions] Add a test for webRequestBlocking listeners that are killed > > Add a test that exercises behavior for a webRequestBlocking listener > that never returns, and then the tab is closed. Do this with two > flavors: > - A listener in the extension's background page, where the > RenderProcessHost is shutdown. > - A listener in an extension tab, which is then closed. > > Verify that in both cases, navigation is unblocked when the extension > listener goes away. > > Inspired by, but not in any way a fix for, https://crbug.com/877543. > > Change-Id: Id918d6d5f7bf5d8235f1386ef48838bffaa1b50c > Reviewed-on: https://chromium-review.googlesource.com/1188942 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594509} Change-Id: I2c9ebb07e448747ca7f83e51470e1d5e96edc9bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889701 Reviewed-on: https://chromium-review.googlesource.com/1247527 Cr-Commit-Position: refs/heads/master@{#594550}
-
Stuart Langley authored
Explority work to see if we can track down when an FSP is asked to get metadata for a caller that doesn't want any metadata. Bug: 587231 Change-Id: I5133016dd9bf01aeb66dc92010c8998d29067642 Reviewed-on: https://chromium-review.googlesource.com/1240553Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#594549}
-
