- 22 Oct, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I5f9b1acc0bdee2a8de592b9e185eb4244023a462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819710}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests and browser_tests. Change-Id: I4a302a38cf48060352477f48775aa5d2a0f27b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466004Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#819709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6029e464cf93..2e1091e0ef69 2020-10-22 cnorthrop@google.com Tests: Add FIFA Mobile trace 2020-10-21 cnorthrop@google.com Tests: Add KartRider Rush+ trace 2020-10-21 syoussefi@chromium.org Vulkan: Faster check for vertex attribute aliasing 2020-10-21 cnorthrop@google.com Tests: Add Marvel Contest of Champions trace 2020-10-21 sugoi@chromium.org Revert "Allow rendering to half float in ES2 contexts when possible" 2020-10-21 geofflang@google.com GL: Use ANGLE_GL_TRY when setting pixel pack and unpack state. 2020-10-21 sugoi@google.com Allow rendering to half float in ES2 contexts when possible 2020-10-21 geofflang@google.com Expose glGetTexLevelParameter{if}v before ES 3.1. 2020-10-21 jmadill@chromium.org Test Runner: Command line sharding args override env. 2020-10-21 jonahr@google.com Disable TransformFeedbackTest.NonExistentTransformFeedback* 2020-10-21 jonahr@google.com Add dlopen_fuchsia.h as exception in export_targets.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132514,chromium:1140113,chromium:1140531 Tbr: jonahr@google.com Test: Test: TransformFeedbackTest.NonExistentTransformFeedbackVaryingWithGLPrefix:/ES3_OpenGLTest: Test: angle_perftests --gtest_filter="*fifa_mobile*"Test: Test: angle_perftests --gtest_filter="*marvel_contest_of_champions*"Test: Test: angle_perftests --gtet_filter="*kartrider_rush*" Change-Id: I949ef152fd6a5ae20534c665f245272c618fdbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491342Reviewed-by:
-
David Van Cleve authored
Currently, TrustTokenKeyCommitments has a bug where we compare an iterator from |additional_commitments_from_command_line_| to another iterator from |commitments_|, due to a typo when landing the original logic. This CL corrects that error. This undefined behavior could be part of the reason why we're seeing TrustTokenKeyCommitments.KeysFromCommandLine failing flakily on Android. Bug: 1140418 Change-Id: I3322104707cb62b1e53ec1ac22979dd647a8934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485784 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#819707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87996d2e7b98..d56c381aa518 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104817,chromium:1124054,chromium:1137566,chromium:1138495,chromium:1138536,chromium:1138554 Tbr: hayato@google.com Change-Id: I64c005eae5dfc51fc7547645f35a5a4d0125543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491660Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819706}
-
Matt Menke authored
Add NIK parameter to ReportingService::ProcessHeader(). TBR=msramek@chromium.org Bug: 993805 Change-Id: I04448b4da9bfad52f9ae0cd6863b19b0e572a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485172 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#819705}
-
Marc Treib authored
Bug: 1138277 Change-Id: Ie3114eca1654afd305fcd3bb260a181a07228085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484706 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#819704}
-
David Van Cleve authored
absl::variant was recently approved for general Chromium usage. This CL adds it to the Blink symbol allowlist. (I had a union I wanted to implement in the child CL and remembered `variant` had recently been approved. I'm not familiar with the criteria for permitting/forbidding symbols in Blink, so I wouldn't be too surprised if it turns out we don't want `variant` in Blink.) R=dcheng Bug: None Change-Id: I0885ef203472bcdb17481423d88eeb2add801766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442230 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819703}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Idd9e4ccbba9303439145d8e884b3e3c008bb5ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491183Reviewed-by:
-
David Van Cleve authored
This CL updates the Trust Tokens issuance helper to read key commitments and understand when the issuer at hand is requesting that the issuance operation be mediated by the operating system instead of sent directly to the issuer's server. The CL: - adds a new delegate class to abstract away actually executing issuance locally (not yet implemented); - for now, has TrustTokenRequestHelperFactory provide a stopgap always-fail delegate; - updates TrustTokenRequestIssuanceHelper's logic to be able to delegate operations locally; - adds a new response status to trust_tokens.mojom to communicate the successful local execution of a Trust Tokens operation (i.e., no need to send the request onward to the server); and - adds a new base::FeatureParam associated with the Trust Tokens feature, gating local Trust Tokens issuance requests. Test: Expands TrustTokenRequestIssuanceHelper unit tests Bug: 1130252 Change-Id: I1bf4e96ea65555d2ad24c5b7b18f95d1791d73b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432862 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Kent Tamura authored
It was possible that FormController::RestoreAllControlsInDocumentOrder() twice: 1. ScheduleRestore() is called. A task to run RestoreAllControlsInDocumentOrder() is scheduled. 2. RestoreImmediately() is called. It runs RestoreAllControlsInDocumentOrder(). 3. The scheduled RestoreAllControlsInDocumentOrder() runs. If FormControlState objects remained after the first call, the second call might restore them to incorrect elements. RestoreAllControlsInDocumentOrder() should check did_restore_all_ flag. Bug: 1138598 Change-Id: I6eb45ae31407905741d3b8c0c28b01b1f07f8dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488945 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#819700}
-
Hayato Ito authored
AboutFlagsHistogramTest.CheckHistograms is flaky on linux. TBR=asvitkine@chromium.org,ellyjones@chromium.org Bug: 1141271 Change-Id: Ifbda96854d6b9658dd27c5d1f90f92e39347fd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491701 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819699}
-
Shubham Aggarwal authored
We prefer having constant default values to be listed alongside the data member declaration instead of in the constructor. This is a purely stylistic change and should not have any functional effect. Change-Id: If4ad7be6e73ff52e92258452fe86a7b3a7f790b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490860Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819698}
-
Alexander Dunaev authored
This CL enables the test that was X11-only. Bug: 1109112 Change-Id: I5fdafac9de0715f8400dad9a5a724f50128db09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466758Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#819697}
-
Hoch Hochkeppel authored
Adding a class to represent the Windows StorageFileStatics class within tests, as well as basic unit tests to validate the test class behaviors. The class behaves similarly to the Windows equivalent, except it includes gtest validations for expected usage, schedules all async operations through a ThreadTaskRunner, and does not implement methods that fall outside the expected usage. Bug: 1035527 Change-Id: Ia3439718cb02773e7a6c6835adcdbc807f47a383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491050Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819696}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/0ce070474164..8f7c80347dc6 2020-10-21 sarahmashay@google.com [validation] Improve CTS test wrapper. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I91c4c617b0424687924e2e4e907c9a58c17af91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491125Reviewed-by:
-
Joel Hockey authored
On the first time in each FilesApp session that a file is deleted, the current contents of the related trash are checked and any files older than 30d are permanently deleted. Bug: 953310 Change-Id: I8d34c3333152bc690652d070bff0d2f34b6ef1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490960 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#819694}
-
Joel Hockey authored
In order to interoperate with other crostini file managers, we will use $HOME/.local/share/Trash as the crostini trashdir, and also prefix all Paths with the $HOME remote mount path. Bug: 953310 Change-Id: I6148dfcc5d240ae1959d0bf00698b882822b97e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477706 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Matt Menke authored
Add NIK parameter to ReportingService::QueueReport(). Bug: 993805 TBR: msramek@chromium.org Change-Id: Ie3181f2a1ae43e0dd7c38833a3d364d63ef8ce3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485392Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Chan Li authored
It breaks "Build Recipes Tester" Bug: 1141272 Change-Id: I24708d22aea1852ddb08fe105d48c65727738d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491681Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#819691}
-
Tomasz Tylenda authored
This is a follow-up on a comment in crrev.com/c/2463051. In nss_context.cc we make GetNSSCertDatabaseForProfile take OnceCallback instead of RepeatingCallback. This is possible, because the callback will be used only once in GetCertDBOnIOThread. We then make all callers use base::BindOnce. BUG=764795 TESTED=build Change-Id: I9120f3c4d0ff70be2dc6c146295a40cc4db17bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484069Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#819690}
-
Brian Sheedy authored
Adds/ignores some additional tags that were found being produced by GPU tests. Bug: 1111876, 1011107 Change-Id: I859b6f61ff9011819daf3fe73811456b352ee1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481908 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#819689}
-
Rakina Zata Amni authored
These tests do not intend to have failed navigations, but they actually failed silently, mostly due to 404s because of bad URLs. Soon (after crrev.com/c/2487024 lands) these tests will actually fail and result in error pages. See navigation-dev thread for more context: https://groups.google.com/a/chromium.org/g/navigation-dev/c/WbNkf2alpPU/m/2tQQ-cXWBgAJ Bug:1133115 Change-Id: Ib75a04aa90635b9eb778ce2da56fcee83965b053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483748 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819688}
-
Nic Hollingum authored
This reverts commit b6deb469. Reason for revert: Deterministically breaks linux-chromeos-dbg, e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20956 Original change's description: > cbui crostini: refactor away CrostiniAppRestartView > > This change removes CrostiniAppRestartView, replacing it with: > * Construction and configuration of a bare View + DialogDelegate pair > * A pair of public functions that create and show this dialog > > This change also adds some unit test coverage for this dialog to > ensure that I didn't break it when doing this refactor. > > Bug: 1075649 > Change-Id: I7de0e2386de14aa6aec8917c630f64a69df26832 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490345 > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819545} TBR=ellyjones@chromium.org,joelhockey@chromium.org Change-Id: I230664fa24b78125632310bf05edd6a3d219f18b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490971Reviewed-by:
Nic Hollingum <hollingum@google.com> Auto-Submit: Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#819687}
-
Matthew Mourgos authored
This is a reland of 315d5cdf The original change was reverted because of test failures due to the feature not being added to tools/metrics/histograms/enums.xml. Original change's description: > Multipaste: Add flag for resetting nudge prefs on new session > > Add a flag which, when enabled, will reset the clipboard nudge prefs > on a new user session. This will allow the nudge to be shown again. > > Bug: 1140656 > Change-Id: I312f05eed655fc1657843d2b7a45214bb671bebe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489020 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819483} Bug: 1140656 Change-Id: I476e50a8ce89a810608636123bf0187e9f360b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490853 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819686}
-
Joel Hockey authored
VolumeMetadata.remoteMountPath is the path on the remote host where this volume is mounted, for crostini this is the user's homedir (/home/<username>). The remoteMountPath will be used in crostini trash to prefix Path in *.trashinfo files so that paths reflect the valid local path, and our trash interactions can interoperate with other linux file managers. Bug: 953310 Change-Id: I623781a63d32564f0a705aed47188b0c26b945c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490961 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I42c9d272577419c343a6bd08f5c2cc33f3f8631e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491484Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819684}
-
Kuo-Hsin Yang authored
Add vovoy@chromium.org as owner for oom_memory_details.* and memory_kills_* files, remove cylee@chromium.org. Change-Id: Ie0789315943a0adea4a9fa05107174ce39770448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489381Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#819683}
-
Joel Hockey authored
On a device, MyFiles/Downloads is a separate volume to MyFiles which is bind mounted. As a result, moving a file from MyFiles/Downloads/ into MyFiles/.Trash is a copy operation rather than move. To fix this, we will have a dedicated MyFiles/Downloads/.Trash for items under Downloads which guarantees that all deletes will stay fast. Bug: 953310 Change-Id: Ib1bc6d9da2aec45e1d4b43eae25cb02b230b117f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469645Reviewed-by:
-
Clark DuVall authored
This is a reland of b9d174e5 This time component builds should be actually fixed with http://crrev.com/c/2490668. Original change's description: > Enable isolated splits in canary > > All known issues have been fixed so enabling this in canary to see if > there are any major problems. > > Bug: 1126301 > Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819200} TBR=agrieve@chromium.org Bug: 1126301 Change-Id: I71afd73c704deb6c7d65a76c6ea8a2b6f0b6fb57 Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490871Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819681}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a8cdc94e138d..d975e29d1e93 2020-10-21 jophba@chromium.org Add SessionMessager class If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I91be3fccdcf759851cad1ded01d4fae53decf3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490485Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ie791e22c49996e80b0e4c07d641d4dea10321957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491301Reviewed-by:
-
Julie Jeongeun Kim authored
This CL extends expiry for Accessibility.ATK-APIs histogram. Bug: 1138235 Change-Id: I2c0f575ec7d484479c2b70696762aef25078c686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483947Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#819678}
-
Joel Hockey authored
go/chrome-ss/b025494050650332c0d6964cb82b977199bd9fd0 go/chrome-ss/8d3b3f36cf84c787244001584e2b8425be3e7549 The foreground page adds a listener to the background 'delete' event, and for any of the operation-done events (CANCEL, ERROR, SUCCESS) where trashedItems is populated, the foreground page will display an Undo toast. The toast message is '<filename> deleted' or '<n> items deleted', and has an action 'Undo' button to allow users to undo the delete. Bug: 953310 Change-Id: I55f2a59e03fc6c355f3362db9cc5a6767c4086ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469340Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/726aef930d80..c51c18a5866c 2020-10-21 andoli@chromium.org [ts] Typecheck settings/SettingsScreen.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I10a1ce658a5d4e0aa3d0eb65732ac25b857b8b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491046Reviewed-by:
-
Yicheng Li authored
It is a security concern that users potentially get trained to use their GAIA password for 3rd party websites / apps, so after discussing with the browser side and GAIA team, we decided to not offer the password option in this auth dialog. The dialog will be triggered if either PIN or fingerprint is available. Bug: b/156258540 Change-Id: I9dffaa1fed36ca476cb5976d5229d5f49278e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487826 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
-
Sven Zheng authored
This reverts commit afa62bad. Reason for revert: crbug.com/1140928 linux-lacros-rel browser tests become very flaky. Error: FATAL:wayland_buffer_manager_host.cc(371)] Check failed: !submitted_buffer->released. Original change's description: > Reland "[ozone/wayland] Use 4x4 opaque background and stack underlay correctly" > > This is a reland of aa21781d > Root-cause of previous issue was Gnome's interpretation of whether > buffer.release should be triggered for buffers preempted from subsurface > cache. > > Original change's description: > > [ozone/wayland] Use 4x4 opaque background and stack underlay correctly > > > > Using a 4x4 sized opaque background will not regress performance in > > underlay cases because the root surface is still opaque. The background > > will be stretched out by wayland viewporter extension. > > > > This is 6/? CL for overlay forwarding using wl_subsurface. > > > > Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 > > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#810527} > > Change-Id: I7ecbc27a82598479f7131b5645dfe96136d227a1 > Bug: 1133195, 1063865 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442137 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819226} TBR=rjkroege@chromium.org,msisov@igalia.com,fangzhoug@chromium.org Change-Id: I8a4b069f29a20ba9bcd38e0f37cc29651e960d75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133195 Bug: 1063865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490858Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819674}
-
Kenichi Ishibashi authored
Hide it behind ServiceWorkerStorageControlImpl as a preparation for the Storage Service move. Bug: 1055677 Change-Id: Ia672decab9670c662470c26fbd83d25f6361274e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477141 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819673}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603302740-e55fee2d2ced5621a041f91ab31ac53e5d576c91.profdata to chrome-linux-master-1603322998-a2bfaa167e3697b2b14734e406c0399abff8eaf1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I479ad9a6ba5795e45aaeb0c5f42a59cfc9961bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491480Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9606cffa66d0..c4af5cd3397d 2020-10-21 treehugger-gerrit@google.com Merge "Fix RAIL_MODE_LOADING->LOAD in RAIL Mode query" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4b0500f6c502e046b04116d29e513ff95b562b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489755Reviewed-by:
-
