GitLab

It doesn't seem like it's being respected. See build:
https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20RandomOrder/builds/382

It's getting close to Wednesday - I'd like to remove [ Win ] so we can get onto more important work and then circle back around when we have more time to find the correct prefix.

R=qyearsley@chromium.org
BUG=670843

Review-Url: https://codereview.chromium.org/2560423003
Cr-Commit-Position: refs/heads/master@{#437986}

BUG=649495

Review-Url: https://codereview.chromium.org/2507753003
Cr-Commit-Position: refs/heads/master@{#437985}

testCanPlayePlatformMediaCodecs was disabled due to flakiness. It seems
that the test is no longer flaky and can be re-enabled (since we are no
longer using WMPA, or because of some unknown changes in test
reliability).

NOTE: If ever the screen is off when the test runs, the test fails.

BUG=620890
TEST=100x run on Nexus 5 and Nexus 7

Review-Url: https://codereview.chromium.org/2570483005
Cr-Commit-Position: refs/heads/master@{#437984}

It used to be used for data/ dir removal, but it is now
integrated into ArcSessionManager.
Remove the unused class now.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2573463002
Cr-Commit-Position: refs/heads/master@{#437983}

BUG=673022

Review-Url: https://codereview.chromium.org/2565673003
Cr-Commit-Position: refs/heads/master@{#437982}

SSLClientSessionCache::DumpMemoryStats() creates one
MemoryAllocatorDump for each cache entry. To make the memory dump lighter,
this CL dumps the total size and count and does not create sub dumps.

BUG=669108

Review-Url: https://codereview.chromium.org/2574513002
Cr-Commit-Position: refs/heads/master@{#437981}

Change the HttpServerPropertiesManager::net_task_runner_ to use a TestMockTimeTaskRunner in unittests so that
we are able to verify tasks posted with delay in the future.

Now all the tests that were ExpectCacheUpdate or ExpectScheduleUpdatePrefsOnNetworkThread
will need to call net_test_task_runner_>FastForwardUntilNoTasksRemain() so that all
the tasks complete running.

BUG=670519

Review-Url: https://codereview.chromium.org/2563273002
Cr-Commit-Position: refs/heads/master@{#437980}

Provide more user-friendly experience as a welcome screen on Timeline panel.
The new UX is put behind an experiment.

BUG=570441

Review-Url: https://codereview.chromium.org/2557973002
Cr-Commit-Position: refs/heads/master@{#437979}

Add accelerator SHOW_IME_MENU_BUBBLE into table kActionsAllowedAtLoginOrLockScreen to allow using 'Alt+Shift+K' to open opt-in IME menu in login or lock screen.

BUG=668394,642423
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2566583004
Cr-Commit-Position: refs/heads/master@{#437978}

BUG=668207
TBR=rnk

Review-Url: https://codereview.chromium.org/2565173005
Cr-Commit-Position: refs/heads/master@{#437977}

This CL adds rappor metrics for recording the eTLD+1 of the top-level
frame and cross-origin iframe when the user pauses an autoplaying video.

BUG=672526

Review-Url: https://codereview.chromium.org/2563723002
Cr-Commit-Position: refs/heads/master@{#437976}

In Bug 607822, many MacOS tests were disabled because the underlying implementation not ready. We have since fixed many bugs, and notifications seem to be working fine. This patch removes all of web bluetooth TestExceptions and re-enables notifications on the MacOS

BUG=673147

Review-Url: https://codereview.chromium.org/2569593002
Cr-Commit-Position: refs/heads/master@{#437975}

Per the IndexedDB specification, a versionchange transaction is running
until the open request's transaction member is set to null, which
should happen (synchronously) after the onabort() event handler is
called. Therefore, tests can only assume that a transaction stopped
running after the onabort event handler has occurred.

BUG=657968

Review-Url: https://codereview.chromium.org/2538343002
Cr-Commit-Position: refs/heads/master@{#437974}

Ash only ships on Chrome OS, so simplify our BUILD.gn files by removing
all the is_win and is_chromeos conditionals.

This also removes a dependency from chrome/browser/ui/BUILD.gn that existed
for all use_aura builds. Aura should not require ash on Windows or Linux.

BUG=666776
TEST=bots

Review-Url: https://codereview.chromium.org/2569723003
Cr-Commit-Position: refs/heads/master@{#437973}

This switches the icons to paper-icon-button-light, using the same
styling as elsewhere on the page. This doesn't actually improve page
load time, since all of these buttons are behind dom-ifs. It does,
however, simplify the CSS and make the Grouped mode buttons match the
mocks.

BUG=589357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346383004
Cr-Commit-Position: refs/heads/master@{#437972}

Take the address of the ProfileImportHandler::Create routine when
adding it to the mojo interface registry.

BUG=

Review-Url: https://codereview.chromium.org/2563393002
Cr-Commit-Position: refs/heads/master@{#437971}

BUG=

Review-Url: https://codereview.chromium.org/2573643002
Cr-Commit-Position: refs/heads/master@{#437970}

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638

Review-Url: https://codereview.chromium.org/2550263002
Cr-Commit-Position: refs/heads/master@{#437969}

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2571653002
Cr-Commit-Position: refs/heads/master@{#437968}

The last public use of it is part of the pre-MD profile switcher.

BUG=633986

Review-Url: https://codereview.chromium.org/2556833002
Cr-Commit-Position: refs/heads/master@{#437967}

Review-Url: https://codereview.chromium.org/2566983004
Cr-Commit-Position: refs/heads/master@{#437966}

The test has been flakily failing on linux today

TBR=wangxianzhu@chromium.org

BUG=673539

Review-Url: https://codereview.chromium.org/2571553004 .
Cr-Commit-Position: refs/heads/master@{#437965}

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2555453003
Cr-Commit-Position: refs/heads/master@{#437964}

I messed up the mapping. As penance, add tests for everything and make
the Android tests less of a mess.

The failure mode here is P-521 client certificates won't quite work
right in TLS 1.3. I believe TLS 1.2 and below would not have been
affected.

BUG=672972

Review-Url: https://codereview.chromium.org/2567523003
Cr-Commit-Position: refs/heads/master@{#437963}

If VrCore exists on non-Daydream devices, WebVR Cardboard support should be enabled.

BUG=671370

Review-Url: https://codereview.chromium.org/2556093002
Cr-Commit-Position: refs/heads/master@{#437962}

The child process launcher now switches to the host executable's
path before running a new child process. That breaks mash_runner
code which launches the host executable if the host executable was
invoked by relative path.

This changes mash_runner to always reference the host executable
by absolute path when rewriting child command lines.

BUG=None
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2573593002
Cr-Commit-Position: refs/heads/master@{#437961}

Assets are yet to be added to this change.
BUG=664367

Review-Url: https://codereview.chromium.org/2531223003
Cr-Commit-Position: refs/heads/master@{#437960}

Since external experiment ids are not based on Chrome's low
entropy source, they do not have the same guarantees about
not identifying a user as Chrome's variations. As such, we
should only transmit them for signed in users, whose identity
is already known by Google so there's no risk of identifying
them through these headers.

Note: The signed-in state checking in this CL is only done for
web content area requests and not other internal requests,
like to the suggestion service, where it treats the state as
"not signed in". This is fine to do because variations service
ids are still sent, which is what the other call sites are
interested in.

BUG=672532
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org

Review-Url: https://codereview.chromium.org/2558913003
Cr-Commit-Position: refs/heads/master@{#437959}

The browser tests for ResourcePrefetchPredictor check that the actual
request priority is equal to the expected value. But for the images the
priority cannot be precisely defined because there is a race between the
preload scanner issuing fetch requests and frame view performing layout
and promoting priorities of all visible images.

BUG=650253,673028

Review-Url: https://codereview.chromium.org/2569723002
Cr-Commit-Position: refs/heads/master@{#437958}

This is useful when the user creates a bound interface ptr and passes it without
actually using it to make any calls, which is pretty common.

BUG=579646

Review-Url: https://codereview.chromium.org/2563593005
Cr-Commit-Position: refs/heads/master@{#437957}

When changing from one shadow type to another, cross fade the two.

BUG=608852

Review-Url: https://codereview.chromium.org/2562143002
Cr-Commit-Position: refs/heads/master@{#437956}

The goal of this CL is to modify content_browser's IMEDriver so we have access
to ui::InputMethodChromeOS's functionality in mus+ash.

This CL:
- Modifies ui::InputMethodChromeOS so it can call an ack callback after
  processing events.
- Introduces InputMethodBridge to acts as a bridge between
  ui::mojom::InputMethod and ui::InputMethodChromeOS.
- Introduces RemoteTextInputClient to send commands received from
  ui::InputMethodChromeOS to a remote client over mojo IPC.
- Modifies content_browser's IMEDriver implementation to use
  ui::InputMethodChromeOS via InputMethodBridge.
- Some unittests to verify that InputMethodBridge works correctly.

BUG=665981

Review-Url: https://codereview.chromium.org/2557493002
Cr-Commit-Position: refs/heads/master@{#437955}

BookmarkBarController has a weak pointer in a |pulsingButton_| data
member. This is an NSView which can be destroyed in
-[BookmarkBarController redistributeButtonsOnBarAsNeeded] when it is
removed from its superview.

Since bubbles close asynchronously, and fade out, the bookmark bubble
can cause a UAF to |pulsingButton_| via stopPulsingBookmarkNode. This
can occur if a resize triggers redistributeButtonsOnBarAsNeeded while a
bookmark bubble is still alive.

There's no need for this to be a weak pointer. Make it scoped_nsobject
instead.

This affects both Cocoa and MacViews.

BUG=616051
TEST=Added unit_test:
BookmarkBarControllerTest.RedistributeButtonsOnBarAsNeeded

Review-Url: https://codereview.chromium.org/2567973002
Cr-Commit-Position: refs/heads/master@{#437954}

wayland-protocols: Add device_configuration_exists error to zcr_keyboard_configuration_v1 interface.

This error is produced if get_keyboard_device_configuration method is
called with a keyboard object that is already associated with
keyboard device configuration object.

BUG=670247

Review-Url: https://codereview.chromium.org/2564353002
Cr-Commit-Position: refs/heads/master@{#437953}

This patch adds a check to ensure that all of the required tiles are
in the now bin.

R=ericrk@chromium.org, sunnyps@chromium.org
BUG=622080
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2566603004
Cr-Commit-Position: refs/heads/master@{#437952}

Re-land https://codereview.chromium.org/2531953002 and
https://codereview.chromium.org/2547933003.

When a negative margin top pushes a block back up into its previous siblings
we need to check for any floats in those siblings it now needs to avoid or clear.

Previously we were just looking at its neighbour, we need to keep looking until
we reach a sibling that we don't overlap.

Fix the performance regression on mossiella.com in page_cycler_v2.tough_layout_cases
by only looking for floats if margin collapsing has actually moved the child up.

BUG=671645, 670325, 666487

Review-Url: https://codereview.chromium.org/2568643002
Cr-Commit-Position: refs/heads/master@{#437951}

This lets you drag files into the url bar to open them.

BUG=none

Review-Url: https://codereview.chromium.org/2566753003
Cr-Commit-Position: refs/heads/master@{#437950}

IntersectionGeometry is an ephemeral object, so make it stack
allocated, let it use raw pointers to LayoutObject, and move it to
core/layout.

Also, be explicit about the implicit root by introducing
rootIsImplicit.

R=ojan@chromium.org,xjz@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2553103004
Cr-Commit-Position: refs/heads/master@{#437949}

When a child of an overflow: hidden object is composited (and the ancestor is not) we were failing to apply the border-radius clip. This patch fixes the problem by adding a new masking layer for this situation, and modifying the layers used for painting to set the clip appropriately.

New tests are added to verify the behavior for border styles, and existing layout tests cover the bug (and fail before this patch). Unit testing is used for verifying update behavior.

There are remaining issues tracked in TODOs with corresponding bugs.

BUG=157218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2194273002
Cr-Commit-Position: refs/heads/master@{#437948}

- The avatar button should only be set as active if the a bubble is
opened
- Removed the code for the fast chooser in the cocoa files

BUG=670613

Review-Url: https://codereview.chromium.org/2552423002
Cr-Commit-Position: refs/heads/master@{#437947}