GitLab

This reverts commit ae6e8514.

Reason for revert: cronet and webrtc aren't on Xcode 10 yet.

Original change's description:
> [ios] Bump minimum Xcode requirement to 10.
> 
> Change-Id: I60521b36cb903ca18d59fe88caa1a9c7b1aa9e87
> Reviewed-on: https://chromium-review.googlesource.com/1182377
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587174}

TBR=rohitrao@chromium.org,sdefresne@chromium.org,justincohen@chromium.org

Change-Id: I815f001ec9c75008791dd46cb1ee39f62248a160
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1194601Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587222}

Instead of using multiple mutable Controllers for WebContents
and Uri, use a single StartParams Controller and derive
everything else from that.

Bug: 113094427 (followup)
Test: cast_shell_junit_tests
Change-Id: I0d9e11a5b905d5937378b03569b99bc277117a0d
Reviewed-on: https://chromium-review.googlesource.com/1194795Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587221}

This CL reworks the core of SVGMarkerData so that it first extracts the
"features" of the current segment/PathElement, and then uses those
features to determine the orientation.

The state of SVGMarkerData is also changed from two pairs of points to
two vectors, since this is the representation that's actually used by
CurrentAngle(). It should also be a better representation when handling
of degenerate curves is added.

CurrentAngle() is changed to return a 'double', and the clamping
previously done in the method is now done by the callers. Additionally
The code that computes the bisected angle is split out to a separate
function.

Bug: 450368
Change-Id: Ic9561cab3bbf9c3f5cbc9f3607cfc9bfe90fea05
Reviewed-on: https://chromium-review.googlesource.com/1193847Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#587220}

Bug: 878519
Change-Id: I4a29c0ff3c0de6799e1597bcdbe81f812bc5a86f
Reviewed-on: https://chromium-review.googlesource.com/1195097Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587219}

Previously we were theming the bottom toolbar with the website
specified theme color. After talking with UX we decided that it would
only have the bottom toolbar color reflect whether incognito mode was
enabled. This CL makes it so the bottom toolbar is light colored when
incognito is not enabled and dark colored when it is enabled.

Bug: 875870, 852140
Change-Id: I839d2938209d463191892dcd3fe68c527bba44c2
Reviewed-on: https://chromium-review.googlesource.com/1192125Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587218}

This reverts commit a2495396.

Reason for revert: Underlying crash has been fixed.

Original change's description:
> Temporarily disable two ContextualSearchTapEvent tests.
> 
> Recent changes to ContextualSearchPolicy are causing the KitKat Phone
> Tester to fail, temporarily disables the affected tests.
> 
> TBR=donnd@chromium.org
> 
> Bug: 878430,878512
> Change-Id: I449216aee736cbfcce30cbc035793cd8ccb8d608
> Reviewed-on: https://chromium-review.googlesource.com/1194738
> Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586915}

TBR=donnd@chromium.org,thildebr@chromium.org

Change-Id: I7ad819188a9cd57dc4551c80610be051e81fa524
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 878430, 878512
Reviewed-on: https://chromium-review.googlesource.com/1195754Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587217}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/safe_browsing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=vakh@chromium.org

Bug: 874080
Change-Id: I49c31da1c962eb6005ed6655e259ed719c6f9953
Reviewed-on: https://chromium-review.googlesource.com/1190929Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587216}

This is a reland of ed0a1be1 after fixing
a broken test.

Original change's description:
> Fix the issue with 3rd-party DLL blocking and IAttachmentExecute
>
> Because the IAttachmentExecute interface will invoke registered
> third-party IOfficeAntiVirus provider, it's possible to put Chrome
> in a state where all downloads fail if a DLL needed by one of the
> provider is blocked.
>
> This CL introduces 2 temporary solutions that aims to separately
> address the issue for enterprise and regular users. The long-term
> solution is to move the call to the attachment services to a
> utility process where third-party DLL injection is explicitly
> allowed.
>
> For enterprise users, simply never enable the blocking feature on
> domain-joined machines.
>
> For regular users, add a feature (InvokeAttachmentServices) that
> allows us to no longer invoke the IAttachmentExecute interface and
> instead use the fallback code path that manually sets the Zone
> Identifier (Mark of the Web).
>
> The fallback code was a bit outdated because Windows 10 now adds the
> HostUrl and ReferrerUrl data into the Zone Identifier. This CL adds
> a new feature that writes this data similarly to how the
> IAttachmentExecute interface does. This change is also behind a new
> feature (AugmentedZoneIdentifier).
>
> Finally, the chrome.mediaGalleries API
> (https://developer.chrome.com/apps/mediaGalleries) was also using
> the IAttachmentExecute API. A third feature now controls whether
> the mediaGalleries component uses the same function as the download
> manager, in order to benefits from the changes described above.
>
> Bug: 870998
> Change-Id: I50c5d804c469b2499f1e6ec6998e146baaaace7a
> Reviewed-on: https://chromium-review.googlesource.com/1188864
> Reviewed-by: Asanka Herath <asanka@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586940}

Bug: 870998, 852295
Tbr: chrisha@chromium.org
Tbr: thestig@chromium.org,
Tbr: qinmin@chromium.org
Tbr: asanka@chromium.org
Change-Id: I7d3e52e16f69ce746ebd682bdf1d69d78441f488
Reviewed-on: https://chromium-review.googlesource.com/1195682Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587215}

Using "use_jumbo_build=true" args in GN, speed up builds in
components/url_formatter.

Bug: None
Change-Id: I8c1ea3a67bafb99cb3b432a4b15ed22390ce4f58
Reviewed-on: https://chromium-review.googlesource.com/1190362Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#587214}

Since Interstitial pages don't allow navigation they can't be told to
go back from the renderer. Trap the back mouse button in the interstitial
page and handle it directly.

BUG=852230

Change-Id: Ibbd5d97a9bd692a0b431a19eb6466b0512e7bce5
Reviewed-on: https://chromium-review.googlesource.com/1194831
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587213}

Bug: 803137
Change-Id: I0ecd7f1885cca5b15c3aa2e6c95cddf867753a75
Reviewed-on: https://chromium-review.googlesource.com/1195746Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587212}

Pieces of dead code removed:
* is_possible_change_password_form -- this data member is
  never read, only assigned.
* UsernamesCollection data type, never used
* name data member -- only used on iOS, so removed from the
  Mojo bindings (which are only used on platforms using
  //content)

Bug: 852772
Change-Id: I29337fbfc632dbce38d6b85cd00e885e28f738c7
Reviewed-on: https://chromium-review.googlesource.com/1195504Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587211}

Change-Id: I00071ce9d7917f7671e82547fab9f60d7c2ef2c8
Reviewed-on: https://chromium-review.googlesource.com/1192415
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587210}

This will be used to show only a summary of available offline content on the
net error page, instead of the list view.

Bug: 852872
Change-Id: Id9a23351ce3a43ebd4308abde38a0d3f4829ae5d
Reviewed-on: https://chromium-review.googlesource.com/1190645
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587209}

This CL extracts the second half of CommitDataNavigation method into a
new CommitDataNavigationWithRequest method.  The new method is called by
the old WebLocalFrameImpl::CommitDataNavigation method and by
RenderFrameImpl::LoadNavigationErrorPageInternal.

The CL also consolidates and deduplicates RenderFrameImpl code related
to committing of error pages:

  - It avoids duplication of the code that calculates
    blink::WebFrameLoadType and blink::WebHistoryItem based
    on content::HistoryEntry*

  - It removes the need to pass arguments that either 1) do not differ
    among callers or 2) can be deduced from other arguments.  For example:
    - GURL(kUnreachableWebDataURL)
    - is_client_redirect

This CL should be a pure refactoring, with no change in behavior.

Bug: 874544
Change-Id: I0088ad6367407ba70aa28c550ca46d7121dd78eb
Reviewed-on: https://chromium-review.googlesource.com/1176230
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587208}

This timing logically belongs to NavigationInfo structure and
DecidePolicyForNavigation call, instead of DidStartProvisionalLoad.

Any additional bits of information in DidXXXLoadYYY should generally
belong to one of the existing structures and not be plumbed separately.

This also makes it possible to further reduce duplication between
StartNavigation and CommitNavigation by calling latter from the former
in some circumstances.

Bug: none
Change-Id: Ic1d42a4445e068c2414a59e397f2503dca864689
Reviewed-on: https://chromium-review.googlesource.com/1194875Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587207}

Before this CL, migration to USS for wallet data USS bridge fails
because
 - this bridge does not support incremental updates,
 - a clear-all gc directive is expected for every (non-empty) update
   for such bridges, and
 - the uss migrator does not provide the directive (as it has no clue
   about which data types expect which directives).

This CL exempts initial updates from this rule and allows them to
arrive without any gc directive.

Bug: 876308
Change-Id: I2dd91f077ee3602d88e96c5532c3bb910b48c224
Reviewed-on: https://chromium-review.googlesource.com/1194366
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587206}

Show a message to the user when we are not selected to return a
response due to multi-device hotword loss.

Bug: b:112364854
Change-Id: I8c876622ddb69fc7e67ff64848394e1c5fa60491
Reviewed-on: https://chromium-review.googlesource.com/1192590Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#587205}

Skip updating visual viewport's paint property nodes unless one of the
inputs has changed.

Bug: 868927,877184
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I62e37c449a14098175e79d6d357a5aecac314e9a
Reviewed-on: https://chromium-review.googlesource.com/1194564
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587204}

This is accomplished by avoiding holding Cronet_UrlRequestImpl::lock_
while issuing callbacks. Holding the lock is only necessary while
modifying state that should be processed in an atomic fashion.
The Cronet_UrlRequestImpl will not be deleted until after final
callbacks have been run so there is no chance of a use-after-free.

Bug: 869402
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;luci.chromium.try:ios-simulator-cronet
Change-Id: Ie851b57296c394e6f098022a7930d65f62f7b0c6
Reviewed-on: https://chromium-review.googlesource.com/1183625Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587203}

PaintLayer::location_ is relative to the containing block, not the
parent layer.  For a MouseEvent on a position: absolute element, we were
adding the parent layer's location to a value that already included it,
which doesn't make sense.

The behavior of layerX and layerY remains quirky and not standardized.
There is an open issue at https://github.com/w3c/uievents/issues/135.
It's unclear if the FIXME about ConvertToLayerCoords is still correct.

Bug: 856525
Change-Id: Iba5bb7b2c955b4bd526597628cd789ff0eb42e90
Reviewed-on: https://chromium-review.googlesource.com/1195648Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587202}

Bug: 875344, 877669
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I15bbd8c9f64d999f0d987af9d0b8d2b2785165be
Reviewed-on: https://chromium-review.googlesource.com/1188777
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587201}

Now that our release builds are clean we can always print the output
so that it's easier to identify the cause of build failures.

Bug: 877221
Change-Id: I842314b924b05e79fea55352c8517d8c944c7c28
Reviewed-on: https://chromium-review.googlesource.com/1194796Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587200}

Behavior change: we only update source_counts if the source is actually
recorded (and not dropped). Additionally, for sources with multiple
URLs, we stop double counting.

Bug: None
Change-Id: Ifa7ac204b41a41fd50b55cf755455870ea460fb5
Reviewed-on: https://chromium-review.googlesource.com/1188646
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587199}

Change a bunch of WebUIs to use the non-deprecated version.

Change-Id: I1d918500b59ea92f642fda08bdfb020a56acaf26
Reviewed-on: https://chromium-review.googlesource.com/1194979Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587198}

When users apply a filter on chrome://settings/siteData, MediaLicenses and
FlashLSO nodes where not added to the cookie tree, so they are not displayed.
This CL adds them back in.

BUG=808690
TEST=tested locally with sites that save Media Licenses

Change-Id: Ibef359a2c9bdf02c2a59864e8e6232d2953000a8
Reviewed-on: https://chromium-review.googlesource.com/1171595
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587197}

Adding a test to validate that calling measureText a second time, it gives
the same results (an arrray with the same values) as a first time.

Change-Id: I5308b6610633de2d5ac44d45f07a97d7f63657e5
Reviewed-on: https://chromium-review.googlesource.com/1191536Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587196}

When the immersive reveal starts, move |top_container_| to the widget's
overlay view so it's on top of everything. The layout logic doesn't
change because it's handled by BrowserViewLayout and is agnostic to the
actual parent view, and because the overlay view has the same bounds as
the client view.

Some responsibility for immersive reveal init and shutdown is moved
from ImmersiveModeControllerAsh to the BrowserView.

Bug: 857546
Change-Id: I6192810e411240b588cb1e82363b19cc30eb1edf
Reviewed-on: https://chromium-review.googlesource.com/1192140
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587195}

Move the scale call to the branch of the code that already expects
coordinates to be scale.

Thank you @Xiyuan for the tip on what was going wrong.

Bug: 878602
Change-Id: Iae524d3fbb073380ee7ce7721fc7bd08196cafc1
Reviewed-on: https://chromium-review.googlesource.com/1194507Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587194}

Add user's advanced protection status to download pings and password
protection pings.

Server side proto change already landed in cl/209451527


Bug: 866620
Change-Id: I5e0d6034bad77d512bc91ed919f90600658d0bd8
Reviewed-on: https://chromium-review.googlesource.com/1192382
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587193}

The bottom toolbar overflow menu button should have an
accessibility delegate (the top toolbar button does have one).
This CL adds a delegate to it.

Bug: 877007
Change-Id: I3dc101a98513a10be5a233ed60640b5b7502a557
Reviewed-on: https://chromium-review.googlesource.com/1194341Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587192}

Bug: 869726,870595
Change-Id: I8f6065ee0befe39b4e13ef7bf04f5382bb5b2bc6
Reviewed-on: https://chromium-review.googlesource.com/1185963
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587191}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d4c79096..19afaa14

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I34fd93eaa8c355d28b4d1ecf620426f0ee78ac61
Reviewed-on: https://chromium-review.googlesource.com/1195643Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587190}

It seems that spurious mousemove events on Win have been creeping into
tests in this suite (e.g. a test window pops up under where the system
thinks the mouse cursor is, and generates a mouse-enter). These events
appear to be at the root of flakes for at least one, and possibly more,
tests in this hierarchy.

This CL installs a ui::EventRewriter that discards all system mouse
events in an attempt to reduce flake in the tests.

Bug: 833380
Change-Id: I48adacad0fdf4126ea4198bfa72b336d0eb63389
Reviewed-on: https://chromium-review.googlesource.com/1194253
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587189}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/86a2ffa02e46..45e7b57c0467


git log 86a2ffa02e46..45e7b57c0467 --date=short --no-merges --format='%ad %ae %s'
2018-08-29 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@45e7b57c0467

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I555179fe4eed0c0a66b6e1e29ff77f67f42cbcbd
Reviewed-on: https://chromium-review.googlesource.com/1195055Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587188}

SelectionModifierCharacter's main function, TraverseInternal, contains
two nested loops without clear loop variable or terminate condition,
making it very hard to understand.

This patch refactors it so that:

1. Introduce an InlineBoxPosition loop variable that is modified only
at the end of each iteration of the outer loop, so that it becomes
clear what we are working on in each iteration.

2. Changes the inner loop to have exactly one iteration, which has in
fact flattened the inner loop. This patch intentionally keeps the loop
statement to minimize changes and emphasize that this patch is pure
refactoring.

Regarding correctness of 2: Without patch, each iteration of the inner
loop has three possibilities, depending on the initial value of the
(box, offset) pair:

I. Returns directly, which remains the same with patch.

II. Changes value of (box, offset) and continues. With patch, it sets
the value of (next_box, next_offset), and then sets |can_create_position|
to false to instruct the outer loop to change the loop variable value
without any extra work.

III. Changes value of (box, offset) and breaks, which ends up
- Creating a Position |p| and test if it can be returned
- If not, use |p| to create next iteration's (box, offset) value
With patch, it sets |can_create_position| to true so that the same
|p| is created and tested, and if |p| is not the return value, also
uses |p| to set up the value of next iteration's |box_position|.

Bug: 877263
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iad30a37b1ef209170ed6dd770862c13e40320f86
Reviewed-on: https://chromium-review.googlesource.com/1194964Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587187}

Specs:
https://screenshot.googleplex.com/6gGm7iDdKmB

Bug: 878520,878162
Change-Id: I0bd9673232cd0036422ecdb71410151db476290b
Reviewed-on: https://chromium-review.googlesource.com/1194340Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587186}

Bug: 878389
Change-Id: I5c226325dbbfc2f0f044986e03943e08ff4330e3
Reviewed-on: https://chromium-review.googlesource.com/1195672Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587185}

This reverts commit 7456855a.

Reason for revert: Causing at least one, potentially two issues. Will fix and reland to new branch instead.

Original change's description:
> Android horizontal tab switcher entrance/focus animation improvements
> 
> This adds a non-overlapping specific animation where each card is moving
> directly back to its place in the stack, rather than doing the slightly
> curving motion that is needed for an overlapping stack. It gets rid of the
> final remaining issues aroudn horizontal tab switcher enter/exit animations
> 
> 
> 
> Change-Id: I3e4ff3adbab67e7e6a970cbd5eac59f1b703a667
> Bug: 846166
> Reviewed-on: https://chromium-review.googlesource.com/1118751
> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584836}

TBR=yusufo@chromium.org,mdjones@chromium.org,rlanday@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 846166, 876685
Change-Id: Ib1f06123b10936fb0d71909c6f40a255963c8817
Reviewed-on: https://chromium-review.googlesource.com/1195668Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587184}

Route calls to handle keyboard events through BridgedNativeWidgetHost,
instead of calling into the views::View, which will exist only in the
browser process. The event handling functions need to "know" if the
event was handled, so make the calls synchronous and return whether or
not the event was handled.

Add similar routing for menu dispatching.

Also add the method GetIsFocusedViewTextual to BridgedNativeWidgetHost,
since it is nearby and similar.

Bug: 859152
Change-Id: I67b21dbd736fc4ccbb5c5216707dd3a1667d6ef5
Reviewed-on: https://chromium-review.googlesource.com/1192267
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587183}