- 19 Apr, 2020 4 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e838d8d0fbc..3ce055109dd8 Created with: gclient setdep -r src-internal@3ce055109dd8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071247 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: I7af5a392ef986f47b3ebbdccb97f07025d83cc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154927Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760340}
-
Wei-Yin Chen (陳威尹) authored
Bug: 982018 Change-Id: Ied383279878bcf66eb80343eae34942c06d875b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155805Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#760339}
-
Anton Bikineev authored
This also adjusts the tests. Original change's description: > clang plugins: default no-members-in-stack-allocated to on > > Artifacts can be removed after the clang prebuilt is updated. > > Change-Id: I473c22843445745a39d1fc648a7bbcc336631b8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152329 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Cr-Commit-Position: refs/heads/master@{#759880} Change-Id: I16e07fe68e308005350c37cf50d0fe5c1e2611e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154788 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760338}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ic1e9a56fb5806a89ac56f0facf37b88c4cd7c361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155809Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760337}
-
- 18 Apr, 2020 36 commits
-
-
Anders Hartvoll Ruud authored
This enables support for the 'revert' keyword once again, now that issue 1071454 is fixed. This reverts commit e5912ac3. Bug: 579788, 1071454 Change-Id: I5ca25177567e80f85e05584dcfee12c5398e1084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153121Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760336}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a59affb2a75..ae28b321d07d git log 6a59affb2a75..ae28b321d07d --date=short --first-parent --format='%ad %ae %s' 2020-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 49ad8eaae192..33b58ebb7ea8 (24 commits) Created with: gclient setdep -r src/third_party/skia@ae28b321d07d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I42f6a77cb9a0d2886cb758c9e253898b0c28538b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760335}
-
Kramer Ge authored
OzoneDrmMojo is at 100% in M81 and M83 branch cut has passed, feature is by default on in M83. Legacy IPC code should be removed. Bug: 620927,806092 Change-Id: I40346e50df69515163a7b6e1df92b3a50a101bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142332Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#760334}
-
Nico Weber authored
This reverts commit 2883cd18. Reason for revert: broke tests; we also need to update 2 baselines: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8882703558916297872/+/steps/package_clang/0/stdout Original change's description: > clang plugins: default no-members-in-stack-allocated to on > > Artifacts can be removed after the clang prebuilt is updated. > > Change-Id: I473c22843445745a39d1fc648a7bbcc336631b8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152329 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Cr-Commit-Position: refs/heads/master@{#759880} TBR=thakis@chromium.org,kouhei@chromium.org,johannkoenig@google.com,bikineev@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idd66b71f7b71f7ae64ffc8cb4d24160a86cc80f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155363Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0ebc69c9ef34..6a59affb2a75 git log 0ebc69c9ef34..6a59affb2a75 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 reed@google.com flutter is ready for m44 Created with: gclient setdep -r src/third_party/skia@6a59affb2a75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Iab553aef43bb5f8cb3a87620d6f36c1824e219ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155672Reviewed-by:
-
Jacobo Aragunde Pérez authored
According to the standard, the figcaption that corresponds to a certain figure element can only be its first or last child. Existing code was searching among all of its descendants, which might include captions belonging to a different figure and caused the reported bug. Bug: 1060810 Change-Id: I0fc7f2dc52fb211f640913b64e449259ae55d146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144273Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#760331}
-
Gavin Williams authored
- Accepts a printer id, kicks off a printer status request, then once complete broadcasts the status to "printer-status-update". Bug: 1059607 Change-Id: I91b30632a6682a4705616d714038a7826483753c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128236 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#760330}
-
Yuki Shiino authored
This fix is not perfect, but solves partial build breakage with dllimport/dllexport specifiers. Bug: 839389 Change-Id: I1d31d341ff1ab0f29797d48b97df45e2815e866a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154430Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#760329}
-
Nnamdi Theodore Johnson-Kanu authored
This CL is in preparation for enabling Polymer3 in ChromeOS settings pages. It uncomments polymer_modulizer build target and makes sure Polymer3 modules can be generated from js files. Bug: 1045266 Change-Id: I8570053b3aa043b180078dd69286f4db51acd898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153305 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#760328}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9283cf0354c5..3e838d8d0fbc Created with: gclient setdep -r src-internal@3e838d8d0fbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Ibc9d7604f0e8f1f3a3f91f3fd269ef04e584efbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155669Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb490911a952..0ebc69c9ef34 git log fb490911a952..0ebc69c9ef34 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 johnstiles@google.com Fix modulo-by-zero crash during SPIR-V conversion. Created with: gclient setdep -r src/third_party/skia@0ebc69c9ef34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ie3515c173a1fd8eaa10585b9377f4a99f07f814c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155668Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I53ad6739e0ee384aa3bd13aaaf700dc11a4609a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155617Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760325}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I587b28b49d6fe4da269a8eb160586048081a8fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155360Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760324}
-
Philip Rogers authored
This reverts commit 0410b740. Reason for revert: Causing MediaFeedsWebUIBrowserTest.All failures, see https://crbug.com/1072145. Original change's description: > Add live details, images, duration fields for episodes. > > Bug: 1065986 > Change-Id: I4d3339006bbea2aaf1a6c9566e34a6faa506b04c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148247 > Commit-Queue: Sam Bowen <sgbowen@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760284} TBR=dcheng@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I77600047ed412095a253d955770a74e613b4dbb4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065986, 1072145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155621Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760323}
-
Philip Rogers authored
This reverts commit 1f585617. Reason for revert: This is causing flakes, see: https://crbug.com/1072143. Original change's description: > [Extensions Metrics] Add metrics for action invocation source > > Add a new histogram to track the invocation source for extension > toolbar actions. This can include: > - The main toolbar > - The new extensions menu > - The old overflow menu (in the 3-dot menu) > - A programmatic API call (currently limited to allowlisted > extensions). > > Bug: 1064111 > Change-Id: I373768ba97c67d4b80bdc56585fd5a8e6c5163cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147685 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Caroline Rising <corising@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760154} TBR=rdevlin.cronin@chromium.org,bcwhite@chromium.org,corising@chromium.org Change-Id: I191039916b5f3626bf06196a41eb896c7ed02bc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064111, 1072143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1943cb1302d..30b6825fa7b1 git log b1943cb1302d..30b6825fa7b1 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@30b6825fa7b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7fb2bbc51e22600fb322a40d05eeb9809ebbaa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155615Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f09ddec3..171cc405 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2691dd630e5d27e2722a67dadfcebecd92e7baa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155236Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760320}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 92a97b99. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 4de68d38 "fixup! [css-grid] Migrate flex-sizing-columns-min-max-width.html to WPT" f511fde8 "[css-grid] Migrate grid-gutters-and-flex-content.html to WPT" a236d77b "[css-grid] Migrate grid-gutters-and-tracks.html to WPT" d51ce450 "Add a WPT for image being lazy loaded multiple times" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia10512f1942f27b732a085c5b24a73efc343225c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155234Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760319}
-
Istiaque Ahmed authored
ScriptFinishedCallback can/should be a OnceCallback as it would only run (at most) once. This makes internal class Handler take OnceCallbacks too, simplifying the code a bit. Bug: None Change-Id: Id74e83ba255c9507ea778a7ad9fef08f8d7b9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133659 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760318}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c8fb8b1..f09ddec3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia5ffe3aeb886e21d1ab41afc1e4f6408d9c6b34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155228Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ifd2156c012a7203e4bdb8c9d7bd1fe3c994d142d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155052 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#760316}
-
Mugdha Lakhani authored
Remove CookieControlsBridge dependency from PageInfoController. CookieControlsBridge enables improved Cookie Controls UI. (Context: https://bugs.chromium.org/p/chromium/issues/detail?id=1040091) WebLayer will likely support it in the future and TODOs have been added to componentize it. Bug: 1052375 Change-Id: I3d92e1af94a41cd0e4407cc9d0771a23542f743e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151455 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760315}
-
Anders Hartvoll Ruud authored
CSSBitset is the same as a std::bitset, except it uses CSSPropertyID in its API, and has substantially (~10x) better performance when traversing the set bits for cases where few bits are set. Previous experiments has shown that the typical number of applied declarations per element is in the 10-20 range (out of a 500+ bitset), which makes this optimization relevant. There are two reasons for adding this. First, there is a need (in the near future) to interact with a CSSPropertyID-based bitset outside of the StyleCascade. Therefore it's nice to have an API which actually accepts/yields CSSPropertyIDs, to avoid noisy casting at every call- site. Second, there will be a need to traverse the bits efficiently in a situation where the common case has very few bits set. This CL replaces std::bitset with CSSBitset in CascadeMap, without using any of the capabilities which make CSSBitset special, but those capabilities will be used in the near future. Change-Id: I7080c97f784f01c4f560e9fb570443dd927b7a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152370Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#760314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c632aa633792..fb490911a952 git log c632aa633792..fb490911a952 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@fb490911a952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ibee7a69ed991824c39cb8f3cf9da4f6cafef4349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155552Reviewed-by:
-
Lei Zhang authored
Change-Id: I2a594c53509a303a95aaf3268dfae914b2fff30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154734Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760312}
-
Greg Thompson authored
Include the contents of directories that unexpectedly exist. This may shed some light into failures on ToTWin64(dbg). BUG=1013720 R=zmin@chromium.org Change-Id: I466528a73e8aee93e70c7af11ccfa2c82b9e1198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152832 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760311}
-
Anders Hartvoll Ruud authored
The 'initial', 'inherit' and 'unset' keywords were handled, but 'revert' was not. This caused crashes when trying to represent certain declaration block serializations using shorthands. Change to use IsCSSWideKeyword instead, which includes 'revert'. (It should also avoid the same problem the next time a new CSS-wide keyword is added). Bug: 1071454 Change-Id: I968a32a5ad5b2a1a1958f60ec19679c6a642df14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152817Reviewed-by:
-
Roman Sorokin authored
This is a reland of 7d5271d9 Original change's description: > Migrate moar tests to LoginManagerMixin > > Bug: 1067260 > Change-Id: Ic86579fd50c5815c9adadbd3feade22cbd1c37a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144146 > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760159} TBR=raleksandrov@google.com Bug: 1067260 Change-Id: Ia5689b03885ba68cdd933590d1088090d662f07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153158 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760309}
-
Roman Sorokin authored
Also introduce arc-tos-host-for-tests switch instead of setTosHostNameForTesting function. Needed for CL:2144279 Bug: 1067260 Change-Id: Iff5417eb02338944e07dbe982cc65edf4d18f30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145876 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#760308}
-
Esmael El-Moslimany authored
Change OGB height to 56px to match chrome-search://local-ntp (64px included the bottom margin). Include the customize button in the scroll region using "position: sticky". Shrink customize button when content width is below 550px. Shrink customize button and make background transparent when background image is shown. Set ntp-most-visited height based on number of rows of shortcuts. Shortcuts when dragged use a fixed position which does not contribute to the parent element height. Update the shorcut icons to 24px width and height. Add a 2px top padding to ntp-most-visited so the focus outline is not cutoff. Include text direction in the chrome-untrusted://new-tab-page HTML. Bug: 1070684, 1070668, 1070650, 1067366 Change-Id: Iee5a0055d77d992389d9542c9f9683bb7d2639f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155021 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#760307}
-
Haiyang Pan authored
Bug: 1070264 Change-Id: Ib741b6123633cf58a6b45f44a8154b8dae97f2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155410Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#760306}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91a820098f0c..9283cf0354c5 Created with: gclient setdep -r src-internal@9283cf0354c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: Iaf42a88b0a723556453f760d04b3e3e5e06c3357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155443Reviewed-by:
-
Chris Lu authored
This will allow the Overlay framework to not create an overlay request when a user navigates to a page that is marked as auto-translate. This is necessary because the initial translate step is TRANSLATING and the Overlay framework responds to Infobar additions by presenting a Banner, which should not happen if the BEFORE_TRANSLTE step is skipped. Bug: 1071914 Change-Id: Ie174702b4e12f91da75d71fbb15850053a97e7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154396 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#760304}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d5da0298b9b..33b58ebb7ea8 git log 2d5da0298b9b..33b58ebb7ea8 --date=short --first-parent --format='%ad %ae %s' 2020-04-18 timvp@google.com Vulkan: Give unsized arrays at least 1 entry Created with: gclient setdep -r src/third_party/angle@33b58ebb7ea8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I8364941e1818f461755e880ff19cdde4fb9365c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155477Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/39aac148144c..b1943cb1302d git log 39aac148144c..b1943cb1302d --date=short --first-parent --format='%ad %ae %s' 2020-04-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b1943cb1302d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I07cd6276f524f5170d6ed35be39187eb046afc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155438Reviewed-by:
-
Brian Manthos authored
Building api_registration.lib clean directly fails. Repro steps: 1. rmdir /s/q out\default 2. gn gen out\default 3. autoninja.bat -C out\default obj/chrome/browser/apps/platform_apps/api/api_registration.lib153933 Change-Id: Ia4b24b3c9822c0586e93ff4931b18bc2471f7f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153933Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Brian Manthos <brianman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#760301}
-
