- 28 Apr, 2015 6 commits
-
-
sky authored
These directories were added here: https://codereview.chromium.org/1085233004/ R=ben@chromium.org,erg@chromium.org,msw@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/1105303002 Cr-Commit-Position: refs/heads/master@{#327187}
-
nednguyen authored
Add logic to make sure that page sets paired with smoothness/repaint only have interaction records with same label & they have repeatable flags enabled. To make sure that this doesn't crash any smoothness benchmarks, I modified benchmark_smoke_unittest to run all smoothness benchmarks (including ones that only support android) in patch #3. To validate the test runs, see telemetry_perf_unittest's result in patch #5 smoothness.key_silk_cases: https://codereview.chromium.org/1111543002/ smoothness.polymer: https://codereview.chromium.org/1060583012 BUG=444701,444703 Review URL: https://codereview.chromium.org/1104573002 Cr-Commit-Position: refs/heads/master@{#327186}
-
dbeam authored
R=rdsmith@chromium.org BUG=481664 Review URL: https://codereview.chromium.org/1111593002 Cr-Commit-Position: refs/heads/master@{#327185}
-
msw authored
Skip native_viewport's init of gfx::GLSurface when headless. Remove the unused --use-osmesa flag (--use-test-config suffices?). Re-enable the window_manager_apptests again; fingers crossed. BUG=480040 TEST=Bot passes window_manager_apptests. R=sky@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1103413002 Cr-Commit-Position: refs/heads/master@{#327184}
-
pcc authored
The -Oz flag enables more aggressive size optimizations. Shrinks the libchromeshell.so DSO by around 2.5MB. BUG=481675 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1103393002 Cr-Commit-Position: refs/heads/master@{#327183}
-
maxbogue authored
No test because SigninManager is low on my list of things to write tests for. I've filed http://crbug.com/481099 to track it. BUG=478597 Review URL: https://codereview.chromium.org/1100983005 Cr-Commit-Position: refs/heads/master@{#327182}
-
- 27 Apr, 2015 34 commits
-
-
jrummell authored
BUG=471322 TEST=EME tests pass Review URL: https://codereview.chromium.org/1050823009 Cr-Commit-Position: refs/heads/master@{#327181}
-
hendrikw authored
Modify initial the offscreen size if empty DCHECK to assert that we don't run into this situation again BUG=481035 Review URL: https://codereview.chromium.org/1106773002 Cr-Commit-Position: refs/heads/master@{#327180}
-
tapted authored
Mac Chromium.app sizes expectations were last updated after the switch to 64-bit which had a large increase (r305043 and http://crbug.com/435576). Later, there was a large drop for Chromium.app in r314575 due to the PDF plugin being combined into the ChromiumFramework. The perf expectations for ChromiumFramework were updated, but not Chromium.app. This has meant that large jumps are unlikely to affect the Mac sizes tree-closers, since they are absorbed into the gains from r314575. Instead, large jumps are getting picked up late because they are triaged from perf graphs rather than the Chrome waterfall. Chrome has been growing about 1MB per month on average. Set the tolerance to 1% (rather than 5%) for something likely to detect the recent large erroneous jumps. After this, Chromium.app will close the tree once it gets to 159,128kB. The prior threshold was 165,929kB. Chromium.app currently reports 157,589kB Also update ChromiumFramework. It's not out of whack, but it makes sense for it to share a common threshold tolerance with Chromium.app. BUG=468637 Review URL: https://codereview.chromium.org/1101133004 Cr-Commit-Position: refs/heads/master@{#327179}
-
hcarmona authored
BUG=463245 Review URL: https://codereview.chromium.org/1104883002 Cr-Commit-Position: refs/heads/master@{#327178}
-
rnephew authored
Currently the dumpsys power monitor uses a static value of 4.0 for the voltage when determining the power usage. This changes it to get the voltage from the device to make the power measurements more accurate. BUG=476043 Review URL: https://codereview.chromium.org/1107173002 Cr-Commit-Position: refs/heads/master@{#327177}
-
https://codereview.chromium.org/1077893005/thakis authored
Add a comment to UpdateProcThreadAttribute() to note that its parameter needs to outlive this. BUG=476316 Review URL: https://codereview.chromium.org/1106263002 Cr-Commit-Position: refs/heads/master@{#327176}
-
miu authored
BUG=156767 Review URL: https://codereview.chromium.org/1109603003 Cr-Commit-Position: refs/heads/master@{#327175}
-
davidben authored
There's no reason for them to be virtual. Also removed a field I missed in a previous CL. BUG=477847 Review URL: https://codereview.chromium.org/1111553002 Cr-Commit-Position: refs/heads/master@{#327174}
-
nick authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1101023002 Cr-Commit-Position: refs/heads/master@{#327173}
-
oshima authored
Enhanced MirrorWindowController to manage multiple mirroring windows. BUG=365662 Review URL: https://codereview.chromium.org/1107733006 Cr-Commit-Position: refs/heads/master@{#327172}
-
limasdf authored
Use ExtensionSystem::Ready instead of NOTIFICATION_EXTENSIONS_READY. R=kalman@chromium.org BUG=354459 Review URL: https://codereview.chromium.org/1102193002 Cr-Commit-Position: refs/heads/master@{#327171}
-
aurimas authored
Chrome no longer supports API 14 and 15 BUG=473837 Review URL: https://codereview.chromium.org/1109963003 Cr-Commit-Position: refs/heads/master@{#327170}
-
simonhong authored
This cl disables BeginFrame scheduling for OOPIF. We will enable this for OOPIF when we have a architecture for delivering BeginFrame message for OOPIF. R=kenrb@chromium.org, brianderson@chromium.org, creis@chromium.org BUG=471411 Review URL: https://codereview.chromium.org/1107763002 Cr-Commit-Position: refs/heads/master@{#327169}
-
lgarron authored
BUG=362214 Review URL: https://codereview.chromium.org/1098983003 Cr-Commit-Position: refs/heads/master@{#327168}
-
jyasskin authored
Exclude PluginPowerSaverBrowserTest.PluginMarkedEssentialAfterPosterClicked from DrMemory for timing out. BUG=481687 TBR=tommycli@chromium.org Review URL: https://codereview.chromium.org/1109973003 Cr-Commit-Position: refs/heads/master@{#327167}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/1e14c28..9b3210f TBR=tkent@chromium.org,pdr@chromium.org Review URL: https://codereview.chromium.org/1111533002 Cr-Commit-Position: refs/heads/master@{#327166}
-
dpranke authored
Without these, a GN clobber build fails, and we get warnings during the non-compile builds. R=garykac@chromium.org BUG= Review URL: https://codereview.chromium.org/1108953002 Cr-Commit-Position: refs/heads/master@{#327165}
-
dpranke authored
This CL contains several fixes needed to make the ChromeOS GN debug component build link. R=brettw@chromium.org, erg@chromium.org, garykac@chromium.org, kjellander@chromium.org BUG=433082 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg;tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg Review URL: https://codereview.chromium.org/1054963007 Cr-Commit-Position: refs/heads/master@{#327164}
-
aurimas authored
This CL also add OWNERS file for ApiCompatibilityUtils BUG=473837 Review URL: https://codereview.chromium.org/1082303004 Cr-Commit-Position: refs/heads/master@{#327163}
-
pdr authored
This patch adds a version of rasterize and record on key silk cases with --enable-slimming-paint. BUG=464910 Review URL: https://codereview.chromium.org/1106823003 Cr-Commit-Position: refs/heads/master@{#327162}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/a6f7507..d7c014f CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=humper@google.com Review URL: https://codereview.chromium.org/1107953003 Cr-Commit-Position: refs/heads/master@{#327161}
-
jamiewalch authored
Since the width of this dialog is no longer fixed, this CL also updates base.resizeWindowToContent to set the width as well as the height, and adds support for centering. BUG=b/19796166 Review URL: https://codereview.chromium.org/1081813007 Cr-Commit-Position: refs/heads/master@{#327160}
-
msw authored
I fixed local crashes in https://codereview.chromium.org/1107133002 The bot fails on gl_surface init, which I can't repro: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/4898/steps/app_tests/logs/stdio [0427/144427:ERROR:gl_surface_x11.cc(98)] XOpenDisplay failed. [0427/144427:ERROR:gl_surface_x11.cc(62)] NativeViewGLSurfaceOSMesa::InitializeOneOff failed. [0427/144427:FATAL:gl_surface.cc(136)] Check failed: InitializeOneOffImplementation( impl, fallback_to_osmesa, gpu_service_logging, disable_gl_drawing). BUG=480040 TEST=Bot goes green again. TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1106363002 Cr-Commit-Position: refs/heads/master@{#327159}
-
thakis authored
BUG=477846 NOTRY=true Review URL: https://codereview.chromium.org/1106353002 Cr-Commit-Position: refs/heads/master@{#327158}
-
Adam Langley authored
BUG=480785 Cr-Commit-Position: refs/heads/master@{#327157}
-
mfoltz authored
BUG=46422 TBR=jhawkins for .grdp Review URL: https://codereview.chromium.org/1056023003 Cr-Commit-Position: refs/heads/master@{#327156}
-
spang authored
Revert of Add CPP API for BLE advertisments. (patchset #12 id:220001 of https://codereview.chromium.org/1054743003/) Reason for revert: Breaks component=shared_library build (missing export?) ../../device/bluetooth/bluetooth_adapter_chromeos.cc:321: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::BluetoothAdvertisementChromeOS(scoped_ptr<device::BluetoothAdvertisement::Data, base::DefaultDeleter<device::BluetoothAdvertisement::Data> >, scoped_refptr<chromeos::BluetoothAdapterChromeOS>)' ../../base/memory/scoped_ptr.h:128: error: undefined reference to 'device::BluetoothAdvertisement::Data::~Data()' ../../device/bluetooth/bluetooth_adapter_chromeos.cc:322: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)' obj/device/bluetooth/device_bluetooth.bluetooth_adapter_chromeos.o(.debug_addr+0x6f20): error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)' Original issue's description: > Add CPP API for BLE advertisments. > > This CL adds the new classes, changes to existing classes and tests for adding > the CPP API for LE advertisements. The design for this is available at > http://go/chrome-ble-advertising. > > R=armansito@chromium.org, jamuraa@chromium.org > BUG=466375 > > Committed: https://crrev.com/c96da18077ef4b5ab28cb8b2684cd84386075e5a > Cr-Commit-Position: refs/heads/master@{#327128} TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,rkc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466375 Review URL: https://codereview.chromium.org/1111563002 Cr-Commit-Position: refs/heads/master@{#327155}
-
nick authored
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1100633004 Cr-Commit-Position: refs/heads/master@{#327154}
-
jam authored
Also remove third_party\mojo_services\src\http_server which is unused. BUG=479353 Review URL: https://codereview.chromium.org/1109943002 Cr-Commit-Position: refs/heads/master@{#327153}
-
mohsen authored
Revert of Classify navigations without page id in parallel to the existing classifier. (patchset #34 id:660001 of https://codereview.chromium.org/1002803002/) Reason for revert: Caused compile error in "Google Chrome Mac" bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/726 Original issue's description: > Classify navigations without page id in parallel to the existing classifier. > > For now, this only happens in debug builds. > > BUG=369661 > TEST=NavigationControllerBrowserTest.NavigationTypeClassification_* > TEST=Every other test on the planet. > > Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff > Cr-Commit-Position: refs/heads/master@{#327122} TBR=phajdan.jr@chromium.org,clamy@chromium.org,creis@chromium.org,hajimehoshi@chromium.org,isherman@chromium.org,jeremyim@chromium.org,mattm@chromium.org,mnaganov@chromium.org,mvanouwerkerk@chromium.org,nasko@chromium.org,stevenjb@chromium.org,bengr@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Review URL: https://codereview.chromium.org/1104403002 Cr-Commit-Position: refs/heads/master@{#327152}
-
spang authored
Summary of changes available at: https://chromium.googlesource.com/external/trace-viewer/+log/ba605a2..eea44df eea44df Add "evdev" to input latency category filter c2dae9e Fix core.analysis.table_builder_test.instantiateEmptyTable_withEmptyValue breaking Travis CI TBR=dsinclair Review URL: https://codereview.chromium.org/1103323003 Cr-Commit-Position: refs/heads/master@{#327151}
-
prasadv authored
This CL adds a post upload hook to add extra try bots list to the CL description in order to run Telemetry benchmarks on Perf trybots in addtion to CQ trybots if the CL contains any changes to Telemetry benchmarks. BUG=462581 Review URL: https://codereview.chromium.org/1060763002 Cr-Commit-Position: refs/heads/master@{#327150}
-
benwells authored
There are similar test files that are used by non-android specific testing that can be used instead. BUG=457403 Review URL: https://codereview.chromium.org/1092383003 Cr-Commit-Position: refs/heads/master@{#327149}
-
ben authored
R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/1091513005 Cr-Commit-Position: refs/heads/master@{#327148}
-