- 04 Jan, 2019 40 commits
-
-
rbpotter authored
- Remove PROCESS_INVITE_FAILED event that was handled identically to PROCESS_INVITE event. - Use CustomEvent instead of Event for all events Bug: None Change-Id: I9de2723779267dc0e8b8d195337b89d9aeb5ca8f Reviewed-on: https://chromium-review.googlesource.com/c/1395178 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#619886}
-
Ben Kelly authored
The SimpleCache stores stream 0 and a footer at the end of the entry file. Currently it must seek to the end to read the footer and then seek to the beginning of stream 0 to read it. This seeking may be costly on devices with spinning disks. This CL adds support for prefetching the entire stream 0 and footer in a single read operation. The amount to prefetch may be speculatively set or, when in APP_CACHE mode, stored in the index. Storing the exact amount is only supported in APP_CACHE mode since the access time field is not needed in that mode and can be reused. Bug: 913107 Change-Id: I3877fc08875bf0206bda9b97bd119d3543877016 Reviewed-on: https://chromium-review.googlesource.com/c/1366762Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#619885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b7e284b4ec4f..8743424b5d6d git log b7e284b4ec4f..8743424b5d6d --date=short --no-merges --format='%ad %ae %s' 2019-01-04 jclinton@chromium.org Revert "cbuildbot/manifest_version.py: Use Gerrit autosubmit feature throughout" 2019-01-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8743424b5d6d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I35a43eecb4c6781dbec3514412b3c2ec887acfe0 Reviewed-on: https://chromium-review.googlesource.com/c/1395161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619884}
-
Sean Gilhuly authored
Begin frames were being processed when there was no BeginFrameObserver, occasionally causing |last_begin_frame_args_| in ExternalBeginFrameSource to be overwritten. These lost frames create a backlog in |pipeline_reporting_frame_times_|, which eventually causes a DCHECK. Remember whether or not begin frames are needed. If they aren't, call DidNotProduceFrame() instead of OnBeginFrame(). This mirrors a check in AsyncLayerTreeFrameSink::OnBeginFrame(). Bug: 916354 Change-Id: Id5361ec6c48044a21c4946585f0da5ef862dd6d5 Reviewed-on: https://chromium-review.googlesource.com/c/1393441Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#619883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9bb34ca22069..76616a10a786 git log 9bb34ca22069..76616a10a786 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9fa54eab2590..e4109f27136d (7 commits) Created with: gclient setdep -r src/third_party/skia@76616a10a786 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ibd709927cbd2fd6b0c8a1c03c0b2bdf5026a888e Reviewed-on: https://chromium-review.googlesource.com/c/1395818Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72ed1926c934..d85cad21ef30 Created with: gclient setdep -r src-internal@d85cad21ef30 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I05e04a89786621db1fd3b6a5801e4836875cd6c3 Reviewed-on: https://chromium-review.googlesource.com/c/1395817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619881}
-
Lin Sun authored
Remove intel flag from faiure expectations for fixed cases. Comment fixed mesa version for Linux driver bugs. Bug: 483282, 905006, 686075, 666384, 905011 Bug: 680276, 867675 Change-Id: Ib54f28397bdd073778bea7294870516bb19d1ce6 Reviewed-on: https://chromium-review.googlesource.com/c/1390765 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619880}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2033f83..c30e42d5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic99d2771f7dfbb0e9772c9f09f5869ed03271dcc Reviewed-on: https://chromium-review.googlesource.com/c/1395155Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619879}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bfdf22c. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 4836c563 "Change web platform test with mouse inputs under "pinterevents/"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I765f112223b7604f3a33563797575d2d9e76df1d Reviewed-on: https://chromium-review.googlesource.com/c/1395564Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619878}
-
Prashant Malani authored
ScopedTaskEnvironment is sufficient for the purposes of power/ml unit tests, so remove usages of TestMockTimeTaskRunner. This also removes need to support both TestMockTimeTaskRunner *and* ScopedTaskEnvironment in FakeBookClock. Bug: 917580 Test: All related unit tests still pass. Change-Id: Iec413bf52422a12462f8ff99ef5e02e23907925a Reviewed-on: https://chromium-review.googlesource.com/c/1393896Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#619877}
-
Sky Malice authored
Bug: 908963 Change-Id: I655419255ea7a99e3d053fba85464f0ce082ddfe Reviewed-on: https://chromium-review.googlesource.com/c/1395137Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/225f08bf85a3..e4109f27136d git log 225f08bf85a3..e4109f27136d --date=short --no-merges --format='%ad %ae %s' 2019-01-04 jdarpinian@chromium.org WebGL: validate texture format matches sampler type Created with: gclient setdep -r src/third_party/angle@e4109f27136d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:809237 TBR=syoussefi@chromium.org Change-Id: Ic594afb3521a746b929d588bb130d454908513c5 Reviewed-on: https://chromium-review.googlesource.com/c/1395346Reviewed-by:
-
Findit authored
This reverts commit 8f13336d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 619841 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGYxMzMzNmQ0M2NhMTBlZTEwYmQyMmFkMDJhYWIxMWM3ZDc5OTEyOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/8493 Sample Failed Step: viz_unittests on (none) GPU on Mac Sample Flaky Test: SkiaOutputSurfaceImplTest.CopyOutOutside Original change's description: > Add reshape and copy outside case for SkiaOutputSurfaceImplTest > > Bug: 894806 > Change-Id: Id76b1a229b9583e7d7304b4f5262e2b8d9bbbbb3 > Reviewed-on: https://chromium-review.googlesource.com/c/1388020 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619841} Change-Id: Ic8105579dffefcf7f13cfb12e30e350c6ffee6e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894806, 919012 Reviewed-on: https://chromium-review.googlesource.com/c/1395719 Cr-Commit-Position: refs/heads/master@{#619874}
-
Kenneth Russell authored
Pixel_Canvas2DRedBox Pixel_CanvasDisplayLinearRGBAccelerated2D Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing Pixel_CanvasLowLatency2D Bug: 918952 Change-Id: Ic747a861cb778f5f07c00e6b5862c8a3e4ce9407 Tbr: fserb@chromium.org Tbr: mcasas@chromium.org Tbr: zakerinasab@chromium.org Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1394984Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d690842f5ccd..72ed1926c934 Created with: gclient setdep -r src-internal@72ed1926c934 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860880 TBR=mmoss@chromium.org Change-Id: If0646ec71c34da071513c0b1a3241d865e932d6d Reviewed-on: https://chromium-review.googlesource.com/c/1395162Reviewed-by:
-
Chris Harrelson authored
Change-Id: Iadcbd28ef1aba41f27e0c0a7c9256e3fd42d0941 Reviewed-on: https://chromium-review.googlesource.com/c/1394875 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#619871}
-
Findit authored
This reverts commit 5aa7731c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 619843 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWFhNzczMWMzMDc1ZmU2M2QxZjAxNjI1MmZjMDk0YmJhMTQ5MWQxNww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/30552 Sample Failed Step: network_service_browser_tests on Windows-10-15063 Sample Flaky Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog Original change's description: > Extensions: Focus correct button on options dialog close. > > Also fix some const references surfaced by presubmit. > > Bug: 912026 > Change-Id: I2661f69f0e63e613a9b8e9d565813c3e27fed340 > Reviewed-on: https://chromium-review.googlesource.com/c/1377494 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619843} Change-Id: I66ae0de35342e94b47e76dac658df2eb1f12e4b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912026, 919007 Reviewed-on: https://chromium-review.googlesource.com/c/1395717 Cr-Commit-Position: refs/heads/master@{#619870}
-
Doug Turner authored
Bug: 916654 Change-Id: I70e2f99d558c797b0d1d98cb543fdc13c866e091 Reviewed-on: https://chromium-review.googlesource.com/c/1394374Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#619869}
-
Darren Shen authored
Currently right-clicking on input fields in Mojo apps will bring up an emoji option. Clicking it would crash the app. This is because we assume that an emoji callback function always exists, but actually this is not true for Mojo apps because they are in a different process. This patch adds a null check for the emoji callback so that we don't show the emoji option when we don't have a callback. Bug: 887649 Change-Id: Iaccb0d9f890187f5c405888babefde7d3f33abe0 Reviewed-on: https://chromium-review.googlesource.com/c/1393584 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#619868}
-
Doug Turner authored
If we find a null frame, we reject with a "Document not active" exception. Bug: 916656 Change-Id: If76de22eb1fd977571bb7517e6d745e3ad9077e9 Reviewed-on: https://chromium-review.googlesource.com/c/1391773 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619867}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/825055dd8383..ea44d5db9e74 $ git log 825055dd8..ea44d5db9 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 joelhockey system_api: Return homedir in ContainerStartedSignal Created with: roll-dep src/third_party/cros_system_api Change-Id: Ib010b26d2483c7d299196e9abf0790b3e874d62d Reviewed-on: https://chromium-review.googlesource.com/c/1395577Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619866}
-
Chris Harrelson authored
CL 1391863 inadvertently removed this. Bug: 918713 Change-Id: I3622168c1dab40403361f8d671a3bb84af88de01 Reviewed-on: https://chromium-review.googlesource.com/c/1395557Reviewed-by:
-
Jiajie Hu authored
See https://www.khronos.org/registry/OpenGL-Refpages/es3.1/html/glGetProgramResourceIndex.xhtml Bug: None Change-Id: I9e9e6e40614c292ee1e30c28a67e3494e6662401 Reviewed-on: https://chromium-review.googlesource.com/c/1393266Reviewed-by:
-
Kenneth Russell authored
conformance/canvas/draw-webgl-to-canvas-test.html conformance/extensions/webgl-depth-texture.html conformance/rendering/polygon-offset.html Unknown why these are flaky on this configuration. Bug: 918995 Change-Id: I8ab3ccf3c215999527b9d2da316097f4ce5271f2 Tbr: jdarpinian@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1395005Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619863}
-
Ted Choc authored
It has a single method, confusing name, and provides little/no value. This just inlines the single method into the one call site. BUG=876369 Change-Id: I8cc09dec289c14764563265e1da7ab41c5e74cf3 Reviewed-on: https://chromium-review.googlesource.com/c/1394928Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619862}
-
John Abd-El-Malek authored
This was disabled in August 2017, and since that time URLLoader got better error handling in the referenced method. Change-Id: I9a6192891d67a509edfdb3c47c362b77140fe84b Reviewed-on: https://chromium-review.googlesource.com/c/1395537Reviewed-by:
-
Maggie Chen authored
The unsandboxed GPU process to run DX Diagnostics and to collect DX12/Vulkan info should not be launched if "--disable-gpu" is added to the command line switch. Bug: 916338 Change-Id: Ib2551902f81e011e746436076b3d10c5848f5b37 Reviewed-on: https://chromium-review.googlesource.com/c/1394990 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#619860}
-
Andreas Butler authored
A check is added to ensure that transactions that have already been sent a commit signal from the front end (for whatever reason) are committed instead of aborted in the event of an abort. Spec Change: https://github.com/w3c/IndexedDB/pull/242 Explainer: https://andreas-butler.github.io/idb-transaction-commit/EXPLAINER Change-Id: I942136c1bbfb8a5347bf7cf1f9702f5cbff66521 Reviewed-on: https://chromium-review.googlesource.com/c/1330692 Commit-Queue: Andreas Butler <andreasbutler@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#619859}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/686bde10..a2033f83 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7dc31e95310e5c4acde3e551afff3616c590eba5 Reviewed-on: https://chromium-review.googlesource.com/c/1395001Reviewed-by:
-
Wez authored
Update the blink/renderer/controller/tests/run_all_tests.cc e.g. used by webkit_unit_tests, to provide the expected test environment by deriving from base::TestSuite and overriding Initialize() and Shutdown(). Bug: 918724 Change-Id: I711e29f70517ec793b08441b05fa82e33e461613 Reviewed-on: https://chromium-review.googlesource.com/c/1395194Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619857}
-
Joel Einbinder authored
Change-Id: I232a60e72b500fce1e995231d79a2a32313fd58e Reviewed-on: https://chromium-review.googlesource.com/c/1392174Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#619856}
-
Kenneth Russell authored
It seems that random tests have become flaky on this configuration, but the failures seem to be clustered in certain tests. Skip them on this bot to try to get it reliably green again. conformance2/renderbuffers/ multisampled-renderbuffer-initialization conformance2/textures/canvas/ tex-2d-rgb9_e5-rgb-float conformance2/textures/canvas/ tex-2d-rgb9_e5-rgb-half_float conformance2/textures/canvas/ tex-3d-rg8-rg-unsigned_byte conformance2/textures/image_bitmap_from_canvas/ tex-2d-rgb9_e5-rgb-float conformance2/textures/image_bitmap_from_canvas/ tex-2d-rgb9_e5-rgb-half_float deqp/functional/gles3/texturefiltering/ 2d_array_combinations_05.html Bug: 844483 Change-Id: I903a3641dcc3be6aff4096258cd22f6b45701483 Tbr: jmadill@chromium.org Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1395185Reviewed-by:Jamie Madill <jmadill@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619855}
-
rbpotter authored
- Remove events that have no listeners - Restore a listener for an event that is still useful - Remove usage of "new Event()" and cr.dispatchSimpleEvent which calls it, in favor of CustomEvent - For an event where the payload is/was unused, remove payload. Bug: None Change-Id: I647bb1b826df8f872482b444549829ae9d4e963c Reviewed-on: https://chromium-review.googlesource.com/c/1394916Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/447d7854291e..d690842f5ccd Created with: gclient setdep -r src-internal@d690842f5ccd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7a1b143ea8071f43de45366023e9edbf64b543da Reviewed-on: https://chromium-review.googlesource.com/c/1395159Reviewed-by:
-
Jimmy Gong authored
- Adds UpdateMountCredentials to SmbProviderClient. - This function will interact with Dbus to call CrOS's SmbProvider::UpdateMountCredentials. - Updated FakeSmbProviderClient. Bug: chromium:913691 Test: emerges Change-Id: I6311bc0d38282dacd659f82348189f96d29526bb Reviewed-on: https://chromium-review.googlesource.com/c/1388029Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#619852}
-
Theresa authored
BUG= TBR=tedchoc@chromium.org Change-Id: Ice9774144febf89e34456b482f38866e8b053beb Reviewed-on: https://chromium-review.googlesource.com/c/1393548 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619851}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5820b0c3f3ce..9bb34ca22069 git log 5820b0c3f3ce..9bb34ca22069 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-03 csmartdalton@google.com Allow aliasing in GrProxyProvider::processInvalidUniqueKey 2019-01-03 benjaminwagner@google.com Revert "Remove win_vulkan_sdk." 2019-01-03 benjaminwagner@google.com [infra] Upgrade Win10 in Skolo. 2019-01-03 benjaminwagner@google.com Remove win_vulkan_sdk. Created with: gclient setdep -r src/third_party/skia@9bb34ca22069 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ieb86f344a0e07ef75d03d7fe68a931465a5c3794 Reviewed-on: https://chromium-review.googlesource.com/c/1395160Reviewed-by:
-
Rohit Rao authored
The single implementation of this method, in BrowserViewController, is modified to use WebStateObserver methods instead. BUG=911350 Change-Id: I8543fc6e76b2586ae7cf341f8f7800e2410ec3fd Reviewed-on: https://chromium-review.googlesource.com/c/1394401Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#619849}
-
Pedro Amaral authored
Previously the tab switcher button was removed when HTS was enabled. This is incorrect since accessibility mode could mean reverting to using the old tab switcher top toolbar with the tab switcher button. This CL hides and shows the tab switcher button depending on the accessibility state. Bug: 914858 Change-Id: I1b74f5ed2e94380e260d2a4c6f0fb746f270e2e5 Reviewed-on: https://chromium-review.googlesource.com/c/1385126 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c48496fe54a9..b7e284b4ec4f git log c48496fe54a9..b7e284b4ec4f --date=short --no-merges --format='%ad %ae %s' 2019-01-03 manojgupta@chromium.org Revert "cbuildbot: fuzzer: enable common archiving stage" 2019-01-03 dburger@chromium.org Remove unused cidb method GetMetadata Created with: gclient setdep -r src/third_party/chromite@b7e284b4ec4f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If56d6be5c77c216925c5a48fb681e57e6496dafe Reviewed-on: https://chromium-review.googlesource.com/c/1395345Reviewed-by:
-
