- 12 Jul, 2017 40 commits
-
-
Allen Bauer authored
Bug: 706297 Bug: 683858 Change-Id: Ibb51dbacc26164ead556488da18fb322350fddff Reviewed-on: https://chromium-review.googlesource.com/546697 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485963}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c4176a2fa5aa..46b654df9e70 $ git log c4176a2fa..46b654df9 --date=short --no-merges --format='%ad %ae %s' 2017-07-11 ethannicholas converted GrSimpleTextureEffect to sksl 2017-07-12 reed remove unreachable perspective code for imageshader 2017-07-11 liyuqian Always enable Analytic AA for rects 2017-07-11 bsalomon Make SmallPathOp a non-legacy GrMeshDrawOp 2017-07-12 robertphillips Address ASAN complaint 2017-07-11 robertphillips Plumb raw GrMipLevel* down instead of SkTArray<GrMipLevel> in GrGpu Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Iaa9f8d51a32084c0449c65b80ca70b9c7e9635f5 Reviewed-on: https://chromium-review.googlesource.com/568220Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485962}
-
lukasza authored
These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=avi@chromium.org Review-Url: https://codereview.chromium.org/2976803002 Cr-Commit-Position: refs/heads/master@{#485961}
-
Raphael Kubo da Costa authored
Adapt to https://github.com/heycam/webidl/pull/378 ("Re-align DOMException objects with what is implemented"). We were reimplementing toString() in DOMException because of WebKit r29058 ("Acid3 expects ExeceptionCode constants to be defined on DOMException objects") from almost 10 years ago. A lot has happened since, and we can (and should) just use the toString() implementation from ECMAScript's %ErrorProtoype% (which is explicitly mandated to be in DOMException's inheritance chain by the WebIDL spec). Contrary to what's originally described in bug 556950, we do throw an exception when DOMException.prototype.toString() is called directly: the WebIDL spec now expects it to, and https://github.com/w3c/web-platform-tests/pull/6361 tests this behavior. Additionally, we've changed the way DOMException inherits from %ErrorPrototype%: instead of doing it in V8PerContextData, we now do it in V8DOMException::installV8DOMExceptionTemplate(), as the former had problems with (i)frames detached from the DOM and toString() would just call Object.prototype.toString() instead. The only user-visible part of the change is that "toString" is no longer part of DOMException.prototype's own properties; the error message format is exactly the same in most cases (the exact steps are described in https://tc39.github.io/ecma262/#sec-error.prototype.tostring). Finally, part of http/tests/plugins/cross-frame-object-access.html's output will change from: "Error: Uncaught [object DOMException]" to "Error: Uncaught" This is tricky because it involves PPAPI and its separate process, but basically the plugin in an iframe is trying to access top.location.href, Blink is throwing a SecurityError, but the error message is sent truncated to PPAPI. The message is truncated because V8 is calling its NoSideEffectsErrorToString() when creating the message, and this one does not use the message/name accessors we install, leading to an empty message (it looked slightly better before because we the presence of our own toString() caused Object::NoSideEffectsToString() to choose a different albeit still wrong code path). Blink's handling of this is fine, as the code in V8Initializer takes care of extracting the name and error message from the DOMException V8 object that threw the exception. Bug: 556950, 737497 Change-Id: I9d81edca1de903364bb1aca5950c313885c5964a Reviewed-on: https://chromium-review.googlesource.com/558904 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485960}
-
lizeb authored
Reland of customtabs: Remove unnecessary Context plumbing. (patchset #1 id:1 of https://codereview.chromium.org/2976023002/ ) Reason for revert: The downstream CL landed in the meantime, so the revert broke downstream. Original issue's description: > Revert of customtabs: Remove unnecessary Context plumbing. (patchset #5 id:80001 of https://codereview.chromium.org/2966193002/ ) > > Reason for revert: > Causing compilation errors in ChromeCustomTabsConnection.java. > > BUG=741667 > > Original issue's description: > > customtabs: Remove unnecessary Context plumbing. > > > > Also removes Context -> Application downcasts in callers. > > > > Review-Url: https://codereview.chromium.org/2966193002 > > Cr-Commit-Position: refs/heads/master@{#485909} > > Committed: https://chromium.googlesource.com/chromium/src/+/a0d1c1531de988606c0425de933722358985374b > > TBR=yusufo@chromium.org,yfriedman@chromium.org,lizeb@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2976023002 > Cr-Commit-Position: refs/heads/master@{#485950} > Committed: https://chromium.googlesource.com/chromium/src/+/87795a736613375a0bda2195a27777452b2f99d6 TBR=yusufo@chromium.org,yfriedman@chromium.org,aberent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=741667 Review-Url: https://codereview.chromium.org/2979853002 Cr-Commit-Position: refs/heads/master@{#485959}
-
lukasza authored
These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=nasko@chromium.org Review-Url: https://codereview.chromium.org/2978693002 Cr-Commit-Position: refs/heads/master@{#485958}
-
Josh Karlin authored
The tests were a bit lengthy, and with more tests upcoming it makes sense to clean them up by making a histogram-checking function. BUG=741026 Change-Id: Ifb7812d95409ba83d8b07682a4906479ded75c1b Reviewed-on: https://chromium-review.googlesource.com/567270Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485957}
-
Tibor Goldschwendt authored
- Relands fix of https://codereview.chromium.org/2944453002. Bug: 741020 Change-Id: Id6cb772edd0509afa60c217be02188bf16fcada9 Reviewed-on: https://chromium-review.googlesource.com/567384Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#485956}
-
Mike Baxley authored
Test that registers an observer before doing any actions, then later calls Refresh() to update TopSites. Bug: Change-Id: I161910709c7a43ae40f6f2f3dc5005863e30f771 Reviewed-on: https://chromium-review.googlesource.com/567145 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#485955}
-
Mike Baxley authored
Test verifies that only one tile is present. Bug: 741329 Change-Id: I30bb1d7f1f0a5af13ccb2d364d97fe3d67ae6d88 Reviewed-on: https://chromium-review.googlesource.com/568025 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#485954}
-
John Abd-El-Malek authored
TBR=yzshen@chromium.org NOTRY=true Change-Id: I05de50a37e9b258d80c9927d9d3ab893afe105a3 Reviewed-on: https://chromium-review.googlesource.com/566897Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#485953}
-
Ian Vollick authored
This is now dead code. Bug: 738644 Change-Id: I4f199067216fa09d94d1ba59d954f2f120d57f78 Reviewed-on: https://chromium-review.googlesource.com/567705Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#485952}
-
Mike Baxley authored
EarlGrey tests are run differently than other iOS targets, so this should be document. Bug: Change-Id: I112108008a85f810b7e96fb0241b1c8277ec9ea9 Reviewed-on: https://chromium-review.googlesource.com/567918Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#485951}
-
aberent authored
Revert of customtabs: Remove unnecessary Context plumbing. (patchset #5 id:80001 of https://codereview.chromium.org/2966193002/ ) Reason for revert: Causing compilation errors in ChromeCustomTabsConnection.java. BUG=741667 Original issue's description: > customtabs: Remove unnecessary Context plumbing. > > Also removes Context -> Application downcasts in callers. > > Review-Url: https://codereview.chromium.org/2966193002 > Cr-Commit-Position: refs/heads/master@{#485909} > Committed: https://chromium.googlesource.com/chromium/src/+/a0d1c1531de988606c0425de933722358985374b TBR=yusufo@chromium.org,yfriedman@chromium.org,lizeb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2976023002 Cr-Commit-Position: refs/heads/master@{#485950}
-
Boris Sazonov authored
Change-Id: I451ee4818035688e5d3d880e0955b0d9ed716269 Reviewed-on: https://chromium-review.googlesource.com/568037Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#485949}
-
Michael Lippautz authored
Bug: Change-Id: I9e206d26a2c11fbf5193170108c8f4354d32fb4e Reviewed-on: https://chromium-review.googlesource.com/567500Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#485948}
-
Alexander Timin authored
Use renderer scheduler policy to throttle background timer queues when the renderer is backgrounded. R=alexclarke@chromium.org Change-Id: Iff6f4b80883f1030b14e9f67345a7df9dd018a63 Reviewed-on: https://chromium-review.googlesource.com/567932Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485947}
-
Scott Nichols authored
- Adding persistence via the keychain to remember secrets. - Hide the checkbox based on host reported capabilities. Change-Id: Ibf18726fd97636bd880395d44d6dc92a54ff1b69 Reviewed-on: https://chromium-review.googlesource.com/565660Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#485946}
-
Sylvain Defresne authored
The named thread API is deprecated in favor of the post_task.h API. Bug: 689520 Change-Id: I8068157d94c0d3dd2fb385dcf74d4fc28444e64d Reviewed-on: https://chromium-review.googlesource.com/548558 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#485945}
-
Mark Pilgrim authored
Within browser/speech code, use BindOnce when posting tasks to check whether speech recognition is allowed. Bug: 714018 Change-Id: Ifa4eb2797601be2736dda1bf1a17ac57e5a34301 Reviewed-on: https://chromium-review.googlesource.com/565762 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485944}
-
yoshiki iguchi authored
Bug: none Change-Id: I5659106f3c8bd6608f4f6f410e3815fa1bed8c71 Reviewed-on: https://chromium-review.googlesource.com/567899Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#485943}
-
bshe authored
non VR content includes: 1. 2D Dialog for external navigation request while in incognito mode 2. external 2D app Bug: 739778, 740742 Change-Id: Idd1de302a1412a1815b6d64fc7db5ac6b8a458ed Reviewed-on: https://chromium-review.googlesource.com/563883Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#485942}
-
Sylvain Defresne authored
The image is shipped as part of the compiled assets catalog and need to be loaded using -imageNamed: instead of by a path. Bug: 738359 Change-Id: Ife467b503a298e3c1811c2ab76a860f780b482ed Reviewed-on: https://chromium-review.googlesource.com/568032 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#485941}
-
Mark Mentovai authored
This reverts commit 4721652f. Reason for revert: https://crbug.com/689762#c12 Original change's description: > Change NetworkSessionConfigurator to process multiple versions from quic_version field > > Bug: 689762 > Change-Id: Ic0de2dacd01158d85318794d05f8f763659d9228 > Reviewed-on: https://chromium-review.googlesource.com/565784 > Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485678} TBR=rch@chromium.org,zhongyi@chromium.org Change-Id: If18efa529febe19aa543eb2b6947434daeed7374 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 689762 Reviewed-on: https://chromium-review.googlesource.com/567283Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#485940}
-
bratell authored
There are multiple Cache types and Response types so when importing one of them into the global namespace you can easily get naming conflicts, especially with jumbo. This renames Cache and Protocol locally to avoid such naming conflicts. Review-Url: https://codereview.chromium.org/2968183002 Cr-Commit-Position: refs/heads/master@{#485939}
-
Mark Mentovai authored
This test is flaky (sometimes crashes) on "Mac10.10 Tests". TBR=tapted@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 741642 Change-Id: I53925b699979d967d3e3aa1df73436dfefdcbd57 Reviewed-on: https://chromium-review.googlesource.com/568100 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#485938}
-
Daniel Hollingshead authored
Merges server changes 161010731, 161020298 by birenroy. Bug: 488484 Change-Id: I81e4cb367e2f2b5627b9d68355ef5a4ac1b1a9e0 Reviewed-on: https://chromium-review.googlesource.com/567386 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485937}
-
bcwhite authored
BUG=728322 Review-Url: https://codereview.chromium.org/2967063002 Cr-Commit-Position: refs/heads/master@{#485936}
-
Ken Rockot authored
Implements lazy serialization in the C++ bindings. This means a few things: - Every bindings endpoint monitors the remoteness of its peer endpoint - Bindings endpoints prefer serialized messages only when their peer appears to be remote - Generated C++ bindings will use an unserialized message context to capture and carry message parameters when sending on an endpoint that does not prefer serialized messages - Unserialized message contexts will serialize a bindings message if coerced to do so, either by an explicit call to Message::SerializeIfNecessary or by Mojo internals when the message needs to be routed out-of-process Because support for lazy serialization incurs a significant code size cost, individual mojom GN targets must opt into support by setting |support_lazy_serialization| to true. This is turned on for ipc_perftests test interfaces as well as mojo_public_bindings_unittests test interfaces, and is used to ensure sufficient test coverage for all message construction and dispatching code paths. BUG=725321 TBR=yhirano@chromium.orf Change-Id: I85197b74a87bcf9fc9ff14b4c787c7eabc897829 Reviewed-on: https://chromium-review.googlesource.com/562180 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485935}
-
Parastoo Geranmayeh authored
This could avoid a potential crash. Bug: 741054 Change-Id: I7f606d0edc3741b05b73f678f7a2e28c343852f4 Reviewed-on: https://chromium-review.googlesource.com/567463Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#485934}
-
gambard authored
Prefetching allows the collection view to get cells configured by the item before it is visible. The item will not reconfigure the cell for this display. If the CollectionViewController tries to reconfigure the items associated with this cell in the moment between the prefetching and the time the cell is visible, the reconfigure will do nothing. In ContentSuggestions this problem was encounter for the display of the articles' images. Bug: 740572 Change-Id: I99c1bd2a95159d22512494961b3fb1ad935ad998 Reviewed-on: https://chromium-review.googlesource.com/567924Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#485933}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c835897..c9a1f8e8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: If8b8c9f4446feecba97e43fa9f1c5c7078ea448a Reviewed-on: https://chromium-review.googlesource.com/567635Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485932}
-
Pavel Feldman authored
Change-Id: I4f926faa964b9eded1ec4ea9a19058c30de05de0 Reviewed-on: https://chromium-review.googlesource.com/564303 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485931}
-
Mark Mentovai authored
This reverts commit 164f881f. Reason for revert: https://build.chromium.org/p/chromium/builders/Android/builds/74079 Original change's description: >
📺 Use video aspect ratio to determine PiP params. > > Use the bounds of the fullscreen video to determine the starting > bounds for the PiP transformation and the aspect ratio of the PiP > window. > > Change-Id: Ia2227c9d277b5ae2a1dedddb899082e2947137fe > Reviewed-on: https://chromium-review.googlesource.com/536974 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485916} TBR=bauerb@chromium.org,mlamouri@chromium.org,peconn@chromium.org,jochen@chromium.org Change-Id: I972cec53d7937ec9c210832677ff79cc80bef2fe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/567273Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#485930}
-
Peter Conn authored
This reverts commit 164f881f. Reason for revert: Caused a failure https://build.chromium.org/p/chromium/builders/Android/builds/74079 Original change's description: >
📺 Use video aspect ratio to determine PiP params. > > Use the bounds of the fullscreen video to determine the starting > bounds for the PiP transformation and the aspect ratio of the PiP > window. > > Change-Id: Ia2227c9d277b5ae2a1dedddb899082e2947137fe > Reviewed-on: https://chromium-review.googlesource.com/536974 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485916} TBR=bauerb@chromium.org,mlamouri@chromium.org,peconn@chromium.org,jochen@chromium.org Change-Id: I91b3e716c02bd5c41cf93d3fde04e0874d26d3e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/566865Reviewed-by:Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#485929}
-
Stepan Khapugin authored
This reverts commit 54275e80. Reason for revert: breaks ios_showcase_egtests downstream. Failure details: https://paste.googleplex.com/6470224534568960 - fails on all simulator bots. Original change's description: > [ios showcase] Removes ios/web dependency. > > Showcase is intended to be a standalone UI app and as such should not reference > //ios/web or //ios/chrome. This CL eliminates the Showcase app creating an IOSChromeMain > instance and thus implicitly being an //ios/web embedder, instead directly inlining the > minimal parts of that startup that are needed (initializing base::CommandLine and loading resources). > > As part of that change, this CL eliminates Showcase bundling //ios/web resources. > > Bug: 738880 > Change-Id: I0a3d3494838cc588034feb48443d24ddf1bec03a > Reviewed-on: https://chromium-review.googlesource.com/565453 > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Louis Romero <lpromero@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485815} TBR=blundell@chromium.org,lpromero@chromium.org,sczs@chromium.org Change-Id: I8f2daeb1adeabe4622e312b5bc1d70a5591bd68e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 738880 Reviewed-on: https://chromium-review.googlesource.com/566864Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485928}
-
Koji Ishii authored
Following bot results are included. 723 724 728 884 lines were removed by consecutive passes since 643 (Jul 6), excluding the bot troubles yesterday (701-711). This should undo all additions during the bot troubles. TBR=eae@chromium.org NOTRY=true BUG: 591099 Change-Id: I5c62411bf0a3b32a5c1c95fc94c2d0c5dd3a6d10 Reviewed-on: https://chromium-review.googlesource.com/567939 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#485927}
-
Julien Brianceau authored
Bug: none Change-Id: Iba0bacce5bd0baf9079bab9a8ce0e2bb4f884fca Reviewed-on: https://chromium-review.googlesource.com/565405Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485926}
-
Anita Woodruff authored
Bug: 532989 Change-Id: I2295d05c59e24f8ae36d763a38c65188b2495675 Reviewed-on: https://chromium-review.googlesource.com/559047 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#485925}
-
Vadym Doroshenko authored
Bug:657041 Change-Id: Idafd23621f458dfd73757899bca952f470f31767 Reviewed-on: https://chromium-review.googlesource.com/563299 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#485924}
-