- 06 Nov, 2020 23 commits
-
-
Collin Baker authored
The original GetSlotIndexForTabModelIndex served two purposes: getting the slot for an existing tab, and getting the insertion index for a new slot. This splits it into separate methods with common logic remaining in a shared method. The logic had a bug when requesting the first tab of a group while tabs just before it are animating closed. This bug is fixed. To help debug the associated crash, CHECKs are added. Bug: 1138748 Change-Id: I6e0d797bb70e9aa1da813dbf1fecf228290e55b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515363 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#824672}
-
Toni Barzic authored
AppUninstallDialog::InitializeCheckbox gets the app URL domain, and changes the first domain character to upper-case, assuming that the domain is non-empty. This may not be case if the app URL is an IP address. BUG=1084451 Change-Id: I5c43ff22fa3474a1c0ff0bcf79afd53de9beb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521043Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824671}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iab9bae069e1badd18d6a17d48ac921a564e3094f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824670}
-
Yicheng Li authored
When clicked, the help button will open a help article in a new browser window, so that it's on top of the dialog but the user can return to the dialog. Bug: b:156258540, b:144861739 Change-Id: I1ff8f49e9926ed57f27f2eaca307d5180d574091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518442 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824669}
-
Ilya Sherman authored
* Histograms measuring frequencies should typically include context via some baseline event as a comparison point. * Clean up the docs around directly measuring what you want and around naming. R=mpearson@chromium.org Bug: None Change-Id: Id6250c37a2ec499f38ae148bc1daa1a3c451a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462373 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824668}
-
Tommy Martino authored
Greatly improves robustness of fragment generation Bug: 1136043 Change-Id: Ic424fc2548bc773c049e973c967d0152489ff765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521104 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#824667}
-
Sinan Sahin authored
Tbr: majidvp Bug: 1146218 Change-Id: Ieef5a89bc717ab4814c4ddbdba8cd11b47ba4df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522400Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#824666}
-
Peter Boström authored
Adds reference to chromium-chrome-browser-ui-views-reviews@google.com as a preference to individual reviewers. Bug: None Change-Id: I5bae9a9806315105ba389d651b78da303548cc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522495 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#824665}
-
Charlene Yan authored
Change-Id: I7cef19d51a8760ecf3ecf9c37b826adb94bc890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522410 Auto-Submit: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#824664}
-
Erik Chen authored
This provides EMEA time-zone coverage for lacros/crosapi changes. Change-Id: Ie987fb3aec72aeb30d43ba09631c1fd84b42b93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521870Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824663}
-
Chris Thompson authored
This changes the units from "seconds" to "ms", since the underlying histogram time functions log TimeDelta data in milliseconds. This doesn't affect the logged data, only how it displays on the dashboard, so we don' t need to create a new histogram for this and can just update the unit. Change-Id: I8df03c321e2c9f92aa0f47750715ab3e22ef234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522331 Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#824662}
-
Tom Anderson authored
This allows us to see which calls are blocking within the context of chrome://tracing. BUG=None R=sky Change-Id: I576657f4cba0f978c025202f0f10c7ac6bcc374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522311 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#824661}
-
Tommy Li authored
Bug: 1069833 Change-Id: I8e2dee39bc3dd7b9ce75f900deb9d11fbc458358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519369Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824660}
-
Roberto Moura authored
Create a plus sign button that sticks to right of the thumb strip. It has a plus sign and a transparency gradient and is shown when the plus sign cell is not visible. This is done so that the user can open a new tab even if they haven't scrolled to the end of the collection view. When the user scrolls the collection view or when the toolbars are shown, check whether the user has scrolled past the end of the scroll view and, if so, hide the plus sign button. Show it otherwise. Rename one of the LayoutSwitcherStates from "Full" to "Grid". Add the constats that specify the new thumb strip plus sign button's dimensions to the grid constants file. Add a |didChangeLastItemVisibility| method to the grid view controller delegate. Create a CGFloat property |fractionVisibleOflastItem| inside the grid view controller, which indicates the visibility fraction of the last item. Only call |didChangeLastItemVisibility| on the delegate if the value of |fractionVisibleOflastItem| changes. Bug: 1094335 Change-Id: I056d6d0ece4eb22f84e4904208bd0e83d9b93389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485167 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824659}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I8c32c28d7a5519f5232a99b023b8667167d21ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521780Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5689d6741bc4..e3fee63a19d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9cb176a364d8ebcebd9486556e0cccfd98df631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522118Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ce0db01e081f..9abc1e30cfe5 2020-11-05 medinaandres@google.com [application_agent test] Updated use of protos If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1144985 Tbr: jophba@chromium.org Change-Id: If64cb8b9e9e6b16416819c23a739a6d3083e9f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522354Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604545021-6b268e7944932acdec58448c2452d297c1502b9f.profdata to chrome-win64-master-1604588329-37596c07bf301a8ab7d867a3b0140d934526b155.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0fbc8beaea6a7996fa752d9eaaf9d95e19402c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521217Reviewed-by:
-
kylechar authored
There are occasional crashes accessing an empty |overdraw_surface_recorder_|. Even if |show_overdraw_feedback| is true creation of the recorded can fail, so using that bool to guard access isn't correct. Check if the recorded exists before accessing it instead. Also unconditionally reset |nway_canvas_| since it can be created even if recorder creation fails. Bug: 1143631 Change-Id: Ie00eeb11d84eedd589f7d99e62bbb80ab3d16bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521050 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#824654}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I155f31760ea0c25daaecbd5aff45847ca610fcd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522358Reviewed-by:
-
Dominic Farolino authored
R=haraken@chromium.org, kouhei@chromium.org, nasko@chromium.org, talp@chromium.org Bug: N/A Change-Id: I2e9f819e501b57e4e2b2aa1de324ede3a039dd6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519216Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#824652}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/368dd750..7c6f3c70 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d9198da5593ba126b559dcde29f5381168239e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522215Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824651}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6834b901326..aafe840ca245 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141633 Tbr: xialinyan@google.com Change-Id: Ic4ad06ddbf3d204c59b40dc9ddeb9a76c48ea07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824650}
-
- 05 Nov, 2020 17 commits
-
-
Livvie Lin authored
Change-Id: I9250f5ced9e91be0d3ae158558bdfde4f8b54ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508196 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#824649}
-
sczs authored
** Manual roll since autoroller is not working (https://crbug.com/1144638)** Roll src/ios/third_party/material_components_ios/src/ d4e0da5ce..67e70a63c (1 commit) https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/d4e0da5ce430..67e70a63c9fe $ git log d4e0da5ce..67e70a63c --date=short --no-merges --format='%ad %ae %s' 2020-11-05 andrewoverton [Tabs] Fallback to scrollable when scrollableCentered is set and VoiceOver is running Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: I3b2ecbf5631a90d3482d9ba257f1d0ad28bf9181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521300Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#824648}
-
Chris Lu authored
This change adds setup for a client-driven experiment that buckets users on First Run into 3 groups, two experiment and one control. Bug: 1138603 Change-Id: I7c100d173ea2d64e718950047d0c2f04ff4c3fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506749 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824647}
-
Johannes Kron authored
The current low-latency rendering runs without any renderer algorithm. This gives a very low latency at the cost of dropping frames in an uncontrolled way. The goal of the low-latency renderer algorithm is to add a small amount of latency to reduce number of dropped frames. We're especially interested in reducing the number of consecutively dropped frames since these are more noticeable than a single dropped frame. The low-latency renderer algorithm is enabled from WebRTC by setting the metadata field maximum_composition_delay_in_frames. This is an experimental feature that is active if and only if the RTP header extension playout-delay is set to min=0ms and max>0ms. The feature can be completely disabled by specifying the field trial WebRTC-LowLatencyRenderer/enabled:false/ Bug: 1138888 Change-Id: Ia59db56b115f2cb6e8348e115781f8ad0c33eedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502343Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#824646}
-
Shawn Quereshi authored
This is a reland of 02cc2edd Original change's description: > [cast_bindings] Tests for MessagePort abstraction. > > Test coverage for public MessagePort interface and its interactions with > MessagePort::Receiver. Includes conversion to and from the underlying > platform type of MessagePortCast or MessagePortFuchsia. > > Bug: 1135377 > Test: //components/cast/message_port:message_port_test added > Change-Id: I5e51aa5e08eb1e3e8957963b033497a94fe0bdac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515208 > Commit-Queue: Shawn Quereshi <shawnq@google.com> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824126} Bug: 1135377 Change-Id: Ifb49217d8d10a0e2903f132661c138978fb97b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521890 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824645}
-
Alexey Baskakov authored
Also remove extensions_web_apps_ provider. This CL introduces no behavior changes. In next CL: Clean up ExtensionApps class as if it manages kExtension apps only. Bug: 1065748 Change-Id: Ibb2a41db9d0ed23ff4d5d572298dc29a02515077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520476Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b503f5ff6b58..22775d8e1755 2020-11-05 mattkot@microsoft.com Retry CIPD client download on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1145741 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ia07bd7a75deb96514c4ced95f81f89bf5fe085a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521999Reviewed-by:
-
Michael Checo authored
- Update css variables to conform to responsiveness specs at different breakpoints. Spec: https://carbon.googleplex.com/cros-ux/pages/scanning/responsiveness Screenshots: 600px <= width < 768px: http://shortn/_jbKNxJrAMB 768px <= width < 960px: http://shortn/_Jy9QYyvf63 1280px: http://shortn/_ARoXo5FcD4 Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I30390bde40f0a2bb033f30e7b12b92aea8669239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514660Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#824642}
-
Caroline Rising authored
Screenshot can be found in bug. Bug: 1146024 Change-Id: If5d7977068051b8c96e4c36104655580d6bde29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510410Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#824641}
-
Xiaocheng Hu authored
Before we implemented @scroll-timeline, the parser would convert a "@scroll-timeline" into CSSAtRuleInvalid, and then go through the ConsumeErroneousAtRule() code path. Now even with the flag disabled, we still parse "@scroll-timeline" into CSSAtRuleScrollTimeline and then go through the ConsumeScrollTimeline() code path and fail inside. This patch parses "@scroll-timeline" into CSSAtRuleInvalid() so that the when the flag is disabled, parser behavior is exactly the same as if we haven't implemented it at all. Change-Id: Ib83bbc19fe2715f52d10a9ce5d351670dcb8bd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522050 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#824640}
-
Xiaocheng Hu authored
This patch adds a Chromium feature for CSSKeyframesMemoryReduction and enables it in field trial testing config. This is preparation for a Canary/Dev finch experiment. Bug: 1141814 Change-Id: I03c1c9beca18bdf4b286704f60b6895f60835d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518097Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#824639}
-
David Bienvenu authored
Bug: 1007808 Change-Id: Icc6949f3d34dfea6c23f8494de05be38d72d739a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518091Reviewed-by:
-
Jihwan Marc Kim authored
Rename is_source_touch_event_set_non_blocking to is_source_touch_event_set_blocking Bug: 849420 Change-Id: I216b9103ca29f11f041503a9746d2cf69bf0c1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489775Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Intent-to-ship here: https://groups.google.com/a/chromium.org/g/blink-dev/c/cubTsTuZWEY Bug: 1008483 Change-Id: Ib66bb7f3dcfc79bbc8b01216a8f772cb6a33b0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518106Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#824636}
-
Natalie Chouinard authored
Add new ChromeStartupDelegate and initialize on startup. Bug: 1143402 Change-Id: If30d0119782e2eec9b24642555ca9536913c6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521349 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#824635}
-
Peter Kasting authored
Bug: 772945 Change-Id: I26f5f4ebd83765c9603e23abab69e9fe890ac209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519362 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Christoph Schwering authored
The features are not subject to an active experiment. * AutofillEnforceMinRequiredFieldsForHeuristics is enabled. * AutofillEnforceMinRequiredFieldsForQuery is disabled. * AutofillEnforceMinRequiredFieldsForUpload is disabled. Bug: 1007974 Change-Id: I17c634d07f5e7b69fbf16708fe89cbe81d2ee617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411937Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#824633}
-
