GitLab

NGMappingUnitsRange does nothing but a base::span<>. So this patch
replaces it with base::span<> to reduce unnecessary code.

Change-Id: I5bafa4b26cb7539876096cd89e31d10f00f393c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642160
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666107}

- Made the "Settings" menu text a level 1 heading for screen readers
  to meet WCAG 1.3.1 Info and Relationships success criteria.
  See: https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships

- Added an axe-core accessibility test for the settings menu.

Screenshot: https://i.imgur.com/yhUG2D7.png

Bug: 963183
Change-Id: I0063aa33e99dedfdefb94e14905ed833cfc5fcb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618279Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: John Emau <johnemau@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#666106}

Cleans up all remaining TODOs pointing to 926048, which covers adding
WMR support to the XR browser tests. Specifically, this properly
implements controller and pointer poses using the data provided by
the test instead of using hard coded values.

Bug: 926048
Change-Id: I014781127e8d7e5151a1766ad2a8d28761140ecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642960Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666105}

We are not supposed to call FrozenNativePage.getView().
This is no-op in Release build.

Bug: 952331
Change-Id: I10fe58f1daaaa4f5b42c913a8c0cbd6685441ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643071Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666104}

In order to move off of the browser IO thread this CL replaces a number
of thread API usage with sequence APIs instead.

Bug: 960012
Change-Id: I8f66c05c53dad55fcbe3347b4fbb1f49b8f0e6d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643668Reviewed-by: Staphany Park <staphany@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666103}

And don't pool QUIC requests with different NetworkIsolationKeys when
kPartitionConnectionsByNetworkIsolationKey is enabled.

BUG=963480

Change-Id: I41a3bf3f4f0a24a5bfc264de46fc28e1f880d46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629227
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666102}

Add addVirtualAuthenticator and removeVirtualAuthenticator to the
WebAuthn Devtools Domain. Patch VirtualFidoDevice so that it no longer
hardcodes the transport declared on attestation, this makes testing
different authenticators easier.

This is one in a series of patches intended to create a Testing API for
WebAuthn, for use in Web Platform Tests and by external webauthn tests.

For an overview of overall design, please see
https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing

Bug: 922572
Change-Id: Ib606a265576b8059d3a347c63b26a30574136538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636828
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666101}

- Updates label of the PPD file selection for advanced printer dialog
  and for edit printer dialog.
- Learn More link will be updated to point to correct URL.

Bug: 939899
Test: End to End manual
Change-Id: Ie759ae625263ce5f758d3a045b72e1565efeec6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636396Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666100}

TBR=meacer@chromium.org

Change-Id: I8107a1e11daa2b939386c5dc92e2c20ff383b029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644302Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666099}

TBR=mlamouri@chromium.org

Bug: 970866
Change-Id: Ib8911bc25d886d5771ee7b80c9fbc91202a05b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644164Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666098}

TBR=ahemery@chromium.org

Bug: 970841
Change-Id: Ib51b648e2fd09251b058b943d49b8458727c4800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644015Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666097}

The Abort operation is triggered by the RP, and returns the AbortError.
The current error massage for AbortError is "The user aborted a
request.". The change makes the AbortError massage as
"The Rely Party aborted a request."

Bug: n/a
Change-Id: Iea3991f930ba039d05ec7279aa4b3191303c836f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642685Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Suzy Li <suzyli@google.com>
Cr-Commit-Position: refs/heads/master@{#666096}

I'm planning to remove protocol::Serializable::serialize(bool),
removing the ability there to make a ProtocolMessage
that carries JSON. This is the last usage of such messages
in both Chromium and V8; so I've put a bit of conversion
boilerplate code which is borrowed from
content/browser/devtools/devtools_protocol_encoding.cc.
Sadly it's longer, but it is a price to pay for simplifying
the API. Thanks much for considering.

Change-Id: I24a01e1ed6134f58fa65f03d29506afa33a7ff01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641551
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666095}

Sets event policy to None on all transient ancestors to match behaviour
of main window.

TBR=afakhry@chromium.org

Test: ash_unittests ScopedOverviewTransformWindowTest.EventTargetingPolicy
Bug: 963394
Change-Id: Ic4b2f67648a2582d677d989aeda1e83b235e9d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643349Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666094}

This CL moves part of the code from registerPaint into a new API
in PaintWorklet. The reason is that these code are working on a
member that is in the PaintWorklet class, so it really should belong
to the PaintWorklet class.

Bug: None
Change-Id: If8c0eb0390d8c64d2fedb48a1a337e6981c11f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644007Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666093}

This flag specifies whether to target the platform's copy of the HWASan
runtime, rather than one bundled with the application.

I decided to make this a build flag rather than change the default because
there are use cases for both settings.

- Builds with hwasan_platform=true may only be used on HWASANified builds of
  the platform.
- Builds with hwasan_platform=false are only expected to work on
  non-HWSANified builds of the platform. They may work in HWASANified builds,
  but this is not guaranteed because the compiler is allowed to target the
  bundled runtime library which may have a different ABI to the platform's
  copy.

Moreover, hwasan_platform=false requires the compiler to emit additional
code into each function which can hurt performance and binary size.

Bug: 916828
Change-Id: I45c9ccdc0a5cf1b3c6a729263204a023b40ba15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642787
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666092}

This also adds extra scenarios.
* Resizing with overview on the other side.
* touch event

I also found the scenario that splitview controller can be
called recursively during shutdown, which is fixed by the change
in SplitViewController

Bug: None
Change-Id: I293ed17bba4961d338ac0f9a389f42f8f233d4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637244
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666091}

Bug: 969891
Change-Id: Ic6a0d8b7428b7a474c8e3044ca8a8aa2d1de20b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641990Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666090}

Current the RegisterMainThreadDocumentPaintDefinition is taking a
std::unique_ptr<Vector<CSSSyntaxDescriptor>> because the
CrossThreadCopier doesn't yet know how to handle a Vectof of
CSSSyntaxDescriptor.

This CL adds a CrossThreadCopier template in the css_syntax_descriptor.h
so that we no longer need to wrap the Vector<CSSSyntaxDescriptor> into
a std::unique_ptr. We add this template in the specific header file
such that it won't pollute the cross_thread_copier.h.

This CL does not change behavior.

Bug: None
Change-Id: Idcad4f578f44605cf535598713e3c03c5035b7aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642957Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666089}

Bug: 922813
Change-Id: I9017954c687da3323127dd93b9afe63bfa9ee57b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643497
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666088}

OtaActivator objects are meant to be single-use with a single binding,
so there was never a need to use a BindingSet here.

Bug: 961084
Change-Id: I4b60cc7c556faed5acaec80a211aae1f22cf117d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641549Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666087}

Change-Id: I7714480b1369877a8164f57c22ab7bd43c9feb3a
Bug: 945963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639742
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666086}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c48f24c7f88..71c6bc07e67f


git log 2c48f24c7f88..71c6bc07e67f --date=short --no-merges --format='%ad %ae %s'
2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@71c6bc07e67f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I4094fb46b4c81724733d3a603acd2db7dc0505d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643904Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666085}

Add a localization concatenation check to the presubmit script that issues
an error when a disallowed concatenation is found. Concatenation to a
localizable string is only allowed when it's a string that doesn't
contain letters.

* Example (allowed): ls`Status code` + ': '
* Example (disallowed): ls`Status code: ` + statusCode
* Example (disallowed): ls`Status ` + 'code'

I also fixed the current violations.

Bug: 941561

Change-Id: I428a174f00ad4567a280756b13cfb44bc317d75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637146Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#666084}

Some gpu bugs are related to the monitor refresh rate. Adding this display
information will help us on gpu debugging.

Bug: 964095
Change-Id: I4756a2f4f58383e966e3bbc73bfb2f6a858d690b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629761
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666083}

Non-renderer child processes must acquire interfaces from the global
system service instance; this is also true for many interfaces acquired
by renderers, and r660952 made the assumption that interfaces exposed to
all types of child processes were handled by shared code common to all
process host types.

However, the way CallStackProfileCollector is exposed specifically,
renderer processes must still acquire it from a browser service
instance. This restores that behavior.

Bug: 969742
Change-Id: Ib864b9220d73014b45a89cb92acc000766b606e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641548Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#666082}

Bug: 749276
Change-Id: I90a2e189371aae200b1271d8effb70b0ed66ba31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629694
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666081}

When overview, splitview and applist are active at the same time,
fallthrough to app list to handle the key events. Otherwise, it should
still be overview to handle the key events.

Bug: 970052, 969899
Change-Id: Ic090a5bc06aeb88ee286bfc35434cd19749e0221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642740Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666080}

The feature_engagement component has a public API that requires clients
to add some configuration and boilerplate code within the component
itself, such as the base::Feature, and chrome://flags configuration.

This leads to clients having to add an additional reviewer without
necessarily adding value to the review process. twellington@ has for a
long time reviewed many such changes, but has lacked the ability to sign
off on the feature_engagement parts, even though they are well aware of
the requirements and typical usage patterns.

This CL therefore adds twellington@ as an OWNER for the relevant files
that clients typically have to edit.

Bug: None
Change-Id: Ibabef70bbe21c089d9a3a6043d2362edc7fb20ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642745Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666079}

This is in preparation of removing the custom cr.EventTarget
implementation in favor of native EventTarget.

Bug: 854268
Change-Id: I8f2b7ee6b3e3d9a4b409f82ddde22929d5b02754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642756
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666078}

TBR=arthursonzogni@chromium.org

Bug: 970815
Change-Id: Ief201ab09e9d9ef873b46aa7640eccb18e3b3d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642743Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666077}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9672bf6d..10dea84f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I060b83a9216ece83b9843709bdc5743864a116ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643838Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666076}

As part of the kernel uprev process devices may receive kernel support
for VMs. In these situations it would be nice to allow the user to
enable Crostini. However, while the kernel is in its experimental
rollout phase for a given device there is no guarantee the kernel won't
be reverted to a version without VM support. As a compromise, let's
still allow users to enable Crostini when supported, but guard it behind
an experiment flag so users are forced to acknowledge the possibility of
data loss.

BUG=b:133833983
TEST=start chrome with --kernelnext-restrict-vms, verify crostini is not
available. Enable enable-experimental-kernel-vm-support flag and verify
crostini is available.

Change-Id: If5727122e5d76f1a674ae96964d5eb6587eb5bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639726
Commit-Queue: Jon Flatley <jflat@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666075}

These metrics currently use swap time which is the time the compositor
sends compositor frame to the display compositor. This CL changes the
metrics to use presentation time which is the time pixels actually
appear on screen, according to gpu.

BUG=899847

Change-Id: I5981fbc88a2cabebd5f4109e26f7e4cb152ea3fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598212Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666074}

In this template, we defined MediaValuesCached::MediaValuesCachedData to
be Type, so after that definition, we should just use Type instead of
MediaValuesCached::MediaValuesCachedData.

This CL does not introduce behavior change.

Bug: None
Change-Id: I7337cf2a1d87aeecc8ff1048e1a666753b0166c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643887Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666073}

I'm leaving Chrome and am transferring my Android Selection ownership
to Shimi.

Change-Id: I9dd6aa1d5837ce8bd17d1bbaa9bdb750bb1bef6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644378Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666072}

This got missed in crrev.com/c/1637611

TBR=dcheng@chromium.org

Bug: 850669
Change-Id: I0ef7db0eaa9d8e6de64786278d57a92bf91a689f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639818
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666071}

This patch removes the special casing code that converts card network
payment methods to "basic-card" in the Android implementation of
Payment Request.

With this patch, requests that use a card network as a supported
payment method will be rejected as unsupported payment methods. Tests
are updated to reflect this new expectation.

This deprecation has been approved for M64, but was never implemented.
Intent to deprecate:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/1udpnrlQK4Q/ot_E-htQAQAJ

A Blink counter was added to count actual usage of card network as
payment method in the wild. This is now practically 0.
See "PaymentRequestNetworkNameInSupportedMethods" in the histogram:
https://uma.googleplex.com/p/chrome/histograms?endDate=20190525&dayCount=7&histograms=Blink.UseCounter.Features&fixupData=true&showMax=true&filters=channel%2CEQ%2C4%2Cisofficial%2CEQ%2CTrue&implicitFilters=isofficial

Bug: 719526
Change-Id: Iad1e44039628f7fd64c71871b1643776a21dd257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640778Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666070}

No behavior change, removing an un-necessary blank line only.

TBR=andruud@chromium.org

Bug: None
Change-Id: I378f66e0df75016b1d9848fe55ea8325d84e3556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643889
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666069}

No change to production, only tests.

This aims to modify cookie expiration-related logic in tests, in a way
which is more obviously consistent with expectations:

* Cookies cannot be set with millisecond-level precision, so remove
  makeExpiringCookieMs().
* Use "Max-Age" directive instead of "Expires" directive. This ensures
  the expiration time is relative to when the cookie is set, rather than
  when "new Date()" was invoked, reducing opportunity for races.
* Named constants for cookie lifetimes, to clarify meaning.

Bug: 969912
Test: run_webview_instrumentation_test_apk --enable-features=NetworkService,NetworkServiceInProcess -f CookieManagerTest#*
Cq-Include-Trybots: luci.chromium.try:android_mojo
Change-Id: Ie2da4b4f92ec4bf8b26c6fc3b70d3086a7ba57b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636181Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666068}