- 14 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5135af05fe14..1169b2e38c9b 2021-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibfd2e927e9575abe7ee0dbfd424b7a6a451a80f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627819Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843407}
-
Oriol Brufau authored
CompositeEditCommand::MoveParagraphs has a start and end positions, and constrains them with Most{Forward,Backward}CaretPosition. The problem was that the resulting positions could end up reversed, triggering a CHECK failure in CreateMarkup. This patch changes CompositeEditCommand::MoveParagraphs so that it only attempts to contrain the positions if they are different, and also changes MostBackwardOrForwardCaretPosition to ensure that the shadow- adjusted candidate is not further from the initial position than the non-adjusted candidate. Bug: 1165325 TEST=CompositeEditCommandTest.MoveParagraphContentsToNewBlockWithUAShadowDOM TEST=SelectionAdjusterTest.AdjustSelectionTypeWithShadow TEST=VisibleSelectionTest.ShadowCrossing TEST=VisibleSelectionTest.ShadowNested Change-Id: Ib52ed472809e15aa551fdfc4ed1fa2323433d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627368 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843406}
-
Joe DeBlasio authored
This CL updates Chrome to use a newer variant of the report proto. It does not change any logic in Chrome otherwise. In particular, the updated proto supports submitting SCTs for multiple certificates at once. This CL does not change Chrome logic to aggregate across reports. As a result, every report has exactly one certificate report in it. Bug: b/175493719 Change-Id: I3586998f04846509a589b7f09fa65fe949a8e4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588811Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#843405}
-
Yoshifumi Inoue authored
This patch changes |LayoutBlock::PositionForBox()| to return null position if |LayoutBlock| is anonymous for avoiding call |Position::FirstPositionInOrBeforeNode()| with null position. Note: |LayoutBlock::PositionForBox()| is used only for legacy layout. Note: I don't have the test case to reproduce because ClusterFuzz's test case is too huge (large than 1MB) to reduce. Bug: 1157993 Change-Id: Ief106d22bb6c29620182fbb9a4f5fe84919879c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626820 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843404}
-
Miyoung Shin authored
This CL updates RemoteObjectImpl#close() to unreference the object from the registry for the case that RemoteObject outlives RemoteObjectHost. Bug: 1105937 Change-Id: I74f91d0267ade082fc4ecce350bab448c3b37560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567022Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#843403}
-
Peter Kotwicz authored
The motivation for the migration is that FragmentStatePagerAdapter is deprecated. BUG=1162839 Change-Id: I600ef392633b9c75cf1b11a6e56a862a685f7c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611949 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843402}
-
David Bertoni authored
Prior to this CL, the default was that test extensions were loaded with file access enabled. This is not necessary, and doesn't reflect the real world, where most APIs work without needing file access. With this CL, the default is that a test must explicitly request file access for the extension. To reflect this, some member functions have been renamed and their behavior modified so that it's clear that the test is requesting file access. This also fixes the PermissionsApiTest.OptionalPermissionsFileAccess test, which had incorrect embedded extension IDs. Bug: 1163548 Change-Id: Ib0f80b0448f49628488074082bfd54486dde3aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613306Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843401}
-
Tommy Li authored
Some users have their DSE set to an autogenerated TemplateURL created as the user browses (via OpenSearch). Those engines are automatically deleted when the corresponding History entry is deleted. This code protects those DSEs from removal. This was part of the CanReplace() clause in M88 and before, so we regressed this in M89. This CL fixes the regression and adds a test to prevent future regression. BUG=1166372 Change-Id: I448d053b7dcfc38343f2d82e5c86df8c5e168d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628045 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843400}
-
Kuo Jen Wei authored
The calculation of default window size is based on fixing width to 764px in all preview aspect ratio cases(3:4, 4:3, 9:16, 16:9) and deriving height from that fixed width so that after preserve space for left, right, bottom icons(--xxx-line*2), the |#preview-box| can fit in preview aspect ratio as close as possible. After these, the new default window size under different preview aspect ratio will be: 3:4 -> 764x888; 4:3 -> 764x552; 9:16 -> 764x1144; 16:9 -> 764x444. Also change the minimal window width x height to 486 x 444 accordingly. Bug: b/175324385 Test: Manually verify default window size under 3:4, 4:3, 9:16, 16:9 preview. Change-Id: Ic4c569819f29b813029f478e6920f66453ab4792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615730Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#843399}
-
Solomon Kinard authored
The key |use_dynamic_url| is a valid key to the exclusion of |matches| or |extension_ids| only if it's set to true. Otherwise one of the latter two keys must be present. Prior to this change, a false value set for the former would have acted as a wildcard for the latter two keys. Bug: 1133624 Change-Id: Ic37253a5931968fc57284ecb7068d032f0bfac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612484 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
-
Harvey Yang authored
The flag indicates if IIO Service is running in ChromeOS, which determines sensor clients to use Mojo implementations or not. BUG=b:173485266, b:168434557, b:172414302 Change-Id: Ib89dea49b03671e9ba36f19720c30e6035521731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624327 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843397}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c593077f725b..5135af05fe14 2021-01-14 cjamcl@chromium.org Fix Lighthouse locale fetching. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131516 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib0ce99d3d3a6351e4ccd3733e1e0e1c7fab65207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628572Reviewed-by:
-
Mark Pearson authored
It's flaky. I can't figure out how to mark it as flaky using this test harness, so disabling instead. BUG=1166314 Change-Id: I744540f637ec527dc33acf7d96190fd9a89e5914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626415 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#843395}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8ba0a01d1e59..6f833b7f78c9 2021-01-14 hao.x.li@intel.com Add internal compute pipeline in ResolveQuerySet for Timestamp Query 2021-01-14 enga@chromium.org dawn_wire: Skip device inject error if the client drops the device 2021-01-13 bclayton@google.com ShaderModule: Include extra information in shader errors 2021-01-13 bajones@chromium.org Enabled BindGroupLayout deprecation warning and fixed tests it broke. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ib1d6bf38eb17951aed647b2c0f998c99a8cd0152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628582Reviewed-by:
-
Hirokazu Honda authored
The hardware video decoder outputs color artifacts with av1 film grain streams. We deny av1 film grain streams so that software decoders are instead used for them. Bug: b:176927551 Test: No artifacts with film grain streams (i.e. software decoders are used) on volteer Change-Id: I85eceb0a82ee6e021943194d2429c1c6be87fe4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615723 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843393}
-
sczs authored
- Sets the NTPViewController to the ntp_home_mediator so it can save/load the Feed scrolling offset for the refactored feed. - Adds setContentOffset to ntp_view_controller to set the offset to the saved value. Bug: 1114792 Change-Id: Ib4256a3cb4d65a8e7e6e6f00ec017a13a1447250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628316 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#843392}
-
Austin Sullivan authored
PermssionContext -> PermissionContext Bug: N/A Change-Id: I2934e259a7c5640998ed702e2ac2d09e660958a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618520 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/32f5f4343ba8..703f21e21747 2021-01-14 bpastene@chromium.org Revert "presubmit: Use new API to check for owners approval" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166467 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I277ab8329f5e0d5bbf5b11653e634365aa4b4879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627170Reviewed-by:
-
Kenton Lam authored
The types.js file now just contains typedefs for Closure. There are some constants defined in events.js which are actually used at runtime. Change-Id: Ibe12b78de463785e1a27f613ff6cad54facaa90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626614Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#843389}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f6d4980860b..da4de1dd41b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com,mpearson@google.com Change-Id: I3a31e0918c6eaf015492d47567e99cd6acda018e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628371Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843388}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c4a1bd4553ff..2cc3490759bb 2021-01-13 amaiorano@google.com VulkanBenchmarks: add texture sampling to Triangle benchmarks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3cadc323dededbb3be8203bb027e43e6538c4875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625938Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c79df687e09..198dc345383e 2021-01-13 sunnyps@chromium.org Support importing NV12/P010/P016 D3D textures as EGLImage 2021-01-13 ynovikov@chromium.org Don't build angle_end2end_tests_mac_sources on iOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1116101 Tbr: timvp@google.com Test: Test: D3DTextureYUVTest* Change-Id: I37d409364c0c715b3205aeaa0d534bfe972f82fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628612Reviewed-by:
-
Erik Chen authored
This CL implements the sign() method from the platform_keys_internal extension API. It adds a new Sign() method to the crosapi KeystoreService that simply forwards the call to ash. Change-Id: If696709159d2e8d97afd3133534f325f019344fb Bug: 1164523, 1166105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626086 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#843385}
-
Kenton Lam authored
In preparation for adding webui message handlers, it will be cleaner to have the dialog-related code in a separate file. Change-Id: I926788149d63a512055d1bb1932f60362f6b6172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626811Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
-
Ghazale Hosseinabadi authored
On chrome://extensions/shortcuts, when shortcut is set, a11y announcement is not correct, since it announces "Shortcut is not set". This CL fixes this bug, i.e., when shortcut is set, it announces "Shortcut set", followed by the shortcut. a shortcut, and navigate back to re-read the set shortcut. Bug: 1031007 Test: Enable screenreading, navigate to chrome://extensions/, set Change-Id: Ib128b637222ff3e0f92742781e75d8320edb345a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625749 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This CL changes the owner of ServiceWorkerStorageControlImpl as a preparation for service worker Storage Service migration. In an end state, storage::PartitionImpl will own the instance of ServiceWorkerStorageControlImpl in production and browser tests. In unit tests, an instance of ServiceWorkerStorageControlImpl needs to be hosted somewhere else because content::StoragePartitionImpl (which owns a remote to storage::PartitionImpl) is not available for most unit tests. This CL: * Makes ServiceWorkerContextWrapper own ServiceWorkerStorageControlImpl so that ServiceWorkerRegistry doesn't have to own it. This ownership is tentative and the ownership will be transferred to storage::PartitionImpl in the future. * Makes EmbeddedWorkerTestHelper own ServiceWorkerStorageControlImpl for unit tests. As side effects, this CL: * Moves SimulateStorageRestartForTesting() from ServiceWorkerRegistry to EmbeddedWorkerTestHelper. * Makes ServiceWorkerContextWrapper hold the file path for the database and a reference to QuotaManagerProxy so that ServiceWorkerContextWrapper can create an instance of ServiceWorkerStorageControlImpl as needed. The lifetime of ServiceWorkerStorageControlImpl in ServiceWorkerContextWrapper is almost the same as ServiceWorkerContextCore for now. Bug: 1016064 Change-Id: Ife17ba8122342808cfd9bb3f18ad69524838c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623727 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843382}
-
Yutaka Hirano authored
The traits were needed because of FrameHostMsg_OpenURL which was removed at https://chromium-review.googlesource.com/c/chromium/src/+/2259537. Bug: None Change-Id: I87282de1ff5f4479099291e9ea39f2ee877f1fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626851Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#843381}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.90. R=rmhasan@google.com Bug: 1041619 Change-Id: Id6e03214083a962849d4f523d422928f04af0162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625920 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#843380}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I8057dbe4cf6afff55b7f92cdf3bcb99dfad31380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628000Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843379}
-
WangHui authored
Don't send error callback for request originated from within a service worker since we can't get a |AwContentsClientBridge| based on the |render_frame_id| of the |request_|. Bug:None Signed-off-by:
WangHui <wanghui210@huawei.com> Change-Id: I66172b371b305b7d8ef88f87e1a21d3097d1a5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627528Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843378}
-
Miguel Casas authored
MS Teams on ARM-based ChromeOS with the new VideoDecoder (not launched) tries to create many direct video decoders (I see e.g. 42 on kukui); some succeed but eventually they don't and the tab ends up hitting an OOM. The process is not well understood and needs further debugging. This CL replicates the kMaxNumOfInstances [1] logic from the legacy VideoDecodeAccelerator to the new direct VideoDecoder, so the new behaves like the old, allowing us to unblock the linked bug. [1] https://source.chromium.org/search?q=kMaxNumOfInstances&sq=&ss=chromium%2Fchromium%2Fsrc:media%2Fgpu%2Fv4l2%2F Landing this provision on Kukui was already discussed on . https: //chromium-review.googlesource.com/c/chromium/src/+/2372926/10#message-ca9039b5fb3eb9e1fbcd9701ddc476b257f088d6 Bug: b/170870476 Change-Id: Ice0d9f16e7ca0063c03cccdafe54e29ad5602cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628069 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#843377}
-
Daniel Hosseinian authored
Store the creation and modification dates as base::Time fields in DocumentMetadata. Bug: 93619 Change-Id: I34eedf5cf88dd102e492ed0451d3e4a4a7988cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610626 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843376}
-
Austin Sullivan authored
Refactor chrome/browser/ui Bug: 1110509 Change-Id: I39f7b5c4845890450bd187adf42b8881bdad29b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602577 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Connie Wan authored
Bug: 1106846 Change-Id: Icb8f2ae377e68eef47636bd881947ad0b3e8281d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419755 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
-
Erik Chen authored
This CL refactors the ash implementation of platformKeysInternal.getPublicKey into chromeos::platform_keys. This has no intended behavior change for ash. This CL hooks up the crosapi KeystoreService::GetPublicKey by forwarding to the same chromeos::platform_keys implementation. Change-Id: I19daa05727353c65ca072e365297c0e51f6d8b85 Bug: 1164523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626044Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Austin Sullivan authored
Annotates destructor with "override" - MockFileSystemAccessPermissionContext - MockFileSystemAccessPermissionGrant Bug: N/A Change-Id: I0182c5040282b1e8da0ee0a2f91871fe68c592f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618368 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
All modules wait for each other before showing up. A timeout protects against long loading modules. It is not clear yet what the best timeout is. Thus, the timeout duration is Finch-configurable. Fixed: 1154008 Change-Id: I1dcd29a168c4f01408979c439edb47903837371f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623718 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843371}
-
Omar Morsi authored
With crbug.com/1113115 closed, ARC applications can be mentioned in KeyPermissions policy to enable ARC to access corporate keys. Bug: None Change-Id: I283c399b4d593f4b33910f2e8d160ab09be91e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561841Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Commit-Queue: Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843370}
-
David Black authored
Per last minute change, selection will no longer have a ring. It will just be a semi-transparent blue overlay. Focus ring will more snugly fit the view. Bug: 1147182 Change-Id: Ib6257dee971d3a3f6d8f11ba663b300e1fb7d1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628501 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843369}
-
Yulun Wu authored
ui/views/controls/label does not use themed colors from ash/style so app_list_item_view should explicitly modify the color for title_. Bug: 1139478 Change-Id: I590663a1c2e27c35f148a557017451c41d8db214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627874 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843368}
-
