- 23 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fccfaf11e1e..ed680bea92a2 git log 9fccfaf11e1e..ed680bea92a2 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 eseckler@google.com processor: Remove a left over TODO Created with: gclient setdep -r src/third_party/perfetto@ed680bea92a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie22ee9ebef5cd5c2bcff784bcdcf8d440702cc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708560}
-
chrome://help-appPatti authored
Add a new WebUI at chrome://help-app for the new Chrome OS Help App. To enable, run Chrome with --enable-features=HelpAppV2. For now, it shows nothing but a blank page with "Help App" as the page title. Bug: 1012578 Change-Id: I0b3cd92e69497488528a38ad77c84903dd40d7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858546Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708559}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5aa803aa2d84..9d832da5228b git log 5aa803aa2d84..9d832da5228b --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org cros_build_lib: close more open files explicitly Created with: gclient setdep -r src/third_party/chromite@9d832da5228b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8010667c7db80469fdc580f84c1672b952376ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875378Reviewed-by:
-
Michael van Ouwerkerk authored
The launch bug has approval for M78: http://crbug.com/998912 Bug: 971725 Change-Id: I22f68b314fdba53848855357b0b4a46fc3eb26f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871551Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#708557}
-
Andy Paicu authored
Added hkamila@ and andypaicu@ to the PERMISSIONS_OWNERS file and then added said file to OWNERS permissions code. Bug: 1016730 Change-Id: Iadf1b101214044699222fa9bb6151597aeb54dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871600Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#708556}
-
Christian Dullweber authored
Tbr: afakhry@chromium.org Bug: 1017110 Change-Id: I3c153b07a4d6c381b7c85684d0e59f09b71712b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875259Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#708555}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I161e6f1c035eda84f61f79b01454b80a6bb08861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875377Reviewed-by:
-
Javier Ernesto Flores Robles authored
Change-Id: I2c40a4311ca8609c8a7461c42e9a770b8ebc5a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875255 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708553}
-
Andy Paicu authored
As requested in https://chromium-review.googlesource.com/c/chromium/src/+/1860015 I've added a test to ensure that when adding a quiet permission request, it will be killed by a loud one. Bug: 1014026 Change-Id: Ic966af5752356917d8a47929be67e8e189aeb642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873925 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This test fails on Linux build bots. TBR=avi@chromium.org Bug: 954217, 1017102 Change-Id: I5a96bb2fc33114668e5747b8b0996fe224ef403b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875855Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708551}
-
Robbie McElrath authored
variations::SeedResponse currently stores the seed date as a 'long' representing milliseconds since UNIX epoch, but in C++ that can be a 32 bit type, which results in the timestamp being truncated. This CL changes the type to int64_t. Test: Manually verify the timestamp isn't being converted to 32 bits. Bug: 1010625 Change-Id: I80481e5eecf456d52757f398ceaee0f97644534c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873226Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52f1f671..2fad46eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If8a4d4b4ae31900a5e89eee51fe73fb0599def85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875225Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708549}
-
Andreas Haas authored
We are removing external uses of ArrayBufferContents::DataHandle so that eventually we can remove the whole class and change the implementation of WTF::ArrayBuffers. This CL is an intermediate step on the way which replaces the external use of DataHandle to make a later refactoring of ArrayBufferContents easier. Due to recent changes in V8 it is not necessary anymore to call {AdjustAmountOfExternalAllocatedMemory} for memory of ArrayBuffers. V8 get this information now from ArrayBuffer objects on the heap. R=jsbell@chromium.org Bug: chromium:1008840 Change-Id: I14497d44487eb5185968180b42bfdec6f60c228e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869414 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#708548}
-
Gauthier Ambard authored
The tests where failing if the AddPayment flag is enabled. This CL makes sure that they are passing with the flag enabled and disabled. Bug: none Change-Id: Iad1c7c5e625b7e1e1549cd7288c8297310f44e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869001Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708547}
-
Gauthier Ambard authored
Bug: 987646 Change-Id: I5fd6d0828a2c22e613d97d34689f864c809d93a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871598 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#708546}
-
Kent Tamura authored
No-Try: true Change-Id: I85ac17b8904034e844f22ba122b7f0c81e475d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875019Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#708545}
-
Christian Dullweber authored
This reverts commit c7d42e29. Reason for revert: Suspected to break AppListClientImplBrowserTest.UninstallApp https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8074 Original change's description: > Use AppService to uninstall apps on Chrome OS. > > BUG=1009248 > > Change-Id: I659067359fbdb5fb430f9dcb60a0dbee1fcf6184 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864496 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708514} TBR=xiyuan@chromium.org,nancylingwang@chromium.org Change-Id: I94e44362796779c94b75e37e6457288aef92ca55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1009248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875093Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0f707697f70a..9fccfaf11e1e git log 0f707697f70a..9fccfaf11e1e --date=short --no-merges --format='%ad %ae %s' 2019-10-23 eseckler@google.com Merge "processor: Move TrackEvent tokenizing & parsing into module" Created with: gclient setdep -r src/third_party/perfetto@9fccfaf11e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib5a2abc7f7104080bcabdd994daa31854b663f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875375Reviewed-by:
-
Clemens Arbesser authored
Bug: b/142430956 Change-Id: I1d2c8df077e64b6eada750c9c5a028c80aa43350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872594Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#708542}
-
Gauthier Ambard authored
TBR=eugenebut@chromium.org Bug: 987646 Change-Id: Ia90cc6d182ad052352ea450218b88917d04ab54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871884 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708541}
-
Yoshifumi Inoue authored
This patch gets rid of unused member functions |{First,Last}LogicalLeaf()| from |NGPhysicalLineBoxFragment| for improving code health. Note: This patch is follow up of the patch[1] which gets of usages of |NGPhysicalLineBoxFragment::{First,Last}LogicalLeaf()|. [1] http://crrev.com/c/1866101 Utilize NGInlineCursor in NGCaretPosition Change-Id: I64df633e1d43161b623f1ca3d7e9e1772b78577a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875017 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708540}
-
Benoît Lizé authored
thread_local is already used in Chrome, though not widely as it is still banned by the style-guide. Add a benchmark to estimate its performance. Detailed results below, tldr: - On Linux: 2-3x faster than the current TLS implementation for reading, ~10x faster for writing - On Android: ~4x faster for reading On Linux (Intel Xeon "Haswell"): [ RUN ] ThreadLocalStoragePerfTest.ThreadLocalStorage *RESULT TLS read throughput: ThreadLocalStorage= 154230.54381689752 operations/ms *RESULT TLS write throughput: ThreadLocalStorage= 168171.8043152885 operations/ms *RESULT TLS read-write throughput: ThreadLocalStorage= 82276.76257394624 operations/ms *RESULT TLS read throughput: ThreadLocalStorage 4 threads= 155118.12245024586 operations/ms *RESULT TLS write throughput: ThreadLocalStorage 4 threads= 171458.9441558219 operations/ms *RESULT TLS read-write throughput: ThreadLocalStorage 4 threads= 82700.67318347971 operations/ms [ RUN ] ThreadLocalStoragePerfTest.PlatformTls *RESULT TLS read throughput: PlatformTls= 318390.2190524707 operations/ms *RESULT TLS write throughput: PlatformTls= 232018.56148491878 operations/ms *RESULT TLS read-write throughput: PlatformTls= 144791.13878230652 operations/ms *RESULT TLS read throughput: PlatformTls 4 threads= 255597.5871587772 operations/ms *RESULT TLS write throughput: PlatformTls 4 threads= 195446.10573634322 operations/ms *RESULT TLS read-write throughput: PlatformTls 4 threads= 132872.70794578793 operations/ms [ RUN ] ThreadLocalStoragePerfTest.Cpp11Tls *RESULT TLS read throughput: C++ thread_local TLS= 384763.37052712584 operations/ms *RESULT TLS write throughput: C++ thread_local TLS= 2500625.1562890722 operations/ms *RESULT TLS read-write throughput: C++ thread_local TLS= 2430724.3558580456 operations/ms *RESULT TLS read throughput: C++ thread_local TLS 4 threads= 342794.4604415193 operations/ms *RESULT TLS write throughput: C++ thread_local TLS 4 threads= 1192037.1915603767 operations/ms *RESULT TLS read-write throughput: C++ thread_local TLS 4 threads= 1774937.8771742987 operations/ms On Android (Pixel 1, Snapdragon 821): [ RUN ] ThreadLocalStoragePerfTest.ThreadLocalStorage *RESULT TLS read throughput: ThreadLocalStorage= 48410.911819524124 operations/ms *RESULT TLS write throughput: ThreadLocalStorage= 29321.041952546824 operations/ms *RESULT TLS read-write throughput: ThreadLocalStorage= 18727.64387512407 operations/ms *RESULT TLS read throughput: ThreadLocalStorage 4 threads= 34612.97501981593 operations/ms *RESULT TLS write throughput: ThreadLocalStorage 4 threads= 22686.79741824245 operations/ms *RESULT TLS read-write throughput: ThreadLocalStorage 4 threads= 14610.463137070981 operations/ms [ RUN ] ThreadLocalStoragePerfTest.PlatformTls *RESULT TLS read throughput: PlatformTls= 40691.75991861648 operations/ms *RESULT TLS write throughput: PlatformTls= 43693.49884430696 operations/ms *RESULT TLS read-write throughput: PlatformTls= 23500.547562758213 operations/ms *RESULT TLS read throughput: PlatformTls 4 threads= 31334.701615303868 operations/ms *RESULT TLS write throughput: PlatformTls 4 threads= 33404.26171570969 operations/ms *RESULT TLS read-write throughput: PlatformTls 4 threads= 19587.027120197752 operations/ms [ RUN ] ThreadLocalStoragePerfTest.Cpp11Tls *RESULT TLS read throughput: C++ thread_local TLS= 205532.9469313931 operations/ms *RESULT TLS write throughput: C++ thread_local TLS= 19075.81491881333 operations/ms *RESULT TLS read-write throughput: C++ thread_local TLS= 15905.078491562355 operations/ms *RESULT TLS read throughput: C++ thread_local TLS 4 threads= 81040.56080068075 operations/ms *RESULT TLS write throughput: C++ thread_local TLS 4 threads= 11412.84127248615 operations/ms *RESULT TLS read-write throughput: C++ thread_local TLS 4 threads= 9210.180934004447 operations/ms Bug: 998048 Change-Id: I018c3a7989f3ae48406ba86c282f5c4e4b205bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873751Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708539}
-
Jan Scheffler authored
This patches restricts the changes from [1] to pdf embeds. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1659983 Bug: chromium:997521 Change-Id: I8a94c9c1eecf132388508ceed47b426f2c842ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798350Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#708538}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf73f081. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 707870e6 "CSS: WPT tests property values are supported." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I27ad1c318b21d61470e8b0cd9cd34f4d10d5909b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875209Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708537}
-
Peter Kasting authored
Bug: 82078 Change-Id: Icd953a0dfdcfd6c6b16b1606735f1f029dd734cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873278 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#708536}
-
Yoshifumi Inoue authored
This patch gets rid of usages of |NGInlineFragmentTraversal::SelfFragmentsOf()| from |NGCaretPositionTest| as a preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I1a80644e391d59df0af6f15e33dd751708bb1a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874422 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
David Staessens authored
This CL removes the video_decode_accelerator_unittest and associated helpers. These tests have been deprecated in favor of the video_decode_accelerator_tests and video_decode_accelerator_perf_tests targets. The video_decode_accelerator_unittest for the Android platform seems to use a completely different test binary so this test has been retained. TEST=./video_decode_accelerator_tests on eve BUG=1802897 Change-Id: I66565844be5608f560f3a56ca72aa579c7c1c68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851629 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708534}
-
Victor-Gabriel Savu authored
Bug: chromium:None Change-Id: I1cb8859a1b41888863aaafeb29060473a672bc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871704Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#708533}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |GetFragmentOfNode()| to reduce number of usage of |NGInlineFragmentTraversal::SelfFragmentsOf()| as a preparation of migrating |NGFragmentItem| and improve code health. Bug: 982194 Change-Id: Icdb25e66cfd3348217885ca7bfdf30035eee72e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874074 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Austin Tankiang authored
Bug: 1003238 Change-Id: I4f8f81a25258e9b4d23206f3fd476872026bc1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868529Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#708531}
-
Hajime Hoshi authored
This test is failing on macOS build bots due to its long log output. TBR=davidben@chromium.org Bug: 1017036 Change-Id: I69d0181f71bf1c5791d566a84685efadecad6bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875351Reviewed-by:
-
Hiroki Sato authored
Now that accessibility window mapping in Android side is finished, |all_parent_map| and |parent_map_| in AccessibilityTreeSourceArc should be same. This CL cleans it up. Bug: None Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*:ArcAccessibilityHelperBridgeTest.*" Change-Id: I9cd429f3d1020d2b6c93ac5c2ce48bb8780dd8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868770 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#708529}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c0e6e7a631e7..e792f87ded42 git log c0e6e7a631e7..e792f87ded42 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 kcwu@chromium.org Fix BMP image header parser and detector Created with: gclient setdep -r src/third_party/pdfium@e792f87ded42 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:None Change-Id: I89e15b1efc8fb71299cd275f16231856d11fbcd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875371Reviewed-by:
-
Alex Newcomer authored
Previously, we only hid on taps, but UX says we should also hide on swipes, etc. Bug: 1012759 Change-Id: I06d5616cd6a157bf5c7b25a68ba0dd60fba2ea08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874503 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#708527}
-
Maggie Cai authored
This CL adds the preferred apps storage in the App Service Server, and implement methods to sync the change between App Service Server and the Subscribers. BUG=853604 Change-Id: Iba78cd0d02d95464de038c7d97f267d75bdcec9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866228 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708526}
-
David Tseng authored
This reverts commit 217c3a78. Reason for revert: <INSERT REASONING HERE> crbug.com/1016132 Original change's description: > Makes magnifier observe AXEventManager for focus changes > > Bug: 865575 > Change-Id: I8d8328a459d7621d6fc0a0d65e0f24f788b9767f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852414 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704854} TBR=dmazzoni@chromium.org,dtseng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 865575,1016132 Change-Id: Id77035499da1e2b36c1216b622eb8f341449406b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875449Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/224f10ee..52f1f671 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7146f4cd1b110a10e7ed7fe60690ad99ab9ec807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875216Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3ea49ac23f8..5aa803aa2d84 git log c3ea49ac23f8..5aa803aa2d84 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org portage_util: use encoding=utf-8 for commands 2019-10-23 vapier@chromium.org cleanup: use bytes for pipes 2019-10-23 vapier@chromium.org run_tests: turn on more python3 coverage Created with: gclient setdep -r src/third_party/chromite@5aa803aa2d84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib8ca878174d0244329fbcfc197f6bea1c7f3fffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875410Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/401b25c878da..b1ae481f7fe3 git log 401b25c878da..b1ae481f7fe3 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 ehmaldonado@chromium.org git-cl: Remove hack to ask for random mirrors when querying Gerrit. Created with: gclient setdep -r src/third_party/depot_tools@b1ae481f7fe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:881860 Change-Id: I0e6d97ef98750a426859872f53e39dc0a8c23fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875370Reviewed-by:
-
Jacobo Aragunde Pérez authored
Convert the implementation and all users of content::mojom::FonctCacheWin. Bug: 955171 Change-Id: I434383bf5ef0b036eaca6e005b5f389348344a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827012Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
