- 03 Nov, 2020 40 commits
-
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb20-58.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Ibeefcf93e32138cdd178f2e9559c57f4e81797df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518103Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#823675}
-
Avi Drissman authored
Fixed: 1144809 Change-Id: Ic16a621c3b74e6259a0ac3d94f359869a30c4e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516019 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#823674}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/df4236e338ac..2e411e2f8478 2020-11-03 chrche@microsoft.com [Loc] Migrate coverage to Loc V2 2020-11-03 andoli@chromium.org Sets up infrastructure to migrate extensions of type 'view' 2020-11-03 aerotwist@chromium.org TypeScriptify LineLevelProfile.js 2020-11-03 mulherje@gmail.com Update template for text buttons to allow for mousedown event listener If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1134103,chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie856c0f4fe7eacc75c47e80cf049592819f2aebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823673}
-
Henrique Nakashima authored
The assert is for debugging as if native is not initialized this will crash anyway. Moving it from IncognitoTabModelImpl breaks its dependency on TabModelJniBridge. Bug: 1109013 Change-Id: I3cd06e4f2115b315bb1ba3e7699e925a9b30c4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511092Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#823672}
-
Mohamed Heikal authored
When image_editor DFM is not defined, pressing the edit button should do nothing rather than crash chrome. Bug: 1145044 Change-Id: Ideaf738bde7c626bee627648c517f4fe9f3a4910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517619Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823671}
-
Sigurdur Asgeirsson authored
Change-Id: I6fbf2bdfcba2445997dd55e102dac491b2f981d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517622 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#823670}
-
Michael Thiessen authored
This will be a 3-sided multi-part CL. In this change I move CriteriaHelper to base/, leaving a copy in content/ I will then migrate the downstream and upstream content/ imports to base/ imports. After downstream has rolled I'll remove the content/ copies. Bug: 1134178 Change-Id: I07c646a1cc9aebfcd2c2a7cd3e0446f0581f6e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518120Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823669}
-
Yuke Liao authored
This CL uses also_build_ash_chrome on CI builders to as to be consistent with the linux-lacros-rel CQ builder. Bug: 1129223 Change-Id: Id4fa70033a2702ed94590a943239492001a9a2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517145 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823668}
-
Michael Checo authored
Screenshot: http://shortn/_OHS9E7XPgF Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: Ida6b9bccfeb781d353ccb944713e4c95b1735387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506304 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#823667}
-
Clark DuVall authored
This should fix the crash seen with isolated splits. Isolated split class loaders are not able to load native libraries due to b/b/171269960, so the paths must be resolved manually. This will have a corresponding change in the internal repo. Bug: 1143321 Change-Id: I58f4e496417248ad38b388a4e45fafb3843226bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515439 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823666}
-
Mariam Ali authored
This CL fixes the regular guest NTP where it seems to be unreachable. Bug: 1144597 Change-Id: Ie1d5a8ca5f059e15b3c2526b01e67ad4f12aebee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512889Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Mariam Ali <alimariam@google.com> Cr-Commit-Position: refs/heads/master@{#823665}
-
Rakib M. Hasan authored
Bug: None Change-Id: I3e8c0bf667a028b256c2d200df33d4f8d68ff389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515022 Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#823664}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba40ae7e..adbea905 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieab7cde1cb844986feda89090d1e09a8b972c34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517144Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823663}
-
Wei Li authored
Prior to this change, expand button inherits ToggleImageButton's default focus behavior which is ACCESSIBLE_ONLY. This button should be focusable by default as user can navigate/toggle the button using a keyboard. Bug: 1001103 Change-Id: Ic698f3865ddcb8cc66b962292831c3d5a73fc29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510729Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#823662}
-
Henrik Boström authored
Despite this test already being marked as [ Pass Crash ], when the test crashes on the bots, the Flake Portal registers the crash not as a crash but as a failure, see https://crbug.com/1094930#c25. For now, I'm marking this test as [ Pass Crash Failure ]. TBR=hta@chromium.org Bug: chromium:1094930 Change-Id: Ic6e1b54798ba53302ef1b7ac9dee4b06cba2a08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517462 Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#823661}
-
Tommy Nyquist authored
This reverts commit dbe0ea06. Reason for revert: New test fails on the following bots: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20N%20%28dbg%29 Original change's description: > ContentCapture: re-stream onscreen content when the frame show again > > Previously ContentCaptureConsumer had no way to know the the frame > shows again because the visible content didn't change. > > This patch resets the task session when the frame was hidden, so > ContentCapture task will stream on-screen content because they > aren't streamed from the task point of view when the frame was > shown. > > Adds the test to coverage this scenario. > > Bug: 1137463 > Change-Id: I0065ce080101d2149622b0f9f6a3aa196c18d717 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511030 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Michael Bai <michaelbai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823251} TBR=michaelbai@chromium.org,wangxianzhu@chromium.org Change-Id: I219bd94c5dfc36b073590d6e604ce951aef3c966 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518401Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#823660}
-
Jamie Madill authored
This config is unsupported. Leave angle_unittests because they're used with Chrome separate from ANGLE. This removes angle_end2end and angle_perftests. Bug: angleproject:5298 Change-Id: Ia7ddca4de7e2989fd7e2d375dec7a9a3bf942f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517642Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#823659}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/655afebfcd13..5bdfcd8f3397 2020-11-03 sokcevic@google.com Add `main` when guessing origin remote If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143724 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Ib34347e387f75f7d63ba2b9d4cd0eee314f1711e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823658}
-
Rakib M. Hasan authored
These changes will add a tester for Android Marshmallow which will run Weblayer skew tests. It also renames the Android 10 builder. Bug: 1114563 Change-Id: I13b72e50cac7e322bfd8214fae4e08718d7667b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514675Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#823657}
-
Liquan (Max) Gu authored
Context: In order to extract the common part of CPRService#initAndValidate() into PRService#initAndValidate() and provide extensibility for WebLayerPRService's counter part, this CL breaks down CPRService#initAndValidate() into several small methods ready to be moved into PRService. Changes: * Broken initAndValidate() down into these methods: - modifyMethodData(): provide a chance to monkey-patch methodData if needed. - onWhetherGooglePayBridgeEligible(): provides a chance for the caller to decide whether skip-to-gpay route would be enabled. - onQueryForQuotaCreated(): provides a chance to monkey-patch mQueryForQuota if needed. - disconnectIfExtraValidationFails(): provides a chance to do extra validation. - onSpecValidated(): provides a chance for the valid PaymentRequestSpec to be saved by ChromeLayerPRService and WebLayerPRService, initialize the UI service and do journey logging. - addPaymentAppServiceFactories(): provides a chance to add different payment app factories in Chrome and WebLayer. * Refactored getValidatedMethodData(): extract the Skip-to-GPay monkey-patching of the methodData out of the method, calling it modifyMethodData() which going forwards will be called only in Chrome (not WebLayer). Bug: 1144527 Change-Id: I3635e8450a847d989cb0bc1c86c8d7bb7d1dc014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514699 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823656}
-
Josh Nohle authored
Since cl/337200290, the Nearby Share server returns both Google contacts and device contacts in the ListContactPeople RPC response. That update labels every contact with a Google-, device-, or unknown-contact type. The burden is on the client to filter by type if desired. In this CL, we add an enabled-by-default flag to allow use of device contacts returned in the ListContactPeople RPC response. When the flag is disabled, we filter out device contacts. Server-side support for device contacts is fairly new, and there is a risk for returning duplicate contacts: one Google contact and one device contact that are essentially the same. We want a kill switch in case things go awry. Fixed: 1143680 Change-Id: I239f50593188910ba00773bc878a41bc77126f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510351 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#823655}
-
Lily Chen authored
Adds comments explaining the meaning of each ExclusionReason value. Bug: None Change-Id: Ia3ae82d2ce552ec783be635092f301c408abfc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508554 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823654}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I77fb9d627875410fd5f3160137377bd62d7ccdc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823653}
-
Scott Violet authored
BUG=1142989 TEST=twoFragmentsDifferentIncognitoProfiles twoFragmentsSameIncognitoProfile testMultipleIncognitoProfiles Change-Id: I50ab97c20036466b697b88ca9e78e5d2cf5fed39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510731 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823652}
-
Andrew Grieve authored
This reverts commit 85773e52. Reason for reland: * Fixed data deps * _BuildWithChromium() handles missing key Original change's description: > Revert "Reland "Android: Use locally-build devil deps only when build_with_chromium=true"" > > This reverts commit f8b7ec28. > > Reason for revert: Causing all builds to fail on android-pixel2-perf failing > > Original change's description: > > Reland "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > This reverts commit b47e9c83. > > > > Reason for reland: Updated more .pydeps files. > > > > Original change's description: > > > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > > > This reverts commit 49fdeca1. > > > > > > Reason for revert: Breaking presubmit due to stale .pydeps file: > > > android_webview/tools/run_cts.pydeps > > > > > > Original change's description: > > > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > > > > > Bug: 1120190 > > > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#819489} > > > > > > TBR=agrieve@chromium.org,bpastene@chromium.org > > > > > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1120190 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#819668} > > > > TBR=agrieve # reland > > > > Bug: 1120190 > > Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819810} > > TBR=agrieve@chromium.org,bpastene@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1120190, 1141891 > Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820355} Bug: 1120190 Bug: 1141891 Change-Id: Ic7a398fcd8cb5f45a03c20acbd4e9c7300442f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497153Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823651}
-
Josh Nohle authored
We are still using all CryptAuth histograms to evaluate the migration to CryptAuth v2 Enrollment and DeviceSync. The migration is complete on the GmsCore side but still rolling out on Chrome OS and server sides. Fixed: 1144788 Change-Id: Iaf9cf46686fe1b3298ec6145fdcd2a3c9a5e4224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517901 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823650}
-
Curt Clemens authored
Add all of the missing filetype icons in nearby-preview. Rework the existing elements so that the sizing/spacing/colors fit the spec. Add additional ShareTypes for the new icons. Bug: 1123942 Change-Id: I49b64014ec22e30386e4438650c3ed8fefe9a1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499069Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#823649}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1142671 Change-Id: I14e20b732dd574ce2bdaba4ce2d885fa40795f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500703 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#823648}
-
Nate Fischer authored
No change to logic. This disables some AwSettingsTest test cases which I've confirmed flake locally. This test suite should now pass on API 28 (Android P). Bug: 1144352 Bug: 1144935 Bug: 1144938 Bug: 1144945 Test: run_webview_instrumentation_test_apk -f AwSettingsTest.* Change-Id: If1d9695ff1ceb632019ded16e2fc975e1cd90e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515162 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823647}
-
Jamie Madill authored
This test suite seems to be randomly flaky. The retry mechanism should let the tests pass even if they have up to 2 failures. Even though they should be 99% deflaked with one retry, give them two attempts to be 100% sure of not getting a flaky failure. De-flakying is more important than any other concern. Also leaves the 'linux_args' setting in the new test spec in case we end up using it on Linux as well. Bug: angleproject:5273 Change-Id: Id3deb84b1c5533f37f3b55b9d9659ddc66358544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517042Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#823646}
-
ckitagawa authored
This CL adds the following functionality - Don't proceed to capture if the device is experiencing memory pressure (moderate or critical). - If under memory pressure and playing back - Moderate Pressure: release any out-of-viewport bitmaps - Critical Pressure: stop showing the preview Bug: 1144768 Change-Id: I988f84053462807ba9956f26626aa556dca61c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514365 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#823645}
-
Eric Orth authored
Empty alias name has been parsable and allowed since the update to draft-ietf-dnsop-svcb-https-01. Fixed: 1145098 Bug: 1138620 Change-Id: I980365204c1b997335c781567e62c7fcdf3094e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517627 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#823644}
-
Tommy Nyquist authored
This reverts commit fffc75e9. Reason for revert: New test consistently fails Marshmallow 64-bit Tester bot. See: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester Original change's description: > Suppress TabStrip IPH when bottom sheet shows > > This CL hides TabStrip IPH when bottom sheet shows and reshows IPH > right after bottom sheet hides. This CL is gated by Finch parameter > "enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate > function TabUiFeatureUtilities#isLaunchBugFixEnabled. > > Bug: 1135926 > Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823416} TBR=mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org Change-Id: I942224058529eb3e2eda72ca531f30d61d984724 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518083Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#823643}
-
Torne (Richard Coles) authored
On Q+ we disabled audio capture as we have no way to selectively disable it for incognito tabs, but this was missed when upstreaming Q. Chrome needs QUERY_ALL_PACKAGES permission on R+ to check for any possible intent handler for URLs. This was added downstream but missed while upstreaming R support; add it now. Bug: 948282, 1042023 Change-Id: I4136beddcba0227ef6cfc2073f90d645151ce6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507575Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#823642}
-
Wojciech Dzierżanowski authored
PlayerIdentifier::operator<() was defined through operator<() on PlayerIdentifier hashes. This almost always gives correct results, but not in general. Hash collisions are possible (collisions of sums of hashes are a bit "more possible", see old PlayerIdentifier::Hash()), so operator<() could return false for two PlayerIdentifier instances that are actually in a less-than relationship. The hash function is not really needed anyway, because base::flat_set is better suited here than std::unordered_set. Change-Id: I12eec1aa27774d0bd6e10232c35968832fed1ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492440Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#823641}
-
Josh Nohle authored
Move the Nearby Share feature flags out of //c/b/browser_features and into the feature-specific location //c/b/nearby_sharing/common/. This was recommended by fgorski@ in crrev/c/2510351. Note: Nearby Share is currently only being built for Chrome OS. We clean up locations that did not reflect this. Fixed: 1144259 Change-Id: I5c5483e35a040f244df4b88c29e992106f869c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515045Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#823640}
-
Akira Baruah authored
Adds getter methods to MetricsServiceClient that specify limits on local log storage. An embedder can override these new methods to configure limits based on their use case, rather than relying on the defaults previously hardcoded into MetricsLogStore. The default values returned by the new methods match the old hardcoded values to maintain original functionality. Bug: None Test: metrics_unittests Change-Id: I86f61d2cd1a0b41ae6e64866dcf0921b9a1ff930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505741 Commit-Queue: Akira Baruah <akirabaruah@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823639}
-
Etienne Pierre-doray authored
UpdatePriority was exposed in v8-platform. This CL override the method to delegate to base implementation. Change-Id: I87c30acc7f692d2d9eb9cfb6339a26077cc4c876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517701Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#823638}
-
Yicheng Li authored
Bug: b/156258540 Change-Id: I7fef896b35c3141f4377b90eda34c8925c008c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506242 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823637}
-
Ian Wells authored
Bug: 1115463 Change-Id: I29b0658596cd5c9c10ea2832435cca7a873f6ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510914Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#823636}
-