GitLab

This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=nick@chromium.org

Review URL: https://codereview.chromium.org/1159623009

Cr-Commit-Position: refs/heads/master@{#333081}

BUG=465354

Review URL: https://codereview.chromium.org/1160403005

Cr-Commit-Position: refs/heads/master@{#333080}

- Split the tests into their own file.
- Add the deleted on server case.
- Factor out many common subroutines.

BUG=480604

Review URL: https://codereview.chromium.org/1168533002

Cr-Commit-Position: refs/heads/master@{#333079}

BUG=489317

Review URL: https://codereview.chromium.org/1165463010

Cr-Commit-Position: refs/heads/master@{#333078}

Add skeleton UI for sync page. This CL creates the new page, adds its strings, and brings in new Polymer dependencies on the paper-radio-* elements.

This CL does not add functionality or proper styling to the page. This will be done in follow-up CLs.

R=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/1159623003

Cr-Commit-Position: refs/heads/master@{#333077}

BUG=496438
NOTRY=True

Review URL: https://codereview.chromium.org/1149233004

Cr-Commit-Position: refs/heads/master@{#333076}

This landed in https://chromium.googlesource.com/external/mojo/+/a500628dfc647cc520d999a972b80d9ff62b0b26, but I want to use it now in the Chromium repo.
BUG=478251

Review URL: https://codereview.chromium.org/1167623005

Cr-Commit-Position: refs/heads/master@{#333075}

Cleaning up some tests to use helper functions and remove dangling
pointers. It also fixes the DisabledManagerWorksAfterBrowserRestart
test which wasn't initializing after creating a new manager.

Review URL: https://codereview.chromium.org/1148853005

Cr-Commit-Position: refs/heads/master@{#333074}

Querying is done asynchronously, with a browser-side cache of responses.
GPU will try out the requested overlay configuration and report if it was
successful. Response delay is typically 1 frame but could be more in
rare situations. A maximum cache size is imposed so that a video that's being
moved/resized won't cause memory consumption to explode

TBR=danakj (trivial enum change)

Review URL: https://codereview.chromium.org/1157793004

Cr-Commit-Position: refs/heads/master@{#333073}

With the fix of 411038 in (https://codereview.chromium.org/1162083003).
Re-enable the failing test on Android Nexus 5.

BUG=412145
TEST=build/android/test_runner.py gtest --debug -s webkit_unit_tests \
     --num_retries=0 --gtest-filter=TouchActionTest.Pan

Review URL: https://codereview.chromium.org/1156373015

Cr-Commit-Position: refs/heads/master@{#333072}

BUG=496936

Review URL: https://codereview.chromium.org/1143053006

Cr-Commit-Position: refs/heads/master@{#333071}

TBR=sievers (already reviewed)

Reason for reland:
Fix build for ozone_demo.

> Revert of ozone: Remove singleton pattern for SurfaceFactoryOzone. (patchset #1 id:1 of https://codereview.chromium.org/1159493010/)
>
> Reason for revert:
> Broke Linux ChromiumOS compile.
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/17764/steps/compile/logs/stdio#error1
>
> Original issue's description:
> > ozone: Remove singleton pattern for SurfaceFactoryOzone.
> >
> > OzonePlatform is sigleton already, so it's not necessary for
> > SurfaceFactoryOzone to be singleton.
> >
> > Committed: https://crrev.com/48b0a7165bd6c9d889fc6d6959a6e59cf7ef9dc6
> > Cr-Commit-Position: refs/heads/master@{#332889}
>
> TBR=spang@chromium.org,sievers@chromium.org,alexst@chromium.org,dongseong.hwang@intel.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/1167533007
>
> Cr-Commit-Position: refs/heads/master@{#332899}

Review URL: https://codereview.chromium.org/1171513002

Cr-Commit-Position: refs/heads/master@{#333070}

This CL picks up the value serialization changes from crrev.com/1157793003 as
well as the refactor of story_runner_unittest so that it no longer depends on
BuildbotOutputFormatter.

As a result, there are no remaining dependencies on BuildbotOutputFormatter in
Telemetry, save for results_options.py, which allows for consumers to continue
to use BuildbotOutputFormatter for the time being.

BUG=477056
R=nednguyen

Review URL: https://codereview.chromium.org/1165883003

Cr-Commit-Position: refs/heads/master@{#333069}

R=jlklein@chromium.org, jlklein
BUG=none

Review URL: https://codereview.chromium.org/1167523004

Cr-Commit-Position: refs/heads/master@{#333068}

See issue for details.

BUG=493438

Review URL: https://codereview.chromium.org/1163463005

Cr-Commit-Position: refs/heads/master@{#333067}

Minor update to the docserver. This is a multi-faceted patch which takes
care of some issues with our server:

 - No more AppEngine cron. The front-end is no longer responsible for
   updating Datastore entities, it just serves up the data that's there.

 - No more Gitiles or Subversion filesystems. Github filesystems are
   deprecated but not fully removed.

 - New LocalGitFileSystem can retrieve arbitrary repo history data
   directly from a local copy of the repo using commandline git.

 - Refactor appengine_wrappers; unused concepts deleted, datastore and
   URL fetching moved to their own first-class concepts, added
   environment_wrappers for more generic cross-platform factories.
   Memcache still lives in appengine_wrappers for now.

 - Clean up some of the mess caused by Gitiles support: no more refresh
   tasks, so no more refresh "paths" in data sources. Most of the
   foo_data_source.py changes here are just reverting that crap.
   FileSystem versioning is no longer necessary and no longer used, but
   not fully removed in this patch.

 - Added update_cache.py, a utility which can scrape a local chromium
   repo and populate Datastore with the data needed on the front-end.
   This tool can also be used to load and store on-disk caches of said
   Datastore in order to speed up incremental updates from the same
   host.

BUG=
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/1151283007

Cr-Commit-Position: refs/heads/master@{#333066}

The main motivation is to enforce correct layering and dependencies

BUG=478250
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1169493003

Cr-Commit-Position: refs/heads/master@{#333065}

BUG=none
R=jlklein@chromium.org

Review URL: https://codereview.chromium.org/1144963006

Cr-Commit-Position: refs/heads/master@{#333064}

R=jlklein@chromium.org, jlklein
BUG=

Review URL: https://codereview.chromium.org/1155863003

Cr-Commit-Position: refs/heads/master@{#333063}

This behavior was used to either force IPv4 resolution on dual-stack devices (using the --disable-ipv6 command-line flag) or to force IPv6 resolution.

Now that the flags have gone away, this behavior is no longer needed in the HostResolver.

BUG=344685

Review URL: https://codereview.chromium.org/1163903002

Cr-Commit-Position: refs/heads/master@{#333062}

Call LeakSanitizer before RenderViewTest::TearDown(), as the latter may
leak WebKit objects when it shuts down V8.

BUG=328552,463143
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1169493006

Cr-Commit-Position: refs/heads/master@{#333061}

BUG=457697

Review URL: https://codereview.chromium.org/1156393003

Cr-Commit-Position: refs/heads/master@{#333060}

Add the ability to create a CronetUrlRequest with a priority.
BUG=

Review URL: https://codereview.chromium.org/1159343003

Cr-Commit-Position: refs/heads/master@{#333059}

BUG=

Review URL: https://codereview.chromium.org/1149383006

Cr-Commit-Position: refs/heads/master@{#333058}

Switch to using the definitions from src/public/ where possible.

Change DEPS to remove blanket allowances of src/trusted/desc/, and
only whitelist some remaining required headers.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832
TEST=build

Review URL: https://codereview.chromium.org/1171493003

Cr-Commit-Position: refs/heads/master@{#333057}

This is a re-land of https://codereview.chromium.org/1126383005, fixed
not to cause a crash when 'WebView.loadUrl' is called from inside the
onReceivedTitle callback, added a regression test. Also, the document
title is now cached to minimize the amount of callback calls.

Original patch description:

The usual channel for delivering onReceivedTitle (via updating title for
a NavigationEntry) doesn't work in the case of history navigations, because
WebContentsImpl silences no-op updates of entries titles.

Chrome Browser uses another event for updating the title in this case --
via WebContentsDelegate::LoadingStateChanged. This patch enables WebView to
use it as well.

Note that WebChromeClient.onReceivedIcon doesn't need to be re-sent, as
nobody seems to bother checking whether the icon update is a "no-op", so
updates on history navigations just work.

BUG=481570,495234

Review URL: https://codereview.chromium.org/1161783005

Cr-Commit-Position: refs/heads/master@{#333056}

R=jlklein@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1151263014

Cr-Commit-Position: refs/heads/master@{#333055}

SequencedSocketData is a bit cleaner and easier to use than the
alternatives, which we may want to get rid of, long term.

HttpStreamParser.AsyncChunkAndAsyncSocketWithMultipleChunks did rely on
DeterministicSocketData's behavior to get in a state where the previous
chunked upload body write was pending when data was appended to the
chunked upload data stream, but the updated test uses a new method to
ensure that happens.

BUG=492696

Review URL: https://codereview.chromium.org/1166693004

Cr-Commit-Position: refs/heads/master@{#333054}

Noticed this was hanging around after the NavigationTransitions cleanup, was originally used in a test but now nothing calls it.

BUG=370696

Review URL: https://codereview.chromium.org/1162833003

Cr-Commit-Position: refs/heads/master@{#333053}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/89d5988..cb67414

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1170593002

Cr-Commit-Position: refs/heads/master@{#333052}

In order making testing more convenient, this CL does the following
refactoring:

- Creates a new virtual CreateCharacteristicsFinder in
BluetoothLowEnergyConnection;
- Starts the connection on BluetoothLowEnergyConnection after a call to
Connect() (this was already suggested by tengs@ in a previous CL);
- Creates a new protected constructor in BluetoothCharacteristicsFinder;
- Mocks for BluetoothCharacteristicsFinder and
BluetoothLowEnergyConnection;

The unit tests covers the Connect() and Disconnect() execution paths. A
second part will cover receiving bytes and Send().

This CL also fixes some small bugs on BluetoothLowEnergyConnection.

BUG=

Review URL: https://codereview.chromium.org/1144333007

Cr-Commit-Position: refs/heads/master@{#333051}

There are actually two changes here:
. Convert HTMLViewerApplication to use an ApplicationImpl rather than
  be an Application.
. Make HTMLDocument use services from the application it was created
  for rather than HTMLViewer's application.

BUG=none
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/1165013005

Cr-Commit-Position: refs/heads/master@{#333050}

Previously OverscrollWindowDelegate sometimes would call OnOverscrollModeChange on its delegate even if the overscroll mode didn't change. Specifically this happened for OVERSCROLL_NONE when an overscroll-cancelling condition such as a mouse move would occur.

This could confuse OverscrollWindowAnimation and make it cancel the overscroll animation which shouldn't have been cancelled. On Windows there is currently a mouse event dispatched after each swipe on the touch screen, so this caused crbug.com/493672.

BUG=493672

Review URL: https://codereview.chromium.org/1167013002

Cr-Commit-Position: refs/heads/master@{#333049}

TEST=FocusControllerApiTest.DuplicateActivationEvents
TEST=FocusControllerApiTest.ActivationEvents
TEST=FocusControllerMouseEventTest.DuplicateActivationEvents
TEST=FocusControllerMouseEventTest.ActivationEvents
TEST=FocusControllerGestureEventTest.DuplicateActivationEvents
TEST=FocusControllerGestureEventTest.ActivationEvents
TEST=FocusControllerHideTest.ActivationEvents
TEST=FocusControllerDestructionTest.ActivationEvents
TEST=FocusControllerRemovalTest.ActivationEvents

BUG=489813, 489814

Review URL: https://codereview.chromium.org/1151133003

Cr-Commit-Position: refs/heads/master@{#333048}

This reverts commit 5d18b249.

Reason: Broke iOS build: http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/27843

NOTRY=true
NOTREECHECKS=true
BUG=465354
TBR=sievers@chromium.org,nick@chromium.org

Review URL: https://codereview.chromium.org/1153503009

Cr-Commit-Position: refs/heads/master@{#333047}

Several bots occasionally fail commands immediately following calls to
DeviceUtils.EnableRoot with "device not found" errors. I think this may
be because adb wait-for-device can come back before the device is
completely available. Switching to WaitUntilFullyBooted should ensure
that the device has returned to a usable state (or is actually gone).

BUG=493900

Review URL: https://codereview.chromium.org/1167903006

Cr-Commit-Position: refs/heads/master@{#333046}

As |GaiaAuthFetcher::CreateAndStartGaiaFetcher| can already be
specialized by a subclass, |GaiaAuthFetcher::CancelRequest| should as
well, to allow specialized fetchers to be cancelled.

BUG=495597

Review URL: https://codereview.chromium.org/1153293004

Cr-Commit-Position: refs/heads/master@{#333045}

The results of this test will improve dramatically when
crbug.com/317007 is fixed.

BUG=317007

Review URL: https://codereview.chromium.org/1157093002

Cr-Commit-Position: refs/heads/master@{#333044}

This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.

BUG=465354
TBR=nick@chromium.org

Review URL: https://codereview.chromium.org/1159623009

Cr-Commit-Position: refs/heads/master@{#333043}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f54e04d..ea9a19d

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1143333007

Cr-Commit-Position: refs/heads/master@{#333042}