GitLab

Revert 291214 "Fixes three crashes" in an attempt to find the cause of Athena related unit test failures on the ASAN bot.

http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=2862

> Fixes three crashes
>  * AppListViewDelegate was accessing deleted search_provider.
>  * DeviceSocketListener::StopListening can happen after DeviceSocketManager is deleted
>  * Explicitly delete FilePathWatcher. This was causing
>    recursive callback to FilePathWatcherImpl::Cancel from
>    FilePathWatcherImpl::CancelOnMessageLoopThread, which
>    caused crash.
> 
> 
> Clean ups
>  * change OnIO to OnFILE as they run on FILE thread.
>  * removed unused singleton related code.
> 
> BUG=None
> TEST=Run athena_main on desktop and close window.
> 
> Review URL: https://codereview.chromium.org/490033003

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/467003003

Cr-Commit-Position: refs/heads/master@{#291394}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291394 0039d316-1c4b-4281-b951-d872f2087c98

The manifest_parser.{h,cc} files are colliding with new files I'm
creating for the Web Manifest feature. Appcache manifest files should
be prefixed by "appcache".

BUG=None
NOTRY=true
TBR=torne (for third_party_files_whitelist.txt)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291388

Review URL: https://codereview.chromium.org/469413003

Cr-Commit-Position: refs/heads/master@{#291393}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291393 0039d316-1c4b-4281-b951-d872f2087c98

Include the stack trace of the code that triggered the error.
Refactored the error generation method to prevent extension
code from breaking the state of the internals.

BUG=404406

Review URL: https://codereview.chromium.org/482603002

Cr-Commit-Position: refs/heads/master@{#291392}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291392 0039d316-1c4b-4281-b951-d872f2087c98

Fails check_licenses

> Rename appcache/manifest_parser* to appcache/appcache_manifest_parser*.
> 
> The manifest_parser.{h,cc} files are colliding with new files I'm
> creating for the Web Manifest feature. Appcache manifest files should
> be prefixed by "appcache".
> 
> BUG=None
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/469413003

TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/493383003

Cr-Commit-Position: refs/heads/master@{#291391}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291391 0039d316-1c4b-4281-b951-d872f2087c98

This patch does three things:

1. Implements the Blink platform interface WebCredentialManagerClient by
   adding a CredentialManagerClient class to the password manager component.

2. Wires that implementation up to Blink's platform layer by creating an
   instance of the new client, held in ChromeContentRendererClient, and
   setting it as each new RenderView's client.

3. Stubs out IPCs for the renderer to pass messages up to the browser in
   order to do the heavy lifting of actually answering Blink's requests by
   generating and delivering Credential objects.                                                                                                             

BUG=400674
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/464883002

Cr-Commit-Position: refs/heads/master@{#291390}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291390 0039d316-1c4b-4281-b951-d872f2087c98

Screenshots available on the bug.

BUG=394303

Review URL: https://codereview.chromium.org/487193003

Cr-Commit-Position: refs/heads/master@{#291389}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291389 0039d316-1c4b-4281-b951-d872f2087c98

The manifest_parser.{h,cc} files are colliding with new files I'm
creating for the Web Manifest feature. Appcache manifest files should
be prefixed by "appcache".

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/469413003

Cr-Commit-Position: refs/heads/master@{#291388}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291388 0039d316-1c4b-4281-b951-d872f2087c98

Currently setZoom() doesn't check whether zoom factor provided
falls within range or not. It is possible to pass big zoom level
through 'zoom' open pdf parameter which can make browser unresponsive.

This patch updates the zoom factor provided in setZoom() to fall
within range.

BUG=303491

Review URL: https://codereview.chromium.org/475933004

Cr-Commit-Position: refs/heads/master@{#291387}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291387 0039d316-1c4b-4281-b951-d872f2087c98

Added warning_ function that highlights messages in orange in the debug
message panel.

MediaStreamTrack.onmute and MediaStreamTrack.onunmute are now
highlighted in red as an error and in orange as a warning.

BUG=None
TEST=Manually triggered the events directly.
NOTRY=TRUE

Review URL: https://codereview.chromium.org/493073002

Cr-Commit-Position: refs/heads/master@{#291386}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291386 0039d316-1c4b-4281-b951-d872f2087c98

The class is extracted from EventRouter of Files.app.
It is going to manage device states and dispatch the device events.

BUG=360946, 396258
TEST=add unit tests

Review URL: https://codereview.chromium.org/472603004

Cr-Commit-Position: refs/heads/master@{#291384}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354881
TBR=ygorshenin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/494223003

Cr-Commit-Position: refs/heads/master@{#291383}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370025

Review URL: https://codereview.chromium.org/489893002

Cr-Commit-Position: refs/heads/master@{#291382}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291382 0039d316-1c4b-4281-b951-d872f2087c98

Closing a file should not be abortable, since we could end up on files which
once opened, are never closed.

TEST=browser_tests: *FileSystemProvider*WriteFile*
BUG=405821

Review URL: https://codereview.chromium.org/497673002

Cr-Commit-Position: refs/heads/master@{#291381}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405985
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/485893009

Cr-Commit-Position: refs/heads/master@{#291380}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291380 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291379}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291379 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/495313002

Cr-Commit-Position: refs/heads/master@{#291378}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291378 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291377}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291377 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180754:180760&mode=html
TBR=wibling@chromium.org,gavinp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/498663002

Cr-Commit-Position: refs/heads/master@{#291376}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=406236

Review URL: https://codereview.chromium.org/485103005

Cr-Commit-Position: refs/heads/master@{#291375}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291375 0039d316-1c4b-4281-b951-d872f2087c98

- sizeimage DCHECK:
The video device can adjust the buffer size to be bigger
than we need as long as the data can fit. Theoretically
sizeimage should be bigger than PlaneAllocationSize. But
Exynos driver has a 256 byte padding for sizeimage. It is
rounded up when calculating coded_size. So sizeimage can
be smaller than PlaneAllocationSize. For example, say
format.fmt.pix_mp.width and height are 1920x1088.
format.fmt.pix_mp.plane_fmt[0].sizeimage is 2089216
(1920*1088+256). |sizeimage| is rounded up and |coded_size|
becomes 1920x1089. So format.fmt.pix_mp.plane_fmt[i].sizeimage
(2089216) is less than PlaneAllocationSize (1920*1090=2092800).

Also, we should not round down because the coded size is passed
VideoEncodeAccelerator::Client::RequireBitstreamBuffers.
The client will allocate buffers according to the coded size.

- bytesperline DCHECK:
bytesperline of different planes should be checked against
media::VideoFrame::row_bytes, not the width of coded size.

BUG=387701
TEST=Run Hangout in debug builds.

Review URL: https://codereview.chromium.org/406893002

Cr-Commit-Position: refs/heads/master@{#291374}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291374 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/495223002

Cr-Commit-Position: refs/heads/master@{#291373}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291373 0039d316-1c4b-4281-b951-d872f2087c98

It was introduced by http://codereview.chromium.org/426873004/

BUG=406160
TEST=Run the VDA_Unittest on ARM CrOS device

Review URL: https://codereview.chromium.org/483093005

Cr-Commit-Position: refs/heads/master@{#291372}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291372 0039d316-1c4b-4281-b951-d872f2087c98

Show "This video could not be loaded" error on playing unsupported video.

BUG=405860
TEST=manually testted

Review URL: https://codereview.chromium.org/495003002

Cr-Commit-Position: refs/heads/master@{#291371}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291371 0039d316-1c4b-4281-b951-d872f2087c98

Reason: Failure on ASAN build bots.
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(3)/builds/2854/steps/athena_unittests/logs/OneAppActivity

> Athena: Adding basic resource management framework (un-/re-loading) of V2 applications
> 
> Functionality:
> 
> The |AppRegistry| has for each running application an |AppActivityRegistry|.
> 
> The |AppActivityRegistry| knows all activities associated with the application it represents.
> It can furthermore shut the app entirely down upon resource manager request. It will then create
> an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This
> placeholder can then ask the |AppActivityRegistry| to restart the application again.
> 
> A shutdown request for the application is only performed when all activities were marked for
> UNLOAD.
> 
> If there were multiple activities upon shutdown for one app, the app has to take care of
> re-creating all windows and thus re-creating all activities. Since an activity match cannot
> be performed, the |AppActivityProxy| will only be shown once and it will show in the location
> of the most recently used activity of that app. If we later on find an app which really uses
> multiple windows and it is imperative to keep the history for all of them tact & the app is
> recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and
> try to address it in a cleaner way, but at this time that seems rather un-useful since it is
> not known if required.
> 
> BUG=388085
> TEST=AppActivityTest.*
> 
> Review URL: https://codereview.chromium.org/477523002

TBR=skuhne@chromium.org

Review URL: https://codereview.chromium.org/497013002

Cr-Commit-Position: refs/heads/master@{#291370}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291370 0039d316-1c4b-4281-b951-d872f2087c98

And while I'm at it, change the includes to use the qualified path for
the grit generated header file
($gen_dir/content/app/resources/grit/content_resources.h).

BUG=338338
TEST=None
R=avi@chromium.org,jamesr@chromium.org,thestig@chromium.org,tony@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/486573002

Cr-Commit-Position: refs/heads/master@{#291369}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405955
NOTRY=true

Review URL: https://codereview.chromium.org/484353003

Cr-Commit-Position: refs/heads/master@{#291368}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401588

Review URL: https://codereview.chromium.org/469993006

Cr-Commit-Position: refs/heads/master@{#291367}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291367 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes the list redraw partially instead of full-redraw when some contents are changed in the directory. This should improve the performance of redraw.

In addition, as the result of the fix, the cache is not flashed on partial redraw, and the issue 374713 has gone.

BUG=374713
TEST=manaul tested

Review URL: https://codereview.chromium.org/486783006

Cr-Commit-Position: refs/heads/master@{#291366}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291366 0039d316-1c4b-4281-b951-d872f2087c98

It caused a failure on Android bot:

********************************************************************************
New warnings.
Please fix, or perhaps add to /mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt
--------------------------------------------------------------------------------
M C IJU: TestCase org.chromium.content.browser.PopupZoomerTest defines setUp that doesn't call super.setUp()  At PopupZoomerTest.java
--------------------------------------------------------------------------------



Original patch comments:

> Hide PopupZoomer when the container view or window loses focus
> 
> Currently there is a method which hides all the popups but call to 
> hide PopupZoomer is missing. Added the call to hide PopupZoomer inside 
> hidePopups and hiding the zoomer when the view loses focus or the 
> window loses focus. Also added unit test code.
> 
> BUG=405477
> 
> Review URL: https://codereview.chromium.org/470193005

TBR=r.ghatage@samsung.com

Review URL: https://codereview.chromium.org/497693002

Cr-Commit-Position: refs/heads/master@{#291365}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324170
TEST=None

Review URL: https://codereview.chromium.org/474563004

Cr-Commit-Position: refs/heads/master@{#291363}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291363 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291362}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291362 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180746:180753&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/493383002

Cr-Commit-Position: refs/heads/master@{#291361}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371538
TBR=pkasting@chromium.org for include fix in chrome/browser/ui/omnibox/omnibox_edit_model.cc

Review URL: https://codereview.chromium.org/469623004

Cr-Commit-Position: refs/heads/master@{#291360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291360 0039d316-1c4b-4281-b951-d872f2087c98

Currently there is a method which hides all the popups but call to 
hide PopupZoomer is missing. Added the call to hide PopupZoomer inside 
hidePopups and hiding the zoomer when the view loses focus or the 
window loses focus. Also added unit test code.

BUG=405477

Review URL: https://codereview.chromium.org/470193005

Cr-Commit-Position: refs/heads/master@{#291359}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405345
NOTRY=true

Review URL: https://codereview.chromium.org/492393002

Cr-Commit-Position: refs/heads/master@{#291358}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291358 0039d316-1c4b-4281-b951-d872f2087c98

This patch resolves a few issues with GitilesFileSystem.

BUG=404239
NOTRY=True

Review URL: https://codereview.chromium.org/498503002

Cr-Commit-Position: refs/heads/master@{#291357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291357 0039d316-1c4b-4281-b951-d872f2087c98

dragend would never fire on mac because
BrowserPluginEmbedder::SystemDragEnded() clears |guest_dragging_over_|, which stops
BrowserPluginEmbedder::DragSourceEndedAt() to send the dragend
message.
This isn't an issue in aura b/c, we see DrageSourceEndedAt() before
SystemDragEnded().

BUG=401941
Test=On mac, load a <webview> in a chrome app, register a "dragend"
listener to a draggable div. Drag that div, observe "dragend" listener
firing properly.

Review URL: https://codereview.chromium.org/499493002

Cr-Commit-Position: refs/heads/master@{#291356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383635

Review URL: https://codereview.chromium.org/498563002

Cr-Commit-Position: refs/heads/master@{#291355}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291355 0039d316-1c4b-4281-b951-d872f2087c98

I'm changing two things to Connector:
. Removing setting destroyed_flag in NotifyError. This seems wrong
  since Connector hasn't been destroyed. If destoyed_flag_ was
  non-NULL and we set it to true and we're nested, then when the stack
  unravels destroyed_flag_ won't be unset even though Connector may
  not have been destroyed. This would leave Connector in a very bad
  state.
. Makes NotifyError cancel a wait. If there was a wait outstanding or
  a notification was in flight than if we don't cancel the wait we may
  very well end up back in OnHandleReady trying to do something.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/494243002

Cr-Commit-Position: refs/heads/master@{#291354}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291354 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to avoid a pairing request prompt when connecting to a service on
a system that tries to upgrade the connection from general bonding to general
bonding with MITM protection, which according to Android and ChromeOS Bluetooth
experts is the correct behavior.

BUG=403069
TEST=chrome.easyUnlockPrivate.connectToBluetoothServiceInsecurely() should work
     just like chrome.bluetoothSocket.connect(), but not show a pairing request
     prompt when pairing with Android L.
R=tengs@chromium.org, keybuk@chromium.org

Review URL: https://codereview.chromium.org/491753002

Cr-Commit-Position: refs/heads/master@{#291353}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291353 0039d316-1c4b-4281-b951-d872f2087c98