GitLab

BUG=409938
NOTRY=true

Review URL: https://codereview.chromium.org/520303004

Cr-Commit-Position: refs/heads/master@{#293601}

Make sure the Activity is updated when the theme-color changes. Also, update the
background color from UpdateWindowIcon() override, instead of from UpdateWindowTitle(),
since the latter doesn't get called if the title didn't actually change, and so
just changing the color doesn't actually update the view.

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/549593002

Cr-Commit-Position: refs/heads/master@{#293600}

This adds support for expressions like

    Switch(arg)
      .Case(1, result1)
      .CASES((2, 3), result2)
      .Default(result3)

Currently these expressions are compiled simply as short-hand for

    If(arg == 1, result1)
      .ElseIf(arg == 2 || arg == 3, result2)
      .Else(result3)

but in the future we should be able to optimize it better.

The CASES macro ugliness is unfortunately necessary until we're
allowed to use C++11.  Later we'll be able to change it to
real C++ code like "Cases({2, 3}, result2)" (which clang-format
will then format a bit more nicely too).

BUG=408845
R=jln@chromium.org, jorgelo@chromium.org

Review URL: https://codereview.chromium.org/438683004

Cr-Commit-Position: refs/heads/master@{#293599}

Also updates the text for the candidate properties to follow the current spec.

BUG=402560

Review URL: https://codereview.chromium.org/468393003

Cr-Commit-Position: refs/heads/master@{#293598}

BUG=318977

Review URL: https://codereview.chromium.org/542823002

Cr-Commit-Position: refs/heads/master@{#293597}

Replaces a CHECK() with a parser error when reserved "depends on" values
appear in the sample flags.

BUG=410404
TESTS=TrackRunIteratorTest.SampleInfoTest_ReservedInSampleFlags,
 TrackRunIteratorTest.SampleInfoTest_ReservedInDefaultSampleFlags

Review URL: https://codereview.chromium.org/540503003

Cr-Commit-Position: refs/heads/master@{#293596}

Revert of Make ui gn check pass. Misc GN build improvements. (patchset #3 id:40001 of https://codereview.chromium.org/545313002/)

Reason for revert:
Broke http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/11835

[783/786 | 258.324] LINK ./chrome
FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -pthread -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=none -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link= -Wl,--disable-new-dtags -o ./keyboard_unittests -Wl,--start-group @./keyboard_unittests.rsp  -Wl,--end-group  -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0 -ludev -lfontconfig -lX11 -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXss -lXtst -lpangocairo-1.0 -lpango-1.0 -lcairo -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lgconf-2 -lresolv -lfreetype -lasound -lXrandr -lcups -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lgcrypt -lz -lpthread -lcrypt -lm -lcap -ldbus-1 -lcrypto -lexpat
../../content/utility/utility_thread_impl.cc:38: error: undefined reference to 'content::UtilityThread::UtilityThread()'
../../content/utility/utility_thread_impl.cc:44: error: undefined reference to 'content::UtilityThread::UtilityThread()'
../../content/utility/utility_thread_impl.cc:49: error: undefined reference to 'content::UtilityThread::~UtilityThread()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Original issue's description:
> Make ui gn check pass. Misc GN build improvements.
>
> Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is.
>
> R=jamesr@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b41a8d6e789ac5df9a6d314cd0ad59f584f53dea

TBR=jamesr@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/546943003

Cr-Commit-Position: refs/heads/master@{#293595}

BUG=

Review URL: https://codereview.chromium.org/543073003

Cr-Commit-Position: refs/heads/master@{#293594}

While working on https://codereview.chromium.org/542733002/ to fix
issue 410276, a question came up about how important OpenPrevEntry was
to maintain; it made that CL more complex and for what users?

It turns out, it's not really used. See
https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/wlMR_zNJ85k
for a discussion.

Let's remove it and save ourselves some headaches.

R=clamy@chromium.org
BUG=410276

Review URL: https://codereview.chromium.org/547513002

Cr-Commit-Position: refs/heads/master@{#293593}

Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/545313002

Cr-Commit-Position: refs/heads/master@{#293592}

"b=" -- the build number
"p=" -- the patch number
"c=" -- the client type (current values are "ios", "android", and "webview")

Currently, b and p only make sense for chrome types and are only being implemented for ios and android.

BUG=409934

Review URL: https://codereview.chromium.org/530153002

Cr-Commit-Position: refs/heads/master@{#293591}

focus_manager.js with it.

R=arv@chromium.org
BUG=393873
NOTRY=true

Review URL: https://codereview.chromium.org/507573002

Cr-Commit-Position: refs/heads/master@{#293590}

Remove the existing blacklist and whitelist allowed futex operations instead.
The semantics change a little bit as none of the "priority inheritance" operations
are allowed.

BUG=408847
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/550473002

Cr-Commit-Position: refs/heads/master@{#293589}

Recently string containing the SVN revision has changed. This change handles
both. Examples below.
Old: https://chromium.googlesource.com/chromium/src/+/01188669a2b154818e5db03cc36fb2dd23b8d947
New: https://chromium.googlesource.com/chromium/src/+/13cb79e07dcf1138a35a82e312aea265b06e8879

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/547733003

Cr-Commit-Position: refs/heads/master@{#293588}

Revert of Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (patchset #1 id:1 of https://codereview.chromium.org/546073002/)

Reason for revert:
This revert did not fix the pixel tests

Original issue's description:
> Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (patchset #5 id:80001 of https://codereview.chromium.org/520793002/)
>
> Reason for revert:
> Looks like it may have broken the layout tests.
>
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31264
>
> Original issue's description:
> > Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc.
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/37ffe8f81510bbfb82b48640aa96fe7e51efc654
>
> TBR=enne@chromium.org,senorblanco@chromium.org,sugoi@chromium.org,danakj@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://chromium.googlesource.com/chromium/src/+/cea33af6d0b2c2c1805ef016da5161fc0ed540a0

TBR=enne@chromium.org,senorblanco@chromium.org,sugoi@chromium.org,danakj@chromium.org,robertphillips@google.com,reveman@chromium.org,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/547763003

Cr-Commit-Position: refs/heads/master@{#293587}

Switch to updated battery icons with less-opaque backgrounds
that are more visible against the white notification
background.

BUG=166645
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/549573003

Cr-Commit-Position: refs/heads/master@{#293586}

https://chromium.googlesource.com/chromium/blink/+log/dcd4f892fb78a6f808982633fbc7398714f157be..86ce4af33b763b24cf2365d8cd19a2ebade676c3
TBR=arv@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/543183002

Cr-Commit-Position: refs/heads/master@{#293585}

BUG=1
TBR=mal@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/542173003

Cr-Commit-Position: refs/heads/master@{#293584}

Adding support for the optional_field_style=reftypes flag.
This is needed for the invalidation client which expects
"boxed" types (e.g., Boolean rather than boolean) for
primitive fields, and depends on null comparisons to
determine whether or not a field is set.

BUG=377891,411282
R=nyquist@chromium.org

Review URL: https://codereview.chromium.org/549543002

Patch from Colin Meek <meek@chromium.org>.

Cr-Commit-Position: refs/heads/master@{#293583}

The whitelist allows the alpha_enabled flag to be used on Beta and Stable
channels.

BUG=410550
TBR=jackhou@chromium.org, benwells@chromium.org
TEST=verify on Chrome OS device that wallpaper picker works on Beta channel.

Review URL: https://codereview.chromium.org/546103002

Cr-Commit-Position: refs/heads/master@{#293582}

Build spew goes from 1.3K to 0.5K lines.

BUG=411461
NOTRY=true

Review URL: https://codereview.chromium.org/550463002

Cr-Commit-Position: refs/heads/master@{#293581}

clang didn't like the reinterpret_cast either:
..\..\sandbox\win\sandbox_poc\pocdll\registry.cc(24,10) :  error(clang): case value is not a constant expression
    case reinterpret_cast<LONG_PTR>(HKEY_USERS):
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
..\..\sandbox\win\sandbox_poc\pocdll\registry.cc(24,10) :  note(clang): reinterpret_cast is not allowed in a constant expression

Since this function doesn't prevent any duplication, just kill
it and pass the string to Try() manually.

No behavior change.

BUG=82385
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/543153002

Cr-Commit-Position: refs/heads/master@{#293580}

Now that the new GN has landed with support for this, we can start using this flag.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/532423003

Cr-Commit-Position: refs/heads/master@{#293579}

BUG=411083
R=dbeam@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/544273002

Cr-Commit-Position: refs/heads/master@{#293578}

During teardown it's possible to race calling Renderer::GetMediaTime()
on the main thread with ~Renderer() on the media thread.

This was introduced in be9da705 by
moving the TimeDeltaInterpolator (which used to never get destroyed)
into Renderer (which does get destroyed during error/stop).

BUG=411320

Review URL: https://codereview.chromium.org/545943004

Cr-Commit-Position: refs/heads/master@{#293577}

TBR=robertphilips@chromium.org

Review URL: https://codereview.chromium.org/546893002

Cr-Commit-Position: refs/heads/master@{#293576}

FrameBuffer is basically a superset of FrameInfo, so let's merge FrameIdMap with Framer and
use FrameBuffer instead of FrameInfo.

No functional changes, only refactoring.

Review URL: https://codereview.chromium.org/540713002

Cr-Commit-Position: refs/heads/master@{#293575}

There can be TabModels which know about Tabs that are not
alive and cannot yet be instantiated.  Do NULL checks before
checking the Tabs.

BUG=403592
R=dgozman@chromium.org, dtrainor@chromium.org

Review URL: https://codereview.chromium.org/542953002

Cr-Commit-Position: refs/heads/master@{#293574}

It appears that RenderWidgetHostViewMac::Destroy is never getting
called in some instances, and that is resulting in crashes when we end
up in its destructor, which is called by Objective C's runtime.

I suspect that this is a leak somewhere, and that on other platforms we
simply never call the destructor.

Call the necessary bits of RenderWidgetHostViewMac::Destroy to avoid
crash when a RenderWidgetHostImpl reaches its destructor before its
view_ has been reset.

Also, turn the weak pointers to RenderWidgetHostViewBase in
RenderWidgetHostImpl and RenderWidgetHostViewGuest
to use base::WeakPtr to prevent the many dangling instances.

BUG=404828

Review URL: https://codereview.chromium.org/538883002

Cr-Commit-Position: refs/heads/master@{#293573}

Followup of https://codereview.chromium.org/317093002/. This CL adds tests for showing confirmation dialog for unsecure signin.

As prerequisite, this CL also,

1. changes the signin continue url to a local page in the gaia auth extension.
2. adds LoginUiService::Observer events for showing signin confirmation dialog for unsecure signin.
3. fixes broken methods in FakeGaia

BUG=368905

Review URL: https://codereview.chromium.org/418043002

Cr-Commit-Position: refs/heads/master@{#293572}

And validate them accordingly (all-space names are still empty and invalid).

BUG=405913
TEST=Go to chrome://settings. Try to enter "      " for the profile name. The
textbox should stay red. Enter "     batman    " for the profile name, and save.
The name should be saved as just "batman". Expect some bat signals.

Review URL: https://codereview.chromium.org/532023003

Cr-Commit-Position: refs/heads/master@{#293571}

In the interest of phasing out the totally unnecessary
*Chrome*ExtensionFunction base classes, this establishes a
ChromeExtensionFunctionDetails object which can be created
by extension function implementations in //chrome who need
access to Chrome-specific details.

This object can be very easily composed into such function
implementations such that they can move away from using
e.g. ChromeAsyncExtensionFunction or
ChromeUIThreadExtensionFunction as a base class and instead
rely on more universal and generic ExtensionFunction and its
immediate derivatives.

A conversion of the tabs API ExecuteCodeInTabFunction is
included for demonstration purposes.

BUG=None
R=scheib@chromium.org
CC=lfg@chromium.org

Review URL: https://codereview.chromium.org/543873002

Cr-Commit-Position: refs/heads/master@{#293570}

The DENIED judgement set by DenyCertForHost is never actually used to
make any interstitial decisions (it is, in fact, explicitly treated as
unknown). To simplify the API and make it cleaner, this change removes
DenyCertForHost from ssl_policy_backend.h and ssl_host_state_delegate.h
and the related classes.

BUG=402764

Review URL: https://codereview.chromium.org/465133004

Cr-Commit-Position: refs/heads/master@{#293569}

Revert of Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc. (patchset #5 id:80001 of https://codereview.chromium.org/520793002/)

Reason for revert:
Looks like it may have broken the layout tests.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31264

Original issue's description:
> Use SkSurface and SkImage instead of SkGpuDevice and SkBitmap in cc.
>
> Committed: https://chromium.googlesource.com/chromium/src/+/37ffe8f81510bbfb82b48640aa96fe7e51efc654

TBR=enne@chromium.org,senorblanco@chromium.org,sugoi@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/546073002

Cr-Commit-Position: refs/heads/master@{#293568}

Review URL: https://codereview.chromium.org/509253003

BUG=410611

Review URL: https://codereview.chromium.org/540673003

Cr-Commit-Position: refs/heads/master@{#293567}

Switching the use_athena gyp-flag only affects the code inside //chrome. So move
the USE_ATHENA inside //chrome so that toggling the flag doesn't cause all
targets to be rebuilt, and only code inside //chrome is rebuilt instead. This
should also prevent accidental dependence on USE_ATHENA in code outside of
//chrome.

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/541983002

Cr-Commit-Position: refs/heads/master@{#293566}

I changed analyzer such that if a gyp file (or an included gypi file)
changes all targets in the gyp file are marked as changed. This means
I should no longer have to special case gyp files. I'm leaving the
exception in place for any gyp files in build as any change to those
really needs to recompile the world.

BUG=109173
TEST=none
R=thakis@chromium.org

Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b

Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333

Review URL: https://codereview.chromium.org/512693004

Cr-Commit-Position: refs/heads/master@{#293565}

It was rebased incorrectly and the new findbugs (from a move) weren't added.
BUG=398263
R=boliu@chromium.org
TBR=boliu

Review URL: https://codereview.chromium.org/544303002

Cr-Commit-Position: refs/heads/master@{#293564}

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/537633004

Cr-Commit-Position: refs/heads/master@{#293563}

Previously, only BS/DEL set this guard but there are cases with keyboards
that send single characters immediately followed by a composition (e.g.
swiping words on stock Google keyboard) and we want to make sure that
there is no race condition where the actions taken in response to the
KeyPress don't cancel the following composition.

BUG=408678

Review URL: https://codereview.chromium.org/518123002

Cr-Commit-Position: refs/heads/master@{#293562}