- 21 Jun, 2014 1 commit
-
-
newt@chromium.org authored
This also removes the yellow "warning" background variation, so all infobars now have the same background color. BUG=375379 R=dfalcantara@chromium.org Review URL: https://codereview.chromium.org/346853005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278877 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Jun, 2014 39 commits
-
-
pshenoy@chromium.org authored
NOTRY=True Review URL: https://codereview.chromium.org/337923007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278870 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
The Java bridge erroneously did a "delete this" on the observer when request completion was signaled. That is not necessary, since the BitmapFetcherService takes ownership of all observers. As a result of this, there is also no need for the observer to signal request completion. If clients are interested in taking action on completion, they can do so in the Observer's destructor. TBR=sky@chromium.org, tedchoc@chromium.org BUG=380916 NOTRY=true Review URL: https://codereview.chromium.org/341083008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278869 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
Now the --experimental-web-platform-features flag solely controls whether Service Worker is web-exposed. This lets us remove a virtual test suite and also exposes more of SW to perf and crash monitoring before actually shipping. This is a clone of https://codereview.chromium.org/339973003/ by falken@ with a trivial browsertest fix. BUG=365201 TBR=falken,michaeln,jam,kalman Review URL: https://codereview.chromium.org/348843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278868 0039d316-1c4b-4281-b951-d872f2087c98
-
courage@chromium.org authored
This change makes some small tweaks to identity.email and getProfileUserInfo based on apps-dev feedback, and enables them in stable. The UI string for identity.email now reads "Know your email address". chrome.identity.getProfileUserInfo can be called without the email permission (in which case it returns an ID only). BUG=368343 Review URL: https://codereview.chromium.org/337423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278867 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
BUG=361318 TEST=Enabled new tests. R=jam@chromium.org, shadi@chromium.org Review URL: https://codereview.chromium.org/345223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278866 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=370746 NOTRY=true Review URL: https://codereview.chromium.org/342323009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278865 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
TBR=dnicoara NOTRY=true Review URL: https://codereview.chromium.org/348923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278864 0039d316-1c4b-4281-b951-d872f2087c98
-
aruslan@chromium.org authored
BUG=382309 NOTRY=True Review URL: https://codereview.chromium.org/346753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278863 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=none R=kalman@chromium.org, sbc@chromium.org Review URL: https://codereview.chromium.org/344183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278862 0039d316-1c4b-4281-b951-d872f2087c98
-
yukishiino@chromium.org authored
http://crrev.com/173803002 introduced WebView::NotifyMaybeTextInputClientChanged, but the CL missed some cases. We should be aware of more cases that the underlying web_contents may change. - When an interstitial page is attached / detached - When the render process is gone browser_tests are broken with these cases when --enable-text-input-focus-manager enabled. This CL fixes the broken tests. BUG=290701 TEST=Run browser_tests with --enable-text-input-focus-manager enabled. Review URL: https://codereview.chromium.org/347103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278861 0039d316-1c4b-4281-b951-d872f2087c98
-
sievers@google.com authored
Cconsolidate the logic inside gl_fence.cc to allow checking if a GLFence can be created. R=reveman@chromium.org Review URL: https://codereview.chromium.org/331293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278860 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
The Non-SFI implementation of OpenResource is pretty complicated. This is because the logic to support that operation was entirely in the trusted plugin. Now, we can perform the necessary logic entirely in Chromium, so it can be made much simpler. CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32 BUG=239656 Review URL: https://codereview.chromium.org/339213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278859 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
No longer need this PostTask hack since enabling ubercomp in android webview. This essentially reverts r259875 BUG=344087 Review URL: https://codereview.chromium.org/344863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278858 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@chromium.org authored
Remove old "Async" prefix from a time when FileStream could perform sync operations, and use base::File methods instead of reimplement them. Remove a TODO from native_message_process_host given that we decided it is not worth moving that functionality to FileStream ATM. BUG=322664 TBR=sergeyu@chromium.org, kinuko@chromium.org R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/323683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278857 0039d316-1c4b-4281-b951-d872f2087c98
-
simonhatch@chromium.org authored
If transition-entering-stylesheet is defined in the response headers for the incoming document, they're parsed out, passed to the TransitionPageHelper in the embedder, and are applied to the page via addStyleSheetByUrl at the appropriate time in the transition. This is the chrome side of the CL, blink side here: https://codereview.chromium.org/285623003/ Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5 BUG=370696 Review URL: https://codereview.chromium.org/309143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278856 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
Optimized 51/86 files in 01:05:47s Result: 57369 => 40173 bytes (17196 bytes: 29%) BUG=387254 TBR=msw@chromium.rog Review URL: https://codereview.chromium.org/332343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278855 0039d316-1c4b-4281-b951-d872f2087c98
-
mohammed@chromium.org authored
When the extension/app requests to read and modify the accessibility settings, two messages are displayed to the user during install-time. The CL aims to combine these into one message to say "Read and modify ...". BUG=344566 R=jww,meacer,kalman Review URL: https://codereview.chromium.org/324273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278854 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
First stop to fix favicon for fractional scale factor. I'll convert the rest of ui::ScaleFactor in 38 BUG=376367,381601 R=pkotwicz@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/335233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278853 0039d316-1c4b-4281-b951-d872f2087c98
-
yzshen@chromium.org authored
> Ensure all members of OriginChipInfo/OriginChipView get initialized. > > BUG=382921 > TEST=none > TBR=gbillock > > Review URL: https://codereview.chromium.org/345183005 TBR=pkasting@chromium.org Review URL: https://codereview.chromium.org/341313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278851 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
IPC enforces a limit on receipt, but we should check on the sending side and reject the (un)registration promise too. BUG=386724 R=falken@chromium.org, michaeln@chromium.org Review URL: https://codereview.chromium.org/342163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278850 0039d316-1c4b-4281-b951-d872f2087c98
-
mkosiba@chromium.org authored
The android_webview build will require there only be a single R class (details in bug). This change makes the necessary changes to the build infrastructure for this to happen but the actual swap to building the webview this way will land as a subsequent CL. BUG=387155 build-only change, all trybots compile fine. NOTRY=true Review URL: https://codereview.chromium.org/255613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278849 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
The CL disables the incognito link on the gaia page if parental control is on. It adds a cached version for windows parental control check so that it may be accessed from IO thread. A similar CL for thread-safe android parental control check is under review at https://chrome-internal-review.googlesource.com/#/c/166265/. BUG=383682 Review URL: https://codereview.chromium.org/336213005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278848 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
The ComponentCloudPolicyService needs to work with the SchemaRegistry, so it was initially owned by the DeviceLocalAccountPolicyProvider (which always has a valid reference to the registry). However, this means that the ComponentCloudPolicyService can't precache any policies until the session is started. To enable precaching at enrollment time and at the login screen, the ComponentCloudPolicyService has been moved to the broker instead. This allows some code simplifications too, but requires changing the ownership of the SchemaRegistry for device local accounts. This CL is just moving code around; a subsequent CL will trigger the precaching. TBR=zelidrag@chromium.org BUG=224596 Review URL: https://codereview.chromium.org/342233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278847 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
BUG=364141 Review URL: https://codereview.chromium.org/334923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278846 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=382921 TEST=none TBR=gbillock Review URL: https://codereview.chromium.org/345183005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278845 0039d316-1c4b-4281-b951-d872f2087c98
-
powei@chromium.org authored
The Android snapshot was found to be chopping off the bottom content. This is due to not accounting for the height of the toolbar. This patch enlarges the snapshot by that offset. BUG=384551 Review URL: https://codereview.chromium.org/340603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278843 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/326283002/jamesr@chromium.org authored
Reason for revert: Need to revert the blink side and this (incorrectly) adds an OVERRIDE for a cross-repository override. Original issue's description: > Accelerate small canvases if Ganesh is on. > > cc side of change. > > TBR=phajdan.jr@chromium.org > BUG=382738 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276753 TBR=ajuma@chromium.org,kbr@chromium.org,phajdan.jr@chromium.org,chrishtr@chromium.org NOTREECHECKS=true NOTRY=true BUG=382738 Review URL: https://codereview.chromium.org/349733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278842 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
The virtual keyboard bindings will be provided by mojo soon. Until then, this is a temporary hack to provide an implementation for the missing API. The virtual keyboard shows up in athena with this last change. BUG=380215 R=bshe@chromium.org, oshima@chromium.org Review URL: https://codereview.chromium.org/348823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278841 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
In this CL: - crbug.com/343688: when editing the profile name but not changing it, the text field would freeze. this is because it would remain enabled, but hidden, and steal the button click (because it used to be a first responder) - add a separator between the "not you" and "lock" bottom option buttons, to match the mocks. I added this as a vertical separator to the BaseBubbleController itself, so that other classes can use it in the future. - center the profile name correctly. Because of the pencil icon, the name would be shifted slightly to the left - the "change photo" overlay should be more opaque - the bubble bottom corners were overlapped by the option buttons, and didn't appear rounded. BUG=343688 Review URL: https://codereview.chromium.org/323143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278840 0039d316-1c4b-4281-b951-d872f2087c98
-
cmumford@chromium.org authored
Was previously flushing the actual LevelDB table on disk and then corrupting. This approach is more loosely coupled with LevelDB disk format and lays the groundwork for future tests (and refactoring) to not rely on an actual corrupted db. Also reduced the number of test objects written to the db to 5. Review URL: https://codereview.chromium.org/334303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278838 0039d316-1c4b-4281-b951-d872f2087c98
-
epenner@chromium.org authored
We try to set the scaling governor for all CPU cores, but this doesn't work SOCs that dynamically disable cores entirely (ie. Qualcomm). Since this only happens on Qcomm, this patch stops the 'mpdecision' process on Qualcomm, which makes it behave like other devices. PERF-SHERIFFS: This may improve metrics for the better given all cores are in 'performance' mode now. It should hopefully reduce noise, since a different number of cores might have had 'performance' set on each run, and any code that runs on a non-performance core will suffer from noisy timings/rates. Example: Tough-compositor-cases std-dev went from 0.25ms to 0.04ms with this change. BUG=383566 Review URL: https://codereview.chromium.org/338233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278837 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
with -o2 Optimized 6/16 files in 00:03:20s Result: 6014 => 4014 bytes (2000 bytes: 33%) BUG=387254 TBR=msw@chromium.org Review URL: https://codereview.chromium.org/343203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278836 0039d316-1c4b-4281-b951-d872f2087c98
-
kmadhusu@chromium.org authored
To analyze the impact of prefetching high-confidence search suggestions in Android Chrome, this CL, - Adds a listener for counting Google searches from various search access points. No actual search query content is observed. - Records the search count based on the prerendering settings. (see trybot results in patchset #8). BUG=382694 R=asvitkine@chromium.org, davidben@chromium.org, jam@chromium.org, pkasting@chromium.org, samarth@chromium.org Review URL: https://codereview.chromium.org/342053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278835 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Review URL: https://codereview.chromium.org/348553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278834 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
With this change, a Key object's algorithm member is copied on every read access. Effectively preventing it's modification as required by the WebCrypto specification. BUG=385143 R=bartfab@chromium.org, kalman@chromium.org Review URL: https://codereview.chromium.org/332233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278833 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
This method doesn't belong in ExtensionService, and can instead live in PermissionsUpdater. This helps keep the permissions updating logic together. Also update PermissionsUpdater to use a browser context instead of a profile, where possible. BUG=351891 Review URL: https://codereview.chromium.org/347803005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278832 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=367863 R=avi@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/341073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278831 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
As much as I would like to keep all tests working, it seems unreasonable to hold-back performance improvements for all of Chromium (particularly android) to keep this test "passing". https://codereview.chromium.org/302063002/ BUG=387101 TBR=mnaganov@chromium.org Review URL: https://codereview.chromium.org/343213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278830 0039d316-1c4b-4281-b951-d872f2087c98
-
timvolodine@chromium.org authored
Make sure battery status works with proper default values on Android. Add an exception for battery present check for Galaxy Nexus because it wrongly reports that the battery is not present (see http://crbug.com/384348). BUG=122593, 384348, 360068 TEST=http://jsbin.com/battery-status-diagnostics (manual) Review URL: https://codereview.chromium.org/330333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278829 0039d316-1c4b-4281-b951-d872f2087c98
-