GitLab

... also use range-based for loops in some nearby places.

R=cmumford@chromium.org
BUG=554289

Review-Url: https://codereview.chromium.org/2255853003
Cr-Commit-Position: refs/heads/master@{#412703}

Currently the following commands do not behave similarly to Cocoa textfields
when the selection direction changes-
-moveWordForwardAndModifySelection
-moveWordBackwardAndModifySelection
-moveToBeginningOfLineAndModifySelection
-moveToEndOfLineAndModifySelection
-moveToBeginningOfParagraphAndModifySelection
-moveToEndOfParagraphAndModifySelection
-moveToEndOfDocumentAndModifySelection
-moveToBeginningOfDocumentAndModifySelection
-moveParagraphForwardAndModifySelection
-moveParagraphBackwardAndModifySelection
-moveWordRightAndModifySelection
-moveWordLeftAndModifySelection
-moveToLeftEndOfLineAndModifySelection
-moveToRightEndOfLineAndModifySelection

This CL adds a new enum gfx::SelectionBehavior which specifies whether a
selection is to be made and how. RenderText::MoveCursor() is modified to take
this enum as a parameter. Also, two new text edit commands are added to the
ui::TextEditCommand enum-
-MOVE_PARAGRAPH_BACKWARD_AND_MODIFY_SELECTION
-MOVE_PARAGRAPH_FORWARD_AND_MODIFY_SELECTION

Textfield::IsTextEditCommandEnabled is modified to enable the following commands on
Mac-
 -MOVE_DOWN:
 -MOVE_DOWN_AND_MODIFY_SELECTION:
 -MOVE_PAGE_DOWN:
 -MOVE_PAGE_DOWN_AND_MODIFY_SELECTION:
 -MOVE_PAGE_UP:
 -MOVE_PAGE_UP_AND_MODIFY_SELECTION:
 -MOVE_UP:
 -MOVE_UP_AND_MODIFY_SELECTION:

Further, Textfield::ExecuteEditCommand is modified to set the correct
SelectionBehavior value for the different text editing commands. Also, lots of
tests are added.

This CL should have no behavior change for non-Mac platforms.

BUG=613438, 586985

Review-Url: https://codereview.chromium.org/2228833002
Cr-Commit-Position: refs/heads/master@{#412702}

https://chromium.googlesource.com/chromium/src/+/2cf52b959

BUG=482229
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/2253353002 .

Cr-Commit-Position: refs/heads/master@{#412701}

Adds the number of prior dismissals and ignores to the permission report.

BUG=613883

Review-Url: https://codereview.chromium.org/2250893002
Cr-Commit-Position: refs/heads/master@{#412700}

This is in preparation for adding UI. Will keep the future code grouped
together.

BUG=609556

Review-Url: https://codereview.chromium.org/2258573002
Cr-Commit-Position: refs/heads/master@{#412699}

When scaling tiles using Core Animation, certain tile sizes / scale
factors appear to cause rounding issues and seams between tiles.

Rounding tiles to a multiple of 64 works around the
most obvious case of this, which is seen on the print preview screen.

BUG=632274
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:win10_blink_rel;master.tryserver.blink:mac10.11_blink_rel

Review-Url: https://codereview.chromium.org/2251583002
Cr-Commit-Position: refs/heads/master@{#412698}

Fixing print preview closing in g-mail bug caused ALT + left
arrow to break for certain cases. Changed condition for not
closing dialog to be more specific.

BUG=636234, 634237

Committed: https://crrev.com/d65b6608c1349ba70606565b2bed9ff8b016473a
Review-Url: https://codereview.chromium.org/2215063002
Cr-Original-Commit-Position: refs/heads/master@{#410717}
Cr-Commit-Position: refs/heads/master@{#412697}

Although not documented on SDK page, this is possible in DownloadManager
source code.

BUG=618458

Review-Url: https://codereview.chromium.org/2242213006
Cr-Commit-Position: refs/heads/master@{#412696}

This CL explicitly enables the persistence toggle for geolocation
prompts on Android, and tests geolocation requests with the toggle on
and off.

BUG=632269

Review-Url: https://codereview.chromium.org/2251673002
Cr-Commit-Position: refs/heads/master@{#412695}

https://chromium.googlesource.com/chromium/src/+/c4cb58f53

BUG=466200
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/2245263008 .

Cr-Commit-Position: refs/heads/master@{#412694}

BUG=638692

Review URL: https://codereview.chromium.org/2252263002 .

Cr-Commit-Position: refs/heads/master@{#412693}

BUG=None
R=xhwang@chromium.org
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2248283003
Cr-Commit-Position: refs/heads/master@{#412692}

BUG=621139

In preparation for https://codereview.chromium.org/2118853002/, two other
CLs were landed first.  Because the main CL was abandoned in favor of a
simpler approach, we are reverting one of these two preparatory CLs:

https://codereview.chromium.org/2197613002/ made major changes to the
prototype of PaintTabBackgroundUsingFillId() in order to force it to be
a non-method.  These and some related changes are now unnecessary, and
are being reverted here.  NOTE: The revert was done manually, so other
subsequent changes should be preserved.

(NOTE: https://codereview.chromium.org/2150013002/ moved a number of
static members and methods of the Tab class into the anonymous namespace,
along with a few methods that were "mostly static".  These changes are
considered a general code improvement, and are being left alone.)

Review-Url: https://codereview.chromium.org/2255823002
Cr-Commit-Position: refs/heads/master@{#412691}

Corrects some data being improperly guarded by locks.

connection_filters_ must always be accessed under lock. This change
will lead to deadlock if any filter tries to add or remove filters
during OnConnect, but 1) nobody is doing that yet and 2) it is
currently unsafe to do this already. With guaranteed deadlock at
least it's now impossible to do by accident.

Refines the thread checking in ConnectionFilterImpl
to allow for destruction on any thread if OnConnect has never
been called. This guards against ConnectionFilterImpls being
added after shutdown is initiated. This state may not be reachable
in practice since we shouldn't bring up new RPHIs during shutdown,
but it seems reasonable to express more accurate constraints here
and the change is trivial.

Finally, this also allows the IOThreadContext's internal
MessageLoopObserver (nee "Obs"?) to be cleaned up when the
IOThreadContext is shut down, rather than leaving all of them
around until shutdown. This is worthwhile since incognito
BrowserContexts may be created and destroyed arbitrarily many
times in a normal browser session, accumulating many such
observers which would otherwise live indefinitely.

BUG=638581
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2245333005
Cr-Commit-Position: refs/heads/master@{#412690}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b3ea8fe90272..77756a527391

$ git log b3ea8fe90..77756a527 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2255683003
Cr-Commit-Position: refs/heads/master@{#412689}

For the SchemaMap, use unique_ptrs instead of linked_ptrs. Also clean
up the implementation a little.

BUG=None

Review-Url: https://codereview.chromium.org/2255953002
Cr-Commit-Position: refs/heads/master@{#412688}

Previously, gn gen would expand all imports and only record the final
arg keyvalue pairs in args.gn, if called as gn gen --args='import...'.

Now the actual import statement will be recorded. This allows avoiding
a manual args.gn edit of you want an actual import statement there, for
example if the imported gni houses a predefined set of default args
that you want to follow, and want to re-gn when it changes.

R=brettw@chromium.org,dpranke@chromium.org
BUG=588513

Review-Url: https://codereview.chromium.org/2250623004
Cr-Commit-Position: refs/heads/master@{#412687}

BUG=637037
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2257513003
Cr-Commit-Position: refs/heads/master@{#412686}

It was hidden to the user since chrome://gpu was not showing
any workarounds, but they were still applied in the gpu process.

Also add a gpu test that sets
--disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing
and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND
in both browser and gpu processes.

BUG=359367

R=kbr@chromium.org, zmo@chromium.org

TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755
Review-Url: https://codereview.chromium.org/2195743005
Cr-Original-Commit-Position: refs/heads/master@{#409197}
Cr-Commit-Position: refs/heads/master@{#412685}

Revert of Refactoring button field and its type (patchset #13 id:240001 of https://codereview.chromium.org/2227563003/ )

Reason for revert:
Webkit tests failing on WebKit Linux MSAN

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/11748

webkit_tests webkit_tests

unexpected_failures:
imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-auto-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-none-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-button-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
imported/wpt/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html
imported/wpt/pointerevents/pointerevent_pointercancel_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-table-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-span-test_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html
imported/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html

Original issue's description:
> Refactoring button field and its type
>
> - Remove m_button field from PlatformMouseEvent as
>     there was one in WebPointerProperties.
> - Remove duplicate PlatformMouseEvent::MouseButton
>     and WebScrollbarBehavior::Button enums and use
>     WebPointerProperties::Button enum instead.
> - Making WebPointerProperties::Button an enum class.
>
> - Also cleanup related target for pointerevents. The related target for all pointerevents (similar to mouseevent) should be null except for boundary events. So relatedTarget can be removed from some of the functions as they don't send boundary events.
>
> BUG=635670
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> TBR=pfeldman@chromium.org
>
> Committed: https://crrev.com/3acb734ff34a77e76228425d06952317c10e252b
> Cr-Commit-Position: refs/heads/master@{#412552}

TBR=pdr@chromium.org,bokan@chromium.org,dtapuska@chromium.org,mustaq@chromium.org,pfeldman@chromium.org,danakj@chromium.org,sky@chromium.org,thestig@chromium.org,nzolghadr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
BUG=635670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2245063006
Cr-Commit-Position: refs/heads/master@{#412684}

The cardboard code has long been abandoned but it is still being compiled and
has dependencies on multiple active components, which gives us burden to
maintain the obsolete code. The old cardboard SDK is also being deprecated so
we have no choice other than removing these code.

This CL removes the cardboard feature and the cardboard code.

BUG=638655

Review-Url: https://codereview.chromium.org/2252123002
Cr-Commit-Position: refs/heads/master@{#412683}

* If the file associated with a download has been
  deleted through an external user action, it is styled
  differenting in the download manager UI.

* Don't allow externally deleted files to be shared.

* Refresh list of externally deleted files after
  download items are removed through the browser UI.

BUG=616324

Review-Url: https://codereview.chromium.org/2258553003
Cr-Commit-Position: refs/heads/master@{#412682}

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2259523002
Cr-Commit-Position: refs/heads/master@{#412681}

The atk GN configs were moved to a separate GN file in
https://codereview.chromium.org/1909273002 but it appears
that the original configs were not removed, and are still
referenced.  Let's remove the old configs and just use
the new ones.

And while we're at it, add an assertion to check that glib
is enabled when atk is.

BUG=632297

TBR=agrieve@chromium.org

Review-Url: https://codereview.chromium.org/2251673004
Cr-Commit-Position: refs/heads/master@{#412680}

Instead of listing the Android owners of //base/android and
//base/test/android in several GN-files, just refer to their
canonical location.

This CL also adds Android owners to approve changes to
//base/test/*android* files and the //base/test/BUILD.gn file.

BUG=None

Review-Url: https://codereview.chromium.org/2254813003
Cr-Commit-Position: refs/heads/master@{#412679}

Revert of Remove content::NotificationPermissionDispatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2244913002/ )

Reason for revert:
Causing failure on Builder WebKit Linux Leak

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22036

request-permission-detached-context.html

15:25:46.371 7635 worker/0 http/tests/notifications/request-permission-detached-context.html leaked
15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
15:25:46.374 17565 [4/95] http/tests/notifications/request-permission-detached-context.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
15:25:46.372 7635 worker/0 http/tests/notifications/request-permission-detached-context.html failed:
15:25:46.372 7635 worker/0  leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})

Original issue's description:
> Remove content::NotificationPermissionDispatcher.
>
> blink::Notification can make calls to the Mojo PermissionService itself.
>
> BUG=561879
>
> Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> Cr-Commit-Position: refs/heads/master@{#412636}

TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerkerk@chromium.org,peter@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=561879

Review-Url: https://codereview.chromium.org/2258673002
Cr-Commit-Position: refs/heads/master@{#412678}

BUG=catapult:2683

Review-Url: https://codereview.chromium.org/2254503002
Cr-Commit-Position: refs/heads/master@{#412677}

Specifically this records how many sub scopes a service worker registered
for foreign fetch with, and for the service workers that registered for
foreign fetch, this also records the number of origins they are intercepting
requests from.

BUG=540509

Review-Url: https://codereview.chromium.org/2209963002
Cr-Commit-Position: refs/heads/master@{#412676}

BUG=634572

Review-Url: https://codereview.chromium.org/2249853009
Cr-Commit-Position: refs/heads/master@{#412675}

Along the way, remove some linked_ptr usage, too.

BUG=555865,556939

Review-Url: https://codereview.chromium.org/2240083004
Cr-Commit-Position: refs/heads/master@{#412674}

After https://codereview.chromium.org/2241643003, Tab#getView() will
only return the wrapper framelyout that wraps infobars, content view or
native page view. This work simplifies the logic in
CompositorViewHolder.

BUG=635871

Committed: https://crrev.com/01dca5c74d54e47c725ae94d7714884bf51f21af
Review-Url: https://codereview.chromium.org/2248793003
Cr-Original-Commit-Position: refs/heads/master@{#412133}
Cr-Commit-Position: refs/heads/master@{#412673}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3496e088..36345583

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2253263002
Cr-Commit-Position: refs/heads/master@{#412672}

IndexedDB uses leveldb's default write buffer size of 4MB. This is usually
sufficient, but for space constrained devices, like Chromecast, this can
limit the amount of usable space because compaction requires double the
table space plus the logfile. Limiting the write buffer size reduces the
logfile size.

BUG=637847

Review-Url: https://codereview.chromium.org/2243363002
Cr-Commit-Position: refs/heads/master@{#412671}

BUG=622493

Review-Url: https://codereview.chromium.org/2248343002
Cr-Commit-Position: refs/heads/master@{#412670}

We define two new use counters, to cover the methods defined in
SVGSVGElement.idl

New use counter SVGSMILPausing covers
    void pauseAnimations();
    void unpauseAnimations();
    boolean animationsPaused();

New use counter SVGSMILCurrentTime covers
    float getCurrentTime();
    void setCurrentTime(float seconds);

Review-Url: https://codereview.chromium.org/2246023002
Cr-Commit-Position: refs/heads/master@{#412669}

BUG=629095
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2193563002
Cr-Commit-Position: refs/heads/master@{#412668}

to WebWidgetClient.

This change also renames ChromeClient::windowRect to
ChromeClient::rootWindowRect to avoid confusion with
WebWidgetClient::windowRect, since they are used for
different purposes.

This change is part of WebView/WebWidget split refactor.

BUG=583347

Review-Url: https://codereview.chromium.org/2177333002
Cr-Commit-Position: refs/heads/master@{#412667}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/56e262f146e4..b3ea8fe90272

$ git log 56e262f14..b3ea8fe90 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2251173002
Cr-Commit-Position: refs/heads/master@{#412666}

Record the amount of time continouous background video playback happens.
Record each time the render frame media is shown/hidden/resumed/paused.
Record each time the render frame media is resumed and paused in the background.

BUG=576248
TEST=browser test + manual testing

Review-Url: https://codereview.chromium.org/2218963003
Cr-Commit-Position: refs/heads/master@{#412665}

Watch time for our purposes is defined as the amount of elapsed media time
for audio+video media. A minimum of 7 seconds of unmuted, foreground media
must be watched to start watch time monitoring. Watch time is checked every
5 seconds from then on and reported to multiple buckets: All, MSE, SRC, EME,
AC, and battery.

Any one of paused, hidden, or muted is sufficient to stop watch time metric
reports. Each of these has a hysteresis where if the state change is undone
within 5 seconds, the watch time will be counted as uninterrupted.

Power events (on/off battery power) have a similar hysteresis, but unlike
the aforementioned properties, will not stop metric collection.

Each seek event will result in a new watch time metric being started and the
old metric finalized as accurately as possible.

BUG=633743
TEST=new unittest.

Review-Url: https://codereview.chromium.org/2160963002
Cr-Commit-Position: refs/heads/master@{#412664}