- 10 Sep, 2020 40 commits
-
-
My Nguyen authored
The logic in settings side is added in https://crrev.com/c/1600384. Main logic is to turn off kSpellcheckEnable when spell check is off for the 1 supported language. This is equivalent to turning off kSpellcheckEnable when hun_dictionaries is empty as it has similar origin to spellCheckEnable. They both come from users' spellcheck dictionaries pref, forced and blocked dictionaries list. More background: http://go/cros-lang-settings-spell-check-migrate Update the test in languages_page_test.js to better reflect users's action. Side effect: Originally, when users turn off spell check for all languages, spell check is left on. Now, when they turn the last one off, spell check is off as well. Related CL: https://crrev.com/c/2360093 Drive-by: Remove unused SetSingleLanguageDictionary function in test. Bug: 1113439 Change-Id: Id8700c3b357da53e22e5f79420b163c8ef50b2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390300Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805734}
-
Victor Hugo Vianna Silva authored
This class was used in a single place (to observe auto-sync settings via Android APIs), its name was very similar to the exposed AndroidSyncSettingsObserver interface, and its documentation was wrong (it treated it as AndroidSyncSettingsObserver). The CL removes the class and uses an anonymous class instead. Bug: None Change-Id: I73af1acf74b90d50e7412a50b1097668a1cfe17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403462Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#805733}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599716388-02eae1071f5b6fe6862d29aa135a2ecf5509f01d.profdata to chrome-mac-master-1599738815-ff1bf13166c585a2e1282bb43357481f321e4e87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I283c1e10a7c46675e0665f6ca93d37e3ec031149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805732}
-
Benoit Lize authored
base::Lock still regresses multiple benchmarks (see crbug.com/1125866) for a summary of regressions. Bring back the SpinLock for non-DCHECK() builds. This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2390066, with a few changes: - base::subtle::SpinLock -> base::internal::SpinLock - lock()/unlock() -> Acquire()/Release(), to match the usual naming. - Remove unused methods Another motivation for a partial revert (with inlining of SpinLock in partition_lock.h) is to prepare further work to make this lock sleep, if base::Lock's fast path doesn't improve enough. Bug: 1125866, 1125999, 1061437 Change-Id: Ia433b6da870f0a843de67f23d906d37e3f8c0806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398528Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805731}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2bd90e9b1d358b641ffbc4824f5360f179962ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401032Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805730}
-
Ben Kelly authored
Bug: 1010624 Change-Id: I40f2482ee7d81d548706a8cc46ad7669c22a9df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401913Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#805729}
-
Guillaume Jenkins authored
According to the Apple doc below, donating intents is a way for apps to tell Siri "The user just performed this action inside my app". This is used by Siri to give better results to the user when they search in Spotlight, or to give suggestions to the user on the homescreen, such as "Do you wish to Search in Chrome?". According to the doc, donating intents should only happen immediately after the user performs the related action inside the app. Also, donating intents is not needed to register shortcut actions. That happens automatically via the intent definition file. For those two reasons, there is no need to donate the SearchInChrome intent during startup, so this CL removes that. https://developer.apple.com/documentation/sirikit/donating_shortcuts Bug: 1125200 Change-Id: I93c1e71ced03b70d0849ce27390ccbfe9821b4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401761Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#805728}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8d1bf91b4dab..b3f3e76c87ac 2020-09-10 rslawik@google.com Merge "Fix unique constraint failed error" 2020-09-10 ssid@google.com Merge "Add source location as typed event argument" 2020-09-10 taylori@google.com Merge "ui: Use id for thread state selection" 2020-09-10 treehugger-gerrit@google.com Merge "UI: allow ?=&; chars from postMessage strings" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2008fc0ae5197550965ca296c8bf10f0505c1957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403311Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic9aac6fe2745df8bfb9f353bee279ba1be4f7fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403312Reviewed-by:
-
danakj authored
It's possible to go through a backdoor now, and this explains that you can do so, while begging you to not do so. R=avi@chromium.org Bug: 1091083 Change-Id: I164f1d39ec99a852dec2ce65662e22f81002a529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402202Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805725}
-
Morten Stenshorne authored
This reverts commit e7bbc732. Reason for revert: Breaks ThreadCacheTest.NoCrossPartitionCache (and possibly the others, too): https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/84939 Original change's description: > base/allocator: Add a thread cache to PartitionAlloc. > > This CL adds a thread cache to PartitionAlloc. It is optional, only > applies to thread-safe partitions, and uses the same freelist encoding > and bucketing as the main allocator. > > The thread cache is added "in the middle" of the main allocator, that is: > - After all the cookie/tag management > - Before the "raw" allocator. > > That is, the general allocation flow is: > 1. Adjustment of requested size to make room for tags / cookies > 2. Allocation: > a. Call to the thread cache, if it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > 3. Handle cookies/tags, zero allocation if required > > On the deallocation side, the process is reversed: > 1. Check cookies / tags, adjust the pointer > 2. Deallocation > a. Return to the thread cache of possible. If it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > > The thread cache maintains an array of buckets, the same as the parent > allocator. A single thread cache instance is only used by a single > partition. Each bucket is a linked list of allocations, capped to a set > maximum size. Elements in this "freelist" are encoded the same way they > are for the main allocator. > Only the smallest buckets are eligible for caching, to reduce the > memory impact. > > There are several limitations: > - Only a single partition is allowed to have a thread cache > - No periodic purging of thread caches is done > - No statistics are collected > > The last two limitations will be addressed in subsequent CLs. Regarding > the first one, it is not possible to use Chrome's native thread local > storage support, as it allocates. It is also desirable to use > thread_local to improve performance. > > Bug: 998048 > Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805697} TBR=haraken@chromium.org,lizeb@chromium.org Change-Id: I34ffdb52974d2d996da6eeb0e1b3aac9dd9ef6cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403363Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805724}
-
Irina Fedorova authored
This CL adds a simple version of the StartWeakCheck function to the InsecureCredentialsManager that doesn't use the zxcvbn-cpp library yet. Checking long passwords is implemented as it will be in the final version of password weakness check. It also adds the GetWeakCredentials function to the InsecureCredentialsManager. Bug: 1119752 Change-Id: I50013c9824701fdccabda7a76644f37c90fa6227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398622 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#805723}
-
Rouslan Solomakhin authored
Before this patch, Chrome on Android could attempt to use null WebContents* or RenderFrameHost* pointer derived from the corresponding Java objects, while an iframe is being removed, which caused a crash. This patch adds WebContents.isDestroyed() check in Java and null checks for RenderFrameHost* pointers in C++ derived from corresponding Java objects. After this patch, Chrome does not crash when an iframe is being removed on Android during PaymentRequest operation. Bug: 1125614 Change-Id: Id390a6eceaa3c8ccfcc496583ee82c9e6bb2a20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401318 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805722}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b8c3292e. With Chromium commits locally applied on WPT: 6e8ec7a9 "sensors: Drop tests for Sensor.start()/stop() return types." 5083fb9d "sensors: Rewrite the frequency hint test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I98bdb053ac04629ec5b90609f39c12dfc1df96d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403400Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805721}
-
Eric Robinson authored
Change-Id: Ic6b5158b12454ee02593922030d681b373b8dc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363832Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805720}
-
Miriam Polzer authored
Private set membership (PSM) is a new protocol added to determine a device's initial enrollment state. Before actually using it, we want to run it before executing the existing protocol and measure: - How long a successful request takes. - How many attempts, errors and successful attempts occur. - Whether the result differs from the existing protocol's result. Tests will be addid in a follow-up. Bug: 1116028 Change-Id: Ief3c47fd0e481a1327fe6b0842dfd9fb702b40a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381530 Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#805719}
-
Calder Kitagawa authored
This reverts commit 3480cbb1. Reason for revert: This caused some performance/memory regressions that are far larger than expected. Original change's description: > [Paint Preview] Pre-warm compositor > > This CL adds the ability to pre-warm a compositor process for use by > paint preview show-on-startup. > > 1. The compositor is started when native is initialized if the > experiment is enabled. > 2. Depending on the situation the compositor is then used or killed. > a. Compositor is used: disconnect handler is updated and it is used > as if there was a compositor already. > b. Compositor is not used: the process is killed immediately. > > This moves initialization of the compositor service up to O(100 ms) > earlier (in local tests). > > Bug: 1126180 > Change-Id: I1e6f627403e8c020b6551c510ad908bba0fc24a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398562 > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805317} TBR=mahmoudi@chromium.org,ckitagawa@chromium.org Change-Id: I7cd5067906f3833f9d927f9b3be1fe2600dbb741 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126180, 1126665, 1126734, 1126728, 1126648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403389Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805718}
-
Manuel Rego Casasnovas authored
StyleBuilderConverter::ConvertBorderWidth() is computing the zoom twice, the value we set in |result| variable is already zoomed. But then we have some extra lines that zoom it again and check if the final value is between 0px and 1px, to return 1px. This is wrong, as |result| was already zoomed, we can avoid that second operation and use that value to do the check directly. This was causing issues in the past but in very corner cases (so not very easy to reproduce). However due to the change on how subpixel border widths are managed (now they're floored, see r770064) this issue is causing that some borders are invisible. Added one WPT test that would fail with scaling factor 1.5. Also added a internal test using "zoom" property. BUG=1126396 TEST=external/wpt/css/css-backgrounds/border-width-small-values-001-*.html TEST=wpt_internal/css/css-backgrounds/border-width-zoom-001.html Change-Id: I27baac92036f7761e1616d55e90e4ed80cbb8914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401030Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#805717}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I56875368287704e6b49ab8528c81a7b54e0b1c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402194Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#805716}
-
Andreas Haas authored
The issue is fixed in V8, but the regression test needs the Chrome embedding. The V8 fix gets reviewed in https://crrev.com/c/2367858. Bug: chromium:1117258 Change-Id: Iac2cb32d2877074cd1e6a2d39d242838b34f2563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368359Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805715}
-
Morten Stenshorne authored
Still flaky. TBR=johnidel@chromium.org Bug: 1077216 Change-Id: I2d99f56edbabb22c980d761dd02be1cee4af7349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403362Reviewed-by:
-
Morten Stenshorne authored
Fails here: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/84937 TBR=qinmin@chromium.org Bug: 580766 Change-Id: I762cd32aac3bd438f33877d2ae51ed3ada81d056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403244Reviewed-by:
-
Morten Stenshorne authored
CL:2371729 didn't actually disable it. Still flaky. TBR=justinmiron@chromium.org,fergal@chromium.org Bug: 1121444 Change-Id: Ia9f55651c33b8139e2646fc25d084f2fd433b2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403360Reviewed-by:
-
Nigel Tao authored
Change-Id: I4cacda602ab66fc165c89b656b156dccfba0588d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398750Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#805711}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: If1285abe18ee761bb69d3d6e3b165ed847755e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398978 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805710}
-
Olivier Robin authored
For an unknow reason, UIDevice orientation always returns unknown in unittests when scenes are enabled. Breadcrumbs ignore orientation when it is unknown in the first report. This is a result of the class initialization. But there is no real reason to ignore unknown as an histogram value as it is a valid value. Change-Id: Id33db23db1755907292e23bdd89e3d6379f303e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398660Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/29b1f07f4ab2..84508b9666d5 2020-09-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e9ccdaed to 30a5da05 (421 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I75200b94b185d1344acd8820a08aabc47c0e1c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403055Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e9c8b7155d4..822283dbb736 2020-09-09 deadbeef@webrtc.org Prepare for usrsctp being updated. 2020-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa7a6a96..6e37a7f7 (805300:805451) 2020-09-09 joedow@google.com Fixing a crash when capturing non-DPI aware windows at high DPIs 2020-09-09 mbonadei@webrtc.org Switch from "rtc_ios_xctest_test" to "test". 2020-09-09 philipp.hancke@googlemail.com objc: add rollback type to RTCSdpType 2020-09-09 ivoc@webrtc.org Make AV sync robust to failures to set a desired minimum delay 2020-09-09 eshr@google.com Add NV12 video buffer type 2020-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a50ca66b..aa7a6a96 (802712:805300) 2020-09-09 mbonadei@webrtc.org Add 'requests' to .vpython. 2020-09-09 hmaniar@nvidia.com Adding field trial to control send buffer size 2020-09-08 titovartem@webrtc.org Use time controller based task queue factory in PC level tests. 2020-09-08 titovartem@google.com Follow up on https://webrtc-review.googlesource.com/c/src/+/180360 2020-09-08 asapersson@webrtc.org Use field trial list in CpuSpeedExperiment. 2020-09-07 philipp.hancke@googlemail.com authors: add comments about individual / org sections 2020-09-07 mbonadei@webrtc.org Revert "Reland "reenable mouse_cursor_monitor tests on linux"" 2020-09-07 nisse@webrtc.org Delete unused counters added_zero_samples_ and discarded_packets_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083527,chromium:1104245 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae31423c27a4196b6bc578ff18f1ad5e5b59ee7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403057Reviewed-by:
-
Victor Hugo Vianna Silva authored
Per the plan laid out in the linked bug, we need to persist whether the "natural decoupling" happened, i.e. this information must be kept across browsing sessions. This CL adds a boolean sync pref for this and exposes getter and setters for it all the way up to the Java code. Bug: 1125622 Change-Id: Ibeea8745f45d65cf016dbe0b316bd48228f34b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398524 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I666b338a5060005e6b79bf009449d80d0ceb988a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385300Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805705}
-
Simon Zünd authored
This is a reland of 73ac7d88 The reland changes the test locale from 'es-ES' to 'es'. 'es-ES' is unavailable on Mac, while 'es' works (confirmed crash and fix locally). Original change's description: > Keep DevTools navigator.language in-sync with chromiums app language > > DevTools is considered part of the Chromium UI, so it should be > displayed in the same language as the Chromium UI and not the configured > accepted language (chrome://settings/languages). > > This CL moves the code where we override the DevTools renderer > preferences around so it works consistently across platforms. It also > installs an event handler in case the user changes his language settings > so `navigator.language` has consistently the same value in the > DevTools renderer. > > R=petermarshall@chromium.org > > Bug: chromium:1125490 > Change-Id: Iaac568d82357d6ae7c50d5022d687f4f1741b147 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398538 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805219} Bug: chromium:1125490, chromium:1126379 Change-Id: I3b24b73ecb19d8290393a8ebf72db424bc098eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401464Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#805704}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6cf96585524..8d1bf91b4dab 2020-09-10 treehugger-gerrit@google.com Merge "Use deobfuscated symbol name in callsites" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I494cd5dcfec1af5d7bc223e0c576ec8a09605247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403051Reviewed-by:
-
Swapnil authored
We have many extensions stuck in CREATED stage which is reported in ExtensionManagement::UpdateForcedExtensions when extension list is fetched from kInstallForceList pref. We add the extensions to |settings_by_id_| dictionary. This dictionary may be overridden by the entries in kExtensionManagement pref and it is possible that the extensions which are listed in forced list may be listed in kExtensionManagement pref as "allowed" or "blocked". In these cases, we might not install the extension as ExtensionSettings policy overrides the policy for force installed extensions. This CL adds a new failure reason which is reported when extension listed in forced list policy has its installation mode overridden by ExtensionSettings policy to something else. Bug: 989526 Change-Id: I20995df211d5e09492c35c09e7c5152deba2fdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390181 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805702}
-
Alex Ilin authored
'ntp-customize-themes' has been refactored as a separate component in ui/webui/resources/cr_components/customize_themes. This CL migrates the new tab page to use the standalone component. All duplicate files from new_tab_page are being removed. This CL also adds a new ChromeCustomizeThemesHandler class that implements customize_themes::mojom::CustomizeThemesHandler interface. The most of the implementation methods were copied from chrome/browser/ui/webui/new_tab_page/new_tab_page_handler.cc This handler is going to be reused by several WebUIControllers, including NewTabPageUI. Bug: 1115301 Change-Id: Ica5cc63cba52a5a64692d9089f83a81ca49039c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353449 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805701}
-
Camillo Bruni authored
- Avoid v8::NewStringType::kNormal where possible - Use v8::NewStringType::kInternalized for object properties Bug: v8:10884 Change-Id: Ic7ec1e8dbdc1c56a72ed651da361b920c8145e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398544 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I32dc74fae8e59cc5ccc8512304b5de298c776982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382316Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Benoit Lize authored
Threadsafe static local variables call into the C runtime on Windows, which may not be safe in the allocation path (see linked bug). Don't use them for code which is on this path. This is using base::LazyInstance. It currently fulfills our needs, though it is not ideal for a couple reasons: - Not guaranteed to stay independent from local statics. - Can allocate in some paths (mostly DCHECK()s) As such, this is temporary, and we should either make sure that LazyInstance is suitable, or have a replacement local to PartitionAlloc. Bug: 1126432 Change-Id: I9cffed6f313c3fb380383a1607f0e6f27397c2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401469Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805698}
-
Benoit Lize authored
This CL adds a thread cache to PartitionAlloc. It is optional, only applies to thread-safe partitions, and uses the same freelist encoding and bucketing as the main allocator. The thread cache is added "in the middle" of the main allocator, that is: - After all the cookie/tag management - Before the "raw" allocator. That is, the general allocation flow is: 1. Adjustment of requested size to make room for tags / cookies 2. Allocation: a. Call to the thread cache, if it succeeds, return. b. Otherwise, call the "raw" allocator <-- Locking 3. Handle cookies/tags, zero allocation if required On the deallocation side, the process is reversed: 1. Check cookies / tags, adjust the pointer 2. Deallocation a. Return to the thread cache of possible. If it succeeds, return. b. Otherwise, call the "raw" allocator <-- Locking The thread cache maintains an array of buckets, the same as the parent allocator. A single thread cache instance is only used by a single partition. Each bucket is a linked list of allocations, capped to a set maximum size. Elements in this "freelist" are encoded the same way they are for the main allocator. Only the smallest buckets are eligible for caching, to reduce the memory impact. There are several limitations: - Only a single partition is allowed to have a thread cache - No periodic purging of thread caches is done - No statistics are collected The last two limitations will be addressed in subsequent CLs. Regarding the first one, it is not possible to use Chrome's native thread local storage support, as it allocates. It is also desirable to use thread_local to improve performance. Bug: 998048 Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 44a2bf3d. Reason for revert: New test times out. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38462 Original change's description: > [lacros] Support mojo connection in testing environment > > This CL supports setting up mojo connection between lacros and ash in > testing and debugging environment, and it is done via a unix domain > socket. > > Unix domain socket is only used in testing, not production because it > allows a random process to connect to ash-chrome as long as it knows > the socket path. > > Currently, only one lacros-chrome is allowed to connect to ash-chrome, > so in the testing environment, test launcher will run tests serially, > and will change to run in parallel once ash-chrome supports multiple > clients. > > Bug: 1120582 > Change-Id: I9736b03218f8fe937a7d642a35d6ee49b7e081f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384543 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805537} TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org Change-Id: I911a4d8bd80e8f0a217243503986a1a6d4a16338 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403460Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/917a2d741e92..3d41d509a6a9 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5f71fdf34b76 to b24900a1aa39 (2 revisions) 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 41c93c550b07 to 29b1f07f4ab2 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1042393,chromium:819294 Tbr: reed@google.com Change-Id: I2af5cbf40df4253a6757a6e64aab2e8824e03bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403047Reviewed-by:
-
