- 05 Mar, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia4a83a492b01d5699c6bc13943f40696ae312f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747284}
-
Ren-Pei Zeng authored
Bug: b:150263879 Test: Take portrait mode photo with CCA. Change-Id: I6dfb1f76f456cee4f0cdf67e429070569568a86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089145 Auto-Submit: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#747283}
-
Stephen Nusko authored
Add this to our waterfall FYI bot to start gather data in the lab on a trace that just scrolls. This metric has a couple differences since we can't use windowing functions and the histogram format doesn't support microseconds so I used milliseconds instead. I was able to get the results.json and using ui.perfetto.dev I verified (minus the us -> ms and integer percentage -> floating percentage) that the results are exactly the same. You can run this (replacing paths and supplying your own trace file) with the following command: tools/perf/core/tbmv3/run_tbmv3_metric.py \ --trace ~/chromium-team/pixel4_220120_7_flings \ --metric janky_time_per_scroll_processing_time \ --trace-processor-path ../../perfetto/out/linux_clang_release/trace_processor_shell Bug: internal b/150600174 Change-Id: I4acb2da4f998cc22ae537e4c38c9543cb2f2bae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087626 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747282}
-
Marko Ivanovich authored
|dest_url| references url inside navigation request which could be destroyed after call to BeginNavigation. Make it local variable instead, to avoid use-after-free error. Change-Id: I6c387d04e682d32d1e37a70171b23f28fc49d088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087724Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747281}
-
Yang Guo authored
R=tvanderlippe@chromium.org Bug: 1058515 Change-Id: I7e74dfe432cf2e2b81865cf3532bada1dbc1c4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089834Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#747280}
-
Mikhail Khokhlov authored
When several tests are being processed in parallel, each one will try to download the trace_processor binary at the same time. This results in cloud_storage not being able to acquire the file lock and timing out. This CL fixes that by allowing to download the trace_processor_shell only once per script run. Bug: 1047040 Change-Id: I817bac5e11ecfb83fae208c993e5d943c7e94fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087923Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#747279}
-
Mohamed Amir Yosef authored
This CL is simply removing a TODO from the corner cases to handle for moving credentials to the account store. The TODO was about credentials with outdated passwords. The migration flow will kick on upon successful sign in where no other bubble is shown i.e. it cannot be a save or update bubble. This entails there is an up to date password in the underlying stores. In this TODO there is only credentials, and hence it must be up to date. Bug: 1032992 Change-Id: I9c2bdaa1868b309e96c9591eb7cb1db1c7de3517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087224 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#747278}
-
Rouslan Solomakhin authored
The PaymentInstrument.java class is an empty wrapper around PaymentApp.java. All dependencies on PaymentInstrument.java have been updated to use the PaymentApp.java class instead. Bug: 1022512 Change-Id: Ia79bdca2bc98c33c6e1921336950c8e25dc500b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087976Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747277}
-
Christian Dullweber authored
Test is flaky. Tbr: boliu@chromium.org Bug: 1058233 Change-Id: I50f972fbba98dbe8618864abe8e9ff8554f6c3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089755Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Copying the object involved some refcount housekeeping (and more?), which was especially expensive in debug / DCHECK builds. Change-Id: Ifa0a29982f08541f5de47e3b67c4a83b34c576aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089831Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#747275}
-
Ben Joyce authored
Bug: 1052460 Change-Id: I0841d822f4ce9aa8539b9f778989c461568d3834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088506 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#747274}
-
Ben Joyce authored
Change-Id: I0d732c70323b4baf9dadb6b0e420240473ae78c0 Bug: 1052460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088292Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
Accommodate blink heap marking use case: https://chromium-review.googlesource.com/c/chromium/src/+/2029609 Few issues: - NotifyConcurrencyIncrease is periodically called from the main although there might not be more work than previously. - The main thread might finish all the work before calling NotifyConcurrencyIncrease and a worker might then reach its dealine in AssertExpectedConcurrency - The main thread might cancel the job before calling NotifyConcurrencyIncrease - By the time |recorded_max_concurrency_| is assigned (after the worker is spawned), it's possible that all work was acquired and the new worker is unneeded, in which case it won't do any work. This CL fixes the issues by: - Skip DCHECK in AssertExpectedConcurrency() if job was cancelled. - Skip DCHECK in AssertExpectedConcurrency() if GetMaxConcurrency() <= expected_max_concurrency_ after timeout, i.e. work was complete and Notify() is no longer needed. - Reenqueue the task_source only if GetRemainingConcurrency() > 0 And adds regression tests for the cases above. Bug: 1046343 Change-Id: Ic41141eaed790ef83d587157f52d3279877ed74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033673Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#747272}
-
Ulan Degenbaev authored
This changes the result format of the API to the latest version of the proposal at https://github.com/WICG/performance-measure-memory. Specifically, per-origin attribution changed to per-frame attribution with one caveat that cross-origin iframes are considered opaque and iframes nested in cross-origin iframes do not appear in the result. The previous version of API: { bytes: 70*MB, breakdown: [ {bytes: 40*MB, globals: 2, type: 'js', origins: ['foo.com']}, {bytes: 30*MB, globals: 1, type: 'js', origins: ['bar.com']} ] } The current version of the API: { bytes: 70*MB, breakdown: [ {bytes: 40*MB, type: 'window/js', attribution: ['foo.com']}, {bytes: 30*MB, type: 'window/js', attribution: ['bar.com']} ] } Bug: 1049093 Change-Id: I3bbf07ad6e978b9b483561c06cedf6c7a135b7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087627Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747271}
-
Michael Thiessen authored
When validating the scheme for intent URLs, we used the intent scheme as the scheme, instead of the scheme that the intent URL would end up sending to the target app. Bug: 1058032, 1057842 Change-Id: I5185df4a72fb5500cff9a568358c882fdf694093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088500Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#747270}
-
Luke Zielinski authored
There is one known precondition failure that is added to WPTOverrideExpectations. Others will be added in a follow-up Cl. Also expands unit tests to check that we're parsing trailing comments into annotations properly. Bug: 937369 Change-Id: I325272eee364b8cae9ef7739ff9333b829f9f041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088234 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#747269}
-
Morten Stenshorne authored
Probably due to NGFragmentItem improvements. TBR=kojii@chromium.org Bug: 982194 Change-Id: I49fe42fda825b175abd9c158c389a1a03c5efa06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089693Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#747268}
-
sandromaggi authored
In crrev/c/2074499 the argument was raised, that the current handling of call arguments is not too readable (very verbose). This CL aims to refactor this slightly, by introducing a new helper function. Bug: none Change-Id: I98eb6045eb2600dd05501f6fcc6b918ced50bda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081428 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747267}
-
Monica Basta authored
|GAIAInfoUpdateService| do not need to listen on PrimaryAccount* events anymore, it is sufficient to listen to |OnUnconsentedPrimaryAccountChanged| since the sync consent is not a point of interest to this service. Change-Id: I4199f2451c5aa9ef75a89d3ca0870138778ee146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087394Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#747266}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16ddae924efb..3c91b31162b8 git log 16ddae924efb..3c91b31162b8 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 titovartem@google.com Fix potential deadlock during release of quality analyzing codecs 2020-03-05 jonaso@webrtc.org Make Connection::id() const Created with: gclient setdep -r src/third_party/webrtc@3c91b31162b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b40984b367d7c3497086934500e0c5ac7d6c229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089577Reviewed-by:
-
Alice Wang authored
This CL removes the unused method of Android Edu support. Bug: 1044616 Change-Id: Idb87677032608785d751a5033a5335917aee62c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088153Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747264}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I8e355c4882766e539c65b870533a9449e1ca5345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088361Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747263}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eda959aeeb18..b0d65f1b3c40 git log eda959aeeb18..b0d65f1b3c40 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 tvanderlippe@chromium.org Extract protocol generation to separate script 2020-03-05 tvanderlippe@chromium.org Update README to recommend the integrated workflow Created with: gclient setdep -r src/third_party/devtools-frontend/src@b0d65f1b3c40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2f8396da770a7548d8b7cf7342464f4c4e2bebba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089578Reviewed-by:
-
Mohamed Amir Yosef authored
For users who haven't opted-in butter, they should go the reauth flow before being able to save passwords in their account. If users have opted-in already or decided to store locally, the credentials are saved directly without invoking the reauth flow. Bug: 1044038 Change-Id: I519e2739d8f87bfc16b84a484c2aa1d522df0b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050280Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#747261}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b583290a6d81..652ee37df0e7 git log b583290a6d81..652ee37df0e7 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 ddrone@google.com Merge "Add more fields to ChromeLatencyInfo" Created with: gclient setdep -r src/third_party/perfetto@652ee37df0e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5a366cd53c3adb2bfe781e7d7bc192bb962b6689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089575Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eadf87170da..bd1226ba4922 Created with: gclient setdep -r src-internal@bd1226ba4922 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052505 Tbr: jbudorick@google.com Change-Id: I0cf60f9a648dbcf422f8ae95076a81fbda68572a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089573Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747259}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I7e912a11b9db0a38fb066722f387703781860c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089672 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#747258}
-
Eric Seckler authored
Makes ProducerClient::IsTracingActive() also consider active local startup tracing sessions, and adds a test that verifies that system tracing doesn't start until after local startup tracing is complete. Bug: 1058461 Change-Id: I59a488e663ad9ac2aaa41ae4fef8990f3268b695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087410 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747257}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d4ed59c4..4b1eadeb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icb829fe71c85f797f309b804f0cb9afa7e9f66f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747256}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39ca5bfe. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools meade@chromium.org: external/wpt/web-animations rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I5ea826ba8026e71e81d1b21d5392f5afac2ec631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089611Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747255}
-
Jose Lopes authored
It seems these methods are not being used at all. This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Idd854549fbd0b87b3ac41990bd98b2afeb8d0636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078011 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747254}
-
Adithya Srinivasan authored
Computes visible text in portal contents (by making the root web area in a portal compute its name from its contents), and uses this text as a name for the portal element if no name is provided. Bug: 1045608 Change-Id: If72acb5c803ab65d7e8d8cb06f6777dd9b3dac47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024110 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747253}
-
Alex Ilin authored
Reason: many tests are flaky and cause build failures - https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24498 - https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/31877 TBR: yfriedman@chromium.org Bug: 1058790 Change-Id: I6b2d08fddad4a298082907ef5e75511f08ab4595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089673Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#747252}
-
Jose Lopes authored
This is a repeating callback because while video frames are being streamed (which is a repeated operation), this callback may be run to indicate a new target delay. This callback may even run twice in the same method call: * https://cs.chromium.org/chromium/src/media/cast/sender/video_sender.cc?rcl=ef3591b59e679e932cfad02644cec7cfc068a842&l=156 * https://cs.chromium.org/chromium/src/media/cast/sender/video_sender.cc?rcl=ef3591b59e679e932cfad02644cec7cfc068a842&l=219 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib0e230d2dc5fc0e1ad100a41efdd71be7446e8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074439 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#747251}
-
Krzysztof Kotowicz authored
Context: https://github.com/w3c/webappsec-trusted-types/issues/235 Bug: 739170 Change-Id: I8499534f4351ea2c9f689071f3d6510238382d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089651Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Auto-Submit: Krzysztof Kotowicz <koto@google.com> Cr-Commit-Position: refs/heads/master@{#747250}
-
Maksim Ivanov authored
According to the UX feedback, the "backspace" icon displayed in the Ash PIN keyboard ("LoginPinView" class in the code) should use the "E8EAED" color ("GoogleGrey200" in the code). Bug: 1001288 Test: log in via a smart card and log out, start login again, proceed to the PIN dialog, take screenshot, verify that the "backspace" icon has color #E8EAED Change-Id: If3d9cd2cb245f2d7279042f0829f139f83f06387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089691Reviewed-by:Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#747249}
-
Henrique Ferreiro authored
This typo was introduced in https://crrev.com/c/2052783. Bug: 1040499 Change-Id: Ie3fe43eea175a0e9a03ee6d290a1f253440344a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077720 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#747248}
-
Gauthier Ambard authored
Reland of crrev.com/c/2062979 This enables the flag by default on Canary. The idea is to ship it to 100%, with a kill switch by Finch. Bug: 1038034 Change-Id: Ie62476253d81d9a54a9de0678456d2be1b83f727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080255Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#747247}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6cc841a97e38..eda959aeeb18 git log 6cc841a97e38..eda959aeeb18 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@eda959aeeb18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8468969935ae0091b14e7dfc8e4fa49a4518a033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089572Reviewed-by:
-
Jose Lopes authored
This is a repeating callback because it's used to process multiple audio frames, as documented in: * https://cs.chromium.org/chromium/src/media/cast/cast_receiver.h?rcl=aa9316a8407f234582ccb6395f933c37e22463d3&l=26 This is similar to the video equivalent, which is a repeating callback: * https://cs.chromium.org/chromium/src/media/cast/cast_receiver.h?rcl=aa9316a8407f234582ccb6395f933c37e22463d3&l=37 Example of why this is repeating is because it's called both on StartAudio and also on every decoded audio frame: * https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_receiver_session_delegate.cc?rcl=9fb704a00bb8e7983886654eb4cb7327a1ba36be&l=50 * https://cs.chromium.org/chromium/src/chrome/renderer/media/cast_receiver_session_delegate.cc?rcl=9fb704a00bb8e7983886654eb4cb7327a1ba36be&l=69 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ib336c391989c1f0ff44788a6430748d76c3b862b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074438Reviewed-by:
-
