GitLab

Add a very basic preferences window controller with unit test. Fix the prefs nib to know the FileOwner is a NSWindowController and hook them together.
Review URL: http://codereview.chromium.org/102015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14958 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14955 0039d316-1c4b-4281-b951-d872f2087c98

by a crash.

Review URL: http://codereview.chromium.org/99220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14954 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100190


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14953 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben

Closing the last tab with a download in-progress would cause the tab to be
closed and become unusable if the user decides not to proceed with the browser
shutdown.
This is because we check for in-progress downloads when the browser is closed,
and the tab is closed before that, leaving the tab-strip in a bad state.

This CL ensures we also bring-up the confirmation dialog when the last tab is
closed.

BUG=10680
TEST=Start downloading a big file. While the file is downloading, close all
tabs. When closing the last tab, the in-progress download dialog should be
shown. Select the 'Wait for downloads', the download tab should be shown and
the previous tab should still be displayed and functional.
Close all tabs again, this time select the 'Close and cancel downloads'
option, the browser should be closed.
Review URL: http://codereview.chromium.org/100210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98

using the unit_test executable rather than chrome.exe.  This patch repurposes
the --renderer-path switch to be --browser-subprocess-path for both plugins and
renderers.  

BUG=11006
TEST=Any InProcessBrowserTest (they all will start at least one renderer). Use
NavigateToURL to a URL containing flash, we shouldn't crash.


Review URL: http://codereview.chromium.org/99011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14951 0039d316-1c4b-4281-b951-d872f2087c98

Broke the Mac build.

TBR=ben
Review URL: http://codereview.chromium.org/99224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14949 0039d316-1c4b-4281-b951-d872f2087c98

closed and become unusable if the user decides not to proceed with the browser
shutdown.
This is because we check for in-progress downloads when the browser is closed,
and the tab is closed before that, leaving the tab-strip in a bad state.

This CL ensures we also bring-up the confirmation dialog when the last tab is
closed.

BUG=10680
TEST=Start downloading a big file. While the file is downloading, close all
tabs. When closing the last tab, the in-progress download dialog should be
shown. Select the 'Wait for downloads', the download tab should be shown and
the previous tab should still be displayed and functional.
Close all tabs again, this time select the 'Close and cancel downloads'
option, the browser should be closed.


Review URL: http://codereview.chromium.org/99195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14948 0039d316-1c4b-4281-b951-d872f2087c98

* Fix action execution with no specified target output files.
* Handle duplicate --mode= values.
Review URL: http://codereview.chromium.org/99210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14946 0039d316-1c4b-4281-b951-d872f2087c98

Initial prefs window xib from Cole. Hook the menu up to (empty) code. Use scoped pointers to manage memory.
Review URL: http://codereview.chromium.org/100206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14945 0039d316-1c4b-4281-b951-d872f2087c98

This is used for Linux, where we're currently not doing inverse selection.

Review URL: http://codereview.chromium.org/100207


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14944 0039d316-1c4b-4281-b951-d872f2087c98

This wasn't actually a bug in that everything worked fine.  It just meant we
were calling the default handler twice, and returning from what should have
been a void function.

Review URL: http://codereview.chromium.org/99218


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14943 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100200


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14942 0039d316-1c4b-4281-b951-d872f2087c98

This ended up being implemented as a toplevel instead of a popup, to handle
things like virtual desktop switching.  I imagine there are some other problems
we might hit, like the window getting decorated, etc.  Although I think the
shape mask might prevent decorations from being visible.  This is not pixel
perfect with Windows, since we're not anti-aliasing the frame border.

Review URL: http://codereview.chromium.org/100203


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14941 0039d316-1c4b-4281-b951-d872f2087c98

does resolve the location bar not being focused bug on the mac build.

Patch by Sean Bryant (sean@cyberwang.net).

BUG=9419

Review URL: http://codereview.chromium.org/100140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14939 0039d316-1c4b-4281-b951-d872f2087c98

This is a cherry-pick of the following change:

http://code.google.com/p/skia/source/detail?r=159

We introduce this change for the 'lighter' composite operation. We need kAdd_Mode, which is introduced in this change for the operation.

Patch by Shinichiro Hamaji.

BUG=1619

Review URL: http://codereview.chromium.org/93093


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14938 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14936 0039d316-1c4b-4281-b951-d872f2087c98

2. Function actual parameters are not shown in the call stack panel because they are alredy displayed in the scopes panel.
Review URL: http://codereview.chromium.org/99185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14935 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Make sure that the task manager isn't obviously broken on Windows.

Review URL: http://codereview.chromium.org/93067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14934 0039d316-1c4b-4281-b951-d872f2087c98

It seems the AutocompleteResultView::DrawString() function calls the AutocompleteResultView::DrawStringFragment() function even when |text_start| is greater than |text_end|, i.e. there are not matching characters.
This change filters out the above case and fixes a couple of lint errors.
Review URL: http://codereview.chromium.org/100196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14933 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, "Alt" key will set both alt and meta is on (issue 2215).
But Alt-Gr is used to insert alternate character.

BUG=10846

Review URL: http://codereview.chromium.org/99216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14932 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=10863

Review URL: http://codereview.chromium.org/100178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14926 0039d316-1c4b-4281-b951-d872f2087c98

On translate.google.com, it fails to show balloon, because of JavaScript
exception in following code:
  p=a.getClientRects(); ... p[0].top  // p[0] is undefined!

Current v8 binding misses indexed access method in ClientRectList.

CSSOM View Module draft says
 http://dev.w3.org/csswg/cssom-view/#clientrectlist
 In ECMAScript implimentations, objects that implement the ClientRectList
 interface must also have a [[GET]] method that, when invoked with a number,
 acts like the item() method would when invoked with that argument.

BUG=10697


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11200
R=aa

Review URL: http://codereview.chromium.org/100164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14924 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14922 0039d316-1c4b-4281-b951-d872f2087c98

On Gtk/Linux, it emits key events with ASCII text and ctrl on for ctrl-<x>.
In WebKit, EditorClient::handleKeyboardEvent in
WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp drops such events.
On Mac, it emits key events with ASCII text and meta is on for Command-<x>.
These key events should not emit text insert event.

Alt key would be used to insert alternative character, so we should let through.
Ctrl-Alt combination may equal to AltGr key, which is also used to insert
alternative character.

In summary, we can't think of a scenario where you'd use control(w/o alt) or
meta to do insertion of a ASCII character.

BUG=10846,11070,11165

Review URL: http://codereview.chromium.org/99209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14921 0039d316-1c4b-4281-b951-d872f2087c98

think this was happening because we were injecting from the the
browser at load_start, but the document might not be established
in the renderer by the time this message is received.

Since we are now not even showing the toolstrip until
load_complete, it is no big deal to delay the CSS injection
until then.

Review URL: http://codereview.chromium.org/100182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14914 0039d316-1c4b-4281-b951-d872f2087c98

when tab->GetActiveEntry() is NULL.

Review URL: http://codereview.chromium.org/100172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14913 0039d316-1c4b-4281-b951-d872f2087c98

Parts of the code are from ermilov.maxim@gmail.com. Thanks!

BUG=8405
Review URL: http://codereview.chromium.org/100106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14912 0039d316-1c4b-4281-b951-d872f2087c98

Make "Reopen closed tab" be "Reopen closed window" when a window is the top item on the closed tabs stack.

Original patch by Miranda Callahan (see http://codereview.chromium.org/100054 ), r=me.

BUG=11183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14910 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100144


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14909 0039d316-1c4b-4281-b951-d872f2087c98

Also rebaseline another SVG test since eseidel says our result looks ok.

Review URL: http://codereview.chromium.org/100187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14907 0039d316-1c4b-4281-b951-d872f2087c98

This only works with post-1.0 Chrome, as it refers to the new Window names.

R=kuchhal

Review URL: http://codereview.chromium.org/101008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14906 0039d316-1c4b-4281-b951-d872f2087c98

TBR=evan

Review URL: http://codereview.chromium.org/100185


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14904 0039d316-1c4b-4281-b951-d872f2087c98

- Introduce ExtensionHost, which is the guy that talks to the RenderViewHost.
- ExtensionView holds an ExtensionHost, and also renders its contents in an
  HWND.
- Added code to load a page optionally specified in the manifest as a
  background process whenever it exists.
Review URL: http://codereview.chromium.org/92043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14902 0039d316-1c4b-4281-b951-d872f2087c98

Reenabling all of them.
Hopefully it'll help with flakiness.

Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux.

BUG=6584,2136
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/101013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14901 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/100181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14899 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=make sure all tests (unit-tests, ui-tests...) still work.
Review URL: http://codereview.chromium.org/100032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14897 0039d316-1c4b-4281-b951-d872f2087c98