- 16 Mar, 2020 28 commits
-
-
Kent Tamura authored
- New behavior matches to Firefox. - File upload controls in LayoutNG will have overflow:hidden by default. The new behavior will be necessary for site compatibility. Bug: 1040826 Change-Id: I1c620f98806a1751252b4f5a96545609fa90cc1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102997Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#750473}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/222b156b486b..5609eb6d5256 git log 222b156b486b..5609eb6d5256 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@5609eb6d5256 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3db3e800db1b68fa3d1f17e933624284882d6236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750472}
-
Joel Hockey authored
Bug: 1061822 Change-Id: I334d2ff8add76d42dc7aa4f96cc7e7a8a341c0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102996 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#750471}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ibee86744d9313d0908c7722f222d0ae99a678e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104657Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750470}
-
Kunihiko Sakamoto authored
TBR=arthursonzogni@chromium.org No-try: true Bug: 1061029 Change-Id: Ic6c21749e873ebfd8623767febbf49eb62ba2262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103978Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750469}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/572d6abf7f22..ca93436e5b1b $ git log 572d6abf7..ca93436e5 --date=short --no-merges --format='%ad %ae %s' 2020-03-15 junyer Update Unicode data to 13.0.0. 2020-03-12 junyer SRWLOCK requires Windows Vista or Windows Server 2008 at minimum. 2020-03-04 donatas.saulys Using slim RW lock on windows 2020-03-02 junyer Set SONAME to 6. 2020-03-01 junyer Bump SONAME to reflect the ABI break. 2020-02-28 junyer Add macOS and Xcode jobs to the Travis CI matrix. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I2f8c6ee0a33a594a595ab70840bba2b066385d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104262Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750468}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c48fb8427c8c..8cf12290bab8 git log c48fb8427c8c..8cf12290bab8 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8cf12290bab8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8c6189ade78c7eb85f5d716baf3dc49ec2ef2da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104687Reviewed-by:
-
Alan Cutter authored
It is possible for CancelDownloads() to be called after the callback_ has already been called via successful download or a previous navigation. This CL adds a null check to avoid crashing in these corner case scenarios. Bug: 1059847 Change-Id: Idc97407ba67195beba51a9053ee2d71dcbd911f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102995Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#750466}
-
Trent Apted authored
Failin on linux-chromeos-chrome internal bot since https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3955 Error like "[FAIL] [directoryTreeExpandHorizontalScrollRTL]: Tree should not scroll right This is blocking src-internal rolls (for >1 day). Tbr: majidvp@chromium.org, noel@chromium.org Bug: 1061821, 1061670 Change-Id: I27dd3fca5a5d9154519680b748c6dd054f2dd021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103012Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#750465}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I215d45b0f382bb0ae99350dd8d0ec8770a10e8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104512Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750464}
-
Koji Ishii authored
This patch converts a non-file-based image in clipboard to an <img> tag with data URL when pasting to an editing host. The generated markup matches |URLToImageMarkup| and the one Firefox generates for the same case. In addition to the unittests, manually tested by taking screenshots to clipboard by pressing Alt+PrtScrn key on Windows and confirmed: * Pastable to `contenteditable`. * Pastable to `-webkit-user-modify: read-write`. * Not pastable to `<input>`, `<textarea>`, nor to `-webkit-user-modify: read-write-plaintext-only`. Bug: 1008927 Change-Id: I19c17591567ad150575ed15af7743e819eaeb67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086463 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#750463}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: I9e59f2c291c216f784df57796191d87764a73f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103991 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a4a42e6d0baa..cb9a86a9d867 git log a4a42e6d0baa..cb9a86a9d867 --date=short --first-parent --format='%ad %ae %s' 2020-03-15 ynovikov@chromium.org Skip SwANGLE GLES31 tests which crash with 32-bit Subzero. Created with: gclient setdep -r src/third_party/angle@cb9a86a9d867 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ifc12641bb8fcc30402b841874ed2a9ce2b4c62aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103666Reviewed-by:
-
Daniele Castagna authored
This patch adds a flag to enable/disable splitting quads when partially occluded to reduce compositing overdraw. This flag currently disables the optimization, so that we can consider merging this patch back to 81 along with the optimization (then the optimization will need to be explicitly enabled via the flag in 81). Bug: 1061708 Test: Power consumption of meets on a chromebook with the flag on and off Change-Id: I4417076a21c7074244e7bb960b1e1cf477fb721a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103721 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#750460}
-
Dominic Farolino authored
This CL removes two lazy load image tests from the TestExpectations file since they are already passing. It also renames the two tests, since there were typos in their filenames. Bug: 626703 Change-Id: I0497342a7729ca3f551910b25bd14c17de83b65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103009Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#750459}
-
Noel Gordon authored
Bug: 992818 Change-Id: I45a74425ddbc340526696b4e67fded93be96c5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102937 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750458}
-
Joel Hockey authored
Allow AppBrowserController to set default bounds for apps. After the first launch, we will use the regular persistence of position and size for subsequent open or restore. Previous positioning of terminal settings is no longer required. Bug: 1058670 Change-Id: I9793dc1cb046fc0c409471ca589f5f4bfaf57e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100951 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#750457}
-
Trent Apted authored
This reverts commit 2e21ac99. Reason for revert: Persistent compile failure is blocking any src-internal roll for 30+ hours error: no matching constructor for initialization of 'chromeos::assistant::action::CrosActionModule' return unique_ptr<_Tp>(new _Tp(_VSTD::forward<_Args>(__args)...)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../chromeos/services/assistant/assistant_manager_service_impl.cc:160:27: note: in instantiation of function template specialization 'std::__1::make_unique<chromeos::assistant::action::CrosActionModule, chromeos::assistant::AssistantManagerServiceImpl *, bool, bool, bool>' requested here action_module_(std::make_unique<action::CrosActionModule>( ^ ../../chromeos/assistant/internal/action/cros_action_module.h:159:12: note: candidate constructor not viable: requires at most 3 arguments, but 4 were provided explicit CrosActionModule(AssistantActionObserver* assistant_event_observer, link: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3983 Original change's description: > chromeos/assistant: CrosActionModule ctor fix compilation > > Roll src/chromeos/assistant/internal/ d3a99ca02..4e7273378 > added a parameter to CrosActionModule ctor, but the code what was > instantiating one still assumes there are only three parameters. > > This CL adds the fourth parameter where we instantiate CrosActionModule. > > Bug: b:149570650 > Test: Now chrome for chromeos compiles > Change-Id: I950a3557df7d996b5d0695b9fa2de4633c448afe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103717 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Auto-Submit: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750409} TBR=dcastagna@chromium.org,xiaohuic@chromium.org,dmblack@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1061670, b:149570650 Change-Id: I385b38f8dfde3233cccc8213e85ebb9d67f88a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102994Reviewed-by:
-
Toni Barzic authored
Adds histograms that record value set by user for accessibility setting to show shelf navigation buttons in tablet mode. The action is recorded separately for OS a11y settings and OOBE. The value set by user is recorded with a 10 second delay, to avoid overreporting if the user toggles the setting few times in short succession (when the value changes, the previous requests to record the metric are canceled). BUG=1055688 Change-Id: Ie8a8104e4feda6844632b3a249242163949098d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099335Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#750455}
-
Anand K. Mistry authored
This prevents a UAF when called with a callback bound using base::Unretained(), which is a common pattern for owned objects. Bug: 1052729 Change-Id: I017877c2aa88f3dddae26deffe99b7e5eff68b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103733Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#750454}
-
Kunihiko Sakamoto authored
This reverts commit db2ea179. Reason for revert: toBlob-in-detached-document.html is consistently crashing on Mac and Windows bots. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100726 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/45010 https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/52120 https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/22974 Original change's description: > Handle a null context in CanvasAsyncBlobCreator constructor > > Bug: 1061309 > Test: fast/canvas/toBlob-in-detached-doument.html > Change-Id: I3d515666c9228d6d32791bad588149f879020b2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103046 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750299} TBR=dcheng@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1061309 Change-Id: I88be96615ea2bf3a164a3b9d1d17f378f22046b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103010Reviewed-by:
-
Joseph Kim authored
We want to keep records of how long operators need to wait for demo mode to set up. Currently, there exists a metric of how long is spent on the demo-setup page (OOBE.StepCompletionTime.Demo-setup) which has not yet been added to the histograms.xml file. However, this metric is only useful for durations up to 3 minutes, so we require a metric calculated separately. Furthermore, we want to know: - How long is end-to-end setup - How many times do operators need to retry during the setup process Bug: b:148753889, 1061305 Change-Id: I9d8d656ca85863c3975419ab306c097b0bd00d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094065Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Joseph Kim <josephkimsh@google.com> Cr-Commit-Position: refs/heads/master@{#750452}
-
Nico Weber authored
Bug: 346399 Change-Id: I31e77922c0478fd8495089a8ff44b0ccf8201320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103718 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#750451}
-
Kunihiko Sakamoto authored
TBR=jbudorick@chromium.org Bug: 1061624 Change-Id: I37032590b3ab08ecf56da3a33987b6da6142cd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104569Reviewed-by:
-
nancy authored
When Playstore is removed, OnAppStatesChanged is called, and then OnAppRemoved is called. 1: Playstore removed 2: OnAppStatesChanged 3: OnAppRemoved When OnAppStatesChanged is called, ArcApps updates the icon key, so AppServiceAppItem and AppServiceAppIconLoader reload icon with mojom. 1: Playstore removed 2: OnAppStatesChanged -> AppServiceAppItem::LoadIcon -> AppServiceAppIconLoader::LoadIcon Before ArcApps receives the load calls, ArcIconOnceLoader's OnAppRemoved has clear the ArcAppIcon. So when ArcIconOnceLoader receives the load icon calls from AppServiceAppItem and AppServiceAppIconLoader, ArcIconOnceLoader won't clear the ArcAppIcon again, and ArcIconOnceLoader still calls ArcIconOnceLoader to load icon. 1: Playstore removed 2: OnAppStatesChanged -> AppServiceAppItem::LoadIcon -> AppServiceAppIconLoader::LoadIcon 3: OnAppRemoved -> ArcIconOnceLoader::OnAppRemoved 4: ArcIconOnceLoader::LoadIcon -> Create ArcAppIcon to load icon However, the ARC apps have been removed, so ArcAppIcon can't load the icon, and ArcIconOnceLoader and IconCoalescer just keep waiting the icon load result. Modify ArcApps, when the app has been removed, don't call ArcIconOnceLoader to load the icon. Tried to update ArcAppIcon to return result when time out, but that method doesn't work. Because when Playstore is re-enabled, MaybeRequestIcon should be called to ask Arc pref to reload the icon, but ArcIconOnceLoader doesn't know when the app is re-installed, so it can't call MaybeRequestIcon to reload the icon, so when Playstore is re-enabled, it still can't load the icon. b:149229735 Change-Id: I2ac61fe598f9e9d0314a248150f8897c3eb57e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072337 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#750449}
-
Luciano Pacheco authored
This reverts commit ea497580. Reason for revert: Feature moved from M-82 to M-83. Original change's description: > Files app: Enable flag files-ng by default > > Add files-ng classes and attribute to main.html so files-ng styles are > applied during app startup (to avoid a FOUC flash of non-files-ng blue > color). > > Enable file-ng by default in FilesApp and its browser test harness. > > Bug: 992818 > Change-Id: If437271c5604d36b4b0908abb663a84e52b6ae35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087308 > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Alex Danilo <adanilo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747421} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org Bug: 992818 Change-Id: I8b1c770e2c43823eff9a2a9aceae650fcb25a3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103992Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/869e901ad7dd..a4a42e6d0baa git log 869e901ad7dd..a4a42e6d0baa --date=short --first-parent --format='%ad %ae %s' 2020-03-15 jmadill@chromium.org Format perf_test.cc. Created with: gclient setdep -r src/third_party/angle@a4a42e6d0baa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I5be1cccb70bd6a5a88f06c9189788fe4aa121dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103663Reviewed-by:
-
Caleb Rouleau authored
Some of the reimaging to android M didn't work. Do not revert this change if it appears to cause a perf regression. That regression was likely caused by upgrading the devices from Android version K to Android version M. DO NOT REVERT this change. TBR=johnchen@chromium.org Bug: 1041944 Change-Id: Idbcc6de3bd69dfe2724e146dfee1b25e32518f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104453 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#750446}
-
- 15 Mar, 2020 12 commits
-
-
Gyuyoung Kim authored
Below flaky tests were fixed by converting BlinkTestHostMsg_PrintMessage. So, this CL unmarks the flaky tests again. fast/forms/file/file-input-webkitdirectory-key-enter.html fast/forms/file/file-input-webkitdirectory-click.html fast/forms/file/file-input-webkitdirectory-key-space.html fast/forms/file/file-input-click.html Bug: 1059322 Change-Id: I1bff2cfbafe264a04612c06ffd089cdf2fe62173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102991 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#750445}
-
Jing Wang authored
Change-Id: Ic4e881dd93cf1041cef95db75f3f9cd9ba3c05af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087881Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750444}
-
Caleb Rouleau authored
This should not be checked in until the Nexus 5s are reimaged. R=johnchen@chromium.org, wenbinzhang@google.com Bug: 1041944 Change-Id: Icec71e1ff43f69412be185df7725a508a921afcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103441Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#750443}
-
Andreas Haas authored
The indirection over DOMTypedArray::View is not necessary, DOMTypedArray can be used directly. This CL works towards removing ArrayBufferView and TypedArray. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Ib4ab7844b4a10339b4aefd9add4637890e1ce09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102653Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#750442}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c9eced71. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 79933afe "Reland "[ScrollTimeline] Support composited scroll-linked Web Animation"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I22de63f3651dea52f410c2c170b2c06b5745971d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104123Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750441}
-
Alexey Baskakov authored
TwoClientWebAppsSyncTest.Basic TwoClientWebAppsSyncTest.AppFieldsChangeDoesNotSync tests were failing because we don't sync description and scope in the new web apps system: we get these data fields only during full post-sync install. TwoClientWebAppsSyncTest should test a common subset for Bookmark Apps and Web Apps: let's parametrize by ProviderType. SingleClientAppsSyncTest and TwoClientExtensionAppsSyncTest should also be parametrized against ProviderType: we want to be sure that we don't regress hosted apps and platform apps. In next CLs: - We will create brand new two_client_web_apps_bmo_sync_test.cc file to test the new web apps BMO sync system. We will test full post-sync install there. - We will rename single_client_apps_sync_test.cc to single_client_extension_apps_sync_test.cc Bug: 1025156 Change-Id: Id30424cd974f091954cbfd3a493f1c45e9a2f19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096402Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#750440}
-
Darren Shen authored
Show should be 200ms, and hide should be 100ms according to UX. Bug: 1030814 Change-Id: I2858aeb5c713c356a3ba427b2e2de8a59110e547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098181Reviewed-by:
-
David Munro authored
Needs some polish but works end-to-end, all the functionality is there. This is still behind a flag. Screenshots: * Loading: https://drive.google.com/file/d/1-F7R0fd2FHiTcoOxyWwoFy_W23J7vY_R/view?usp=sharing * Resize: https://drive.google.com/file/d/1-7VtbZd2j2fAAYVtB5anV_Ayk6Xty5xx/view?usp=sharing * Settings page to open dialogue: https://drive.google.com/file/d/1-HqyovNWKWz4j-l21RkV0aWIUmKRjCko/view?usp=sharing Test: Browser, unit, manual Bug: chromium:858815 Change-Id: I2967402d2bcd1ebb66e83a5298adedda769deb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096155Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#750438}
-
Rouslan Solomakhin authored
Before this patch, MicrotransactionRenderTest.java resided in the repository, but was not included in the build, because it was removed in https://crrev.com/c/1828291 due to build bot failure and then was accidentally added back in https://crrev.com/c/1826875 without adding it back to the build. This patch removes MicrotransactionRenderTest.java file. After this patch, the repository does not contain the unused file MicrotransactionRenderTest.java. Bug: 1005076 Change-Id: Ie143f174ddecacd53449b423bae82b570370f731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093165 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#750437}
-
Charlie Hu authored
This CL implements the support for report-to param in Document-Policy/ Document-Policy-Report-Only header according to https://w3c.github.io/webappsec-feature-policy/document-policy.html#reporting. Bug: 993790 Change-Id: I54314077f19d2d57a1d5fbc820fd754fd3ff46da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090370 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#750436}
-
Bence Béky authored
In RecordConnectionCloseErrorCode(): * Add new histograms for recording wire values of received IETF CONNECTION_CLOSE frames. * Use existing "Server" histograms only when protocol is Google QUIC. * Use extracted_error_code instead of quic_error_code for client frames regardless of protocol. In rest of QuicChromiumClientSession::OnConnectionClosed(), use extracted_error_code instead of quic_error_code. extracted_error_code is guaranteed to be the correct QuicErrorCode for locally created frames, and for frames received from servers running QUICHE regardless of whether the protocol is Google QUIC or IETF QUIC (via parsing the error description). Bug: 1060736 Change-Id: Iaa8914722c35af7706d234addadb25c9a1ee927b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098962Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
This reverts commit b2882c21. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1061766 Original change's description: > [WebLayer] Move browserservices.Origin to //components/embedder_support > > browserservices.Origin is used by Chrome's site settings page, which > is being componentized so it can be used by WebLayer. This CL moves > the class to //components/embedder_support. > > Bug: 1058597 > Change-Id: Ic47da47f372d1c27238efd2fee8d7bdcba6eb63d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090875 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750294} TBR=jam@chromium.org,boliu@chromium.org,twellington@chromium.org,jdoerrie@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058597, 1061766 Change-Id: I90a44c5f6168133d90efb254649e776f4e395e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104367Reviewed-by:
-
