GitLab

A recent change (crrev.com/2808093008) did two things:
a) Change a cc file but not change the header accordingly
b) Add a new dependency but not update the gn accordingly

This change fixes those two issues to allow building
Chrome on Android with ffmpeg built in.

Review-Url: https://codereview.chromium.org/2848213003
Cr-Commit-Position: refs/heads/master@{#469417}

Revert of Support base::test::ScopedTaskEnvironment and content::TestBrowserThreadBundle in the same scope. (patchset #7 id:110001 of https://codereview.chromium.org/2860533002/ )

Reason for revert:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk fails

failures:
TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle
TestBrowserThreadBundleTest.MessageLoopTypeMismatch

Original issue's description:
> Support base::test::ScopedTaskEnvironment and content::TestBrowserThreadBundle in the same scope.
>
> A test suite that depends on a test suite base that provides a
> base::test::ScopedTaskEnvironment may need browser threads. Currently,
> the test suite cannot use content::TestBrowserThreadBundle to get
> these browser threads because base::test::ScopedTaskEnvironment and
> content::TestBrowserThreadBundle both set the main MessageLoop and
> the TaskScheduler. With this CL, content::TestBrowserThreadBundle
> doesn't set the main MessageLoop and the TaskScheduler if they
> already exist.
>
> E.g.
> Test suite: ToolbarActionViewUnitTest
>             Needs BrowserThreads
> Base test suite: views::ViewsTestBase
>                  Provides a ScopedTaskEnvironment
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2860533002
> Cr-Commit-Position: refs/heads/master@{#469304}
> Committed: https://chromium.googlesource.com/chromium/src/+/ba0dacfc73d208fc779907890bc94dbd09ef1aad

TBR=gab@chromium.org,robliao@chromium.org,sky@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2859283002
Cr-Commit-Position: refs/heads/master@{#469416}

This CL increases the clickable area of direct share icon:
1. Change the icon size from 20dp to 24dp.
2. Add 8dp margin on both top and bottom of the icon.
3. If direct share icon is shown, remove the 15dp padding on the right
of the wrapping LinearLayout and add 15dp margin of direct share icon.
This makes the right area of direct share icon responses to the click
event of direct share rather than share.

The design spec is here: https://bbergher.googleplex.com/specs/context-menu/.

BUG=None

Review-Url: https://codereview.chromium.org/2858433002
Cr-Commit-Position: refs/heads/master@{#469415}

This CL adds some basic zoom and pan support (touch input mode only for now)
for the iOS client.

This is minimum code to make use of DesktopViewport. The client gesture stuff
may still need more refactoring or redesign to support trackpad input mode,
deceleration animation, etc.

BUG=714193

Review-Url: https://codereview.chromium.org/2856933007
Cr-Commit-Position: refs/heads/master@{#469414}

TriggerManager is just a skeleton here, to be expanded in future CLs.

Review-Url: https://codereview.chromium.org/2855643002
Cr-Commit-Position: refs/heads/master@{#469413}

BUG=

Review-Url: https://codereview.chromium.org/2857393004
Cr-Commit-Position: refs/heads/master@{#469412}

The code to delete existing offline pages created previously by last_n
was also causing the deletion of the very offline snapshot currently
being loaded. This change fixes that by verifying that the snapshot that
would be deleted is not the same as the one being loaded.

It also changes slightly the way the information of the lastest last_n
snapshot is cleared: now that only happens when the snapshot is actually
being deleted.

BUG=718212

Review-Url: https://codereview.chromium.org/2854213005
Cr-Commit-Position: refs/heads/master@{#469411}

This helps avoid security bugs where callers store a FrameTreeNode ID
and later assume it is for the same RenderFrameHost.  However, a
cross-process navigation may have taken place, leading to a higher or
lower privileged page.

Because extension APIs use the old approach, the previous API is left
as an unsafe option, with comments encouraging callers to avoid it.

BUG=715541
TEST=No behavior change.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2856653004
Cr-Commit-Position: refs/heads/master@{#469410}

- all: Use -p consistently to specify a path to the compile db to match
  the convention of clang::tooling::ClangTool
- all: Default -p to out/Debug for convenience.
- docs: Update docs to reference renamed arguments
- docs: Update clang-tidy documentation to use the compile DB generation
  wrapper script
- run_tool.py: Change tool to a non-positional argument and make it a
  required argument.

Change-Id: I378402cab36e86da4b13fb43e26067cad4db1795
Reviewed-on: https://chromium-review.googlesource.com/494946
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469409}

BUG=705575
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818283002
Cr-Commit-Position: refs/heads/master@{#469408}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/075011d..211c500

$ git log 075011d..211c500 --date=short --no-merges --format=%ad %ae %s
2017-05-04 philipel@webrtc.org Don't initiate perodic probing if we don't have a bandwidth estimate.
2017-05-04 pbos@webrtc.org Remove layer_sync from TL frame config.
2017-05-04 henrik.lundin@webrtc.org NetEqTest: Extend the callback structure
2017-05-04 sakal@webrtc.org Add functionality to clear surface to a specific color in EglRenderer.
2017-05-04 pbos@webrtc.org Derive current layer from TL frame config.
2017-05-04 magjed@webrtc.org Reland of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (patchset #1 id:1 of https://codereview.webrtc.org/2862663003/ )
2017-05-04 oprypin@webrtc.org Add --quick flag to low bandwidth audio test
2017-05-04 sprang@webrtc.org Update decode/render fps stats when calling VideoReceiveStream::GetStats
2017-05-04 nisse@webrtc.org Revert of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2854873003/ )
2017-05-04 nisse@webrtc.org Reland of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2854883002/ )

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Review-Url: https://codereview.chromium.org/2862723003
Cr-Commit-Position: refs/heads/master@{#469407}

BUG=717765
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2861963002
Cr-Commit-Position: refs/heads/master@{#469406}

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2865493002
Cr-Commit-Position: refs/heads/master@{#469405}

- Use more StringPieces and C++11.
- Merge some repeated code.
- Fix nits.

Review-Url: https://codereview.chromium.org/2858213002
Cr-Commit-Position: refs/heads/master@{#469404}

This change will suppress all fling cancel events unless the last event
was a fling event. Also it generates a proper sequence of a scroll
event with zero distance.

BUG=590754
TEST=Fling and touch the touchpad after fling. Should stop scrolling
motion in android apps.

Review-Url: https://codereview.chromium.org/2840113002
Cr-Commit-Position: refs/heads/master@{#469403}

The best practice is apparently not to do this and to use
Serialize()/Deserialize() functions directly. This also removes an
EnumTraits test that isn't super useful.

BUG=none

Review-Url: https://codereview.chromium.org/2857033002
Cr-Commit-Position: refs/heads/master@{#469402}

TBR=bajones@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2863603003
Cr-Commit-Position: refs/heads/master@{#469401}

https://pdfium.googlesource.com/pdfium.git/+log/df673c28191c..dcefccc9f0f2

$ git log df673c281..dcefccc9f --date=short --no-merges --format='%ad %ae %s'
2017-05-04 dsinclair Removing unused IFX_Pause parameters

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib8116680974b8967fe03da054cdfad05a6dfd721
Reviewed-on: https://chromium-review.googlesource.com/495490
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469400}

BUG=718445

Review-Url: https://codereview.chromium.org/2862863002
Cr-Commit-Position: refs/heads/master@{#469399}

NameMap, which after the previous patch is no longer used by the shader/program managers, is removed, and the tests updated.

Tests are also added for GetOriginalNameFromHashedName, though these don't actually hit the original error case in the bug report. That's a difficult integration issue and is tested instead by the WebGL conformance tests.

Usages of GetOriginalNameFromHashedName are replaced with more specific methods calls in Program::{GetTransformFeedbackVaryings,GetUniformBlocks}. This avoids querying the unnecessary extra four info maps.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
TEST=ShaderManagerTest.DoCompile
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2852923004
Cr-Commit-Position: refs/heads/master@{#469398}

In the Payment Sheet and the Address selector, display the shipping
option error.

BUG=710004
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2855203002
Cr-Commit-Position: refs/heads/master@{#469397}

BUG=706683

Review-Url: https://codereview.chromium.org/2855033002
Cr-Commit-Position: refs/heads/master@{#469396}

Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (patchset #2 id:20001 of https://codereview.chromium.org/2852433003/ )

Reason for revert:
This caused pageVisibility sub-objects to no longer be undefined which (counter intuitively) causes the sub sections to no longer be visible.

There was some discussion about various approaches to fix this here:
https://codereview.chromium.org/2861443003/

However no agreement was reached, so I am reverting this CL.

Original issue's description:
> MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility
>
> This CL:
> * Removes SettingsSubpageBrowsertest which required extra complexity
>   in the Settings page visibility code and only tested coarse load
>   times of subpages; this testing no longer has much value.
> * Eliminates SettingsPageVisibility which was creating multiple
>   definitions of pageVisibility and generally confusing things.
> * Defines pageVisibility in all cases (not just guest mode). This will
>   allow  the use of dom-if and allows conditional pages
>   (i.e. androidApps) to use the same pageVisibility system. Pages still
>    default to visibile unless explicity set to 'false'.
>
> BUG=709442
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2852433003
> Cr-Commit-Position: refs/heads/master@{#468702}
> Committed: https://chromium.googlesource.com/chromium/src/+/1362453f54271dc1036fc104a01cad436c3da26c

TBR=dpapad@chromium.org,hcarmona@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709442

Review-Url: https://codereview.chromium.org/2866463002
Cr-Commit-Position: refs/heads/master@{#469395}

The toolbar color was changed in https://codereview.chromium.org/2809923003
for Chrome Home. The specified color, #424242, would have required
updating tablet tab strip assets to a darker grey, which violated
accessibility standards. Reverting to the old color.

BUG=716351,695973

Review-Url: https://codereview.chromium.org/2859933004
Cr-Commit-Position: refs/heads/master@{#469394}

This CL moves the interactions with android.media.FaceDetector
because they are slow and trigger a "StrictMode policy violation"
(at least in Debug build).  Some of the parameters are made final
to use them inside a Runnable.

BUG=718275

Review-Url: https://codereview.chromium.org/2863553002
Cr-Commit-Position: refs/heads/master@{#469393}

This has been a source of confusion for several developers since the
old instructions are ambiguous about the last step.

BUG=

Review-Url: https://codereview.chromium.org/2864433005
Cr-Commit-Position: refs/heads/master@{#469392}

TBR=skobes@chromium.org

Review-Url: https://codereview.chromium.org/2860893004
Cr-Commit-Position: refs/heads/master@{#469391}

Part of what this test tests is canceling an in-progress find session by
searching for another search term. The problem that was causing the
flakiness was that the find session that was meant to get canceled
actually finished (rarely) before the subsequent request made it to the
renderer, and so the completed session was not reported as canceled. The
small adjustment made in this CL is to only attempt to cancel the search
that has many results, so that its find session is much less likely to
complete before the next find request comes through.

BUG=710486

Review-Url: https://codereview.chromium.org/2857953004
Cr-Commit-Position: refs/heads/master@{#469390}

BUG=

Review-Url: https://codereview.chromium.org/2860113002
Cr-Commit-Position: refs/heads/master@{#469389}

This patch also  makes the SB throttle pass-through if there isn't a valid
DB manager.

BUG=717590

Review-Url: https://codereview.chromium.org/2858483003
Cr-Commit-Position: refs/heads/master@{#469388}

This lets tests interested in testing features related to the
prefs_services inject their own into TestShellDelegate and
register in it whatever prefs they want.

BUG=718472

Review-Url: https://codereview.chromium.org/2861873004
Cr-Commit-Position: refs/heads/master@{#469387}

Fix a potential crash when we have an active user, but its profile
is not ready yet.

BUG=713934

Review-Url: https://codereview.chromium.org/2864453003
Cr-Commit-Position: refs/heads/master@{#469386}

This CL adds a test for a feature added in CL 2839653002, merged to M59.
The test has been implemented along with the original CL but is uploaded
separately to speed up the process (avoiding deps changes).

BUG=705572

Review-Url: https://codereview.chromium.org/2852383002
Cr-Commit-Position: refs/heads/master@{#469385}

Re-disables WebVrTest#testScreenTapsRegisteredOnCardboard, but only on L
instead of of everything.

TBR=dtrainor@chromium.org
BUG=713781

Review-Url: https://codereview.chromium.org/2855123006
Cr-Commit-Position: refs/heads/master@{#469384}

Change compile targets for Linux Clang Analyzer from "all" to "chrome".

R=dpranke@chromium.org
BUG=689095

Review-Url: https://codereview.chromium.org/2850853002
Cr-Commit-Position: refs/heads/master@{#469383}

This is somewhat catastrophic (it results in blank contents or black
tiles), so be sure that it is captured in about:gpu.

BUG=574014

Review-Url: https://codereview.chromium.org/2858683004
Cr-Commit-Position: refs/heads/master@{#469382}

Extends PromoDialog to support vector drawables, and replaces
the large search_sogou.png asset with a vector drawable.

Replaces 131,070 bytes with 4,834.

BUG=666062

Review-Url: https://codereview.chromium.org/2857893003
Cr-Commit-Position: refs/heads/master@{#469381}

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL24_part1.

Goal of CL24:
The interface content::VideoCaptureProvider currently has one implementation
called InProcessVideoCaptureProvider, which is essentially a factory for the
legacy in-process video capture stack. This CL adds a second implementation
called MojoServiceVideoCaptureProvider which is essentially a wrapper for
connecting to and communicating with the new video capture service.

Changes in part1:
* Add class MojoServiceVideoCaptureProvider
* Add skeletons for classes MojoServiceVideoCaptureDeviceLauncher and
  MojoServiceLaunchedVideoCaptureDevice
* Introduce a build flag enable_mojo_video_capture to prevent the new and
  incomplete code from going into builds.

BUG=584797
TEST=
  service_unittests --gtest_filter="*Video*"
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2848973002
Cr-Commit-Position: refs/heads/master@{#469380}

In the JUnit4 conversion CL (https://codereview.chromium.org/2815453003)
super.tearDown() call was mistakenly removed.

BUG=718454

Review-Url: https://codereview.chromium.org/2861433006
Cr-Commit-Position: refs/heads/master@{#469379}

Hard-code TEMPDIR/TMPDIR for "Xvfb" to "/tmp" in webkitpy's Linux layout
test port. The Xvfb tool's "xkb" library compiles in "/tmp" in several
places, and hard-linking expectations get violated if TEMPDIR and "/tmp"
are on different filesystems.

BUG=chromium:715848
TEST=local
  - Ran without patch and TEMPDIR/TMPDIR overrides, verified hardlink
    failure from bug.
  - Ran with patch, no more hardlink failure!

Review-Url: https://codereview.chromium.org/2859703002
Cr-Commit-Position: refs/heads/master@{#469378}