- 20 Mar, 2020 40 commits
-
-
rbpotter authored
Polymer 3 migration CL at: https://chromium-review.googlesource.com/c/chromium/src/+/2109410 fixed a few issues in these tests. Try re-enabling them to see if they are still flaky on all platforms with the updates. Bug: 929455 Change-Id: I1efce24ce8b7c504379d43aa6ece5cb17896318d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112241Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#752238}
-
Shawn Gallea authored
This is needed to allow Wayland clients to set their own buffer listener and associated user data if needed. Bug: 1011977 Test: NONE Change-Id: Ib105669f8fef939a3226bae85df5c5b7910a79a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110526Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#752237}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/933926683991..e41fa2d5e44d git log 933926683991..e41fa2d5e44d --date=short --first-parent --format='%ad %ae %s' 2020-03-20 brianosman@google.com Add vertices_perspective GM to demonstrate skbug/10069 2020-03-20 reed@google.com implement more blendmodes for skvm Created with: gclient setdep -r src/third_party/skia@e41fa2d5e44d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: Ibac2490c5e071ef6b8522233adeee188a944154c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752236}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c699d98e..11573ee4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2472eb5d347b03ca0d8c3e8a92fe86f6ba698078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113412Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752235}
-
Nicolas Arciniega authored
Since the ProxyResolutionRequestImpl is specific to the ConfiguredProxyResolutionService, it is appropriate to rename it to ConfiguredProxyResolutionRequest. Bug: 1032820 Change-Id: If8691fa721b5a41229b534ed7ad164d0aa7bd5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111835Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#752234}
-
Nikita Podguzov authored
This includes migration from deprecated to new version of base::Value. Also fix possible crash in component_active_directory_policy_service.cc when fetched policy value is not a valid dictionary. Bug: 1050010 Change-Id: I5907df155cf55ebd16b34788b629c6326d5c409a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044110 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#752233}
-
David Van Cleve authored
There was a bug in the initial TrustTokenRequestIssuanceHelper implementation where the issuance helper would attempt to fetch keys scoped to the top-level origin, not the issuer origin. (Thanks for catching this, Charlie!) This CL fixes the bug and expands test coverage by making the FixedKeyCommitmentGetter mock verify that the origin it's called with matches an expectation provided at construction. R=csharrison Bug: 1042962 Change-Id: I03711639945fdc49596d748a5b7aeea76347792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113075Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#752232}
-
Olivier Yiptong authored
This implements an experimental async iterator-based API to enumerate installed unique fonts on a system, available on Frames and Workers. This is a new browser capability that aims to provide web developers low-level access to fonts. The first step is to create the ability to enumerate fonts present on the system. This access could be used to obtain the ability to control how text is rendered, with the addition of Font Table Access, in an upcoming changelist. The backend this API gets its data from is implemented in FontCache. This is the first iteration of this API. It only works on Mac at the moment. Bug: 1043306 Change-Id: I5185c806e3db33ab6c5bdd0604e2d1ece8e78e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106747Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#752231}
-
Ayu Ishii authored
This change adds an implementation of the WebOTP API using the GMS Core User Consent API [1] that can be enabled behind a flag. [1]https://developers.google.com/identity/sms-retriever/user-consent/overview Bug: 1060233 Change-Id: I31c849dfbc43258746121f1dd893292038371cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103067 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#752230}
-
Mason Freed authored
This CL adds the ability to control the delegatesFocus (and eventually the manualSlotting) parameter of the attachShadow command using declarative Shadow DOM. Bug: 1042130 Change-Id: I8cc973ca196151fdc29a1194e25eb86f15849e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107362 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#752229}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1893040e26c0..c51d2249e898 Created with: gclient setdep -r src-internal@c51d2249e898 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I88fd1fd094732f011a21f9430d78242db9159e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752228}
-
David Van Cleve authored
This CL adds a new Mojo interface to the network service, HasTrustTokenAnswerer, providing one method HasTrustToken(url.mojom.Origin issuer) => (error or bool) returning whether the user has any trust tokens (https://github.com/wicg/trust-token-api) for the token issuer origin given by |issuer|. The method first checks if it can associate the calling top-level context (in the sense of TrustTokenStore::SetAssociation) with |issuer| and, if not, fails. For this reason, each instance of the interface is logically scoped to a single top-level context; it is expected that, when the interface is provided to the renderer, each Mojo handle will be bound to a single calling context (with a fixed top-frame origin). This will be used to implement the Trust Token API's Document.hasTrustToken method as a thin wrapper around the Mojo interface (see the child CL at https://crrev.com/c/2103082). Test: adds unit tests Bug: 1061116 Change-Id: Ie67858d65f0fa3a61820db79a904678f4932179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103079Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fa64482db516..c81db8c596ed git log fa64482db516..c81db8c596ed --date=short --first-parent --format='%ad %ae %s' 2020-03-20 ehmaldonado@google.com git-cl: Remove GetIsGerrit. Created with: gclient setdep -r src/third_party/depot_tools@c81db8c596ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic97bcda2219bb71cbdc14f0ae3f4a9da23fda305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113193Reviewed-by:
-
Qingwen Pi authored
This implementation will be used in multizone code to remove ::media::DecoderBuffer dependency. Bug: b/149422033 Change-Id: Ic4c327e7c69b5136a02de91487db2f2beb32201d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113438 Commit-Queue: Qingwen Pi <qwp@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#752225}
-
Martin Barbella authored
Change-Id: Ic4ef7ae917e6e75e0e6700c2b7676ca18230f839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113077 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#752224}
-
Khushal Sagar authored
TBR=dcastagna@chromium.org Bug: 976583 Change-Id: Icb35e67674cf1e4b1e60c3eaded37d2236b2026f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112987 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#752223}
-
Yue Zhang authored
Bug: 1035995, 1063334 Change-Id: I8e5e03ea7919665e7b2f97a6ec53306c41acc828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112986 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752222}
-
Demetrios Papadopoulos authored
Specifically moving the following surfaces: - manage_profile.html subpage was already a dependency of lazy_load.html, but it was also (accidentally) still a dependency of people_page.html, causing it to be part of vulcanized.html in Polymer 2 and shared.rollup.js in Polymer 3. - signout_dialog.html and import_data_dialog.html similar to previous change for the CBD dialog. - sync_controls.html and sync_page.html subpages vulcanized.html: 276K -> 234K (-15%) crisper.js: 336K -> 299K (-11%) lazy_load.vulcanized.html: 183K -> 226K lazy_load.crisper.js: 233K -> 271K Also updating Polymer3 related files (settings.js, lazy_load.js) accordingly. Bug: 1026064 Change-Id: I790a29074181b9f908290b76e74aea98b3d1e86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110675 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#752221}
-
danakj authored
This was included for a single method, which does not need web test stuff at all. Move the method (and its companion) over to another file in content/public/test/. R=nasko@chromium.org Bug: 866140 Change-Id: Iad7d324b4c2d839d406b09d4f1c2397c523c309b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112902 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#752220}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9d6efa3a2860..dba08d7f6fed git log 9d6efa3a2860..dba08d7f6fed --date=short --first-parent --format='%ad %ae %s' 2020-03-20 miu@chromium.org Cast Streaming Sender: Add network bandwidth estimation Created with: gclient setdep -r src/third_party/openscreen/src@dba08d7f6fed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I662a6ec9fbf7b81b4b3c211e0d7a57e73dc122ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113312Reviewed-by:
-
John Rummell authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/d2350e1645b5..31886e8f39a4 $ git log d2350e164..31886e8f3 --date=short --no-merges --format='%ad %ae %s' 2020-03-20 jrummell Revert "Add configure flag --disable-mips32r6 for Linux MIPS64 builds" 2020-03-18 jrummell Check that ogg stream contains enough data while checking codec 2020-03-17 liberato Upload ffmpeg configs, etc., for review if tests pass. Created with: roll-dep src/third_party/ffmpeg Bug: 1054229 Change-Id: I3c60e5b749208a937e477dfd31312a2f5c780669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112980Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#752218}
-
Yuke Liao authored
Due to a limitation in the Clang coverage tooling, coverage profling from browser_tests often get corrupted on coverage CI builders on Linux platform , so this CL runs browser_tests without sandbox, and this CL only applies to the CI builder (not CQ). Bug: 1016929 Change-Id: Ic5e2ca3ebb2ea1a77c8456689e2513318b67c5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112985Reviewed-by:
Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#752217}
-
David Bokan authored
The source of the attached bug is calls to ScrollableArea::ShowOverlayScrollbars from PaintLayerScrollableArea::VisibleSizeChanged. This call is performed to flash scrollbars when a scroller is initialized or resized. However, this behavior doesn't apply on the Mac platform. ShowOverlayScrollbars sets the overlay state to showing in ScrollableArea which makes scrollbars visible to hit testing. On non-Mac platforms it'll also cause scrollbars to be visibly shown; however, this mechanism doesn't actually cause scrollbars to paint visible on Mac - that's handled by ScrollAnimatorMac and there's no signal to it to do so here. Furthermore, it starts a timer to fade out the scrollbars but this only happens on platforms where Chromium code owns scrollbar fade out (Android, ChromeOS). This means that on Mac we're in a situation where the scrollbar is visible to hit testing but isn't visible on the screen. This causes us to inadvertently send mouse enter events to the scrollbar causing it to activate unexpectedly. The solution here is to avoid setting the overlay state from this method on Mac. We already plumb all the necessary signals (like content resize) to ScrollAnimatorMac so it should be in full control of the scrollbar visibility state. This CL splits the setter method into one that's called only from Mac's scrollbar painting APIs and one that's called from all the other places where its needed. This allows us to DCHECK that we're not setting this value without going through the Mac painter. Some additional notes: - Select listboxes have an overflow-y:scroll style which means they should get a scrollbar even when there's no overflow. However, there appears to be some issue here; during page load, the listbox adds and then removes its scrollbar. When clicked, it then adds a vertical scrollbar. This happens due to a style-related change (probably focus). It's not clear to me why the scrollbar was removed but this is the reason the test case in https://crbug.com/1039501#c22 requires a click to reproduce. Perhaps we should only be adding scrollbars for non-overflowing content when they're non-overlay. - The scrollbar doesn't fade out because the MouseMovedInContentArea signal is sent only if the scrollable area has overflow (see EventHandler::HandleMouseMoveEvent). It's not clear if that's correct but at the very least it should be up to the ScrollableArea to determine that. The signals for MouseEnteredScrollbar and similar do not have a similar restriction. They probably should (or DCHECK that the scroller has overflow). This can be done in a followup. - It's not clear to me why the geometry of the scrollbar is wrong; it's a small square located on the left rather than right of the scroller. My guess is that it's unexpectedly shown and the code doesn't handle the case where there's no overflow but I haven't investigated this. Bug: 1039501 Change-Id: Id7ba50ffa18994f0fe757f0881be4b7db68df60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110676Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752216}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62b7255252fd..07467b4acaa6 git log 62b7255252fd..07467b4acaa6 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 geofflang@chromium.org Remove GL_CHROMIUM_path_rendering 2020-03-20 geofflang@google.com Android.bp: Ignore unknown warning flags. 2020-03-20 sugoi@google.com ASTC: LDR support doesn't imply HDR support 2020-03-20 thakis@chromium.org Suppress two -Wunreachable-code warnings on Fuchsia in Angle. 2020-03-20 jmadill@chromium.org Vulkan: Fix Framebuffer cache depth/stencil issue. 2020-03-20 jmadill@chromium.org Add optimized rendering feedback loop tracking. 2020-03-20 cnorthrop@google.com Perf: Limit TracePerfTest to single compressed TRex Created with: gclient setdep -r src/third_party/angle@07467b4acaa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1063193,chromium:346399 Tbr: courtneygo@google.com Change-Id: I2afabd50f1fe5618786d138eee3132b1d4b82aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112977Reviewed-by:
-
Scott Violet authored
weblayer shell has a slightly smaller height than chrome. The size is such that this test ends up failing because the generated touch event is outside the visible area. This patch shrinks the height slightly so that it passes on weblayer. I don't believe shrinking the height of this target impacts the overall test.. BUG=1049426 TEST=test only change Change-Id: Ie0f2fadc4ec613d92c074b60eb87c97d70f78094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112984Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#752214}
-
Robert Ma authored
The test does not seem to be flaky recently. TBR=smcgruer Fixed: 986477 Change-Id: Ic09e0466315be8d39d7acfe406be5e6bfd29525a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113511Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#752213}
-
Yue Zhang authored
As it is suggested here https://cs.chromium.org/chromium/src/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/CriteriaHelper.java?l=113&rcl=2e9059b1209182ea41862d3cba9375a7ea179dd4, pollUiThread should be the more proper one used in InstrumentationTests. This CL replaces the pollInstrumentationThread usage with pollUiThread in tab_ui tests if appropriate. Also, this CL re-enables the tests disabled here http://crrev.com/c/2108528 to see if this CL fixes the real culprit. Bug: 1062659 Change-Id: I986d1904f8963588014ca6d203d10f453148497f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109125 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Removes one browsertest each from the bluetooth, serial, and usb chooser dialogs; these browser tests covered the "bubble dismisses on navigation" behavior, which is now provided by LocationBarBubbleDelegateView and tested as part of that class's tests. 2) Removes some code from VRUiHostImpl that observed the chrome BubbleManager. This code was now dead, since no bubbles use the BubbleManager any more. 3) Removes ChooserBubbleDelegate, the only remaining BubbleDelegate in //chrome, now no longer used anywhere. 4) Removes ChromeBubbleManager, now no longer used anywhere. 5) Removes dependencies from //chrome on //components/bubble. Bug: 496955 Change-Id: Ife81ad2ae9e5409e4a78fe2f4ac8df81decccdc2 Tbr: rdevlin.cronin@chromium.org,avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112234 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752211}
-
Luum Habtemariam authored
We previously implemented this generic ppd as a fallback for Epson printers that failed ppd matching. This led to some unforeseen issues detailed in the bug below; as such this special handling is no longer needed and this change removes it. Bug: chromium:1049850 Test: tba Change-Id: I45c9dce72205f8ed9255d983cac8b1a739fa388a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087959 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This is a re-land of [2]. It was reverted due to a flakiness introduce in [3]. The reason for the flakiness appears to have a couple of sources: (a) sometimes the image for one of the ref/non-ref will load a bit faster (b) scrollbars present in the ref case, because the image is not clipped by overflow:hidden (c) 8px margin (a) is fixed by using reftest-wait. (b) is fixed by adding overflow:hidden to the HTML element; (c) is fixed with margin:0. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1773869 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2103708 [3] external/wpt/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html Bug: 992765, 999019, 995119, 999209, 1045745 Change-Id: I6ad8c5564f65d131da9b04180499a4bd98a4c8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111906Reviewed-by:
-
Rakina Zata Amni authored
We've added a "level" param for ProactivelySwapBrowsingInstance in https://chromium-review.googlesource.com/c/chromium/src/+/2043521, so we should update the field trial config. See cr/301790432. Bug: 977562 Change-Id: Ica9231513f541c93e8085b0f06a73bc36fcaed2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109578 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752208}
-
Tricia Crichton authored
Improve the standard message on the need to protect ChromeDriver. The current message is sometimes taken by users as an error statement. Bug: chromedriver:3351 Change-Id: Ic4d8f7bd4413a5472288133b52c0d61b97665849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108786Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#752207}
-
Eugene Zemtsov authored
Adding all WebMediaPlayer related memory dumpers to the allowlist for the background collection. It would let media memory data to be uploaded via standard memory reporting pipeline. Also making sure that play state is not reported in the backgounrd mode, otherwise it triggers a DCHECK. Bug: 1056839 Change-Id: Id19f588f286b011a30345f6d1f150e2788515fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112332 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#752206}
-
Dana Fried authored
ToolbarActionIconView now queries its delegate for icon size instead of it being a configurable parameter on creation. Parameter on creation didn't work anyway because the value would later be overridden when tablet mode was toggled (i.e. this never worked correctly). Bug: 1063423, 1061634 Change-Id: I586a7a0e8aa49649e2be08ad7c73b8113730ee98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112588Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#752205}
-
Martin Barbella authored
This is consistent with other attributes, and looks cleaner when adding grammars to targets. Change-Id: I149fc1bb2b0a515280d649a50d149de424b3a102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111391 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Auto-Submit: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#752204}
-
Taylor Brandstetter authored
This incorporates over a year and a half of changes, including several fixes for security vulnerabilities. Had been prevented from updating it due to a deadlock issue, however the commits that introduced that issue have been reverted. Intentionally not updating to tip-of-tree since there are changes in progress; will roll again when more confident things are stable. Commit log since last roll: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/7a8bc9a90ca9..bee946a60675 Bug: chromium:1025302 Change-Id: Ie21cd4db12cbae07a764f6f1373eb964c88c56c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094540 Commit-Queue: Taylor <deadbeef@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#752203}
-
John Lee authored
Fixed: 964891 Change-Id: Idc993115825dffbcc6cb84edf5117d4b7430c751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110524Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752202}
-
Brian Sheedy authored
Adds the configs for "Win10 FYI x64 SkiaRenderer Dawn Release (NVIDIA)" and its manual trybot counterpart "gpu-fyi-try-win10-nvidia-sk-dawn-rel-64". Bug: 1062399 Change-Id: I0a7ad25e9635fbf319bb6f02cc2e0fe8c0569019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111760Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752201}
-
Wei-Yin Chen (陳威尹) authored
The parameter "thumbnail_aspect_ratio" is still not specified yet. See also: go/clank-sand-wedge Bug: 930979 Change-Id: Ie7318a57c041b39a6dd55b7929c9c1d80f21b40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112112Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752200}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fc407350ad45..bf198e71ef28 git log fc407350ad45..bf198e71ef28 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 thestig@chromium.org Initialize CPDF_TextState members in the header. 2020-03-20 thestig@chromium.org Mark CPDF_Parser::SetLinearizedHeader() as ForTesting. 2020-03-20 tsepez@chromium.org Make CFXJSE_Value use fxv8 helpers for aggregate type access. Created with: gclient setdep -r src/third_party/pdfium@bf198e71ef28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia6d23322f7c62e6ce80e964f1f4e87389348172f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113310Reviewed-by:
-
