- 18 Jun, 2018 40 commits
-
-
Luis Hector Chavez authored
This change makes it possible to allow interfaces to globally handle unhandled RuntimeExceptions, in their bindings or in the callbacks. delegate can now forward the unhandled exceptions to the crash server. Bug: 810087 Test: Android-on-Chrome OS has the same behavior as before Test: Android-on-Chrome OS, when setting the DefaultExceptionHandler's Change-Id: I2b7455a0344a109e1d2416a74ad4a0b98cd007f0 Reviewed-on: https://chromium-review.googlesource.com/1101898Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568128}
-
Sadrul Habib Chowdhury authored
BUG=778749 Change-Id: I3ff438e53838e3e8c9c387fab837af0a31bcdac2 Reviewed-on: https://chromium-review.googlesource.com/1101643Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568127}
-
danakj authored
These methods are only valid when the Layer is in a Layer tree attached to a LayerTreeHost, making them difficult to use. Also, they don't use any private stuff from Layer so they don't need to be part of its API. Instead have code that knows about the LayerTreeHost get the MutatorHost off that. PropertyTrees code could also but doesn't have the LayerTreeHost/LayerTreeImpl passed in today. HasTickingAnimationForTesting() was being tested to return false when the Layer is not attached to a LayerTreeHost, which is testing test-only code. Remove those cases. Instead have tests query the MutatorHost directly. R=weiliangc@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id384e3cef22d62c65e4c63411bdbfd603993f5ce Reviewed-on: https://chromium-review.googlesource.com/1101416 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568126}
-
Aga Wronska authored
Showing demo mode setup UI is already guarded by the appropriate screen group check. This check is sufficient. Change-Id: I61478bb0e0a4933a2f6869781b7a9b115d926f08 Reviewed-on: https://chromium-review.googlesource.com/1104974Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#568125}
-
Raymond Toy authored
Print a deprecation message when WebAudio Media nodes (MediaElementAudioSourceNode, MediaStreamAudioDestinationNode, MediaStreamAudioSourceNode) are created on an OfflineAudioContext. Doing so is not allowed in the WebAudio spec. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/H29uXnsIN54/BKXDqxoJAQAJ Chrome feature entry: https://www.chromestatus.com/feature/5258622686724096 Bug: 845913 Change-Id: I5247d67456afa11582099f4d52d65a76f788639d Reviewed-on: https://chromium-review.googlesource.com/1091656 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#568124}
-
Aleks Totic authored
Will need help with this one. I think it is a real regression. Offending CL modifed LayoutBox::AvailableLogicalHeight https://chromium-review.googlesource.com/c/chromium/src/+/1093996 LayoutBox::ComputePercentageLogicalHeight gets called 740 times for each layout. I was unable to reproduce this on my Linux box. Uploading so I can run on Android. The test also renders incorrectly in Legacy, correctly in NG. The root cause of incorrect rendering is that LayoutBox::ComputePercentageLogicalHeight for TableCell is incorrect in Legacy when: #target { overflow: auto; height: 100%; } td { height: 100%; } table { } <table> <td> <div id="target"> LayoutBox::ComputePercentageLogicalHeight should in this case return intrinsic_logical_height instead of 0. Bug: 852976 Change-Id: Iaf65c226eb9727877d14e68156d522421af57c87 Reviewed-on: https://chromium-review.googlesource.com/1103289Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568123}
-
Ryan Sturm authored
This fixes a typo in the capping heavy pages flag string and removes the text around Renderer side resource scheduler, since that has already launched. Change-Id: Ic0662f4621d2c7094f2c2ec8b2e3591c61e300cf Reviewed-on: https://chromium-review.googlesource.com/1104888Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#568122}
-
rbpotter authored
In normal print preview dialogs, the handler is destroyed with the web contents, but for the special case of chrome://print this does not occur, and old preview requests should be cleared in OnJavascriptDisallowed(). Bug: 853672 Change-Id: I5681680dc64fe020f389c6893d992694e8fcdb95 Reviewed-on: https://chromium-review.googlesource.com/1104877Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568121}
-
danakj authored
With an image theme we use kPlus blending mode so that the alpha of the active and inactive images together adds to 255, and is opaque. Before 8f007b92 we did the same for solid colors as well. But afterward it was lost, only applying to images. This CL restores the kPlus mode for solid colors too. R=oshima@chromium.org Bug: 852612 Change-Id: I6f581d34dea85d98dc602e34a4ad87e4115d2d8c Reviewed-on: https://chromium-review.googlesource.com/1103012Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#568120}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a735a26. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 1db32e09 "OffscreenCanvas Text rendering tests" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" de5c1819 "Do not override kReattach for ::first-letter." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19913 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: I9b054e2564ef14693127be1bc1cfa936a578a774 Reviewed-on: https://chromium-review.googlesource.com/1104784 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568119}
-
Sadrul Habib Chowdhury authored
DidNotSwap() no longer needs to return any value. crrev.com/567297 removed the last instance of a persistent SwapPromise that would return KEEP_ACTIVE. Now that it's gone, the associated code can be removed. BUG=851504 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12d5af548800ac8674c1ab11f38c9aeb73338941 Reviewed-on: https://chromium-review.googlesource.com/1103944Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#568118}
-
Zhongyi Shi authored
Fix QUIC connection migration to cancel migrate back to default if an earlier migration has brought the session to the default network. This change also converts obsolete V1 tests for V2, adding regression test coverage. Bug: 818259, 843299 Change-Id: I8abfdb9af15af132efab62686fb014502e641198 Reviewed-on: https://chromium-review.googlesource.com/1103222 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568117}
-
Daniel Bratell authored
There is both ::extensions::api::storage and ::storage so inside extensions::api, unless you explicitly write ::storage it's unclear what namespace is intended. In jumbo builds, some code ended up in a translation unit where both storage namespaces were known, so this patch adds :: to storage to make the code explicit. There is a code style guideline to not use namespace names that are also top level namespace for this reason, but it's not easy to change all extension api namespaces. Bug: 850484 Change-Id: I1c85fbc9dd3dc8be49d41be25f4886ec98c47926 Reviewed-on: https://chromium-review.googlesource.com/1104678 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568116}
-
Paul Miller authored
BUG=655167 Change-Id: I2b18f52fae92993f1e37852924d8cbaf19872eaf Reviewed-on: https://chromium-review.googlesource.com/1103395Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568115}
-
Balazs Engedy authored
This CL introduces AuthenticatorSheetModelBase, which will serve as a base class for sheets, and implement the shared behavior used on most sheets, as well as maintaining a weak pointer to the dialog model. Also introduce CreateSheetViewForCurrentStepOf, a factory method that constructs the appropriate SheetView subclass, along with the appropriate SheetModel subclass. Bug: 849323 Change-Id: Iaedb3da6aa3f3fdc932b57cc5795143acab7d4c5 Reviewed-on: https://chromium-review.googlesource.com/1104422Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568114}
-
Steven Holte authored
Flakily timing out. BUG=853852 TBR=ekaramad NOTRY=true Change-Id: I894fe217109a63e86ed5aa2b2be2c801b8f91d76 Reviewed-on: https://chromium-review.googlesource.com/1104977Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568113}
-
Fabrice de Gans-Riberi authored
This removes all the remaining disabled tests in the filter file for base tests on Fuchsia and instead filters each of them individually. Bug: 738275, 752368, 753490, 810077, 811881, 851734, 851747, 851759, 851760 Change-Id: I375954138d09ebacc05b2ad37afe1e09901e52e2 Reviewed-on: https://chromium-review.googlesource.com/1096483Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#568112}
-
Pedro Amaral authored
The model properties should be agnostic to the view implementation. ANDROID_VIEW_VISIBILITY was an int but that was view specific and really all the mediator needs to interact with is whether or not the Android View is visible. Change-Id: I0daa79cc0d5a4a2a1a5c7b2443eee731525baa66 Reviewed-on: https://chromium-review.googlesource.com/1103545 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568111}
-
Jun Cai authored
Network Service: Add VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromRequestUsingSimpleURLLoader This CL adds variations http headers browser which uses SimpleURLLoader. Bug: 841309 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I16bc257c18b76f0b2ba6b9ba721b87f4e3fb44a7 Reviewed-on: https://chromium-review.googlesource.com/1100106 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568110}
-
Kai Ninomiya authored
Bug: 828135 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9ac4b3d671bee44c574f1a75ca357296a34f1cba Reviewed-on: https://chromium-review.googlesource.com/1098558 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568109}
-
rbpotter authored
Since /deep/ is deprecated in shadow DOM v1, track highlights and search bubbles as they are added to avoid searching recursively to remove them later. Bug: 852098 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iac61a1f340ae4029589556c3ad09e567126a1639 Reviewed-on: https://chromium-review.googlesource.com/1100102 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568108}
-
Daniel Nicoara authored
Add a BOOT_ANIMATION_OVERLAY type for the initial animation happening at startup. Add a CORNERS_OVERLAY type for window mask around the display corners. BUG=b/110092844 TEST=None Change-Id: Ifde30aeb490171e2f3daf0bb727f9e70e6e6ced4 Reviewed-on: https://chromium-review.googlesource.com/1103301 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#568107}
-
Mathieu Perreault authored
Code was referencing undefined variables. Bug: 853780 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie50c336424a45f780b854b35074b788be65a9368 Reviewed-on: https://chromium-review.googlesource.com/1104779Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#568106}
-
rbpotter authored
Add new print preview to the upcoming UI features flag. Bug: 773928 Change-Id: Ia1fe0883fba0a76b6bbf75b86b932f3b1abf0947 Reviewed-on: https://chromium-review.googlesource.com/1103292Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568105}
-
Matthew Jones authored
This patch sets a flag for using light toolbar drawables when the visual state is update. This was incorrectly excluded with 227a972f. Bug: 852682 Change-Id: I77a2e9f742720b48045a9f02ac1ab0a8ebb77429 Reviewed-on: https://chromium-review.googlesource.com/1104708Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#568104}
-
Wez authored
Replace use of QuitCurrent*Deprecated() with use of the QuitClosure of the //content default main message loop's RunLoop. Bug: 844016 Change-Id: I14eb18304de9c9ddaabc2860998d12733572e7f7 Reviewed-on: https://chromium-review.googlesource.com/1103787 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568103}
-
Ovidio Henriquez authored
This change enables Dedicated Workers to inherit the Feature Policy of the context that created the worker. Bug: 843780 Change-Id: I2afaf7ee8547853a2f1c639961c78260efbd9633 Reviewed-on: https://chromium-review.googlesource.com/1091635 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568102}
-
rbpotter authored
Bug: 850719 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I63fb963d90fe8b240fce80b52f8b852d5c77f311 Reviewed-on: https://chromium-review.googlesource.com/1101923 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568101}
-
Raymond Toy authored
Change the testing scheme for k-rate panner to verify that the output is piecewise constant for a constant source when the automation rate is set to k-rate. Reduce the duration of the test as well; Just a few render quanta is enough to verify that the output is piece-wise constant and different from the a-rate output. Also updated k-rate-constant-source.html to use the same doTest method since the special case is supported. Didn't actually figure out the underlying flakiness of the original test. Bug: 841856 Change-Id: I8e9807e530fc3b1452bae521a2660be3fbe104f9 Reviewed-on: https://chromium-review.googlesource.com/1076809Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568100}
-
chrome://discardsChris Hamilton authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3c25b29dfbb00edbb179003d17cfe061a32ebce3 Reviewed-on: https://chromium-review.googlesource.com/1100086 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#568099}
-
Kevin Bailey authored
...to standard Chrome icon color. Bug: 780835 Change-Id: Ie377265d7f50a8598075aca9b7868239750b2c6f Reviewed-on: https://chromium-review.googlesource.com/1104787 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#568098}
-
Rayan Kanso authored
Change-Id: I840e7e4c5b02b346e7edab78a4264d6b22bb4a9d Reviewed-on: https://chromium-review.googlesource.com/1103202 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568097}
-
Sigurdur Asgeirsson authored
This will allow a narrower guestimate at the validity of performance measurements relating to load events. Bug: 755840 Change-Id: I7087c5840106102844ef7518c0ad42648f4abe3e Reviewed-on: https://chromium-review.googlesource.com/1101304 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#568096}
-
sebsg authored
Change-Id: I2dcfc3411ba478355a927874cf4b3938276288a5 Reviewed-on: https://chromium-review.googlesource.com/1103154Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568095}
-
Jamie Madill authored
This is flaking on Viz/Windows/Intel. Not clear how to select viz as a config in the GPU expectations module. Suppress this on the Windows Intel config for now. Bug: 853762 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I83bc2699d7b7a904eb68b97886d1c91025307d31 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1104783Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#568094}
-
Jamie Madill authored
This reverts commit edb91802. Reason for revert: Suspecting flaky crashes: Win10 FYI Release (Intel HD 630) vr_browser_test https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29/974 Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: (No symbol) [0x6A3B41A0] (No symbol) [0x6A3B174E] device::OpenVRRenderLoop::SubmitFrameWithTextureHandle [0x052D8C2F+323] device::mojom::VRPresentationProviderStubDispatch::Accept [0x0399C195+1089] device::mojom::VRPresentationProviderStub<mojo::RawPtrImplRefTraits<device::mojom::VRPresentationProvider> >::Accept [0x052D9963+19] mojo::InterfaceEndpointClient::HandleValidatedMessage [0x03562159+541] mojo::FilterChain::Accept [0x0441F4F3+131] mojo::InterfaceEndpointClient::HandleIncomingMessage [0x03563006+106] mojo::internal::MultiplexRouter::ProcessIncomingMessage [0x0356658A+698] mojo::internal::MultiplexRouter::Accept [0x03566111+295] mojo::FilterChain::Accept [0x0441F4F3+131] mojo::Connector::ReadSingleMessage [0x03560830+364] mojo::Connector::ReadAllAvailableMessages [0x03560F0D+87] <snip> Bug: 853790 Original change's description: > Add an interface to communicate between the fake openvr and tests > > This change creates a way for tests to control the behavior of > the fake OpenVR, and allows devices to send information up to > tests. > > BUG=801034 > > Change-Id: Ie0fe035ada9553114c054717f52788d375d5c62f > Reviewed-on: https://chromium-review.googlesource.com/1100157 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567725} TBR=jam@chromium.org,bsheedy@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 801034 Change-Id: Ie55238c46b1d9c34d92bee2b6324539912b47846 Reviewed-on: https://chromium-review.googlesource.com/1104837Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#568093}
-
Ben Chan authored
https://android-review.googlesource.com/c/platform/system/connectivity/shill/+/181040 replaced the "HostName" property in the shill Manager interface with a new "DHCPProperty.Hostname" property. However, the migration was partially done, which has been fixed by CL:1102152. This CL updates the code on the Chrome side accordingly. Bug: 852035 Change-Id: Ib0d7fc7e82f13b9f77cda13324702f610d952f61 Reviewed-on: https://chromium-review.googlesource.com/1104312Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568092}
-
Fady Samuel authored
We would like to start a Finch trial for surface sync on Android soon. This CL re-enables Android-specific surface invariants violations checks on Android by removing code in RenderWidgetHostImpl that bypasses those checks. This CL also ensures that when the background transparency changes a new LocalSurfaceId is allocated as this matches the behavior pre-surface-sync. Bug: 672962, 789259, 801350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iad2dc6c508770314ea33eb53f05944609f29b0b9 Reviewed-on: https://chromium-review.googlesource.com/1104315Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568091}
-
Marijn Kruisselbrink authored
NavigationRequest calls ProceedWithResponse if network service isn't enabled because MojoAsyncResourceHandler depends on this. Since we want to start using BlobURLLoader before network service ships, this means BlobURLLoader.ProceedWithResponse can also be called and thus shouldn't be a NOTREACHED. Replace with an empty implementation instead since it isn't pausing the response anyway. Bug: 800901 Change-Id: I7edc6a1b20f5aac2fa312a3a2770424464cf12df Reviewed-on: https://chromium-review.googlesource.com/1103061 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#568090}
-
Sky Malice authored
While not as common of a pattern as storing base::Time in Prefs, it does show up in a few places, and is the logical continuation of the Set/GetTime() methods that we currently have. Change-Id: Ib38c2f4b431733bc4f40323756ea5fc6f68dfbed Reviewed-on: https://chromium-review.googlesource.com/1103147 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#568089}
-