- 04 May, 2018 40 commits
-
-
Marc Treib authored
This reverts commit 79b28587. Reason for revert: performance-return-real-time.js fails on MSAN: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/ Original change's description: > Using non-override time in InspectorPerformanceAgent.cpp. > > Right now the InspectorPerformanceAgent returns incorrect performance metrics > (such as LayoutDuration, ScriptDuration, etc.) if there is an time override in > place. The InspectorPerformanceAgent needs to return real time elapsed. > > Per offline discussion with Pavel(pfeldman@), the reason we don't expose the > non-override time API in the web platform (<blink>/platform/time.h) is that time > override is to abstract the web platform from the time. The web platform should > just deal with time and not know about whether the time is overridden. Exposing > the non-override time API in the very core part of blink will leak the override > aspect and hence compromising the whole design > > BUG: 830033 > Change-Id: If3140892ac60bc853ef5f98f7b478a98ae332806 > Reviewed-on: https://chromium-review.googlesource.com/988833 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Johnny Ding <jnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556012} TBR=dgozman@chromium.org,jnd@chromium.org,haraken@chromium.org,pfeldman@chromium.org,jochen@chromium.org Change-Id: Ic6f8feb1c77147e8b18fad12a95b1761cd13c2a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1044145Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556027}
-
Marc Treib authored
This reverts commit fd8a3a1f. Reason for revert: The depended-on CL has been relanded as https://crrev.com/c/1030451 Original change's description: > Revert "Sync: Use IdentityManager instead of SigninManager" > > This reverts commit aab57914. > > Reason for revert: Depends on crrev.com/c/1025898 which was reverted > > Original change's description: > > Sync: Use IdentityManager instead of SigninManager > > > > This CL migrates ProfileSyncService to IdentityManager for getting > > info on the primary account. This includes switching from > > SigninManagerBase::Observer to IdentityManager::Observer. > > The only remaining use of SigninManager within PSS it to call > > SignOut() which isn't exposed by IdentityManager yet. > > > > Bug: 825190 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Change-Id: Icf9398d63794cab03cb559adba5c767e18c31c0a > > Reviewed-on: https://chromium-review.googlesource.com/983914 > > Commit-Queue: Marc Treib <treib@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553973} > > TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org > > Change-Id: Ib40dbff0f1c8e5fba95cb9881681361abec5aeec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190, 837201 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/1030372 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553997} TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825190, 837201 Change-Id: If6858f033ac8390acfc904379afbf9726a6301c2 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1043885Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556026}
-
Marc Treib authored
TBR=wangxianzhu@chromium.org Bug: 839734 Change-Id: Ic35abab341a46e52d2586f2f5515bf0701f96fec Reviewed-on: https://chromium-review.googlesource.com/1043985Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70f3bb06..cfcbf96b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0f0142146ed2d894be39511968bbfac7b401a53c Reviewed-on: https://chromium-review.googlesource.com/1043690Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556024}
-
Antonio Gomes authored
Driven by CL for prior to a major rename (fetcher -> loader). BUG=none Change-Id: Idcb01dfa92f32b055472f5d98632197d8ecf0dc3 Reviewed-on: https://chromium-review.googlesource.com/1043286Reviewed-by:
-
Marc Treib authored
TBR=hubbe@chromium.org Bug: 177163, 427730 Change-Id: I02ea53b381d3bf053b1ed8247c8d86704329a32b Reviewed-on: https://chromium-review.googlesource.com/1043905Reviewed-by:
-
Kevin Marshall authored
System logs are included by default, unless they are deliberately switched off by using the --no-system-logs flag. -v now turns on DEBUG level logging and enables verbose mode for SSH. Bug: 839662 Change-Id: I286dd33e3c76864154a98a9e4c07af49b036ec09 Reviewed-on: https://chromium-review.googlesource.com/1043453Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556021}
-
https://chromium.googlesource.com/angle/angle.git/+log/41e59f55a4d2..7a8fe15682f3 $ git log 41e59f55a..7a8fe1568 --date=short --no-merges --format='%ad %ae %s' 2018-04-28 jiawei.shao ES31: Add link validation on MAX_COMBINED_SHADER_OUTPUT_RESOURCES Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2669eccf1f1556e8fb8709cb05bb8afb75dca1f7 Reviewed-on: https://chromium-review.googlesource.com/1043652 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556020}
-
Sungguk Lim authored
Use std::unique_ptr instead of deprecated linked_ptr Bug: 556939 Change-Id: Ifb89741b5815b388961a67aebf6d1f7cf07d7b7d Reviewed-on: https://chromium-review.googlesource.com/1040325Reviewed-by:
-
Marc Treib authored
Both in SitePerProcessHitTestBrowserTest and in SitePerProcessHighDPIHitTestBrowserTest. TBR=mcnee@chromium.org Bug: 833380 Change-Id: I5469e74827a6daaff72b6c85b2095866f91b601a Reviewed-on: https://chromium-review.googlesource.com/1043869Reviewed-by:
-
Marc Treib authored
Original CL: https://crrev.com/c/1025898 Revert: https://crrev.com/c/1030150 Patchset 1 contains the original CL. What's changed from there is to set up the primary account without providing a refresh token (like the tests did before this change). Original change's description: > Revert "Migrate Arc unit tests to IdentityManager" > > This reverts commit 1e3550d5. > > Reason for revert: Failing tests, see crbug.com/837201 > > Original change's description: > > Migrate Arc unit tests to IdentityManager > > > > identity::IdentityManager is the new API that replaces SigninManager[Base]. > > > > This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. > > > > Bug: 825190, 731023 > > Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b > > Reviewed-on: https://chromium-review.googlesource.com/1025898 > > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > > Commit-Queue: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553949} > > TBR=yusukes@chromium.org,treib@chromium.org > > Change-Id: Iba9649631ec8633c0b89b867a60e89d3d63a01ad > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190, 731023, 837201 > Reviewed-on: https://chromium-review.googlesource.com/1030150 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553979} Bug: 825190, 731023, 837201 Change-Id: I83753ba9036eb9f93ba32c74302dbd151b03c0bf Reviewed-on: https://chromium-review.googlesource.com/1030451Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556017}
-
Tim Schumann authored
This is a follow-up to https://chromium-review.googlesource.com/1030177 Bug: 832019 Change-Id: I9c473fa5c81fd918cb203d6ae18dd5aeea04e68a Reviewed-on: https://chromium-review.googlesource.com/1042705 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
-
Marc Treib authored
It fails with the leak detector. The version without the "virtual/video-surface-layer/" prefix was already being skipped. TBR=mlamouri@chromium.org Bug: 838128 Change-Id: Icb4e898e9c24c20b94cd5bfb51042b65e1ace7d4 Reviewed-on: https://chromium-review.googlesource.com/1043865Reviewed-by:
-
vitaliii authored
This CL just disables a DCHECK for commit-only types. Please see the bug for explanation why this is safe to do. This is not the optimal solution and we should look into persisting ModelTypeState with initial_sync_done set to true and making commit-only types to diverge less from non commit-only ones. Bug: 837257 Change-Id: Ia917de973a43e28a7b6de2e2337f42199da5e44e Reviewed-on: https://chromium-review.googlesource.com/1042192 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8642bcc3248f..8672346ad7ce $ git log 8642bcc32..8672346ad --date=short --no-merges --format='%ad %ae %s' 2018-04-26 bpastene Add the chromeos/OWNERS file to the ChromeLKGM committer's checkout. 2018-04-25 philipchen cheza: Add release and paladin builder configs Created with: roll-dep src/third_party/chromite BUG=chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7c0cee4658c38f33dd2eb4ac1e0b972a2bbee97b Reviewed-on: https://chromium-review.googlesource.com/1043607Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556013}
-
Johnny(Jianning) Ding authored
Right now the InspectorPerformanceAgent returns incorrect performance metrics (such as LayoutDuration, ScriptDuration, etc.) if there is an time override in place. The InspectorPerformanceAgent needs to return real time elapsed. Per offline discussion with Pavel(pfeldman@), the reason we don't expose the non-override time API in the web platform (<blink>/platform/time.h) is that time override is to abstract the web platform from the time. The web platform should just deal with time and not know about whether the time is overridden. Exposing the non-override time API in the very core part of blink will leak the override aspect and hence compromising the whole design BUG: 830033 Change-Id: If3140892ac60bc853ef5f98f7b478a98ae332806 Reviewed-on: https://chromium-review.googlesource.com/988833Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johnny Ding <jnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#556012}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/068949a8..70f3bb06 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7a7192fe3054a51a1b4845de5ee7c13118185110 Reviewed-on: https://chromium-review.googlesource.com/1043685Reviewed-by:
-
Sean Kau authored
CupsPrinterManager now outlives CupsPrintersHandler so the observer needs to be removed when it is destructed. Bug: 839501 Change-Id: If4c7b38ad7e80be5032095c24456ca16bee1f005 Reviewed-on: https://chromium-review.googlesource.com/1043061Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#556010}
-
Marc Treib authored
This reverts commit 6c3cc295. Reason for revert: ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses fails on Mac Asan 64: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/40456 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F40456%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses%2F0 ../../chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc:171: Failure Expected: (0u) != (measurement->private_footprint_kb), actual: 0 vs 0 Original change's description: > RC: Add memory measurement to render process probe. > > Bug: 755840 > Change-Id: I96af63e817abe9bdefb0916da4d652e97c620a2c > Reviewed-on: https://chromium-review.googlesource.com/1037631 > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555844} TBR=chrisha@chromium.org,fdoray@chromium.org,erikchen@chromium.org,siggi@chromium.org Change-Id: If2e102252f43c0b62b6a539e0df7793ee05281bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755840 Reviewed-on: https://chromium-review.googlesource.com/1043805Reviewed-by:
-
Marc Treib authored
This reverts commit 1cf6caff. Reason for revert: KeyAccessibilityEnablerTest.TwoVolumeKeyDown fails on MSan: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/6993 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F6993%2F%2B%2Frecipes%2Fsteps%2Fash_unittests%2F0%2Flogs%2FKeyAccessibilityEnablerTest.TwoVolumeKeyDown%2F0 Original change's description: > Initial support for Spoken Feedback tablet toggle > > Bug: 839154 > Change-Id: Iebceacd23dde5275c72d4fb6afecedb3dab75396 > Reviewed-on: https://chromium-review.googlesource.com/1035207 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555874} TBR=derat@chromium.org,dtseng@chromium.org Change-Id: I26606c63bf4033b3d177093787a909b31f3d2a38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839154 Reviewed-on: https://chromium-review.googlesource.com/1043785Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: I5490d3410c674b065908698a3928bb09c9217df0 Reviewed-on: https://chromium-review.googlesource.com/1043688Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556007}
-
Tommy Steimel authored
This CL increases the padding on the modern media controls buttons and timeline in order to give larger tap targets. This CL also sets the z-index on the timeline in order to fix an issue where clicking above the timeline wouldn't properly scrub. TBR=mlamouri@chromium.org Bug: 839082, 827537, 817303 Change-Id: I87cb5867d6dde55dee4fc5caa252933163c50ddf Reviewed-on: https://chromium-review.googlesource.com/1043249Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556006}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7c2e6129e28ca9fef2527859ea923e0f298d524d Reviewed-on: https://chromium-review.googlesource.com/1043651 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556005}
-
Trent Apted authored
r545332 preserved the omnibox font size of 14 for default user OS configurations but inadvertently started applying scaling logic used for dialog text that the omnibox text field never used. It is 14pt. Always. Revert to the old behaviour. Importantly, the way the size delta was being captured would fail to shrink a font that was too large to fit, if that delta came from user settings rather than font metrics alone. Bug: 831340, 838065 Change-Id: I1d4a296fa717694bfe77c14d2590d10d0d9c6e9f Reviewed-on: https://chromium-review.googlesource.com/1041390 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#556004}
-
Steven Bennetts authored
ConsoleServiceProvider and DisplayPowerServiceProvider both now implement org.chromium.DisplayService so merge them and their delegate implementations and move them to src/ash since the implementaitons only have ash dependencies. The new implementation is owned by the recently introduced AshDBusServices class. BUG=798569 Change-Id: I54d3b332a68ba453613745ed8ead966efb925de9 Reviewed-on: https://chromium-review.googlesource.com/1041283 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#556003}
-
Adam Rice authored
Chrome checks that the timestamp on X11 events is reasonable and adjusts it if it is not. Currently this is only done when a debugger is not attached. The check for the debugger is expensive, so remove the check and always adjust the timestamps. BUG=837768 Change-Id: I3252374bccd27feb1bdc6088d17b1123d3c64aee Reviewed-on: https://chromium-review.googlesource.com/1039307Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556002}
-
https://chromium.googlesource.com/angle/angle.git/+log/d7b56642c9f7..41e59f55a4d2 $ git log d7b56642c..41e59f55a --date=short --no-merges --format='%ad %ae %s' 2018-05-02 brandon1.jones Autogenerate libGLESv2.cpp and .def Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iad3324c70b5a30f8832752248f63b56bd3f77e46 Reviewed-on: https://chromium-review.googlesource.com/1043645 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Michael Giuffrida authored
Remove the following tab metrics because they're too uniform to be useful in predictive models: * ContentType: Almost always CONTENT_TYPE_TEXT_HTML (corresponding to normal web pages, as opposed to e.g. application/pdf). * IsExtensionProtected: Almost never true. * DefaultProtocolHandler: Rarely populated. Bug: 784639 Change-Id: Ie40b268ab873d71305a59ae9b6356a8e105ceb31 Reviewed-on: https://chromium-review.googlesource.com/1036858Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556000}
-
Timothy Loh authored
This patch fixes LauncherControllerHelper::IsValidIDForCurrentUser to handle Crostini apps, so that the restore process can correctly add pinned Crostini apps. TEST=Manually verified both the Terminal and installed Crostini apps re-appear after reboot. Bug: 839141 Change-Id: I09a40a9f24779b19a2b1bae1c21f9a33e0ae1708 Reviewed-on: https://chromium-review.googlesource.com/1043665Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/2048c078d45e..4f42243e85c8 $ git log 2048c078d..4f42243e8 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 simonhatch Dashboard - Use new isolate target for linux-perf. Created with: roll-dep src/third_party/catapult BUG=chromium:836037 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I812ed7c6ee64248f9595c2590dd7682492042590 Reviewed-on: https://chromium-review.googlesource.com/1043605 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555998}
-
Darren Shen authored
This patch adds a new OnFocus event to the private keyboard API. This event has additional information about whether the focus was triggered by a pen stylus or other means. The plan is for IME extension to listen to this event and change its keyset/position/mode etc. depending on the focus reason. If the extension listens to the private OnFocus event, then the public version would not be triggered (and vice versa). This is to prevent OnFocus from being raised twice. Bug: 824604 Change-Id: I5dd523a183d517e166bbc73abd6a79a6557c6942 Reviewed-on: https://chromium-review.googlesource.com/1015446 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555997}
-
Patrik Höglund authored
This reverts commit a99efe4b. Reason for revert: Still flaky. Original change's description: > Revert "Disable flaky capture unittests on Linux." > > This reverts commit 46bf6346. > > Reason for revert: New webcam plugged in; let's see if they're still flaky. > > Original change's description: > > Disable flaky capture unittests on Linux. > > > > The tests went flaky when we replaced the bot and get VIDIOC_STREAMON > > errors about 25% of the builds. I have no idea to fix that; we tried > > replacing the webcam and moving it around in the USB ports and that > > didn't help. See http://crbug.com/828568 for discussion. > > > > Bug: chromium:831514 > > Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9 > > Reviewed-on: https://chromium-review.googlesource.com/1016301 > > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#552165} > > TBR=phoglund@chromium.org,chfremer@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:831514, chromium:828568 > Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745 > Reviewed-on: https://chromium-review.googlesource.com/1039425 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555342} TBR=phoglund@chromium.org,chfremer@chromium.org Change-Id: I9c976f8bb2e0812029d13ae020896bebadf4ef1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:831514, chromium:828568 Reviewed-on: https://chromium-review.googlesource.com/1041945 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#555996}
-
rbpotter authored
Bug: 838663 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6a8f0c84ebc5b53ed0c74061794d07287a420aa6 Reviewed-on: https://chromium-review.googlesource.com/1038574Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555995}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/60da1b2e..068949a8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I75a7ecfe7fb7f745e9f88856571a725101d2de2d Reviewed-on: https://chromium-review.googlesource.com/1043430Reviewed-by:
-
Fady Samuel authored
Resize throttling in Chromium is complicated. There are three "pending" bits: one for resize, one for paint, and one for auto-resize and the throttling system tries to decide whether to send an ACK from renderer => browser depending on whether the browser wants / expects an ACK. The browser tells the renderer whether it expects an ACK on SynchronizeVisualProperties. This all adds a lot of complexity, and isn't particularly compatible with moving LocalSurfaceId allocation and ACK'ing to the impl thread. SynchronizeVisualProperties will continue to go to the Blink main thread whereas the ACK will come from the compositor thread so it doesn't make sense to push ack bits from main to impl. This CL simplifies throttling to support impl-side ACK'ing and LocalSurfaceId allocation in the following way: The browser manages its throttling independently from the renderer by only issuing a SynchronizeVisualProperties if the previous one has ACK'ed (and it was expecting an ACK). The renderer's ACK decision in this CL is just based on receiving a SynchronizeVisualProperties...that implies that the next commit gets an ACK IPC. In a subsequent CL, ACKs will be based on change in LocalSurfaceId. The invariant maintained by surface sync is: Change in Visual Properties => Change in LocalSurfaceId => Commit => Draw Thus, post-commit, if the LocalSurfaceId changes then it's equivalent to ACK'ing a SynchronizeVisualProperties. Change-Id: Ib3eda5e28e91f34d00a06917911bfd2f778580f7 Bug: 672962 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1039768 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#555993}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f62de01d3a7..d8a189fca3cd $ git log 2f62de01d..d8a189fca --date=short --no-merges --format='%ad %ae %s' 2018-05-03 brianosman Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur" 2018-05-03 skcms-skia-autoroll Roll skia/third_party/skcms aee343c..cc1799c (1 commits) 2018-05-03 egdaniel Implement canCopySurface for GrMock and GrMtl. 2018-05-03 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ ce8eb945c..e76163e3c (1 commit) 2018-05-03 brianosman Disable unpack-row-length support on iOS 2018-05-03 reed remove support code for serialized bitmaps 2018-05-03 brianosman Remove colorspaceinfo 2018-05-03 liyuqian Remove legacy guard flags 2018-05-03 reed check index for valid before subtracting 2018-05-03 egdaniel Remove SK_SUPPORT_LEGACY_BACKEND_OBJECTS from public.bzl. 2018-05-03 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur 2018-05-03 reed allow div-by-zero 2018-05-03 egdaniel Implement GL canCopySurface in GrGLCaps. 2018-05-03 angle-skia-autoroll Roll third_party/externals/angle2/ e708f004b..03bb2231a (1 commit) 2018-05-03 csmartdalton Add support for building with MoltenVK 2018-05-03 reed saturate your adds 2018-04-30 liyuqian Change SkMatrix44::fTypeMask to atomic 2018-05-03 herb Add move to quiet warning 2018-05-02 liyuqian Add name field to calmbench json Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Id2ce28252d4ae405f8c6e270d949f713a6b6f795 Reviewed-on: https://chromium-review.googlesource.com/1043451Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555992}
-
Wenzhao Zang authored
1) The focused pod on views login should request wallpaper, the same with web-ui login. 2) Views-based login calls |ShowGaiaScreenIfReady| to pre-load Gaia, before Gaia page is actually open, which results in the bug. We should move the wallpaper-related code to |UpdateGaiaDialogVisibility| which controls the actual visibility of Gaia page on views-login. Bug: 836112 Change-Id: Ide91ba2e7379b23bae94b40be022bfaa7da3c360 Reviewed-on: https://chromium-review.googlesource.com/1043264Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#555991}
-
Xianzhu Wang authored
This will make the raster invalidation tracking result more understandable, by distinguishing appeared and disappeared chunks from appeared and disappeared display items. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id1ff9218201b7fbca0360c9d93656b8c966c08f7 Reviewed-on: https://chromium-review.googlesource.com/1041573 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555990}
-
rbpotter authored
Add listeners for the print-failed and print-preset-options Web UI events in the new UI, and migrate the behaviors of calling onPrintFailed_() for print-failed and setting the copies and duplex setting values based on the presets when they are received. Also migrate the tests used to verify that presets work. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6cb17b5a189c8d138647a82cf845a47b51d91bdf Reviewed-on: https://chromium-review.googlesource.com/1038660Reviewed-by:
-
Nasko Oskov authored
Chrome error pages currently commit in either the source or destination RenderFrameHost and are not isolated in any way. The "Committed Interstitials" project will change interstitials to work just like error pages. Since interstitial pages use renderer-initiated messaging to proceed through, the security model of them being rendered in a separate process needs to be preserved. This CL is implementing a process isolation model for error pages as described in the following design doc: https://docs.google.com/document/d/17IOOppwf8re2dpz4TflH_7wFkJr6Or-ltXGsTeMOhM0/edit Bug: 448486, 838161 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I58cdc8f823ffa10a7a7ee219e2ade3d69b538882 Reviewed-on: https://chromium-review.googlesource.com/762520 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555988}
-
