- 06 Oct, 2020 40 commits
-
-
Fergus Dall authored
TBR=collinbaker@chromium.org Bug: 1134534, 1134535 Change-Id: I94e11685ebbfbc31ec0f75296e2b12da28d16463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449658Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#814078}
-
Yuchen Liu authored
To avoid log spam, only show DVLOG(0, 1, 2) on debug build. Bug: internal b/170151760 Test: Build and run. DVLOG(3, 4, 5) disappear Change-Id: Ieeb415c60c952e251a551e02df467d2f7861910e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451304Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814077}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df9f8642fc27..da7feb74237d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sidereal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sidereal@google.com Change-Id: I8a25d8a1766147198f7231d04ae600f70e031d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814076}
-
Fergus Dall authored
TBR=joelhockey@chromium.org Bug: 1135410 Change-Id: I60f8130bbf2b4b7451e279ae2b344cfcd721d7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449838Reviewed-by:
-
Weilun Shi authored
Stop showing the interactive pretty print PRESUBMIT error message but still show the loading message when running the PRESUBMIT. Only show the result of the PRESUBMIT at the end of the check. Note that git cl presubmit still shows these interactive error messages. We just stop showing if the check is invoked by git cl upload. Change-Id: I4551af6f98cf80026941369137d372197d4e671f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444372 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#814074}
-
Jian Li authored
Bug: none Change-Id: Iecc0cb44e239c1b4502e81bc50931230732af61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429930 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#814073}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie505b39b7b2a5a3aef79f62c20047de495206b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814072}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3c9f8a5..ba1e9298 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0740d09f8c077383f0a66af482807f84b0728904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814071}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ia7bfc45b8e32d36e93ae97eca0ac8fb06ea6c5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451631Reviewed-by:
-
Kent Tamura authored
|non_content_height| is always zero because UA stylesheet for the inner editor doesn't have border/padding/margin, and web authors can't specify them. This CL has no behavior changes. Change-Id: I9093a8bb33076a67730231b75ce804daadb61a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449674 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#814069}
-
Matt Falkenhagen authored
To clarify that this param controls whether the optimization guide predictions are retrieved, but does not mean they are necessarily used to prefetch. We use this param for the counterfactual logging arm vs prefetching. Add a test for this as well. There is a subtle difference between the two options. |prefetch_always| only had an effect when kLoadingPredictorPrefetch was enabled, but |always_retrieve_predictions| can cause predictions to be retrieved even without prefetch enabled. One test is modified to account for this difference, as now more origins are preconnected to when the option is used. In other words, |prefetch_always| is equivalent to |always_retrieve_predictions| = true AND |kLoaderPredictorPrefetch| is enabled. Bug: 1092329 Change-Id: I575d6d40d62ebe3549bc4831479673a7aae9d9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439973Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#814068}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ic4374f32e11da55628b81d64e0ee34facbeb255d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451730Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814067}
-
Rakesh Soma authored
Bug: 1133565 Change-Id: I0a4e6a8c3310525aa02de4f6f6c726c75419e702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439676 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#814066}
-
Eric Willigers authored
The browser test helper methods in web_app_browsertest_util.cc that install PWAs (InstallWebApp, InstallWebAppFromManifest, PendingAppManagerInstall) now wait for on_registry_ready(). Bug: 1119807 Change-Id: I60c16e04b75603a8d0979fd09e9f6746335cd788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450133 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#814065}
-
Josiah K authored
Change-Id: I6fbd33d3b9dcab11079a9cff4df8d8cbaeda046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451629 Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#814064}
-
Kenichi Ishibashi authored
This CL: * Introduces an error code that indicates a mojo connection to the storage is disconnected. This won't happen yet but could happen in the future. It could happen due to a Storage Service crash after ServiceWorkerStorage is migrated into the Storage Service, and the Storage Service is hosted outside the browser process. * Updates GetStorageUsageForOrigin() to make sure that the callback of the method is always called. Currently it uses WrapCallbackWithDefaultInvokeIfNotRun() but we may use the different approach in the future. Other methods in ServiceWorkerRegistry also need to be updated. Subsequent CLs will do that. * Sets a mojo disconnection handler. Currently it just resets the remote. Subsequent CLs will implement crash recovery logic. See [1] for the overall plan. [1] https://docs.google.com/document/d/1RQgiuAZVbQZbYJeLOfmydBMwXTTfsL2RqZKx90yPT7U/edit?usp=sharing Bug: 1133143 Change-Id: I28cef47d66c6f95b33d7a4a8b152e7d38d32e49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437082 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814063}
-
Dirk Pranke authored
This CL rolls //third_party/catapult to 532e564f622742fc93a7f91dd3556d711e778a7e and picks up https://chromium-review.googlesource.com/c/catapult/+/2450450 which removes zipfile_2_7_13.py as a dependency. This CL also updates the corresponding Chromium .pydeps files that mentioned it. That change also added a dependency on `six`, which seems to be pervasively assumed in other parts of the catapult codebase as present in the environment; however, it isn't guaranteed to be there in the chromium compile-time python build, so this adds that as needed as well. TBR=bsheedy@chromium.org Bug: 1112471 Change-Id: I849355a5bdc18847dcbf39f3d3a9e9fbf428e3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449938 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814062}
-
Andrew Comminos authored
In the process of converting these tests to standard WPTs, fix them up to work inside of wpt_internal. Bug: 956688 Change-Id: I4685ca247091b1a64bd8da735fa42a34420e447a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444793 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814061}
-
Minoru Chikamune authored
This CL adds GetCurrentAgentGroupScheduler function to WebThreadScheduler so that it can be called from the content layer. Bug: 1105403, 1113102 Change-Id: I0c78867453bf942deb4dc98fd557ad4662d4a7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444619 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#814060}
-
Carlos IL authored
Previously forms on secure sites that submit to an insecure target, but that submitted on a new tab (with target=_blank) showed the on form warning but not the on-submit one. This CL fixes it. Pending work: Like other interstitials for navigations on new tabs, this will go back to the NTP if Go Back is selected, it might make more sense to close the new tab in this case, but in the interest of keeping the CL simple for merging, this will be done on a separate CL, which won't be merged. Bug: 1134466 Change-Id: I6169fef6bd368f9c8ca054d7bbd8f96e50490956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451549 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#814059}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601920728-6028d40b51a1c3ae51d439d61f82d0425613d326.profdata to chrome-linux-master-1601942192-5610f8208d2a00c81b789319176c3ce4858b86b7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I12ddf6af25c4546ffc300237b2da92a6217c09e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451672Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/765c9d3a9ca4..41d906752d13 2020-10-05 brianosman@google.com Allow use of SkTHash* in skslc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ie4ec77ae5b8c6f29ce2abb5d096065c194984fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450970Reviewed-by:
-
David Tseng authored
This change precisely stipulates the events handled for each type of editable encountered through tests. R=akihiroota@chromium.org pressing 'e' would also cause sticky mode to turn off. Fixed: 1135118 AX-Relnotes: fixes an issue in Smart Sticky mode where jumping to a text field by Change-Id: I56de4cebc0a1a942d99c5d0c9445b5b33f9d4e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448053Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#814056}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2266710dd28b..df9f8642fc27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sidereal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1135321 Tbr: sidereal@google.com Change-Id: I86814fdf508b39e690c117eed6dbf92243b3b000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451368Reviewed-by:
-
Fergus Dall authored
Bug: 1135405 Change-Id: I606b976fbbce6168fcdf8c6b0bf9b518f5f887ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449872Reviewed-by:
-
Oriol Brufau authored
This is a reland of d46bdb4f It was reverted because the new test could time out in Mac. Fixed by adding '<meta name="timeout" content="long">'. Original change's description: > [Editing] Fix canonical caret position at line break > > Consider this testcase: > <style>div { width: min-content; padding: 5px; }</style> > <div contenteditable>line1<wbr>line2</div> > which is rendered as > line1 > line2 > > Before this patch, when clicking at the beginning of the 2nd line, the > caret would appear at the end of the 1st one, because CanonicalPosition > would search backwards even with a downstream affinity. > > Also, when clicking at the beginning of the 1st line and pressing the > down arrow key, the caret would move to the end of the 1st line instead > of to the beginning of the 2nd one. And pressing the key again would > have no effect, the caret would refuse to go down. > > This patch fixes these problems by making CanonicalPosition take a > TextAffinity parameter which affects whether the canonical position is > first searched backwards or forwards. If no suitable candidate is found, > it will still search in the other direction. > > And then, VisiblePosition::Create takes care of deciding between the > upstream and the downstream canonical positions, depending on the > affinity and whether there is a line break. > > Bug: 1002937 > > Web tests: > TEST=external/wpt/editing/run/caret-navigation-around-line-break.html > > Unit tests: > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/0 > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/1 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/0 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/1 > TEST=VisiblePositionTest.ShadowV0DistributedNodes > TEST=VisibleUnitsLineTest.endOfLine > TEST=VisibleUnitsLineTest.isEndOfLine > TEST=VisibleUnitsLineTest.isLogicalEndOfLine > TEST=VisibleUnitsLineTest.isStartOfLine > TEST=VisibleUnitsLineTest.logicalEndOfLine > TEST=VisibleUnitsLineTest.logicalStartOfLine > TEST=VisibleUnitsLineTest.startOfLine > TEST=VisibleUnitsTest.canonicalPositionOfWithHTMLHtmlElement > TEST=VisibleUnitsTest.canonicalPositionOfWithInputElement > TEST=VisibleUnitsTest.canonicalizationWithCollapsedSpaceAndIsolatedCombiningCharacter > > Change-Id: I82d86d40a87513b2e92c024735957e9f71154094 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410404 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813744} Bug: 1002937 Change-Id: Ida01b6d838f03cfbe66e4cba86472ed90499af45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450292Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#814053}
-
Fergal Daly authored
PROBLEM: It is not possible to retrieve traces from swarming with --gtest_repeat. For a file to be retrievable from swarming, it must be placed in ${ISOLATED_OUTDIR} but specifying anything for --enable-tracing-output disables the unique-filename-per-test behaviour. With this change it becomes possible to do e.g. tools/mb/mb.py run ... \ --gtest_filter=WebNavigationApiTest.Crash \ --gtest_repeat=100 --enable-tracing=*,disabled-by-default-toplevel.flow \ --enable-tracing-output='${ISOLATED_OUTDIR}/' and have unique files for each test that are retrievable with swarming collect. Also drive-by fix typo in name of function. BUG=1043616 Change-Id: Idd1bcbbdb6f18d297170f074e9409c61204fcacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445649 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I19377bc5bd3566acd35b6db6ff47cb23315f609c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451609Reviewed-by:
-
Matt Reynolds authored
HidConnectionImpl is self-owned and will self-destruct on disconnection of the HidConnection or HidConnectionWatcher. This CL modifies the FakeHidConnection used in tests so it behaves the same way. This is a reland of crrev.com/c/2441151 that applies the same change to HidServiceTest.OpenAndNavigateCrossOrigin. BUG=1126689 Change-Id: I9761d08b7d44dbe850d56708623878baac028a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446537 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#814050}
-
Maggie Chen authored
|occluding_damage_rect| has been removed from shared quad state. Now remove it from render_pass_data\top_real_world_desktop\*\*.json Bug: 1117235 Change-Id: I2948f638cee1e651ebb990634d7c85097b1fb837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446544Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814049}
-
Josh Nohle authored
Ensure that any error codes emitted from the feature status getter are reflected in the high-level v2 DeviceSync result metrics. Before this CL, all feature status getter errors were bucketed into the error code kErrorMissingLocalDeviceFeatureStatuses. This caused some confusion in b/169842107. Change-Id: Ifd9373d5f4ad54e6e5b38f09fe1aaa329c1e5eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451592 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#814048}
-
Chong Gu authored
Create --internal-images flag. When used, the update_sdk script will download astro images to //third_party/fuchsia-internal-images. Include internal images in test target if target_cpu is arm64 and x64 host tools are needed. Bug: 1134108 Change-Id: If323130add41543e7a7a7f50acbfea80c8ed790b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446832 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#814047}
-
Jamie Madill authored
Re-land with these tests disabled on Lacros. Uses the new 'use_isolated_scripts_api' feature added here: https://crrev.com/c/2425210 to switch the tests to the ANGLE standalone testing harness. Bug: angleproject:5124 Change-Id: I456aaeeb961f56f6b6e171ea13fb11c566704317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446997Reviewed-by:
-
Devlin Cronin authored
Bug: 1133360, 893373 Change-Id: I941260885f851faeb6f8978850e3361568d8585a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439644Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814045}
-
Zufeng Wang authored
There's an issue of AppServiceAppResult::OnVisibilityChanged not being called for suggestion chips, which meant the Decrease function never ran. As a result, the release notes suggestion chip never disappeared. As a temporary workaround, move the Decrease function into AppServiceAppResult::HandleSuggestionChip. This gets called a bit more often (including when the session starts and when the launcher input is focused). Increase kTimesToShowSuggestionChip to compensate for this. Bug: b/169711884 Change-Id: I1f1827f5c8d4d5a37268074a4af4d2e4840c326b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442809 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814044}
-
John Lee authored
The default contextmenu event is prevented because touch drag and drop on Windows does not interact well with the contextmenu events. Since on Windows, a mouse can be attached to a tablet and have the UI still be in tablet mode, a pointerup event is added to determine if a user actually right-clicks on a tab to invoke the context menu. Bug: 1134282 Change-Id: I92dca4d194905437b6396f42a7be1b6a272ea9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447091Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814043}
-
James Vecore authored
This plumbs through the allowed mediums for the discovery process which was previously not available. Fixed: 1135391 Change-Id: I95c8dbf70a6b120f7e6e0769a8535d99eec7800c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451301 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#814042}
-
Bartek Nowierski authored
It doesn't depend on //base, which is needed for CheckedPtr Bug: 1069567 Change-Id: I4eb2d7e46b2a018f7de08d69aef32e0e3d23aa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440075 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7de00dff..f3c9f8a5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7929d226b2e926a102ba90ae74bc1142dea9047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449939Reviewed-by:
-
Andrew Xu authored
MenuController::HandleMouseLocation() called in MenuController::OnMouseMoved() calls MenuController::SetSelection() which may reset the hot-tracked view. Meanwhile, in OnMouseMoved(), the hot-tracked view updates before HandleMouseLocation(). As a result, the hot-tracked view may fail to update after the mouse move event. This bug should have existed for long time. But it is not noticeable on real devices: when a user moves the mouse, it usually creates more than one mouse move events. Then the second mouse move event updates the hot-tracked view. This CL updates the hot-tracked view after HandleMouseLocation(). Bug: 1135000 Change-Id: Iae810563e897d75912bcc140ed56022d72e3170c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448650Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814039}
-
