GitLab

Looks like this was added pre-swarming. It's unused, and undocumented,
so just remove it.

Review-Url: https://codereview.chromium.org/2842623002
Cr-Commit-Position: refs/heads/master@{#466840}

* Adds a check to prevent showing branding if First Run hasn't completed.

* Updates the widget so that it is updated when an AsyncInitializationActivity
  subclass calls onDeferredStartup().

* Changes the resource for the microphone to match the omnibox's, as well as
  uses its content description.

* Adds tests to confirm that the search engine is updated once First Run
  completes.

BUG=708844,710952

Review-Url: https://codereview.chromium.org/2834253002
Cr-Commit-Position: refs/heads/master@{#466839}

Also, once a Wi-Fi network is removed (e.g. due to explicit config
removal), remove its associated Tether network.

BUG=672263

Review-Url: https://codereview.chromium.org/2821103003
Cr-Commit-Position: refs/heads/master@{#466838}

There are 4 types of renderers that are used by WMPI directly, with a
potential fifth type in the works. Currently, a single RendererFactory
is chosen at WMPI creation time, and bound for the lifetime of WMPI.
However, there is a growing need to allow the smooth transition between
the use of different renderer types, after WMPI’s creation.

This CL introduces the RendererFactorySelector, which will allow us to
choose between different RendererFactory types at runtime. Its purpose
is to aggregate the signals and centralize the logic necessary to choose
which RendererFactory should be used when creating a new Renderer.

The interface is still extremelly simple, but it is expected to grow
as the number of concurrent RendererFactory types grows. In other words,
if there are 3+ renderer factories at play, some complexity is
inevitable, and the right place for that complexity to live is in the
RendererFactorySelector.

NOTE: The RendererFactorySelector uses a FactoryType enum as a key, in
order to avoid having to take dependencies on different (sometimes
platform specific) RendererFactories.

BUG=663503

Review-Url: https://codereview.chromium.org/2711153006
Cr-Commit-Position: refs/heads/master@{#466837}

Despite the fact that the kernel implements physical footprint calculations on
macOS 10.11, the syscall task_info(TASK_VM_INFO, ...) always returns 0. For more
details [10.11.5], see xnu-3248.50.21/osfmk/kern/task.c:3418.

BUG=713854

Review-Url: https://codereview.chromium.org/2838703003
Cr-Commit-Position: refs/heads/master@{#466836}

This will re-enable display of warnings that a test was expected to
fail, but passed.

BUG=710065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2832383002
Cr-Commit-Position: refs/heads/master@{#466835}

BUG=714825
TBR=pdr@chromium.org

Review-Url: https://codereview.chromium.org/2838623003
Cr-Commit-Position: refs/heads/master@{#466834}

This CL removes BatteryMonitorImpl content browser test, its renderer
side test is covered by existing battery layout tests, and its browser
side test is covered by the service test newly created in this CL.

Thus we can eliminate the direct dependency on battery from content
layer, then we can hide all battery monitor impl inside Device Service
with a follow-up CL.

BUG=684422
TEST=service_unittest
TBR=timvolodine@chromium.org

Review-Url: https://codereview.chromium.org/2819163002
Cr-Commit-Position: refs/heads/master@{#466833}

Origional CL (2499493004) was rolled back by sheriff due to failing MSAN tests.
This initial patchset is a direct patch of 2499493004. Second patchset contains the fix.

-Communicate which hosts are runtime blocked to all renderers
-Blocks host permissions for specific hosts by specific extensions
-Tests via blocking content script injection
-Introduces new test class for use with ExtensionSettings policy

BUG=624649

Review-Url: https://codereview.chromium.org/2833843004
Cr-Commit-Position: refs/heads/master@{#466832}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=vandebo@chromium.org

Review-Url: https://codereview.chromium.org/2675773004
Cr-Commit-Position: refs/heads/master@{#466831}

Accessing a unique_ptr in the same call expression that moves it is
generally not safe, since different compilers evaluate have different
orders of evaluation.

BUG=714609
TBR=raymes@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2842493003
Cr-Commit-Position: refs/heads/master@{#466830}

BUG=710265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826303002
Cr-Commit-Position: refs/heads/master@{#466829}

As part of #466704, I changed some logic in mb.py to sort the inputs
that MB hands to GN, in an attempt to make the debugging output a
little easier to follow. It turns out that the way I did this was
broken, as there was a dependency on the ordering of the unsorted
values.

As a result, MB started remapping GN's analyze results back to the
wrong targets, and we've been running the wrong test steps since #466704
landed :(.

TBR=kbr@chromium.org, jam@chromium.org
BUG=714336
NOTRY=true

Review-Url: https://codereview.chromium.org/2843663002
Cr-Commit-Position: refs/heads/master@{#466828}

BUG=711424

Review-Url: https://codereview.chromium.org/2819563003
Cr-Commit-Position: refs/heads/master@{#466827}

This turns InspectorOverlay into InspectorOverlayAgent with respective
lifetime and domain:
- rendering domain merges into overlay;
- Page.configureOverlay moves to overlay;
- highlighting and inspect mode move from DOM to overlay.

BUG=none
TBR=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#465422}
Committed: https://chromium.googlesource.com/chromium/src/+/8982f602a8e1f521949d8dd8dae58cff1c787bec
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Original-Commit-Position: refs/heads/master@{#465812}
Committed: https://chromium.googlesource.com/chromium/src/+/7afbb9a64fbd30254a2dab9a689648621fa29f14
Review-Url: https://codereview.chromium.org/2819183002
Cr-Original-Commit-Position: refs/heads/master@{#466489}
Committed: https://chromium.googlesource.com/chromium/src/+/c8abe8c3b07d77195777e07180a4122f4d50246a
Review-Url: https://codereview.chromium.org/2819183002
Cr-Commit-Position: refs/heads/master@{#466826}

This CL removes CSS for .tertiary-button which is no longer used.

(Code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2837883005
Cr-Commit-Position: refs/heads/master@{#466825}

This is a trivial change to move IMMNotificationClient implementation out of
AudioCapturerWin. Now the new DefaultAudioDeviceChangeDetector can unregister
itself from IMMDeviceEnumerator in destructor.

BUG=669070

Review-Url: https://codereview.chromium.org/2809293006
Cr-Commit-Position: refs/heads/master@{#466824}

Adds two more dialogs, one for new and one for existing devices
and changes the flow to return a SHOW value declaring which dialog
to show. Also adds features for these two new dialogs to variations.

BUG=712833, 712836

Review-Url: https://codereview.chromium.org/2836833002
Cr-Commit-Position: refs/heads/master@{#466823}

This work is to help with the creation of loading.desktop benchmarks.

BUG=713346

Review-Url: https://codereview.chromium.org/2835903004
Cr-Commit-Position: refs/heads/master@{#466822}

The patch puts the screenshots on the frame bar and makes it expandable.

BUG=705054

Review-Url: https://codereview.chromium.org/2830343004
Cr-Commit-Position: refs/heads/master@{#466821}

Due to the fact that legacy layout doesn't have a notion of MarginStrut
we can't calculate margins correctly for use cases that need to use both
layout engines.

This patch collapses margins and update the parent BFC if the next child
cannot be layed out using LayoutNG(ex. tables).

BUG=635619
TESTS=bunch of fixed tests in CSS2.1 and fast/block test suites

Review-Url: https://codereview.chromium.org/2835233004
Cr-Commit-Position: refs/heads/master@{#466820}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=sgurun@chromium.org

Review-Url: https://codereview.chromium.org/2841693002
Cr-Commit-Position: refs/heads/master@{#466819}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=dmurph@chromium.org

Review-Url: https://codereview.chromium.org/2836813005
Cr-Commit-Position: refs/heads/master@{#466818}

Changes in this CL:

1. Added an about:flag for the "MD Incognito NTP". (Note that the primary
purpose of this change is to improve the text on the Incognito NTP, not
just to materialize it; but the latter results in a shorter flag name and
thematically fits with the other recent MD improvements).

2. Since almost none of the old CSS is valid for the new MD, and since
there are also related HTML changes, we use separate HTML and CSS files.
NTPResourceCache decides which one to serve according to the flag. Once
this fully launches, we will simply remove the previous implementation.

3. The new design follows the CSS rules described in
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeKud1YOmPiI.
The requirement that the two sets of bulletpoints determine the width of
the content box has been achieved by JS (the CSS is complicated enough as
it is :-( ).

Tested with the bookmark bar on/off, with a custom theme on/off, and in
front of a UX designer :)

BUG=693525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2804823002
Cr-Commit-Position: refs/heads/master@{#466817}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2835793002
Cr-Commit-Position: refs/heads/master@{#466816}

Code such as the USB device enumeration logic will close the device
immediately in response to a transfer error. This would cause
reentrancy into the CancelTransfer function, leading to a crash. This
patch updates UsbDeviceHandleUsbfs::Close and CancelTransfer to be
reentrancy safe and adds a test case that reproduces the crash without
this change applied.

BUG=714770

Review-Url: https://codereview.chromium.org/2843613002
Cr-Commit-Position: refs/heads/master@{#466815}

- Skip manipulating active window state to exit full screen
  http://crbug.com/714677 tracks work for mash;
- Update LockWindow creation code to run on mash;
- Add a SessionController::NotifyChromeLockAnimationsComplete
  to replace the direct ash::Shell PowerEventObserver call;

BUG=678988

Review-Url: https://codereview.chromium.org/2836163002
Cr-Commit-Position: refs/heads/master@{#466814}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ab1af916..72d17915

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2835163003
Cr-Commit-Position: refs/heads/master@{#466813}

Log absolute foreground duration for page loads before and after paint in from gws observer and core observer.

BUG=710683

Review-Url: https://codereview.chromium.org/2829363002
Cr-Commit-Position: refs/heads/master@{#466812}

Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ )

Reason for revert:
This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29

First seen here:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590

Original issue's description:
> SafeBrowsing: change interstitial sizes
>
> This CL changes the CSS max-height, max-width, etc. dimensions for
> determining when to use mobile vs. desktop interstitial layouts. In
> particular, it targets:
>
>  * wide and short views -> mobile landscape
>  * skinny and tall views -> mobile portrait
>  * wide and medium-height -> mobile landscape (w/ details on the same page)
>
> The phablet layout has been removed because it seems to actually be better
> to just use the mobile layout instead.
>
> This also allows the mobile layout to remain centered even for very wide
> views (parts of it were left-justified before), and reduces the
> top-margin for the icon in the mobile layout, since we were leaving a
> huge gap.
>
> BUG=707481
>
> Review-Url: https://codereview.chromium.org/2788323002
> Cr-Commit-Position: refs/heads/master@{#466746}
> Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51

TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=707481

Review-Url: https://codereview.chromium.org/2842633002
Cr-Commit-Position: refs/heads/master@{#466811}

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements

BUG=713429

Review-Url: https://codereview.chromium.org/2827243002
Cr-Commit-Position: refs/heads/master@{#466810}

BUG=714217

Review-Url: https://codereview.chromium.org/2836173002
Cr-Commit-Position: refs/heads/master@{#466809}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=sgurun@chromium.org

Review-Url: https://codereview.chromium.org/2835233003
Cr-Commit-Position: refs/heads/master@{#466808}

This CL adds native diffing to diagnose_apk_bloat.py via
tools/binary_size/supersize.

The summary section just shows the changes in section sizes and the
details section gives the output of diffing two SizeInfo objects.

BUG=695182

Review-Url: https://codereview.chromium.org/2837953002
Cr-Commit-Position: refs/heads/master@{#466807}

Migrate GpuChildThread to use ConnectionFilter instead of the ChildThread's InterfaceRegistry to expose interfaces on incoming connections.

R=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2819903004
Cr-Commit-Position: refs/heads/master@{#466806}

BUG=710977

Review-Url: https://codereview.chromium.org/2843533002
Cr-Commit-Position: refs/heads/master@{#466805}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5671bb03d416..f0a16108160d

$ git log 5671bb03d..f0a161081 --date=short --no-merges --format='%ad %ae %s'
2017-04-24 rnephew [Telemetry] make uploading page results not rely on story having a url.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib9e1e94bac262942838dc289dfa2dc3f763d7e25
Reviewed-on: https://chromium-review.googlesource.com/486181
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#466804}

No functional changes.

BUG=714661
TEST=

Review-Url: https://codereview.chromium.org/2840553003
Cr-Commit-Position: refs/heads/master@{#466803}

Manually converted to use new Audit.

BUG=704967
TEST=constructor/constantsource.html

Review-Url: https://codereview.chromium.org/2828393002
Cr-Commit-Position: refs/heads/master@{#466802}

https://skia.googlesource.com/skia.git/+log/42a2a20b9114..bb05f70b4be2

$ git log 42a2a20b9..bb05f70b4 --date=short --no-merges --format='%ad %ae %s'
2017-04-24 borenet [recipes] Fix *_VERSION step failure handling
2017-04-24 brianosman Simplify SkImageCacherator slightly

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I5beae27b6aec04915b2bcd97c75d07ec52dcb225
Reviewed-on: https://chromium-review.googlesource.com/486160Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#466801}