- 19 Oct, 2018 40 commits
-
-
Evan Stade authored
Bug: 854704 Change-Id: Ic04c377547f74c4866b46fd91f7f3fc0b075fdd4 Reviewed-on: https://chromium-review.googlesource.com/c/1290139Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#601330}
-
Akira Baruah authored
Includes com.google.android.things.permission.READ_FACTORY_DATA in the AndroidManifest.xml template. This permission is required by the GetFactoryLocaleList() implementation in Cast on Android Things. Bug: b/115985851 Test: Ensure no system errors involving READ_FACTORY_DATA Change-Id: Ia4a281cee86f167911db13aa17156b59c346b086 Merge-With: eureka-internal/205878 Reviewed-on: https://chromium-review.googlesource.com/c/1259612 Commit-Queue: Akira Baruah <akirabaruah@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601329}
-
Daniel Bratell authored
The file payments/android/ssl_validity_checker_android.h was removed when the JNI registration code changed but it remained in the sources list, where it ended up causing some unrelated problems so here it goes. Bug: 683256 Change-Id: I7e57af91ad5848c73d814fc4b89712d106ecf358 Reviewed-on: https://chromium-review.googlesource.com/c/1290271Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601328}
-
chrome://accessibilityJames Wallace-Lee authored
Set the 'aria-expanded' attribute on 'Show accessibility tree' buttons. Bug: 843313 Change-Id: I3efd9acdfb03075c38055c5e4035be087be09b60 Reviewed-on: https://chromium-review.googlesource.com/c/1265898 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601327}
-
Dana Fried authored
Bug: 889642 Change-Id: I805a78630edc9f0c214e5bd02567439b7406f13d Reviewed-on: https://chromium-review.googlesource.com/c/1287030 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#601326}
-
James Wallace-Lee authored
We had some issues handling mouse move events as UI events, so fire an AutomationEvent instead. Makes mouse_handler.js a BaseAutomationHandler. As a follow-up, let's experiment with rate-limiting these events, since they seem to come in more frequently than the dom events did. Bug: 853581 Change-Id: I0606421e5284fcb9803c6428d51b7288393babd9 Reviewed-on: https://chromium-review.googlesource.com/c/1287098 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Define and use mixins for the most common GPU bot configurations. To avoid errors and differences between machines, in most of these mixins, parameters like the OS have been flattened in. Use these mixins on the chromium.gpu, chromium.gpu.fyi, and client.v8.fyi waterfalls. This CL is essentially a no-op; it only modifies a few timeouts due to unification under the mixin "limited_capacity_bot". Bug: 895815 Change-Id: Ia9da945d73720ea70ebb4983808eb23463ee1108 Reviewed-on: https://chromium-review.googlesource.com/c/1287431Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601324}
-
Scott Graham authored
Change-Id: I11242ba10234cab1afc37384cdf025aab5da801d Reviewed-on: https://chromium-review.googlesource.com/c/1292002 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601323}
-
Saman Sami authored
Only Mac needs to know about surface activations, so avoid sending OnFirstSurfaceActivation on other platforms. Bug: 893731 Change-Id: Id5de1043d0c432964c1897af50440bf02277506f Reviewed-on: https://chromium-review.googlesource.com/c/1286354 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601322}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1cb20deb746a..cb21ffe8996b git log 1cb20deb746a..cb21ffe8996b --date=short --no-merges --format='%ad %ae %s' 2018-10-19 eladalon@webrtc.org Add blob-encoding support for RTC event logs 2018-10-19 mbonadei@webrtc.org Reland "Prefix flag macros with WEBRTC_." 2018-10-19 mbonadei@webrtc.org Revert "Prefix flag macros with WEBRTC_." Created with: gclient setdep -r src/third_party/webrtc@cb21ffe8996b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If3b9412c6f56df2e93b8515bed51a7784713cd1f Reviewed-on: https://chromium-review.googlesource.com/c/1292390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601321}
-
Akira Baruah authored
Bug: b/79936337 Bug: b/111880157 Test: Install APK on device and verify via logcat Change-Id: I51a0a34540de6e21f4a8dc5abb4e75d58f8fe4cf Merge-With: eureka-internal/205878 Reviewed-on: https://chromium-review.googlesource.com/c/1259611 Commit-Queue: Akira Baruah <akirabaruah@chromium.org> Reviewed-by:
-
Khushal authored
Since queries for measuring GPU side raster duration is too expensive, rate limit the tiles for which we measure this metric to 1%. R=piman@chromium.org Bug: 894200,896821 Change-Id: I0713e537447a8ca7ebec30747314810e1a881d6e Reviewed-on: https://chromium-review.googlesource.com/c/1292110Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#601319}
-
Will Harris authored
This reverts commit 58443848 (just the policy setting on browser process). Reason for revert: breaks some third party CAPI providers. BUG=880835 Original change's description: > Strengthen MITIGATION_DLL_SEARCH_ORDER on non-component builds. > > Also, add this mitigation to the browser process. > > BUG=870463 > > Change-Id: I1e749a4ede0b41cca69f60262fd878c57ed35564 > Reviewed-on: https://chromium-review.googlesource.com/1162581 > Reviewed-by: Penny MacNeil <pennymac@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581067} TBR=pennymac@chromium.org,wfh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870463 Change-Id: I2ae97b0955cc5d1196ab002e02285da05b3a4d35 Reviewed-on: https://chromium-review.googlesource.com/c/1292370Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601318}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8edf3557ca17..6e85d1a6fc75 git log 8edf3557ca17..6e85d1a6fc75 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 33432579+alan-baker@users.noreply.github.com Fix restrictions in if conversion (#1998) 2018-10-19 jbolz@nvidia.com Use per-configuration location for pch file (#1989) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@6e85d1a6fc75 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2c2c3ebc7ce12fc1b36f1f8fa784c1b98e6d8aab Reviewed-on: https://chromium-review.googlesource.com/c/1292391Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0537b6aba1bd..3bcd7ab930ad git log 0537b6aba1bd..3bcd7ab930ad --date=short --no-merges --format='%ad %ae %s' 2018-10-19 treehugger-gerrit@google.com Merge "Add trace_to_text support for memory events" Created with: gclient setdep -r src/third_party/perfetto@3bcd7ab930ad The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id6db3d39d63beec34cdfb217150e8e98c75ec627 Reviewed-on: https://chromium-review.googlesource.com/c/1292279Reviewed-by:
-
Ted Meyer authored
Plumb the media::DecryptConfig from the CodecPicture to the D3D11 buffer descriptor, and made a small refactor of some of the macros to support error in the case where a decrypt context couldn't be acquired. Bug: 881922 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9ac2cd889bb59e478260e81b3b42ee3d9ff6b177 Reviewed-on: https://chromium-review.googlesource.com/c/1275289 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#601315}
-
gogerald authored
'node id' is volatile which subject to change without notice. This change enables concurrently checking element exists, getting field value and so on Bug: 806868 Change-Id: I90a4254c170e260c93caa201b7fa3b411508c152 Reviewed-on: https://chromium-review.googlesource.com/c/1292430Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#601314}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a4f1ca269765..4ec1257ee988 git log a4f1ca269765..4ec1257ee988 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 derat@chromium.org chromeos_config: Reenable Tast on VM paladin builders. 2018-10-19 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@4ec1257ee988 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I19b71845d56e90e0f1ce9554bd50258d081c5c61 Reviewed-on: https://chromium-review.googlesource.com/c/1292277Reviewed-by:
-
Xiyuan Xia authored
HitTestQuery uses GetTransformToTarget when Window Service is in use because there is a ClientRoot frame sink id in hit test data that the browser process does not know thus could not put it in |target_ancestors| to go the optimized transform code path. Use GetTransformToTarget to correctly transform location with Window Service. Also remove the ClientRoot frame sink id from the hit test data used in a bunch of OOPIF tests that use a direct index into hit test data. Bug: 884360, 895029 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I0943e7719e7fb418eaa2304765376b31065eea07 Reviewed-on: https://chromium-review.googlesource.com/c/1281167Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601312}
-
Nate Fischer authored
We're in the process of moving from the deprecated connection-based GMS SafetyNet APIs to the connectionless APIs. Unfortunately, these APIs behave quite differently, so I'm creating a Feature to make the transition cautiously. Feature-checking logic is plumbed through AwFeatureList to Java so it can be checked downstream (unfortunately, there's no base/ layer API to check features by name). AwFeatureList is based on ContentFeatureList and ChromeFeatureList (and we may be able to share some logic in base layer). As this Feature is off-by-default, there is no change to behavior. Also, see the downstream CL (http://crrev/i/694949). Bug: 748687 Bug: 892834 Test: N/A Change-Id: I5d6642d7bc236836f4ab2a4dbf8888f88b18e479 Reviewed-on: https://chromium-review.googlesource.com/c/1272595 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601311}
-
Sébastien Séguin-Gagnon authored
Has been enabled since M67. Bug: 851294 Change-Id: I7f23c01e01391175bfafad2a9aa50f329812b668 Reviewed-on: https://chromium-review.googlesource.com/c/1285355 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#601310}
-
Wez authored
We switched to staging packages into /tmp instead of data, because some devices have surprisingly slow physical storage. However, since /tmp is a RAM filesystem it can be too small for some packages(!), in particular Debug and/or component builds. We revert to staging into /data by default, but --target-staging-path can now be used to override the path to stage packages into. Change-Id: I25adb9563df0236961f9e79e8b01d9536146ba8d Reviewed-on: https://chromium-review.googlesource.com/c/1291841Reviewed-by:
-
Azeem Arshad authored
This CL fixes issue with settings page crashing in guest profiles. Bug: 896870 Change-Id: I39f4df84843e723b25300fefb8936c7839c3bd8d Reviewed-on: https://chromium-review.googlesource.com/c/1289952Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#601308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/245ff8c6a020..f04272b969b8 Created with: gclient setdep -r src-internal@f04272b969b8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I427c75f28fb807fb203efb55b4d20d4afb9cf0f9 Reviewed-on: https://chromium-review.googlesource.com/c/1292276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601307}
-
Jacob Dufault authored
This repros by - Open login or lock screen, enter tablet mode - Type password using VK - Dismiss VK - Hit the submit button on the password field You can also submit by hitting 'enter' on the VK Bug: 892270 Change-Id: I39b40c6710a3ddca22cd110255f05014a9134798 Reviewed-on: https://chromium-review.googlesource.com/c/1287177Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#601306}
-
Dominick Ng authored
This CL implements a method on the ARC IntentHelperHost to allow ARC to request that a URL be opened as a web app in Chrome. If that URL does not have a corresponding installed web app, the method falls back to simply opening the URL in a tab. An additional extension app launch source is added for the new launch pathway. BUG=893927 Change-Id: Ifbcc48f7cab65373dc6353d422580d6e9cc43796 Reviewed-on: https://chromium-review.googlesource.com/c/1282546Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#601305}
-
Nate Fischer authored
This swaps the deprecated 'arraysize' macro for base::size(), in the //android_webview/ folder. No change to logic. R=boliu@chromium.org Bug: 837308 Test: N/A Change-Id: Ia6960f242f78f117eeb831e451f27596583b0cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1292514Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601304}
-
Mostyn Bramley-Moore authored
CL 1278961 introduced a second blink::kMaxThreadCount which breaks jumbo builds. Let's rename it to kMaxTaskWorkletThreads. Bug: 879306 Change-Id: I5e27227c9ffd01d862ca0ace66029bc932ccd2b9 Reviewed-on: https://chromium-review.googlesource.com/c/1292471 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#601303}
-
Becca Hughes authored
PiP was having issues with hiding the controls because we have a timer that will hide the controls. This timer gets reset every time we interact with it. In one case we actually stop the timer so it does not hide the controls anymore. BUG=897246 Change-Id: I4965b5c6cae0047ee0260131a16c9b346003bcec Reviewed-on: https://chromium-review.googlesource.com/c/1292518Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601302}
-
Vladimir Levin authored
This patch re-enables isolation nodes for layout views (iframes). It seems that this causes a memory regression on one of the telemetry tests, but it seems that it might be a timing issue. The evidence for this is that the regression happens in free memory (evictable) and the tile sizes seem to be same or similar with or without the flag. For more details, see the referenced bug. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Bug: 896328 Change-Id: I9c399f253f246364b68980350cec3d14e5690b75 Reviewed-on: https://chromium-review.googlesource.com/c/1292511Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601301}
-
Scott Graham authored
21edfd3c3a20 [fuchsia] Move non-tests out of tests in the crashpad_tests package ce122b644ce2 [util/net] add error message to scheme check 83e37a9ac145 [fuchsia] add commands for testing on Fuchsia 78d081ee4e91 linux: save and restore old signal actions 1b4fdd0fd079 fuchsia: Re-enable HTTPS transport, but disable tests 9554a89ab60a fuchsia: Use zx_task_resume_from_exception() instead of zx_task_resume() 9b2a119dc6d8 elf: don't warn on trailing unread bytes in the elf dynamic array 0fb654142873 [fuchsia][linux] optionally return local report ID on exception handling 1c09361c2cde fuchsia: Let util build in Mac-host builds 237c5ebdf3a9 fuchsia: Fix include_dirs for host Mac build 7682f0f6ebbd Add ThreadSnapshotMinidump 46b329b3690d list headers' includes as public dependencies b6103e157c5e Add SystemSnapshotMinidump 8d17d5b4cf33 Decode Thread Context in minidump 3b68e1278952 Update bot link for new LUCI console c7f1543dd388 Don't auto-generate gyp build files any more 289be79a33f2 Roll mini_chromium to 3577ffd 196897eb0804 Remove win buildbot bots from cq config 2951fbde523f Remove cq_name from cq.cfg, no longer required/allowed fa96a04fc64d Add .vpython spec to add pywintypes to luci runs TBR: mark@chromium.org Change-Id: I8ecc5aa3925467c2e79a2c1eee7e1bf232aa7331 Reviewed-on: https://chromium-review.googlesource.com/c/1292150Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601300}
-
Tarun Bansal authored
Report H2 ping latency to network quality estimator where it is used for computing the network quality. Change-Id: Ib25e339ccd3967293ec8be94ef35aaa2a30a0678 Bug: 823322 Reviewed-on: https://chromium-review.googlesource.com/c/1285077Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601299}
-
Ryan Sturm authored
This CL moves previews triggering from the IO thread (ChromeResourceDispatcherHostDelegate) to the UI thread (ChromeContentBrowserClient). The new call sites occur in NavigationRequest and update the previews_state in CommonNavigationParams held by the NavigationRequest directly. This means PreviewsDeciderImpl is being moved to the UI thread. Significant changes: - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of profile IO data. - PreviewsUserData is now entirely a UI thread notion. For now, we use PreviewsUITabHelper to manage its lifetime, but it could move to NavigationHandle (if NavigationHandle already supported UserData, that solution would be ideal). - ChromeNavigationData is update to remove PreviewsUserData and PreviewsState (the latter has moved into PreviewsUserData and there is a notion of Allowed PreviewsState and committed PreviewsState) - Offline Previews committed checks use the OfflinePreviewsTabHelper instead of PreviewsUserData now that we are on the same thread. - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well as cleanup to remove PreviewsState from being passed back out of the loader code into NavigationRequest. - There is a TODO to re-evaluate PreviewsState during redirects, which will *not* be plumbed into the network service, so DataReductionProxy Previews will not be updated. Bug: 842233 Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb Reviewed-on: https://chromium-review.googlesource.com/c/1266196 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#601298}
-
Chris Palmer authored
Clear Site Data has shipped. Bug: None Change-Id: If6a15404905a8086fc195ceb1cb2ec6a66a95909 Reviewed-on: https://chromium-review.googlesource.com/c/1292250Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#601297}
-
chrome://accessibilityJames Wallace-Lee authored
In chrome://accessibility, the "Chrome Native UI" section behaves like the "Pages" section. Browser windows are listed individually using the .row class the Pages list uses. -AccessibilityUIMessageHandler::RequestNativeUITree takes a session ID as an argument and returns the accessibility tree for a single browser window. -The TargetDescriptor dictionary includes a field for a browser window's session id, and a "type" field that is either "page" for a WebContents or "browser" for a Browser. -In accessibility.js, showTree and other functions handle both browser windows and pages, since they can check |data|'s type field. -Elements in a .row element are given ids based on the row's id + a description of the element: '<id>:title', 'showTree', 'copyTree', 'hideTree', 'tree'. Bug: 842895 Change-Id: I7ef7b4edb884ff097fdaefc41ba97a813a7b49e1 Reviewed-on: https://chromium-review.googlesource.com/c/1260009 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
-
Joe Downing authored
This reverts commit 64646172. Reason for revert: LoggingTest.LogMessageMarkersOnStack is failing on several builders and this test was introduced in this CL: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/72386 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/12371 Example error message: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932209218566904752/+/steps/base_unittests/0/logs/LoggingTest.LogMessageMarkersOnStack/0 Original change's description: > Add start & end markers around |str_stack| for use by Crash service. > > Crash can locate particular entries in a stack by scanning for start & > end markers with unusual values. We add start & end markers around the > |str_stack| copy of the LogMessage string, created when we're about to > crash the process due to a FATAL level log message. > > Bug: 802393 > Change-Id: I8fd462cc515ddbefb8c7b34363eea848171aa776 > Reviewed-on: https://chromium-review.googlesource.com/c/1201344 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601236} TBR=ajwong@chromium.org,dcheng@chromium.org,wez@chromium.org Change-Id: If00343894caa467887191fbb09a4c80233cc94b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 802393 Reviewed-on: https://chromium-review.googlesource.com/c/1292595Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601295}
-
Will Harris authored
As stated in BrowserChildProcessHostImpl::OnChildDisconnected: "OnChildDisconnected may be called without OnChannelConnected, so stop the early exit watcher so GetTerminationStatus can close the process handle" This test previously did not take this into account and always expected a connected notification before a disconnected notification, so the test can be fixed by just removing this assumption. BUG=879555 Change-Id: I68ce0d27765a6b5387d57bf7af10b84c8fb240ac Reviewed-on: https://chromium-review.googlesource.com/c/1286910Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601294}
-
Yi Gu authored
For worklet animations that run via the main thread, the console log from the worklet may not get back to the main thread within 2 frames. To fix this, we can either wait longer, i.e. wait an extra frame, or not rely on the console log from the worklet as what we do in this patch. Bug: 887659 Change-Id: Ifb8619f571f51a7f5abe132a2c65d7a58f59d600 Reviewed-on: https://chromium-review.googlesource.com/c/1289430Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601293}
-
Marc-Antoine Ruel authored
As part of issue 894048 we'll probably unmap them and have another mean to map the binaries, but in the meantime this is the first step towards migrating to the Go binaries. R=iannucci@chromium.org Bug: 894045 Change-Id: I40c22997e8948a23a2a56e368b1cea55df0d5ab4 Reviewed-on: https://chromium-review.googlesource.com/c/1286748Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601292}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cdebbeb8cca2..af3d6cc8910f git log cdebbeb8cca2..af3d6cc8910f --date=short --no-merges --format='%ad %ae %s' 2018-10-19 thestig@chromium.org Roll v8/ 604c50c84..626844157 (516 commits) Created with: gclient setdep -r src/third_party/pdfium@af3d6cc8910f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9bb62c4420cf39885fd1a9b7ed40c7ae897f5938 Reviewed-on: https://chromium-review.googlesource.com/c/1292289Reviewed-by:
-
