GitLab

http://src.chromium.org/viewvc/blink?view=revision&revision=178719

BUG=385169
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/419673008

git-svn-id: svn://svn.chromium.org/blink/trunk@178966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hit testing which lands on a pseudo element (eg. :before/:after) is
normally modified (in HitTestResult.setInnerNode) to return the
parent element.  This CL makes touch adjustment consistent with this.
We still adjust towards any pseudo elements, but the final node will
be the pseudo element's parent.

This fixes an issues where checkboxes covered by a pseudo element
(as for chrome://settings custom checkboxes) weren't being activated
on tap.  CheckboxInputType::willDispatchClick is invoked only when
the click event is targetted directly at the <input> element, not
when it bubbles up from a descendant such as this pseudo element.

Prior to 
http://src.chromium.org/viewvc/blink?revision=178098&view=revision
this issue was masked because we did a redundant non-rect hit test
 for the mouseup event using the adjusted position.  Now that we
share the original hit test results the difference of behavior was
exposed to mouse event handlers.

BUG=395942

Review URL: https://codereview.chromium.org/418133010

git-svn-id: svn://svn.chromium.org/blink/trunk@178965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is testing a theory that maybe we are not reliably computing
the pid the apache server is running as on win7, and we are getting
confused over whether the server is running. If this theory is correct,
we should either see the hangs go away, or get some sort of different errors
that might help to debug things.

TBR=eseidel@chromium.org
BUG=378444

Review URL: https://codereview.chromium.org/416243006

git-svn-id: svn://svn.chromium.org/blink/trunk@178964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding the code to extract the raw YUV channels from the JPEGImageDedcoder and the plumbing to go from the skia derived classes all the way down to the decoder.

BUG=

Review URL: https://codereview.chromium.org/418653002

git-svn-id: svn://svn.chromium.org/blink/trunk@178963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397678
TEST=BaselineOptimizerTest.test_virtual_root_redundant_with_ancestors_skip_scm_commands_with_file_not_in_scm
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/423553004

git-svn-id: svn://svn.chromium.org/blink/trunk@178961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the spec, drawing an animated image to a canvas should only
draw the first frame.

BUG=286673

Review URL: https://codereview.chromium.org/388253004

git-svn-id: svn://svn.chromium.org/blink/trunk@178959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When DEBUG_AUDIONODE_REFERENCES is set, a message for the destruction
of an AudioContext is printed, but there's no matching message for the
creation of an AudioContext. Add one to make it symmetric and so we
can see how many contexts are created.

BUG=

Review URL: https://codereview.chromium.org/421603002

git-svn-id: svn://svn.chromium.org/blink/trunk@178958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/422553002

git-svn-id: svn://svn.chromium.org/blink/trunk@178956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability. This CL focuses
on ApplyStyleCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/418223004

git-svn-id: svn://svn.chromium.org/blink/trunk@178955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We show console message when they are used.

Intent to deprecate: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2SWnbXAL7Wg

BUG=397429

Review URL: https://codereview.chromium.org/417103002

git-svn-id: svn://svn.chromium.org/blink/trunk@178954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jamesr

Review URL: https://codereview.chromium.org/422533005

git-svn-id: svn://svn.chromium.org/blink/trunk@178953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added ScrollableArea::addScrollbarDamage() to accumulate scrollbar
damage rects.

BUG=394833
TEST=fast/repaint/scrollbar-parts.html

Review URL: https://codereview.chromium.org/418483004

git-svn-id: svn://svn.chromium.org/blink/trunk@178952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178883

BUG=392694
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/417313002

git-svn-id: svn://svn.chromium.org/blink/trunk@178951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability. This CL focuses
on ApplyBlockElementCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/413363004

git-svn-id: svn://svn.chromium.org/blink/trunk@178950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/412353004

git-svn-id: svn://svn.chromium.org/blink/trunk@178949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This will be used by the history system in content/renderer/ to disambiguate
frames during history navigation.

The current system uses two factors to try to find frames for navigation:
frame routing ids, and frame unique names. Routing ids can't be stored for
later use, because they might get saved to disk and collide with routing ids
in a future renderer process. Unique names are more reliable...unless a
website modifies window.name, at which point we try to do lookups based on a
stale name and can't find the right frame.

Instead, we introduce a frame sequence number. Like the existing item and
document sequence numbers, these can be saved to disk with a low chance of
collisions. These can then be reliably used during the current session to
match frames for back/forward navigations.

BUG=393227,395097

Review URL: https://codereview.chromium.org/418103003

git-svn-id: svn://svn.chromium.org/blink/trunk@178947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This class was missed in https://codereview.chromium.org/412483007/, see that
CL's description for the motivation.

I filed http://llvm.org/20452 about the diagnostic for this not being as clear
as it could be.

BUG=82385
R=rnk@chromium.org
TBR=michaeln

Review URL: https://codereview.chromium.org/419853002

git-svn-id: svn://svn.chromium.org/blink/trunk@178945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In DevTools instrumentation we may need to access an async stack trace object
wrapped into a ScriptValue from a different world. We would unwrap it to a
native object only to get it's String and number members, and not passing the
object to user's scripts.

BUG=396916
R=yurys

Review URL: https://codereview.chromium.org/418823002

git-svn-id: svn://svn.chromium.org/blink/trunk@178944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Only one getter left.

BUG=

Review URL: https://codereview.chromium.org/421573002

git-svn-id: svn://svn.chromium.org/blink/trunk@178942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It turns out the 'recursedeps' feature that would use this new DEPS
file needs some more support from bot_update and gclient. Reverting for
now.

TBR=eseidel@chromium.org, cmp@chromium.org
BUG=395862

Review URL: https://codereview.chromium.org/422453002

git-svn-id: svn://svn.chromium.org/blink/trunk@178941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the buildnumber parameter is omitted when requesting an aggregate
file, the file contents should be served up, rather than a file
list.

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/419883002

git-svn-id: svn://svn.chromium.org/blink/trunk@178940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We currently detect the XSSAuditor's fully-blocked frames by the inability
of a parent frame to access their contents due to the cross-origin "data:," URL
they are redirected to as a result of the block. An example of this technique
is the "cross origin frame" console message present in many CSP tests.

Before we can improve the mechanism by which fully-blocked frames are handled,
we need to stop relying on this side-effect.  Instead, it is better to dump
all child frames, and see if they have partial contents.

But to do this we must ensure that all tests put some minimal content
into the frame, otherwise a blocked frame and an empty frame produce identical
output.  We do this in the echo-intertag.pl file.

This was split off from a forthcoming CL to reduce the file count in that CL.

Review URL: https://codereview.chromium.org/420603003

git-svn-id: svn://svn.chromium.org/blink/trunk@178939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Three-sided patch:
[1] Blink: https://codereview.chromium.org/409403002
[2] Chromium: https://codereview.chromium.org/412833002/
[3] Blink: test (THIS PATCH)

BUG=395928

Review URL: https://codereview.chromium.org/411863003

git-svn-id: svn://svn.chromium.org/blink/trunk@178938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some folks raised concerns about removing UNLIKELY() from constructor.
We should revert the change.

TBR=haraken@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/419523004

git-svn-id: svn://svn.chromium.org/blink/trunk@178937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Get rid of the "local" implementation of the blend modes in favor of the
Skia implementation.
Still uses the ARM NEON specific implementation for when
ARM_NEON_INTRINSICS is enabled.
Also change so that createImageFilter uses WebCoreCompositeToSkiaComposite
to map to the Skia Xfermode.

Inspired by WebKit commit http://trac.webkit.org/changeset/170433 by
Dirk Schulze.

BUG=389594

Review URL: https://codereview.chromium.org/416093002

git-svn-id: svn://svn.chromium.org/blink/trunk@178936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This ASSERT was disabled with repaint-after-layout. Now that we have
moved invalidation after compositing update, we can enable it. The
ASSERT uncovered a bug in
RenderLayer::enclosingLayerForPaintInvalidation where we were walking
over stacking contexts and not just renderers.

BUG=360286

Review URL: https://codereview.chromium.org/414503002

git-svn-id: svn://svn.chromium.org/blink/trunk@178935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To remove a FIXME comment. I ran Dromaeo and didn't see any regression.
Here is the result.

w/ CL
1st: 1646.81runs/s (Total)
http://dromaeo.com/?id=224905

2nd: 1621.15runs/s (Total)
http://dromaeo.com/?id=224906

w/o CL
1st: 1662.16runs/s (Total)
http://dromaeo.com/?id=224907

2nd: 1644.60runs/s (Total)
http://dromaeo.com/?id=224908

Also, remove an obsolated FIXME comment.

BUG=345503

Review URL: https://codereview.chromium.org/419673003

git-svn-id: svn://svn.chromium.org/blink/trunk@178934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix reference to non-existent image in some rules to style popover
scrollbar.

R=vsevik, apavlov

Review URL: https://codereview.chromium.org/420713004

git-svn-id: svn://svn.chromium.org/blink/trunk@178933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eustas
NOTRY=true

Review URL: https://codereview.chromium.org/419073005

git-svn-id: svn://svn.chromium.org/blink/trunk@178932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Broken test is incorrect and was disabled.

> Revert 178850 "DevTools: Introduce createRawLocationByConsoleCal..."
> 
> This CL or r178848 broke the following browser tests.
> http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3288
> 
> Let me revert the two CLs at the moment.
> 
> > DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correctly.
> > 
> > Links to internal VM scripts were not linkified correctly in Network panel popover.
> > To test this, send an XHR from console, and try to jump to an injected script from Network popover.
> > 
> > R=eustas, vsevik
> > 
> > Review URL: https://codereview.chromium.org/412183002
> 
> TBR=aandrey@chromium.org
> 
> Review URL: https://codereview.chromium.org/421523002

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/420603009

git-svn-id: svn://svn.chromium.org/blink/trunk@178931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Broken test is incorrect and was disabled.

> Revert 178848 "[DevTools] Make toolbar counters declarative."
>
> This CL or r178850 broke the following browser tests.
> http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3288
>
> Let me revert the two CLs at the moment.
>
>
> > [DevTools] Make toolbar counters declarative.
> >
> > This includes error-warning and devices counters.
> >
> > BUG=none
> >
> > Review URL: https://codereview.chromium.org/408853002
>
> TBR=dgozman@chromium.org
>
> Review URL: https://codereview.chromium.org/416983006

R=haraken@chromium.org
TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/418343002

git-svn-id: svn://svn.chromium.org/blink/trunk@178930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If execution is terminated while constructing the ErrorEvent representing
the incoming v8::Message, do not attempt to report the exception.

R=haraken@chromium.org
BUG=393273

Review URL: https://codereview.chromium.org/405933002

git-svn-id: svn://svn.chromium.org/blink/trunk@178929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the case where a thread takes a lock/mutex within a safepoint scope and leaves the safepoint with the lock held we risk deadlocking if the same thread takes the same lock in a destructor. The reason is that if another thread did a GC while the first thread was in the safepoint the sweep done by the first thread will potentially call a destructor which could then take the same lock. Since the WTF:Mutex is not recursive/reentrant the thread will deadlock on itself.
This change fixes this by introducing a RecursiveMutex which allows a thread to take a lock it is already holding. Interestingly the Windows WTF:Mutex is currently reentrant wrt. the lock() method, but not wrt. tryLock() since tryLock mimics the behavior of the pthread_mutex by keeping a recursion count. To deal with this I introduce a separate tryLock method for the Mutex and the RecursiveMutex that behaves different on windows. On pthreads (Linux/Mac) the tryLock method is identical since it changes behavior depending on how the mutex is created.

I have added a test which demonstrates the dead-lock issue.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com, tkent@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/415083002

git-svn-id: svn://svn.chromium.org/blink/trunk@178928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=373120

Review URL: https://codereview.chromium.org/416353002

git-svn-id: svn://svn.chromium.org/blink/trunk@178927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sergeyv
NOTRY=true

Review URL: https://codereview.chromium.org/417133002

git-svn-id: svn://svn.chromium.org/blink/trunk@178926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Inline flexbox width is calculated wrongly when flow of flexbox is
column and flex-wrap property set to wrap or wrap-reverse. The width
is calculated as if inside elements were layed out horizontally. 
This results in extra unnecessary space.

This patch fixes this bug by removing lines that set the 
maxPreferredWidth with the assumptions that children of flex item 
will be layed out horizontally and maxPrefferedWidth is set as 
width of flex-item having maximum contribution. 

BUG=247963

Review URL: https://codereview.chromium.org/289903007

git-svn-id: svn://svn.chromium.org/blink/trunk@178925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We've got all enum values starting with an uppercase letter in our code

TBR=sergeyv

Review URL: https://codereview.chromium.org/420783002

git-svn-id: svn://svn.chromium.org/blink/trunk@178924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/407723002

git-svn-id: svn://svn.chromium.org/blink/trunk@178923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves the WorkerThreadableWebSocketChannel::Peer construction to
the worker thread from the main thread.
That simplifies the construction and destruction of Peer and removes
#if ENABLE(OILPAN) macros.

BUG=384238

Review URL: https://codereview.chromium.org/350763007

git-svn-id: svn://svn.chromium.org/blink/trunk@178922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hide isXXX() type checking methods in subclasses in order to catch unnecessary
calls at compile time. For e.g., it makes no sense to call
Element::isElementNode() as it is obviously true.

This CL also takes care of removing several such unnecessary calls that were
caught at compile time.

R=eseidel@chromium.org, pdr@chromium.org

Review URL: https://codereview.chromium.org/422463002

git-svn-id: svn://svn.chromium.org/blink/trunk@178921 bbb929c8-8fbe-4397-9dbb-9b2b20218538