- 08 May, 2019 40 commits
-
-
Ehsan Karamad authored
The HeadlessContentRendererClient does not implement CreateBrowserPluginDelegate which causes a renderer crash in the headless mode for objects which set their type to "application/browser-plugin". This CL adds a null check to RenderFrameImpl to stop the crash. Bug: 958678 Change-Id: Ic90ecbded86e764fb81eb9796b5d9e2732966fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598323Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#657570}
-
Yusuke Sato authored
This reverts commit 6f1b99ba. Reason of the revert: With this CL, Chrome on R76-12184.0.0 (eve) crashes when an ARC++ app is launched. TBR=sandersd@chromium.org,dcastagna@chromium.org,dcheng@chromium.org,rjkroege@chromium.org BUG=957381 TEST=R76-12184.0.0 (eve) works with this revert Change-Id: I1d833880611b4d3d1c03e074ccfcb8db12d7acd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600792 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#657569}
-
jchen10 authored
This makes the query of GL_COMPLETION_STATUS_KHR to programs much cheaper by minimizing the round-trip to the GPU thread. Bug: 881152, 957001 Change-Id: Iadfa798af29225e752c710ca5c25f50b3dd3101a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586630 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#657568}
-
Caroline Rising authored
Bug: 910739 Change-Id: I66a8c9465dfe3ec3a29792e56028491ee5733056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600399Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#657567}
-
Karan Bhatia authored
This is a reland of ac4285c8. We now ensure that all primitives in WebRequestInfoInitParams are correctly initialized. Original change's description: > Extensions: Make most of WebRequestInfo immutable. > > This CL makes most of the WebRequestInfo data members const. To achieve this, a > new helper struct called WebRequestInfoInitParams is introduced. This will help > with guarantees around WebRequestInfo's immutability. > > BUG=696822 > TBR=mmenke@chromium.org > > Change-Id: I36bd8284aca9e68e115fba94b579456902f968ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594066 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656970} TBR=mmenke@chromium.org Bug: 696822 Change-Id: Ib86bdf1ad6e66f80d86adb038fafcd0d341c937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600593Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#657566}
-
Ilia Samsonov authored
Refactored TestLauncher to enable mocking in unit tests. Added couple of basic unit tests for TestLauncher. Bug: 936244 Change-Id: I67538d2bb3a05713905a8f6801a3b3bd9813afcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597958Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#657565}
-
Nektarios Paisios authored
Previously, if a user had set a selection on the page and then removed it by carrying out an action that would not otherwise refresh the accessibility tree, such as clicking with the mouse at a random location, the accessibility tree would never find out that the selection had been removed. R=dmazzoni@chromium.org, yosin@chromium.org Change-Id: I0f50accdc6715d706aeed84c051aa125709ae205 Bug: 639340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596150 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#657564}
-
Suman Kancherla authored
The optional attribute is only specified because the argument is a dictionary, XRRenderStateInit, with no required members based on https://heycam.github.io/webidl/#dfn-optional-argument. Bug: 956301 Change-Id: I5e3823e24b7e34310e31eb38dfc3affa8dce2796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599687 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#657563}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84e7932d2737..19905aea14e0 git log 84e7932d2737..19905aea14e0 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 ianelliott@google.com Vulkan: Set the Vulkan scissor to the GLES viewport 2019-05-07 tobine@google.com Vulkan:Only apply invariant pragma to output vars 2019-05-07 staphany@chromium.org Add using-declaration to support Googletest roll. Created with: gclient setdep -r src/third_party/angle@19905aea14e0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I169fefb2e8e5c4610ccb86a50ab32195f8e61720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657562}
-
kyle Ju authored
Command: python third_party/blink/tools/wpt_update_expectations.py Bug: 934919, 881513, 927187 Change-Id: I3248058c467711e605db890948bbe97f5311e260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484616 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#657561}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7978f9cb6d33..5d22a780f989 Created with: gclient setdep -r src-internal@5d22a780f989 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org Change-Id: Ib9e3e937c03f9ddb2e42e4faf6e07f3fcb3e0081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600692Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657560}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/195bcae748c7..f8847c1a94bb git log 195bcae748c7..f8847c1a94bb --date=short --no-merges --format='%ad %ae %s' 2019-05-08 kbr@chromium.org Allow subproject in bug link in test expectations. Created with: gclient setdep -r src/third_party/catapult@f8847c1a94bb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=sadrul@chromium.org Change-Id: I1f029fa6465f59a70a40461c11e52501a2432aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600694Reviewed-by:
-
Daniel Libby authored
Currently the time between the finger touching down and the recognition of a scroll is not captured in any of our metrics (perhaps for good reason, since it is dependent on how fast the user initially moves their finger to get out of the slop region). We'd like to add this histogram to understand what this looks like for users in the wild. R=bokan@chromium.org, nzolghadr@chromium.org, tdresser@chromium.org Change-Id: I25c32bbd096c9f397588fbba8dc4ece198f6660a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590960 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#657558}
-
Kinuko Yasuda authored
This no longer seems to be needed. Change-Id: Ib3cc8c454fb8863b986a23882815013acee5d1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598928 Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#657557}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/73e2413865fc..a037b8b34eab $ git log 73e241386..a037b8b34 --date=short --no-merges --format='%ad %ae %s' 2019-05-07 fkastenholz Refactor QuicFramer::Get...ConnectionCloseFrameSize 2019-05-07 quiche-dev unbreak TachyonIOS, remove const on bool return value in quick_session.h 2019-05-06 renjietang Use a QuicSession member to latch gfe2_reloadable_flag_quic_eliminate_static_stream_map_2. 2019-05-06 dschinazi Make client drop packets with wrong versions 2019-05-06 dschinazi Support IETF RETRY from client 2019-05-06 quiche-dev Create a helper that wraps a competing QuicEndpoint for Quartc simulator tests. 2019-05-06 ianswett gfe-relnote: n/a (Refactor) Move the only method in ConnectionCloseDelegateInterface into QuicPacketCreator::Delegate and delete ConnectionCloseDelegateInterface. No functional change, not flag protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ic003434d2852fd3d65ca3b3c4215876f46f2fafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599709 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#657556}
-
Yusuke Sato authored
This allows us to pass more tests with --enable-features=AppServiceAsh. In some unit tests, the Profile object outlives ArcServiceManager. ArcApps object whose lifetime is equal to Profile's need to check if ArcServiceManager is still alive in its destructor. This CL requires Chromium >=r656870. BUG=None TEST=try TEST=unit_tests --gtest_filter='*AppSearchProviderTest.Basic*' --enable-features=AppServiceAsh TEST=unit_tests --gtest_filter='ArcAppModelBuilderRecreate.*' --enable-features=AppServiceAsh Change-Id: I6905eb01dcb6e69492b97dba2a7f9f7d90c986da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597125 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#657555}
-
Ben Kelly authored
This CL makes the following changes: * Modify URLLoaderClient::OnReceivedCachedMetadata() to take BigBuffer. * Make Blob::ReadSideData() return a BigBuffer. * Pass the BigBuffer through the ServiceWorkerSubresourceLoader. * Pass the BigBuffer down from URLLoaderClientImpl as a span. * Improve the tracing of WebURLLoaderImpl to show number of code cache bytes received. Bug: 867848 Change-Id: I49c30b66dacc85166de64fc1cc1049f79c81f9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599710Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#657554}
-
Mike Wittman authored
Checks that walking stacks from C++ through JavaScript and back to C++ works as expected. Bug: 909957 Change-Id: Ib881d082990df701c7f22da63cff89880b97764b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590607 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657553}
-
Peng Huang authored
Bug: 959800 Change-Id: I990dd544fe1d3b1a4ceacc5eda5c98e9f5c5ce22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599856 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657552}
-
Hanfeng Zhu authored
This reverts commit 6a7745fd. Reason for revert: http://crbug/960172 Bug: 960172 Original change's description: > Disable signin promos for special users. > > Add a new method "isSignInPromoAllowed()" in SigninPromoController to > check whether promos are allowed. The reason is that in some regions > signing in may be problematic, thus promos should be suppressed. > > Bug: 948983 > Change-Id: I389b1d2d693a0bcb63571e78991f7287f734672f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548875 > Commit-Queue: Hanfeng Zhu <hanfeng@google.com> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647994} TBR=msarda@chromium.org,tedchoc@chromium.org,bsazonov@chromium.org,hanfeng@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 948983 Change-Id: I5b5ee040891272ae5010becf11529055a08c1324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596790Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Hanfeng Zhu <hanfeng@google.com> Cr-Commit-Position: refs/heads/master@{#657551}
-
Mike Wittman authored
Platform expectations are that the stack is aligned to 8 bytes on 32-bit platforms and 16 bytes on 64-bit platforms. Having the stack buffer aligned will facilitate alignment-correct implementation within the stack copying itself. Bug: 956626 Change-Id: I217c1948d271839e22283f884adbaa6a14f1c4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593803 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Chris Cunningham authored
We already have a use counter for decodingInfo(), but suppling the key system configuration implies EME usage, which is the recent foucs for investments and upcoming experiments. Bug: 953500 Change-Id: I22b07b1c579d7e7bb0427ec85c765ebec1629bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592696 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#657549}
-
Karan Bhatia authored
This is only used in tests. Instead provide a test only function to test equality. BUG=696822 Change-Id: I97ec7787aaea8ac0c73c662baa7fea05109e1364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595424 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This is a reland of 12b30300 It adds mojom_platform to 'interfaces' from //content/public/common/BUILD.gn to fix compilation error from mac_rel. Original change's description: > Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth" > > This is a reland of d5b00821 > > It updates //BUILD.gn and //content/public/common/BUILD.gn > in addition to the previous change to fix the dependency > problem. > > Original change's description: > > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > > > This CL moves bluetooth folder from public/platform/modules to > > public/mojom/ to gather mojom files to mojom folder with > > creating web_bluetooth_mojo_bindings. > > > > Bug: 919393 > > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Reviewed-by: Doug Turner <dougt@chromium.org> > > Reviewed-by: Colin Blundell <blundell@chromium.org> > > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#649061} > > Bug: 919393 > Change-Id: I61de3e625205e54959ad8d36c84eefa95f861035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559368 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#652487} Bug: 919393 Change-Id: Iae407fa213a9f9335b7bbc695c87369d124c745e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575560 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#657547}
-
dpapad authored
No longer used. Bug: 960564 Change-Id: I07220d3d1d60cdc013fad1909e96636f2c56ac4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600603 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#657546}
-
Becky Zhou authored
Bug: 944061 Change-Id: Ie6f376c3571fa5942ad14a1f642fbf9102f8b7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600558Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#657545}
-
Collin Baker authored
FeatureList::IsFeatureEnabled and FeatureList::GetAssociatedFieldTrial call std::map<std::string, _>::find() with a const char* argument. By default, this results in a conversion to an std::string, hence incurring a memory allocation. C++14 adds a new std::map::find() override to support map lookups by types other than the key when a transparent comparator is specified. This allows, for example, performing lookups in an std::map<std::string, _> using a const char*. This CL changes the declartion of FeatureList::overrides_ to support these allocation-free lookups. Bug: 960618 Change-Id: I59c8d2c16e86a3a6ca458b4047c445b1373df05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600083 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#657544}
-
Jia authored
Roll src/third_party/cros_system_api/ d6ec70dbe..70f65b7ac (7 commits) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d6ec70dbe6b7..70f65b7ac09d $ git log d6ec70dbe..70f65b7ac --date=short --no-merges --format='%ad %ae %s' 2019-05-05 derat system_api, power: Allow slow brightness transitions. 2019-05-03 menghuan attestation: Remove CreateGoogleAttestedKey API 2019-05-06 pbond system_api: remove diagnosticsd constants 2019-05-03 benchan system_api: shill: remove unused kWifiAuthMode constant 2019-04-30 benchan system_api: drop wimax_manager constants 2019-04-10 menghuan attestation: Make the attestation daemon decide the EK key type 2019-03-08 ljusten kerberos: Add ListAccounts method Created with: roll-dep src/third_party/cros_system_api Change-Id: I29f582ee2e8110068afff48d3f185a1a8973bfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600460Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Khushal authored
Since the media code marks candidates opaque based on the video format, it is common to have video quads be marked not opaque. If we use any strategy other than an underlay in this case, the damage rect for the overlay is not subtracted from the damage rect for the OutputSurface plane which causes us to unnecessarily redraw the main plane. R=liberato@chromium.org, piman@chromium.org Bug: 889328 Change-Id: I3e5436b051b1becc39b5b5396ec3f676afc203b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600492Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#657542}
-
enne authored
This reverts commit 88b589af. Reason for revert: causes issue 960436 This seems worse than the original issue, so reverting now while chrishtr is out. Original change's description: > Adjust rounded corner bounds when aggregating quads into a new target state. > > The rounded_corner_bounds field of SharedQuadState needs to be in the > space of the target render surface. When changing that target, therefore, > rounded_corner_bounds needs to be updated accordingly. > > Bug: 947715 > > Change-Id: I83b3f773d960e82d75060326c197ef12ae1755fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590900 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656424} TBR=chrishtr@chromium.org,enne@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947715,960436 Change-Id: I68dbe7679ce90d0de6be4ef1a3958d3ec8f94a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600435Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#657541}
-
John Rummell authored
On some devices this occasionally crashes, so catch the exception and gracefully fail. BUG=946906 TEST=manual playback with Shaka Change-Id: Iee94afeedfc88b034225ce7c7795dcce2b50a347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597657 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#657540}
-
Kurt Catti-Schmidt authored
Implementation of moving by TextUnit_Format. This relies on existing text attributes stored on AXNodeData as a "format". A new class was introduced for quickly comparing two different text formats, named "AXNodeTextStyles". New methods were added to AXPosition to navigate by format, either to the start or end of a format boundary, which AXPlatformNodeTextRangeProvider relies on for format navigation. Tests were added for the new class, AXPosition navigation, and AXNodeData functionality. Bug: 928948 Change-Id: I91ad34cc67ea8996bb18b4d2c4c4597738bc7854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584596 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#657539}
-
Xiaocheng Hu authored
This reverts commit 0af2a61e. Reason for revert: Need another round of crash capturing. Original change's description: > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3" > > This reverts commit cbdaf211. > > Reason for revert: Crash data already collected in 3763 and 3764 > > Original change's description: > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" round 3 > > > > This reverts commit 33b5c673. > > > > Reason for revert: Adding production CHECKs to collect LayoutNG failures > > for the 3rd time. > > > > Original change's description: > > > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"" > > > > > > This reverts commit 26ca019a. > > > > > > Reason for revert: Crash data already collected > > > > > > Original change's description: > > > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > > > This reverts commit ec11fe81. > > > > > > > > Reason for revert: Try to catch more crashes in the wild after > > > > a fix (crrev.com/c/1546713) has been landed. > > > > > > > > Original change's description: > > > > > Revert "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > > > > > This reverts commit bade42c5. > > > > > > > > > > Reason for revert: New crashes already caught. Reverting CHECKs > > > > > back into DCHECKs to reduce noises. > > > > > > > > > > Original change's description: > > > > > > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG > > > > > > > > > > > > Bug: 946004 > > > > > > Change-Id: I9e2aa69a32f7a0373196d57e629256dbc7d78d2a > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540305 > > > > > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > > > > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#644907} > > > > > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > > > > > Change-Id: I15fb43370f58757e09e7b7abc7c40d4af4a6101a > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: 946004 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544156 > > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#645407} > > > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > > > Bug: 946004 > > > > Change-Id: Iccb8c2b998d28f659381c3f89a1686614600860c > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548248 > > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#646516} > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 946004 > > > Change-Id: I9794539b39bc6a0053a7229b03bce7db402ecb5b > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551440 > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#647418} > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 946004 > > Change-Id: I973ccf65be78d4632f67b945614f1a4ee091134d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562500 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#649773} > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946004 > Change-Id: If61d1cbfaeb6a445b8ceee193dba198978d2719c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567130 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650624} TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946004 Change-Id: I43e61cc397ebbb44fb15f9a5bc0448077c281f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600400Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#657538}
-
Ehsan Karamad authored
This CL moves three of the current browser tests to run with and without MimeHandlerViewInCrossProcessFrame. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: I13f10b15a0d173f17faf41d19a7e2e650f072ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600313 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#657537}
-
Antonio Gomes authored
The class is not being referred on the file touched. This is part of bigger the effort to confine WebCallbacks and ScopedWebCallbacks classes within Blink. R=jbroman@chromium.org BUG=945851 Change-Id: Ia414c9e9d596de65ade4ff0255c5df0e0bd2ed01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599192 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657536}
-
Kevin Bailey authored
Tail suggestions are launched, so remove flags that refer to it. Bug: 726769 Change-Id: If15ff4406c6e897c745ff9c625bdf7a7419d3f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599904Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#657535}
-
Scott Violet authored
Now that we're no longer shipping mash, this code can be removed. Also, I'm removing AshServiceTest as it triggers hitting a DCHECK because of this change. AshService will go away shortly anyway. BUG=958203 TEST=this removes dead code Change-Id: I606d72737eb88c0cdda12269af8da4b2908cbfdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600637 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#657534}
-
Ahmed Fakhry authored
- Exit overview mode normally if mini_view of already active desk is selected. - Minimized windows on inactive desks should not be considered activatable. - Minimized windows should not be activated on switching back to their desk. BUG=866622 TEST=Manually and added new tests Change-Id: Icd846e408a0e26c696ade1d86361e782362f64da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600252 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#657533}
-
Matthew Wang authored
Create histograms to track the state transition from the Connected state to the Redirect Found state. Implemented in CL:1548770. Bug: 903645 Change-Id: I8b906f96d72ec98abd8d09ce4f4f20631014136a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549682 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#657532}
-
Yue Li authored
If the opt-in window already exists while showing, focus it. Bug: b/131250731, b/130374617 Change-Id: I53936eed349602d19771b94177367223b56d2ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590877 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#657531}
-
