- 18 Jul, 2020 23 commits
-
-
Lei Zhang authored
It no longer builds after https://crrev.com/788162, so comment it for now to unblock the affected Chrome OS builders. Bug: 1106355 Change-Id: I2895dd2d21253c72ec728ae9af2ce2c9fce60414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304551Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#789721}
-
rbpotter authored
- Modify the new toolbar's input field to display the current zoom level. - Also update the fitting for the new toolbar for fit to width and fit to page to account for the toolbar height, since the new toolbar does not auto-hide. Bug: 1105701 Change-Id: I34c0cf26f1d570023ea9904dd63da0da703e7781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303991Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789720}
-
James Cook authored
Select file dialogs are implemented in ash-chrome via SelectFileDialogExtension, which requires an aura::Window owning window for the dialog. Use the currently active (frontmost) window, which will usually be the spawning Lacros window. Verify that it's still a ShellSurface, just in case window activation has changed between when the user initiated the file picker and ash-chrome has received the mojo message. This isn't quite right -- in theory a non-active window could spawn a file picker -- but it's better than a modal file picker that blocks the whole desktop. Bug: 1090587 Test: multiple lacros windows can have their own file picker children Change-Id: I582cd534e49228f3da5ab67e5ad99812f1a48432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303681Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#789719}
-
Dale Curtis authored
Allows us to avoid spinning up a real audio device for muted playbacks, which saves ~200-300mW of power per Intel. R=tmathmeyer Bug: 764133 Change-Id: I0a6404858eea2ac643d53cb623f653f988c99330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305114 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789718}
-
Daniel Hosseinian authored
The version of GetColorModelForMode() that ChromeOS uses will be used by macOS. Rename it to GetIppColorModelForMode() and move it to print_settings.h. Meanwhile, add some simple tests. Bug: 1106437 Change-Id: Ic01d1cf242c6e77774d247253f6cd912c2566f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303855 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#789717}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d0c9d0cb7ffa..9662fd6cbdfb 2020-07-17 mtklein@google.com support 64-bit PixelFormats 2020-07-17 johnstiles@google.com Fix swarming task failure on Debian10-Clang-arm-Chromebook-GLES. 2020-07-17 mtklein@google.com add 64-bit load/store ops 2020-07-17 csmartdalton@google.com Implement indirect draws with ANGLE's multi draw extension 2020-07-17 nifong@google.com Run both puppeteer tests in a WebGL 1 and 2 configuration. 2020-07-17 mtklein@google.com support 16161616 in fm 2020-07-17 herb@google.com split glyph and geometry data apart 2020-07-17 jcgregorio@google.com Use the new swiftshader bucket. 2020-07-17 mtklein@google.com use precise is-normalized test in gm/p3.cpp 2020-07-17 robertphillips@google.com Clean up some uses of GrContext in tests 2020-07-17 johnstiles@google.com Update GrMorphologyEffect to take an inputFP. 2020-07-17 johnstiles@google.com Update existing TestCreate methods to honor the inputFP in the TestData. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ie24eb9fcfae7af52a4023d2a882488dc0ea65705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789716}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..a8b8ef775c75 2020-07-17 amaiorano@google.com Fix Win32 Chromium and ANGLE builds 2020-07-17 capn@google.com Remove Travis CI and AppVeyor build badges 2020-07-17 capn@google.com Update Kokoro's clang-format to version 10 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1106623 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie251a4eea02b8ef95a16ff1e007916cb71b8fd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789715}
-
Lukasz Anforowicz authored
This CL tries to speculatively avoid 1) cases where a |direct_network_factory_| might be getting used with non-opaque origins (see https://crbug.com/1105794) and 2) cases where a |request_initiator_site_lock| doesn't match |request_initiator|. We speculate that one such case might occur when RenderFrameObserver::ReadyToCommitNavigation triggers a fetch in a new document *before* the new factories have been installed. After this CL, the new factories are installed earlier, before calling RenderFrameObserver::ReadyToCommitNavigation. Bug: 1105794, 1098938, 920634, 1056949 Change-Id: I1f06750d4211e12d196eba0f3a78edeaeaa98cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303678 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#789714}
-
Lei Zhang authored
Since pdf/pdf.cc is just the implementation for an interface into the internals code, separate it and its header out into a separate target. Put the majority of the code in pdf/ into an "internal" target, since that's what it is. To make the dependencies work out, also put pdf/pdfium/pdfium_assert_matching_enums.cc into its own target. Bug: 1103478 Change-Id: I95da94e55f1bddf957a26cece899d27222756584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293457 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789713}
-
Yue Zhang authored
This CL adds e2e test to cover item 1.6.15 in https://testtracker.googleplex.com/testplans/details/32981. Bug: 1105511 Change-Id: Ib19c38b064d0fd201918af0bee0584170db72786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296343 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d8628ddce9a..7043cea402ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1104558,chromium:1105096,chromium:1105606,chromium:1106471 Tbr: atotic@google.com Change-Id: I6cb49cb38b04ad36db89888fb668b6924d37020e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305170Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789711}
-
Nathan Zabriskie authored
This is a follow up CL to crrev.com/c/2280228 which added surface origin and alpha type to SharedImageInterface. It finishes piping that information through to SharedImageBacking. Bug: 1034086 Change-Id: Ia8c2042051d0c36ca73217fcf79da9da0deb181e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304099 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789710}
-
Daniel Classon authored
Added the Polymer Behavior to fetch the settingId parameter from the URL and then focus on elements containing that settingId. Imported in the OS Reset Page. Bug: 1084154 Change-Id: I52bb73227447d6293a7b31402f7cc5a29e045309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296008 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789709}
-
Devlin Cronin authored
Bug: 1103302 Change-Id: I653a90da2e2d628fd1e00ddd28902017f045ac86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288353Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789708}
-
Christopher Cameron authored
Change SharedImageBackingGLImage to not allocate a GL texture until it is going to be used, and also delete the GL texture when it is no longer in use. This is needed for Metal-only SkiaRenderer, where we really don't want to be using GL (and actually can't, because there isn't a context hanging around at all times). TBR=geofflang Bug: 1092155 Change-Id: I6c14d03b50f40bd96de1c0c7355c03493c22865d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298723Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#789707}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc4668dae26e..de90862cce95 2020-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3cd7ca07..d2f62519 (789472:789613) 2020-07-17 danilchap@webrtc.org Delete callbacks from RtpDemuxer on ssrc binding 2020-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b8a4405e..3cd7ca07 (789356:789472) 2020-07-17 philipel@webrtc.org Removed unused include from encoded_image.h. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1e57407b69d32aa1a9c4dcf9cc8b7f5ad9bdd3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789706}
-
Martin Kreichgauer authored
This reverts commit c10ef92a. Reason for revert: Causes GATT connection failures on Windows (crbug.com/1106597) This is a partial revert. I'm not including updates to the comments in device/bluetooth/bluetooth_discovery_session.h because they were unrelated to the actual change and are still correct despite the revert. (See the PS1/PS2 diff for the re-revert.) Original change's description: > fido: stop scanning for BLE advertisements before connecting > > Anecdotally, GATT connection reliability on Windows is higher if the > Bluetooth adapter is not scanning while the connection attempt occurs. > Hence, make FidoCableDiscovery invoke BluetoothDiscoverySession::Stop() > before connecting to a device. Obviously, there is a possibility of > scans occurring for other reasons. But that's unlikely to happen and we > can't do anything about it. > > Note that stopping the scan probably means a single FidoCableDiscovery > instance can at most connect a single device. However, caBLEv1 > currently only really supports a single authenticator anyway. > > Change-Id: Ibaac6bc1563e4429dad0df9570f77c594ed1469c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211281 > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781094} Bug: 1106597 Change-Id: I1e4fcf5b6be1d26a4d7634ad1fe96df1d07b176a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303683 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#789705}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/320ceb93a21c..4bbdfa583e74 2020-07-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib06e97bec490a7100e713362a05d6469cc458390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305233 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789704}
-
Matt Menke authored
These are not commonly included in header files, but fairly often used in cc files, so including them in a widely used header can lead to IWYU issues (this header isn't widely used directly, but was transitively included in 8,000+ files). Bug: None Change-Id: Id08418b088d6b9e55cd9c86852363b016b842b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300033Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789703}
-
Greg Thompson authored
This CL adds FLAG_SHARE_DELETE to many file operations in Chrome's installer; including in delta patch processing and archive extraction utilities. This allows processing on files that are held open to be deleted by another entity so that we can eventually hold temporary files open with FILE_FLAG_DELETE_ON_CLOSE. BUG=516207 Change-Id: I1cd03f6360dfcd61fcd2f09797f0923331076415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302109Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789702}
-
Alexander Alekseev authored
This Cl exposes viz::DebugRendererSettings members as checkboxes in ash HUD overlay. Bug: 1085288,1085287,1085279 Change-Id: Id6ad4aa632cb552277ba47d076056b5ca0cc51f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303468Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#789701}
-
Collin Baker authored
This adds another step to the in-product help promo for creating a new tab group. If a tab context menu is opened before IPH times out, the new group menu item will be highlighted. Bug: 1102655 Change-Id: I6955445394fdd01bffb33ba73e98be914cd93b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297811 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#789700}
-
Mohamed Heikal authored
This reverts commit 7a1a3bdc. Reason for revert: breaks android-archive-rel https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/13342 Original change's description: > Fix build issues with creating R.java in java_library targets > > A collection of bugfixes for creating R.java in java_library_impl > targets: > - test libraries support. > - apk under test R.java shadowing bugfix. > - always generate onResourcesLoaded like package resources did. > - Fix issue where R.java is not generated for the apk package name. > > Bug: 1073476 > Change-Id: I0cebd9626b0ce9049554f8345af516f7bd0ec2aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302919 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789690} TBR=agrieve@chromium.org,mheikal@chromium.org Change-Id: I0113b626a076a3b01abbe985560c5d9f1470faa9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302816Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789699}
-
- 17 Jul, 2020 17 commits
-
-
manuk authored
With the 1-line UI, rich autocompletion adds a label adjacent to the omnibox and then resizes the two as the autocompletion length changes. On location bar focus, the omnibox is unelided; e.g. google.com is unelided to https://www.google.com. Before this CL, unelision occurs *after* the location bar is given focus and its layout computed. With this CL, unelision occurs *before* the location bar is given focus so that it can reserve sufficient width for the unelided URL when updating its layout. Bug: 1062446 Change-Id: Id78d635255de69d9af97a5589a9e001eee3d0feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304666 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#789698}
-
Jonah Chin authored
This change sets up PaintImage to lazily trigger a readback of SkImage via MailboxTextureBacking. It also implements the readback API itself in RasterImplementation. This API is required for OOPR-Canvas as certain PaintImage users need image pixels in CPU memory. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1023281, 1031050 Change-Id: Ib1a1ee3c8ceef72b045277540393a5f55f3135ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280391Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789697}
-
Weilun Shi authored
After moving some functions from net// to base//, the UnescapeValue no longer needs to depend on net// so it can be moved to base/metrics/field_trial_params where it gets used. Also replace the temporary NoOpDecodeFunc with the UnescapeValue as it's available now. Bug: 1068052 Change-Id: I1b1790a3e1491a834822d017a5f2f4bfa34ffbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298942 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789696}
-
Devlin Cronin authored
Some features specified more types than corresponded to the allowlisted IDs. Remove the unnecessary types. (There may be more entries with this issue, but these were the ones I saw.) Bug: None Change-Id: Ib19bc8691b569127a835edc2a967c2f6ca1082a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304957Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789695}
-
K. Moon authored
Adds functions for converting from gfx::Rect to pp::Rect, and from gfx::Size to pp::Size. Also makes a few extra improvements: 1. Adds unit tests. 2. Orders Point functions before Rect and Size, for consistency. Bug: 1101101 Change-Id: I5e3b0a3e5361d799103c9771ac29a9c0b74df999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304931 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#789694}
-
rbpotter authored
These flags aren't needed once Polymer 3 code is fully checked in, except for cases where import paths don't match the source tree structure (e.g. Print Preview). Bug: None Change-Id: Ie040cbb7498afc0aa2ec847b0993f6fcaac9aed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303308Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789693}
-
Clark DuVall authored
This callback should never be null. Bug: 1062962 Change-Id: Ie81c2f52914823df3fa2e55a0d2633779d18a826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305117 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789692}
-
Emily Stark authored
In the simplified domain field trials, the path, scheme, and optionally subdomains get faded to transparent when the user interacts with the page or after the user hovers and exits the mouse. But there are various ways that it's possible to transition from this state (path, scheme, subdomains faded out) to showing the full URL. However, the method that shows the full URL wasn't applying any color changes, only changing the display area/offset. This could lead to some situations where the full URL is scrolled into view, but some parts of it were still transparent (see bug for repro). To fix this, ShowFullURL() now resets the text color and applies emphasis by calling EmphasizeURLComponents(). This ensures that all components of the URL are not just scrolled into the display area but also colored properly and not transparent. Bug: 1106478 Change-Id: Ifc57b33c8e6604764ca004a7035c382465711b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305031 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#789691}
-
Mohamed Heikal authored
A collection of bugfixes for creating R.java in java_library_impl targets: - test libraries support. - apk under test R.java shadowing bugfix. - always generate onResourcesLoaded like package resources did. - Fix issue where R.java is not generated for the apk package name. Bug: 1073476 Change-Id: I0cebd9626b0ce9049554f8345af516f7bd0ec2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302919 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789690}
-
Piotr Bialecki authored
Changes: - Roll ARCore SDK to version 1.18. - Updated device implementation to opt in to use 30FPS. - Updated ARCore APK version to 1.18.200603086 for the test bots to use. - Updated ARCore session recording - now that the code opts in to use 30FPS, the recordings need to be done at 30FPS as well, otherwise the camera configuration will fail. ~3kb since it needs to consume newly introduced APIs to configure AR session. The remaining size increase can be mostly attributed to the dependency growing (+8kb) and overhead (~4kb) - see breakdown for details. Binary-Size: Size increase is unavoidable. The product code increased by Change-Id: Ied48a1d4e6203e697ff5489547f7e9a67be6af0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300808 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789689}
-
Edward Lesmes authored
It was moved to the infra repo [1] so that it could be used by projects other than chromium. [1] https://chromium.googlesource.com/infra/infra/+/HEAD/go/src/infra/tools/dirmd/README.md Bug: 1102997 Change-Id: Idef030d4630d2408acf803e405f3e3b5b06d223c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304105Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#789688}
-
shrekshao authored
Sync with spec update: https://github.com/KhronosGroup/WebGL/pull/3115 Bug: angleproject:4838 Change-Id: Iefa754f90b42f8557c4aa088d0bad5b0d2013317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304134Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#789687}
-
Xiaoling Bao authored
1) Copy raw bytes from std::string to NSData when making request. 2) Copy raw bytes from NSMutableData to std::string when post response back to caller. 3) Forward additional post headers to NSMutableURLRequest so they can be actually sent. Bug: 1106820 Change-Id: I4517abea4ffb087f4bd433dcea85ff0e1a0427d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304994 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789686}
-
Ian Kilpatrick authored
This reverts commit d73ae868. The issue which caused the bot failures was due to a difference in logic between 32bit, and 64bit arch. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304143 This patch has remained unchanged except for part which landed before to fix another unrelated issue. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304659 Original change's description: > Revert "[LayoutNG] Move relative position calculation into NG." > > This reverts commit 27880cb4. > > Reason for revert: > > Suspect of blink_web_tests failures in a lot of bots, like this one: > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/70261 > > Unexpected Failures: > * fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html > * fast/css/relative-positioned-block-nested-with-inline-parent.html > * paint/invalidation/compositing/composited-float-under-composited-inline-individual.html > * paint/invalidation/compositing/composited-float-under-composited-inline.html > * paint/invalidation/compositing/stacked-float-under-composited-inline.html > > Original change's description: > > [LayoutNG] Move relative position calculation into NG. > > > > This patch moves the relative position calculation into NG. Previously > > we needed to manually account for the relative position of an object > > in many different places, overflow calculation, geometry APIs etc. > > > > This patch directly updates the child's offset (relative to its parent) > > to directly incorporate this additional offset. > > > > This calculation occurs within the NGBoxFragmentBuilder, and if an > > object is *placed* by LayoutNG... > > ...LayoutBoxModelObject::RelativePositionOffset returns an empty offset. > > > > This fixes a few small issues where previously we didn't resolve > > percentages against the correct available size when contained within > > an anonymous block. > > > > Bug: 1070822, 1058690 > > Change-Id: I2c623b02cc5a4605d310596f5c60353a21236bff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214608 > > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787991} > > TBR=yosin@chromium.org,wangxianzhu@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,yosin@google.com,mstensho@chromium.org > > Change-Id: I5ca67701222509693d3020fa068c279cef39ecbb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1070822, 1058690 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296628 > Reviewed-by: Jian Li <jianli@chromium.org> > Commit-Queue: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788228} Bug: 1070822, 1058690 Change-Id: I85a51c06d47c9eb451e8e7b77418913e288b7758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300667Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789685}
-
Alex Cooper authored
https://crrev.com/c/2304097 updated the tests that originally required this exception to be added so that they now automatically skip/pass on Windows 7, so we don't need to keep these exceptions anymore. Bug: 1106809 Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789684}
-
Gabriel Charette authored
R=mpearson@chromium.org Bug: 969934 Change-Id: I422cc9030ea6c48870a3c82df85ce343b92f0607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304168 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#789683}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Id3b57710dde76947090ebcc89c00fb1384a2a7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305014Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789682}
-